[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128") TARGET

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

aheejin added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:174 +static __inline__ v128_t __DEFAULT_FN_ATTRS wasm_v128_load8_lane( +const void *__ptr, v128_t __vec, int __i) __REQUIRE_CONSTANT(__i) { + struct __wasm_v128_load8_lane_struct { N

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, mgorny. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-com

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

aheejin updated this revision to Diff 328116. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97834/new/ https://reviews.llvm.org/D97834 Files: clang/lib/CodeGen/CGException.cpp clang/lib/CodeGen/Itanium

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG561abd83ffec: [WebAssembly] Disable uses of __clang_call_terminate (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

aheejin accepted this revision. aheejin added a comment. All Wasm atomics are sequentially consistent; If that's supported by this macro, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140757/new/ https://reviews.llvm.org/D140757 ___

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

aheejin added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:190 +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_s_i16x8, "V8sV16ScV16Sc", "nc", "relaxed-simd") +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_add_s_i32x4, "V4iV16ScV16Sc", "nc", "re

[PATCH] D158409: [WebAssembly] Add multiple memories feature

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. LGTM % nit and the name resolution (multimemory vs. multi-memory) Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-ext

[PATCH] D158409: [WebAssembly] Add multiple memories feature

aheejin added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"], "mno-multi-memories

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin created this revision. aheejin added reviewers: iana, dschuff. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was no space in `((void *)0)` before D158709

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. The added space actually caused emscripten's CI to break: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8771230198259238865/+/u/Build_Emscripten__upstream_/stdout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

aheejin added a comment. The added space in `((void *)0)` in `__stddef_null.h` broke Emscripten CI. I added the space back in D159312

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin updated this revision to Diff 555201. aheejin added a comment. Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 Files: clang/lib/Headers/__stddef_null.h Index: clang/lib/Headers/__s

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. Done. Btw musl defines `NULL` in several places, not only `stdio.h`. It defines `NULL` in `local.h`, `stddef.h`, `stdio.h`, `stdlib.h`, `string.h`, `time.h`, `unistd.h`, and `wchar.h`. Not sure why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D159312: [Headers] Remove a space in NULL define

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef8121b109ef: [Headers] Remove a space in NULL define (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. I believe this is better solved downstream, i.e., in musl. I'm not a musl developer but a user, but I can consider contributing a patch there. I'd like to remove the whitespace for now because it is currently breaking us and it had been that way for a long time anyway,

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. In D159312#4634617 , @dalias wrote: > Please report what you're actually trying to do that's breaking rather than > sending patches to align definitions that are not intended to be aligned. Basically, we tried to use `stddef.h`

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

aheejin created this revision. aheejin added reviewers: iana, aaron.ballman, dalias. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes a comment added in D159

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. I uploaded D159383 , which removes the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

aheejin added a comment. In D159383#4635703 , @dschuff wrote: > Suggested edit to the commit description: > "use musl and stddef.h at the same time" -> "use musl and clang's stddef.h at > the same time" Done (Both the CL description and the commit messa

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

This revision was automatically updated to reflect the committed changes. Closed by commit rG666098c5b3ea: [Headers] Remove musl-related comment about NULL (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159383/new/ https://revi

[PATCH] D69696: [WebAssembly] SIMD integer min and max instructions

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Is this https://github.com/WebAssembly/simd/pull/27 ? Can you please include the spec (even if it's still an unmerged PR) in the CL description next time? LGTM. Repository: rG LLVM Githu

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

aheejin created this revision. aheejin added reviewers: vsk, tlively. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM! After D68351

[PATCH] D69699: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9903ec8979f: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69699/new/ https:

[PATCH] D69697: [WebAssembly] Add experimental SIMD dot product instruction

aheejin added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:135 +TARGET_BUILTIN(__builtin_wasm_dot_s_i32x4_i16x8, "V4iV8s", "nc", "simd128") + We talked offline. There should be two arguments :) Repository: rG LLVM Github Mo

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. This adds `-mreference-types` and `-mno-reference-types` flags to clang and make `-fwasm-exceptions` enables referenc

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

aheejin added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69832/new/ https://reviews.llvm.org/D69832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

aheejin added a comment. pong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69832/new/ https://reviews.llvm.org/D69832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D69832: [WebAssembly] -fwasm-exceptions enables reference-types

This revision was automatically updated to reflect the committed changes. Closed by commit rG70ee430c6e45: [WebAssembly] -fwasm-exceptions enables reference-types (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69832/new/ https:

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:189 + setOperationAction(Op, T, Legal); +} + Just curious, what gets a

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/TargetInfo.cpp:741 + explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes &CGT, ABIKind _Kind) + : SwiftABIInfo(CGT), defaultInfo(CGT),

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

aheejin added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:741 + explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes &CGT, ABIKind _Kind) + : SwiftABIInfo(CGT), defaultInfo(CGT), Kind(_Kind) {} Nit: Do we need `_`? Commen

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. This adds the reference types target feature. This does not enable any more functionali

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin added a comment. I think their implemention is mostly complete, but please let me know if not. This adds bu

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

aheejin added a comment. I think their implemention is mostly complete, but please let me know if not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73322/new/ https://reviews.llvm.org/D73322 ___ cfe-c

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin marked 2 inline comments as done. aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/reference-types.ll:4 +; This currently only tests if the command line argument for reference types +; feature is accepted by llc. + sbc100 wrote: >

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin updated this revision to Diff 240124. aheejin marked an inline comment as done. aheejin added a comment. - Test target feature section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://reviews.llvm.org/D73320 Files: clang/

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin updated this revision to Diff 240125. aheejin added a comment. - Remove a stray attribute number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://reviews.llvm.org/D73320 Files: clang/lib/Basic/Targets/WebAssembly.cpp cl

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin updated this revision to Diff 240127. aheejin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://reviews.llvm.org/D73320 Files: clang/lib/Basic/Targets/WebAssembly.cpp clang/lib/Basic/Targets/WebAs

[PATCH] D73320: [WebAssembly] Add reference types target feature

aheejin updated this revision to Diff 240130. aheejin added a comment. Herald added a subscriber: jfb. Fix test comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://reviews.llvm.org/D73320 Files: clang/lib/Basic/Targets/WebA

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

aheejin updated this revision to Diff 240132. aheejin added a comment. Herald added subscribers: llvm-commits, jfb, hiraditya. Herald added a project: LLVM. rebase + test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73322/new/ https://reviews.

[PATCH] D73320: [WebAssembly] Add reference types target feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG764f4089e89e: [WebAssembly] Add reference types target feature (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73320/new/ https://revie

[PATCH] D73322: [WebAssembly] Update bleeding-edge CPU features

This revision was automatically updated to reflect the committed changes. Closed by commit rG65eb11306e92: [WebAssembly] Update bleeding-edge CPU features (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73322/new/ https://review

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin created this revision. aheejin added reviewers: majnemer, dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, jfb. Because wasm control flow needs to be structured, using WinEH instructions to support wasm EH brings several benefits. This patch makes wasm EH

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 139920. aheejin added a comment. - Comment fix Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp lib/CodeGen/ItaniumCXXABI.cpp lib/

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added inline comments. Comment at: lib/CodeGen/CGCXXABI.h:610 +struct CatchRetScope final : EHScopeStack::Cleanup { + llvm::CatchPadInst *CPI; dschuff wrote: > Should be `public`? This code was moved from [[ https://github.com/llvm-mirror/clang/blob/c

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 140144. aheejin marked an inline comment as done. aheejin added a comment. - Rebase & Simplified the if condition Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added inline comments. Comment at: lib/CodeGen/CGException.cpp:1541 + } llvm::CallInst *terminateCall = + CGM.getCXXABI().emitTerminateForUnexpectedException(*this, Exn); dschuff wrote: > Should this be in an else block? No need to emit it after

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 140156. aheejin marked an inline comment as done. aheejin added a comment. - GNU_CPlusCPlus -> GNU_CPlusPlus Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 141759. aheejin added a comment. - Add a test in which try-catches are nested within a catch - Rebase Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 141979. aheejin added a comment. - Change personality function name to a unique one Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 141983. aheejin added a comment. - Rebase Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGCleanup.h lib/CodeGen/CGException.cpp lib/CodeGen/ItaniumCXXABI.cpp lib/CodeG

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

aheejin added a comment. Nice! Just some drive-by nitpicking, sorry 😅 Comment at: lld/test/wasm/async.ll:11 + +define void @bar() #1 { +ret void Comment at: lld/test/wasm/async.ll:21-22 + +attributes #0 = { "wasm-async" } +attributes #1

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

aheejin added a comment. General question about SIMD intrinsics: So we make dedicated wasm intrinsics only for the cases there are not general intrinsics people can use instead? Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i)

[PATCH] D101112: [WebAssembly] Finalize wasm_simd128.h intrinsics

aheejin added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:171 + +#define wasm_v128_load8_lane(__ptr, __vec, __i) \ + ((v128_t)__builtin_wasm_load8_lane((signed char *)(__ptr), (__i8x16)(__vec), \ tlively wrote:

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Wow these are really a lot of instructions! Comment at: clang/test/Headers/wasm.c:2 +// REQUIRES: webassembly-registered-target // expected-no-diagnostics --

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin added a comment. I think there's a clear upside on keeping this within clang/. 1. As @tlively said, there are many number of instructions to test and keeping "C function - LLVM intrinsic" and "LLVM intrinsic - Wasm instruction" tests in sync without autogeneration will be hard and error

[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

aheejin added a comment. In D101684#2732551 , @dblaikie wrote: > In D101684#2732522 , @aheejin wrote: > >> I think there's a clear upside on keeping this within clang/. >> >> 1. As @tlively said, there are many nu

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was temporarily disabled

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c1406f24d8b: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101735/new/ https:/

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

aheejin added a comment. Why do only these instructions have `const`? It doesn't apply to other read-only arguments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101884/new/ https://reviews.llvm.org/D101884 __

[PATCH] D101884: [WebAssembly] Fix constness of pointer params to load intrinsics

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. I see, thanks. Then other load instructions are OK not to be fixed? - `v128.load` - `v128.loadN_splat` - `v128.loadNxM_s/u` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. > To improve hygiene, consistency, and usability, it would be good to replace > all > the macro intrinsics in wasm_simd128.h with functions. The reason for using > macros in the first place w

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin added a comment. @dblaikie I can remove this one. This is not an important test anyway. But where are we supposed to test the arguments clang driver invokes the backend LLVM compilation with? This was mainly to test if `-exception-model=wasm` reaches the backend compilation. Repositor

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: wingo, ecnelises, pengfei, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 394951. aheejin added a comment. Revert a function name change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGen/WebAssembly/wasm-eh.ll ll

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 395024. aheejin marked 2 inline comments as done. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGe

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:37 -// Emscripten's asm.js-style exception handling -cl::opt -WasmEnableEmEH("enable-emscripten-cxx-exceptions", - cl::desc("WebAssembly Emscripten-style ex

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

aheejin updated this revision to Diff 395025. aheejin added a comment. Remove an unnecessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115893/new/ https://reviews.llvm.org/D115893 Files: clang/test/CodeGen/WebAssembly/wasm-eh.ll ll

[PATCH] D115893: [WebAssembly] Support clang -fwasm-exceptions for bitcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4625b848793f: [WebAssembly] Support clang -fwasm-exceptions for bitcode (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

aheejin added inline comments. Comment at: clang/lib/Driver/Job.cpp:390-392 Argv.push_back(nullptr); + Argv.pop_back(); // The terminating null element shall not be part of the + // slice (main() behavior). If we push `nullptr` and then pop

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1243 // Prototype f64x2 conversions defm "" : SIMDConverthttps://reviews.llvm.org/D98676/new/ https

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin created this revision. aheejin added a reviewer: sbc100. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Functions specified in `-emscripten-cxx

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin updated this revision to Diff 332957. aheejin added a comment. Comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99259/new/ https://reviews.llvm.org/D99259 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver/wa

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin updated this revision to Diff 333041. aheejin added a comment. Add break Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99259/new/ https://reviews.llvm.org/D99259 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver/wasm

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6aae5f7fcd1: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions (authored by aheejin). Repository: rG LLVM Github Monorepo

[PATCH] D100425: [WebAssembly] Codegen for f64x2.convert_low_i32x4_{s,u}

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1104-1107 +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert; +defm "" : SIMDConvert

[PATCH] D100596: [WebAssembly] Remove saturating fp-to-int target intrinsics

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:124-127 + if (Subtarget->hasNontrappingFPToInt()) +for (auto Op : {ISD::FP_TO_SINT_SAT, ISD::FP

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:318 + Intrinsic<[], [llvm_ptr_ty], +[IntrInaccessibleMemOrArgMemOnly, IntrWillReturn, +

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-prefetch-offset.ll:126 +;=== +; v128.load64_zero +;===

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, dexonsmith, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. C

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

aheejin updated this revision to Diff 315366. aheejin added a comment. Remove an extra word Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94038/new/ https://reviews.llvm.org/D94038 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG7be271537e97: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94038/new/ h

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin marked an inline comment as done. aheejin added a comment. In D94039#2480002 , @tlively wrote: > In the description I think "but LLVM does not have a way of that kind of > behavior" is missing the word "modeling" => "but LLVM does not have a way o

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin updated this revision to Diff 315392. aheejin marked an inline comment as done. aheejin added a comment. Delete `declare void @_ZSt9terminatev()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94039/new/ https://reviews.llvm.org/D94039 File

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9724c3cff46f: [WebAssembly] Update WasmEHPrepare for the new spec (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aheejin added a comment. After this patch, `-print-stats` started erroring out. I filed a bug at https://bugs.llvm.org/show_bug.cgi?id=52193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111270/new/ https://reviews.llvm.org/D111270 _

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin updated this revision to Diff 368203. aheejin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `-wasm-enable-eh` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/ https://reviews.llvm.org/D

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for Wasm SjLj

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Oh, I fortot I made this currently set `+multivalue` feature... Maybe we have to rethink that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin planned changes to this revision. aheejin added a comment. Oh sorry I clicked the wrong button Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.org/D108582 ___ c

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin updated this revision to Diff 368237. aheejin marked 3 inline comments as done. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/ https://reviews.llvm.org/D107685 Files: clang/test/CodeGe

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:449 + // done in WasmEHPrepare pass after these IR passes, but Wasm SjLj requires + // Emscripten libraries and processed together in LowerEmscriptenEHSjLJ pass. + if (WasmEnabl

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

This revision was automatically updated to reflect the committed changes. Closed by commit rG77b921b870aa: [WebAssembly] Tidy up EH/SjLj options (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/ https://reviews.llvm.or

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin added a comment. As we discussed offline, I'll remove `+multivalue` part for now; it doesn't have reliable support in the Wasm LLVM backend and Binaryen yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.or

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin updated this revision to Diff 368519. aheejin added a comment. This revision is now accepted and ready to land. Remove multivalue setting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.org/D108582 Files: c

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa947b40cafa8: [WebAssembly] Add Wasm SjLj option support for clang (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

<    1   2   3