[clang] Reland [Driver] Add support for crtbegin.o, crtend.o and libgloss lib to BareMetal toolchain object (PR #144649)

hvdijk wrote: > This patch does not make assumption that it is for the same architecture as > host. Rather, it is inline with other toolchain objects that supports > GCCInstallation which have ld as the default linker. Thus breaking the case where it is not for the same architecture as host.

[clang] More fixes for P3144R2 implementation (PR #149406)

https://github.com/hvdijk created https://github.com/llvm/llvm-project/pull/149406 P3144R2 made it ill-formed to delete a pointer to an incomplete class type, and asserted that incomplete class types were the only incomplete types that were possible to pass to the delete operator. This asserti

[clang] More fixes for P3144R2 implementation (PR #149406)

https://github.com/hvdijk edited https://github.com/llvm/llvm-project/pull/149406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] More fixes for P3144R2 implementation (PR #149406)

hvdijk wrote: Apologies for the repeated review request, not sure why GitHub removed one when I only tried to request an additional reviewer. https://github.com/llvm/llvm-project/pull/149406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] More fixes for P3144R2 implementation (PR #149406)

hvdijk wrote: > Please add an entry to clang/docs/ReleaseNotes.rst in the section the most > adapted to the change, and referencing any Github issue this change fixes. > Thanks! There is no separate GitHub issue for this, but will add a release note. https://github.com/llvm/llvm-project/pull

[clang] More fixes for P3144R2 implementation (PR #149406)

@@ -8392,17 +8392,19 @@ def ext_default_init_const : ExtWarn< "is a Microsoft extension">, InGroup; def err_delete_operand : Error<"cannot delete expression of type %0">; +def err_delete_void_ptr_operand : Error< + "cannot delete expression with pointer-to-'void' type %0">

[clang] More fixes for P3144R2 implementation (PR #149406)

https://github.com/hvdijk updated https://github.com/llvm/llvm-project/pull/149406 >From 94e652bc0bd6a04ef61a9f9b703257d464c7b714 Mon Sep 17 00:00:00 2001 From: Harald van Dijk Date: Thu, 17 Jul 2025 21:47:30 +0100 Subject: [PATCH 1/3] More fixes for P3144R2 implementation P3144R2 made it ill-

[clang] More fixes for P3144R2 implementation (PR #149406)

hvdijk wrote: How about this? For an incomplete class C, we used to generate the misleading "cannot delete pointer to incomplete type 'C'", now "cannot delete pointer to incomplete class 'C'", for a pointer to void, matching wording can just be "cannot delete pointer to 'void'". Does that look

[clang] More fixes for P3144R2 implementation (PR #149406)

@@ -8392,17 +8392,19 @@ def ext_default_init_const : ExtWarn< "is a Microsoft extension">, InGroup; def err_delete_operand : Error<"cannot delete expression of type %0">; +def err_delete_void_ptr_operand : Error< + "cannot delete expression with pointer-to-'void' type %0">

[clang] More fixes for P3144R2 implementation (PR #149406)

@@ -8392,17 +8392,19 @@ def ext_default_init_const : ExtWarn< "is a Microsoft extension">, InGroup; def err_delete_operand : Error<"cannot delete expression of type %0">; +def err_delete_void_ptr_operand : Error< + "cannot delete expression with pointer-to-'void' type %0">

[clang] More fixes for P3144R2 implementation (PR #149406)

https://github.com/hvdijk updated https://github.com/llvm/llvm-project/pull/149406 >From 94e652bc0bd6a04ef61a9f9b703257d464c7b714 Mon Sep 17 00:00:00 2001 From: Harald van Dijk Date: Thu, 17 Jul 2025 21:47:30 +0100 Subject: [PATCH 1/2] More fixes for P3144R2 implementation P3144R2 made it ill-

[clang] More fixes for P3144R2 implementation (PR #149406)

hvdijk wrote: Release note added, and diagnostics updated to use `%select{struct|interface|union|class|enum}` based on `getTagKind()` which is already used for other diagnostics too (look for `|interface|` in the same file). I do take your point about `pointer-to-'void'` being clumsy wording,

[clang] More fixes for P3144R2 implementation (PR #149406)

@@ -8392,17 +8392,19 @@ def ext_default_init_const : ExtWarn< "is a Microsoft extension">, InGroup; def err_delete_operand : Error<"cannot delete expression of type %0">; +def err_delete_void_ptr_operand : Error< + "cannot delete pointer to %0">; def ext_delete_void_ptr_o

[clang] More fixes for P3144R2 implementation (PR #149406)

@@ -8392,17 +8392,19 @@ def ext_default_init_const : ExtWarn< "is a Microsoft extension">, InGroup; def err_delete_operand : Error<"cannot delete expression of type %0">; +def err_delete_void_ptr_operand : Error< + "cannot delete pointer to %0">; def ext_delete_void_ptr_o

[clang] More fixes for P3144R2 implementation (PR #149406)

@@ -8392,17 +8392,19 @@ def ext_default_init_const : ExtWarn< "is a Microsoft extension">, InGroup; def err_delete_operand : Error<"cannot delete expression of type %0">; +def err_delete_void_ptr_operand : Error< + "cannot delete expression with pointer-to-'void' type %0">

[clang] More fixes for P3144R2 implementation (PR #149406)

@@ -8392,17 +8392,19 @@ def ext_default_init_const : ExtWarn< "is a Microsoft extension">, InGroup; def err_delete_operand : Error<"cannot delete expression of type %0">; +def err_delete_void_ptr_operand : Error< + "cannot delete expression with pointer-to-'void' type %0">

[clang] More fixes for P3144R2 implementation (PR #149406)

https://github.com/hvdijk updated https://github.com/llvm/llvm-project/pull/149406 >From 94e652bc0bd6a04ef61a9f9b703257d464c7b714 Mon Sep 17 00:00:00 2001 From: Harald van Dijk Date: Thu, 17 Jul 2025 21:47:30 +0100 Subject: [PATCH 1/4] More fixes for P3144R2 implementation P3144R2 made it ill-

[clang] One more fix for P3144R2 implementation (PR #149406)

https://github.com/hvdijk edited https://github.com/llvm/llvm-project/pull/149406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] More fixes for P3144R2 implementation (PR #149406)

https://github.com/hvdijk edited https://github.com/llvm/llvm-project/pull/149406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2