[PATCH] D25610: [clang-move] Add header guard for the new header.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. The header guard generated by clang-move isn't always a perfect style, just avoid getting the header included multiple times during compiling period. Also, we can use llvm-Header-guard clang-tid

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The code looks good. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:579 DiagnosticIDs::Note); + } else if(UseLoc < MoveLoc || Use.DeclRef == MoveArg) { +

[PATCH] D25610: [clang-move] Add header guard for the new header.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:264 +HeaderGuard += "#define " + GuardName + "\n"; +clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0, + HeaderGuard); ioeric

[clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

Author: hokein Date: Fri Oct 14 08:01:36 2016 New Revision: 284233 URL: http://llvm.org/viewvc/llvm-project?rev=284233&view=rev Log: [clang-move] Add header guard for the new header. Summary: The header guard generated by clang-move isn't always a perfect style, just avoid getting the header incl

[PATCH] D25610: [clang-move] Add header guard for the new header.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284233: [clang-move] Add header guard for the new header. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25610?vs=74663&id=74669#toc Repository: rL LLVM https://reviews.llv

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === --- clang-move/ClangMove.c

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein updated this revision to Diff 74675. hokein added a comment. woohoo, delete more code! https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === --- clang-move/ClangMove.cpp +++ c

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein updated this revision to Diff 74677. hokein added a comment. Delete one more function. https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === --- clang-move/ClangMove.cpp +++ c

[clang-tools-extra] r284236 - [clang-move] Don't overuse Replacements::add.

Author: hokein Date: Fri Oct 14 08:43:49 2016 New Revision: 284236 URL: http://llvm.org/viewvc/llvm-project?rev=284236&view=rev Log: [clang-move] Don't overuse Replacements::add. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25613 Modified: cla

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL284236: [clang-move] Don't overuse Replacements::add. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25613?vs=74677&id=74679#toc Repos

[PATCH] D25600: [ASTMatcher] Add isStaticDataMember matcher for varDecl.

hokein added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005 +/// \endcode +AST_MATCHER(VarDecl, isStaticDataMember) { + return Node.isStaticDataMember(); aaron.ballman wrote: > How does this differ from the existing matcher `hasStaticS

[clang-tools-extra] r284368 - Recommit "[ClangTidy] Add UsingInserter and NamespaceAliaser"

Author: hokein Date: Mon Oct 17 03:33:59 2016 New Revision: 284368 URL: http://llvm.org/viewvc/llvm-project?rev=284368&view=rev Log: Recommit "[ClangTidy] Add UsingInserter and NamespaceAliaser" Summary: This adds helper classes to add using declaractions and namespace aliases to function bodies

Re: [PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

Yeah, "make -j 32" won't compile binaries in clang-tools-extra repo. "make check-clang-tools" should work though I don't use make. I usually run `ninja check-clang-tools` command to build all binaries and run all lint-tests/unittest in clang-extra-tools. There is a remaining build error in the uni

[PATCH] D25600: [ASTMatcher] Add isStaticDataMember matcher for varDecl.

hokein abandoned this revision. hokein added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005 +/// \endcode +AST_MATCHER(VarDecl, isStaticDataMember) { + return Node.isStaticDataMember(); aaron.ballman wrote: > hokein wrote: > > aaron.ba

[clang-tools-extra] r284370 - Fix windows buildbot error.

Author: hokein Date: Mon Oct 17 05:05:25 2016 New Revision: 284370 URL: http://llvm.org/viewvc/llvm-project?rev=284370&view=rev Log: Fix windows buildbot error. Modified: clang-tools-extra/trunk/unittests/clang-tidy/NamespaceAliaserTest.cpp clang-tools-extra/trunk/unittests/clang-tidy/Usi

[clang-tools-extra] r320486 - [clangd] Introduce a "Symbol" class.

Author: hokein Date: Tue Dec 12 07:42:10 2017 New Revision: 320486 URL: http://llvm.org/viewvc/llvm-project?rev=320486&view=rev Log: [clangd] Introduce a "Symbol" class. Summary: * The "Symbol" class represents a C++ symbol in the codebase, containing all the information of a C++ symbol needed

[clang-tools-extra] r320574 - [clangd] Remove the const specifier of the takeSymbol method

Author: hokein Date: Wed Dec 13 04:39:06 2017 New Revision: 320574 URL: http://llvm.org/viewvc/llvm-project?rev=320574&view=rev Log: [clangd] Remove the const specifier of the takeSymbol method otherwise we will copy an object. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.h

[clang-tools-extra] b06372a - [clangd] NFC, correct template argument type for two RetiredFlags.

Author: Haojian Wu Date: 2022-09-05T15:20:31+02:00 New Revision: b06372ae58f0c8ae61f0ba5cf6ad2e4a7615a2a4 URL: https://github.com/llvm/llvm-project/commit/b06372ae58f0c8ae61f0ba5cf6ad2e4a7615a2a4 DIFF: https://github.com/llvm/llvm-project/commit/b06372ae58f0c8ae61f0ba5cf6ad2e4a7615a2a4.diff LO

[clang-tools-extra] 1698799 - [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.

Author: Haojian Wu Date: 2022-09-05T15:55:29+02:00 New Revision: 16987998e6a0ad62efd4e387c18b0b9b5ef51947 URL: https://github.com/llvm/llvm-project/commit/16987998e6a0ad62efd4e387c18b0b9b5ef51947 DIFF: https://github.com/llvm/llvm-project/commit/16987998e6a0ad62efd4e387c18b0b9b5ef51947.diff LO

[clang] 44075cc - [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

Author: Azat Khuzhin Date: 2022-09-14T10:17:03+02:00 New Revision: 44075cc34a9b373714b594964001ce283598eac1 URL: https://github.com/llvm/llvm-project/commit/44075cc34a9b373714b594964001ce283598eac1 DIFF: https://github.com/llvm/llvm-project/commit/44075cc34a9b373714b594964001ce283598eac1.diff

[clang] f6e759b - Remove some unused static functions in CGOpenMPRuntimeGPU.cpp, NFC

Author: Haojian Wu Date: 2022-09-14T17:20:02+02:00 New Revision: f6e759bd26b24e046573ac46d3ee3be6eebd5526 URL: https://github.com/llvm/llvm-project/commit/f6e759bd26b24e046573ac46d3ee3be6eebd5526 DIFF: https://github.com/llvm/llvm-project/commit/f6e759bd26b24e046573ac46d3ee3be6eebd5526.diff LO

[clang] 684b8e1 - Add missing header in MigratorOptions.h for 1a0e743ab01716ecafeb33858d9975cf90017c59.

Author: Haojian Wu Date: 2023-11-06T12:32:43+01:00 New Revision: 684b8e1c08f4ed3bfa452fea5eac230e449bf2aa URL: https://github.com/llvm/llvm-project/commit/684b8e1c08f4ed3bfa452fea5eac230e449bf2aa DIFF: https://github.com/llvm/llvm-project/commit/684b8e1c08f4ed3bfa452fea5eac230e449bf2aa.diff LO

[clang-tools-extra] [clangd] Use InitLLVM (PR #69119)

https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/69119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

https://github.com/hokein commented: I think we should document this extension in the release note. https://github.com/llvm/llvm-project/pull/71945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

@@ -15811,6 +15813,32 @@ static void diagnoseImplicitlyRetainedSelf(Sema &S) { << FixItHint::CreateInsertion(P.first, "self->"); } +// Return whether FD is `promise_type::get_return_object`. +bool isGetReturnObject(FunctionDecl *FD) { hokein wrote:

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/71945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Improve sys header mapping (PR #72122)

https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/72122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Make sure exports of stdlib also works for physical files (PR #72246)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/72246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Make sure exports of stdlib also works for physical files (PR #72246)

@@ -232,6 +232,17 @@ class PragmaIncludes::RecordPragma : public PPCallbacks, public CommentHandler { void checkForExport(FileID IncludingFile, int HashLine, std::optional IncludedHeader, OptionalFileEntryRef IncludedFile) { +a

[clang-tools-extra] [include-cleaner] Make sure exports of stdlib also works for physical files (PR #72246)

https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/72246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Make sure exports of stdlib also works for physical files (PR #72246)

@@ -232,6 +232,17 @@ class PragmaIncludes::RecordPragma : public PPCallbacks, public CommentHandler { void checkForExport(FileID IncludingFile, int HashLine, std::optional IncludedHeader, OptionalFileEntryRef IncludedFile) { +a

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/72428 Fix #67495, #72198 CC @ADKaster, @ecnelises >From 13b97a2239c93fe528174ec9ecc20f3d3ca49e23 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 15 Nov 2023 20:31:12 +0100 Subject: [PATCH] [clang][AST] Invalidate

[clang] [coroutines] Introduce [[clang::coro_return_type]] and [[clang::coro_wrapper]] (PR #71945)

https://github.com/hokein commented: Thanks, the change looks good from my side. I will leave the final stamp to @ChuanqiXu9 and @ilya-biryukov. https://github.com/llvm/llvm-project/pull/71945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/72428 >From ac06843b97cb93d476f0bf8e0474fa270d80631f Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 15 Nov 2023 20:31:12 +0100 Subject: [PATCH 1/2] [clang][AST] Invalidate DecompositionDecl if it has invalid init

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

@@ -13540,6 +13540,15 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) { CreateRecoveryExpr(Init->getBeginLoc(), Init->getEndLoc(), Args); if (RecoveryExpr.get()) VDecl->setInit(RecoveryExpr.get()); + // In general, f

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

hokein wrote: > What differentiates the DecompositionDecl such that we need to mark the decl > invalid when there's an error in the RHS, while for other decls we don't? It > seems inconsistent. DecompositionDecl (aka structure binding) is special here, a legal DecompositionDecl must be declar

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/72851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

@@ -7581,3 +7580,59 @@ alignment boundary. Its value must be a power of 2, between 1 and 4096 }]; } + +def CoroLifetimeBoundDoc : Documentation { + let Category = DocCatDecl; + let Content = [{ +The ``[[clang::coro_lifetimebound]]`` is a class attribute which can be appli

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

https://github.com/hokein approved this pull request. Thanks, looks good from my side. Some nits. https://github.com/llvm/llvm-project/pull/72851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

@@ -7580,10 +7580,15 @@ static void visitLifetimeBoundArguments(IndirectLocalPath &Path, Expr *Call, if (ObjectArg && implicitObjectParamIsLifetimeBound(Callee)) VisitLifetimeBoundArg(Callee, ObjectArg); + bool checkCoroCall = false; hokein wrote: nit

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

@@ -0,0 +1,120 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only -verify -Wall -Wextra -Wno-error=unreachable-code -Wno-unused + +#include "Inputs/std-coroutine.h" + +using std::suspend_always; +using std::suspend_never; + +template struct [[clang::

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

@@ -7581,3 +7580,59 @@ alignment boundary. Its value must be a power of 2, between 1 and 4096 }]; } + +def CoroLifetimeBoundDoc : Documentation { + let Category = DocCatDecl; + let Content = [{ +The ``[[clang::coro_lifetimebound]]`` is a class attribute which can be appli

[clang] [coroutines] Introduce [[clang::coro_lifetimebound]] (PR #72851)

@@ -0,0 +1,120 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++20 -fsyntax-only -verify -Wall -Wextra -Wno-error=unreachable-code -Wno-unused + +#include "Inputs/std-coroutine.h" + +using std::suspend_always; +using std::suspend_never; + +template struct [[clang::

[clang] [clang] Fix CTAD not respect default template arguments that were added after the definition. (PR #75569)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/75569 Fixes https://github.com/llvm/llvm-project/issues/69987 >From 0f49d91b4a22944216cff8654f9c00f892bb02be Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 15 Dec 2023 08:44:57 +0100 Subject: [PATCH] [clang] Fix

[clang] [clang] Fix CTAD not work for C++ explicit type conversion (functional annotation). (PR #75779)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/75779 Fixes https://github.com/llvm/llvm-project/issues/64347 >From 073f3d87bc9e22e3fb80ee9ab297e0bd6e4127f2 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 18 Dec 2023 10:41:45 +0100 Subject: [PATCH] [clang] Fix

[clang] [clang] Fix CTAD not respect default template arguments that were added after the definition. (PR #75569)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/75569 >From 0f49d91b4a22944216cff8654f9c00f892bb02be Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 15 Dec 2023 08:44:57 +0100 Subject: [PATCH 1/2] [clang] Fix CTAD not respect default template arguments that wer

[clang] [clang] Fix CTAD not respect default template arguments that were added after the definition. (PR #75569)

@@ -685,6 +685,8 @@ Bug Fixes in This Version (`#62157 `_) and (`#64885 `_) and (`#65568 `_) +- Fix an issue where clan

[clang] [clang] Fix CTAD not work for C++ explicit type conversion (functional annotation). (PR #75779)

hokein wrote: > Why remove the support for ParenListExpr entirely? Could you not fallback on > looking at the init list expression only when ParenListExpr is null? We could keep `ParenListExpr`, but I'm not sure the benefit (IMO, removing it seems like an API improvement, and make code simple

[clang] [clang] Fix CTAD not respect default template arguments that were added after the definition. (PR #75569)

hokein wrote: Thanks for the review. https://github.com/llvm/llvm-project/pull/75569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix CTAD not respect default template arguments that were added after the definition. (PR #75569)

https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/75569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] RecursiveASTVisitor: traverse the require clause for partial template specializations. (PR #75795)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/75795 This fixes tooling (clangd, include-cleaner) bugs where we miss functionalities on concept AST nodes. >From 9012381987bd702a58683fc5c6c7452c32755a08 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 18 Dec 20

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

hokein wrote: Friendly ping. https://github.com/llvm/llvm-project/pull/72428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Tooling] Print the progress when there are multiple files to process (PR #75904)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/75904 Running clang tools on a single file can be slow. It is even worse when running multiple files, to improve the user experience, we print the processing status. >From 35ca8fc22fd64c2e6513fa790215f72947852dd1 Mon S

[clang] [clang] Fix CTAD not work for C++ explicit type conversion (functional annotation). (PR #75779)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/75779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix CTAD not work for C++ explicit type conversion (functional annotation). (PR #75779)

hokein wrote: > Can you please update your summary to explain the problem and how the fix > addresses the problem. > > This is usually what goes into the git log and we want those to be as > descriptive as possible but also it help code reviewers to understand what > they are reviewing quicke

[clang] [clang] Fix CTAD not work for C++ explicit type conversion (functional annotation). (PR #75779)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/75779 >From 163a43a3c62964a6010dd57aa2670e7629c0a847 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 18 Dec 2023 10:41:45 +0100 Subject: [PATCH] [clang] Fix CTAD not work for C++ explicit type conversion (function

[clang] [clang] Fix CTAD not work for C++ explicit type conversion (functional annotation). (PR #75779)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/75779 >From 163a43a3c62964a6010dd57aa2670e7629c0a847 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 18 Dec 2023 10:41:45 +0100 Subject: [PATCH 1/2] [clang] Fix CTAD not work for C++ explicit type conversion (func

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/72428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/72428 >From e182e764778eb137f465812270fcdf03d0fe2da1 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 15 Nov 2023 20:31:12 +0100 Subject: [PATCH 1/3] [clang][AST] Invalidate DecompositionDecl if it has invalid init

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

hokein wrote: > We need a release note and please add a more detailed summary. A description > of the problem being solved and the solution to the fix provides. Done. https://github.com/llvm/llvm-project/pull/72428 ___ cfe-commits mailing list cfe-c

[clang] [clang] Fix CTAD not work for C++ explicit type conversion (functional annotation). (PR #75779)

https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/75779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix CTAD not work for C++ explicit type conversion (functional annotation). (PR #75779)

hokein wrote: > > Thanks, I have updated the description with more details. > > If it has to appear in the git log, it has to be added to the commit message. > GitHub is separate from Git, so updating the opening comment of the PR won't > be visible through `git`. GitHub's "squash and merge"

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/72428 >From f114c48948d8b56a5e04e50b7f27ce499e60bc77 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 15 Nov 2023 20:31:12 +0100 Subject: [PATCH 1/3] [clang][AST] Invalidate DecompositionDecl if it has invalid init

[clang] [AST] RecursiveASTVisitor: traverse the require clause for partial template specializations. (PR #75795)

https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/75795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix crash on invalid code with parenthesized aggregate initialization (PR #76232)

https://github.com/hokein approved this pull request. Thanks, looks good. https://github.com/llvm/llvm-project/pull/76232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Avoid crash when summarizing pointer-to-member expr for block-end hint (PR #76492)

https://github.com/hokein approved this pull request. Thanks. Can you add your analysis (https://github.com/clangd/clangd/issues/1873#issuecomment-1870902480) to the commit description, I think it is useful to have it in the commit log. btw, it looks like there is a FIXME (https://github.com

[clang-tools-extra] [clangd] Track IWYU pragmas for non-preamble includes (PR #75612)

https://github.com/hokein approved this pull request. thanks, looks good. https://github.com/llvm/llvm-project/pull/75612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Tooling] Print the progress when there are multiple files to process (PR #75904)

https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/75904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Dont require confirmation for include-cleaner batch-fixes (PR #76826)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/76826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Dont require confirmation for include-cleaner batch-fixes (PR #76826)

https://github.com/hokein approved this pull request. This change makes sense for removing all unused includes (as all these unused includes are visible in the editor). For missing includes, they are less obvious, but it is probably fine. (I think it would be great to have a way to view all mi

[clang-tools-extra] [clangd] Dont require confirmation for include-cleaner batch-fixes (PR #76826)

@@ -237,18 +236,6 @@ removeAllUnusedIncludes(llvm::ArrayRef UnusedIncludes) { Diag.Fixes.front().Edits.begin(), Diag.Fixes.front().Edits.end()); } - - // TODO(hokein): emit a suitable text for the label. - ChangeAnnotat

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/76960 We have a previous fix https://github.com/llvm/llvm-project/commit/be861b64d94198230d8f9889b17280e3cd215a0a, which snapshots all processing files. It works most of times, the snapshot (InMemoryFileSystem) is bas

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/76960 >From 6cc7141f1f182763ccec8a4801d3b866cc839324 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 4 Jan 2024 14:59:22 +0100 Subject: [PATCH 1/2] [include-cleaner] Fix a race issue when editing multiple files.

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/76960 >From 6cc7141f1f182763ccec8a4801d3b866cc839324 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 4 Jan 2024 14:59:22 +0100 Subject: [PATCH 1/3] [include-cleaner] Fix a race issue when editing multiple files.

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/76960 >From 6cc7141f1f182763ccec8a4801d3b866cc839324 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Thu, 4 Jan 2024 14:59:22 +0100 Subject: [PATCH 1/4] [include-cleaner] Fix a race issue when editing multiple files.

[clang-tools-extra] [include-cleaner] Fix a race issue when editing multiple files. (PR #76960)

https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/76960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash when referencing the result if the overload fails (PR #77288)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/77288 after 20a05677f9394d4bc9467fe7bc93a4ebd3aeda61 If the overload fails, the `Best` might point to the `end()`, referencing it leads to asan crashes. >From 5061fbfe8c8840dc49c12bb533fa5d537efc8333 Mon Sep 17 00:00:

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/72428 >From 662be3d00eed883db6b1babe489b981847e9b907 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 15 Nov 2023 20:31:12 +0100 Subject: [PATCH 1/3] [clang][AST] Invalidate DecompositionDecl if it has invalid init

[clang] [clang][AST] Invalidate DecompositionDecl if it has invalid initializer. (PR #72428)

hokein wrote: Friendly ping. https://github.com/llvm/llvm-project/pull/72428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash when referencing the result if the overload fails (PR #77288)

https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/77288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix a crash when referencing the result if the overload fails (PR #77288)

hokein wrote: Thanks for the review. https://github.com/llvm/llvm-project/pull/77288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Teach TextNodeDumper to print the "implicit" bit for coroutine AST nodes (PR #77311)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/77311 None >From b0efa2e20f1ca7bc9e18b81231574895fe2281c3 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 8 Jan 2024 14:43:40 +0100 Subject: [PATCH] [AST] TextNodeDumper print the "implicit" bit for coroutine AST

[clang] [AST] Teach TextNodeDumper to print the "implicit" bit for coroutine AST nodes (PR #77311)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/77311 >From b0efa2e20f1ca7bc9e18b81231574895fe2281c3 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 8 Jan 2024 14:43:40 +0100 Subject: [PATCH 1/2] [AST] TextNodeDumper print the "implicit" bit for coroutine AST n

[clang] [AST] Teach TextNodeDumper to print the "implicit" bit for coroutine AST nodes (PR #77311)

@@ -0,0 +1,46 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-unknown %s -std=c++20 \ +// RUN:-fsyntax-only -ast-dump -ast-dump-filter test | FileCheck %s + +#include "Inputs/std-coroutine.h" + +using namespace std; + +struct Task { + struct promise_type { +std::suspend_alw

[clang] [AST] Teach TextNodeDumper to print the "implicit" bit for coroutine AST nodes (PR #77311)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/77311 >From b0efa2e20f1ca7bc9e18b81231574895fe2281c3 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Mon, 8 Jan 2024 14:43:40 +0100 Subject: [PATCH 1/3] [AST] TextNodeDumper print the "implicit" bit for coroutine AST n

[clang] [AST] Teach TextNodeDumper to print the "implicit" bit for coroutine AST nodes (PR #77311)

https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/77311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/77454 This fixes #69219. Consider an example: ``` CoTask my_coroutine() { std::abort(); co_return 1; // unreachable code warning. } ``` Clang emits a CFG-based unreachable warning on the `co_return` statement

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

@@ -60,6 +61,45 @@ static bool isTrivialDoWhile(const CFGBlock *B, const Stmt *S) { return false; } +// Check if the block starts with a coroutine statement and see if the given +// unreachable 'S' is the substmt of the coroutine statement. +// +// We suppress the unreachab

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

https://github.com/hokein ready_for_review https://github.com/llvm/llvm-project/pull/77454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Mark the fallthrough coreturn statement implicit. (PR #77465)

https://github.com/hokein created https://github.com/llvm/llvm-project/pull/77465 None >From 17afb4cb0e43ae77268ad406cd2510af69756fae Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Tue, 9 Jan 2024 14:02:01 +0100 Subject: [PATCH] [AST] Mark the fallthrough coreturn statement implicit. --- cl

[clang-tools-extra] 1ba7f52 - [pseudo] Update the cxx.bnf path in comments to reflect the new

Author: Haojian Wu Date: 2022-06-29T15:10:39+02:00 New Revision: 1ba7f5218ccdc0b4fd836cb4f0d647866f793c87 URL: https://github.com/llvm/llvm-project/commit/1ba7f5218ccdc0b4fd836cb4f0d647866f793c87 DIFF: https://github.com/llvm/llvm-project/commit/1ba7f5218ccdc0b4fd836cb4f0d647866f793c87.diff LO

[clang-tools-extra] fe66aeb - [pseudo] Define a clangPseudoCLI library.

Author: Haojian Wu Date: 2022-07-01T08:31:34+02:00 New Revision: fe66aebd755191fac66a73b50d94c29f60be9a88 URL: https://github.com/llvm/llvm-project/commit/fe66aebd755191fac66a73b50d94c29f60be9a88 DIFF: https://github.com/llvm/llvm-project/commit/fe66aebd755191fac66a73b50d94c29f60be9a88.diff LO

[clang-tools-extra] c998273 - [pseudo] Fix an out-of-bound issue in getReduceRules.

Author: Haojian Wu Date: 2022-07-01T20:16:06+02:00 New Revision: c99827349927a44334f2b04139168efd0bc87cd3 URL: https://github.com/llvm/llvm-project/commit/c99827349927a44334f2b04139168efd0bc87cd3 DIFF: https://github.com/llvm/llvm-project/commit/c99827349927a44334f2b04139168efd0bc87cd3.diff LO

[clang-tools-extra] bbcd8e5 - [pseudo] NFC, polish the fix of c99827349927a44334f2b04139168efd0bc87cd3

Author: Haojian Wu Date: 2022-07-01T21:25:46+02:00 New Revision: bbcd8e5271f4af3adc28e458642a0dc65d253acd URL: https://github.com/llvm/llvm-project/commit/bbcd8e5271f4af3adc28e458642a0dc65d253acd DIFF: https://github.com/llvm/llvm-project/commit/bbcd8e5271f4af3adc28e458642a0dc65d253acd.diff LO

[clang-tools-extra] 5f0a054 - [pseudo] Remove duplicated code in ClangPseudo.cpp

Author: Haojian Wu Date: 2022-07-04T11:32:56+02:00 New Revision: 5f0a054f8954d83aea66bac0ffa27887ff2eaade URL: https://github.com/llvm/llvm-project/commit/5f0a054f8954d83aea66bac0ffa27887ff2eaade DIFF: https://github.com/llvm/llvm-project/commit/5f0a054f8954d83aea66bac0ffa27887ff2eaade.diff LO

[clang-tools-extra] 70c0d92 - [pseudo] Use the prebuilt cxx grammar for the lit tests, NFC.

Author: Haojian Wu Date: 2022-07-05T15:17:18+02:00 New Revision: 70c0d92930b28104324b0888d6c6fdde2ffa5a07 URL: https://github.com/llvm/llvm-project/commit/70c0d92930b28104324b0888d6c6fdde2ffa5a07 DIFF: https://github.com/llvm/llvm-project/commit/70c0d92930b28104324b0888d6c6fdde2ffa5a07.diff LO

[clang-tools-extra] d263447 - [pseudo] Fix the build for the benchmark tool.

Author: Haojian Wu Date: 2022-07-05T15:42:41+02:00 New Revision: d26344731128ccdd8eeb27a12b2c3bd75e5e3a63 URL: https://github.com/llvm/llvm-project/commit/d26344731128ccdd8eeb27a12b2c3bd75e5e3a63 DIFF: https://github.com/llvm/llvm-project/commit/d26344731128ccdd8eeb27a12b2c3bd75e5e3a63.diff LO

[clang-tools-extra] 9ab67cc - [pseudo] Implement guard extension.

Author: Haojian Wu Date: 2022-07-05T15:55:15+02:00 New Revision: 9ab67cc8bfe7181b7d775bab4d7a908dc8774889 URL: https://github.com/llvm/llvm-project/commit/9ab67cc8bfe7181b7d775bab4d7a908dc8774889 DIFF: https://github.com/llvm/llvm-project/commit/9ab67cc8bfe7181b7d775bab4d7a908dc8774889.diff LO

[clang-tools-extra] cd3aa33 - [pseudo] NFC, fix the header guard for Language.h

Author: Haojian Wu Date: 2022-07-07T14:42:26+02:00 New Revision: cd3aa338c720b9ee296348e3670c284cfead969d URL: https://github.com/llvm/llvm-project/commit/cd3aa338c720b9ee296348e3670c284cfead969d DIFF: https://github.com/llvm/llvm-project/commit/cd3aa338c720b9ee296348e3670c284cfead969d.diff LO

[clang-tools-extra] f383b88 - [pseudo] Sort nonterminals based on their reduction order.

Author: Haojian Wu Date: 2022-03-24T14:30:12+01:00 New Revision: f383b88d8214dc8f2d8bc9521c3ddd1c4454927f URL: https://github.com/llvm/llvm-project/commit/f383b88d8214dc8f2d8bc9521c3ddd1c4454927f DIFF: https://github.com/llvm/llvm-project/commit/f383b88d8214dc8f2d8bc9521c3ddd1c4454927f.diff LO

<    1   2   3   4   5   6   7   8   9   10   >