This revision was automatically updated to reflect the committed changes.
Closed by commit rL271382: [include-fixer] Use YAML format in -output-headers
and -insert-header mode. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20827?vs=59187&id=59198#toc
Repository:
rL
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
Make the check's behavior more correct when handling using-decls in multiple
scopes.
http://reviews.llvm.org/D20909
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedU
hokein updated this revision to Diff 59492.
hokein added a comment.
Address code comments.
http://reviews.llvm.org/D20909
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unuse
Author: hokein
Date: Fri Jun 3 03:05:11 2016
New Revision: 271632
URL: http://llvm.org/viewvc/llvm-project?rev=271632&view=rev
Log:
[clang-tidy] Ignore function context in misc-unused-using-decls.
Summary: Make the check's behavior more correct when handling using-decls in
multiple scopes.
Rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271632: [clang-tidy] Ignore function context in
misc-unused-using-decls. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20909?vs=59492&id=59494#toc
Repository:
rL LLVM
http:
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
The further solution is to add the missing header to the file where the
symbol comes from.
http://reviews.llvm.org/D20950
Files:
include-fixer/IncludeFixer.cpp
unittests/include-fixer/Incl
Author: hokein
Date: Fri Jun 3 06:26:02 2016
New Revision: 271660
URL: http://llvm.org/viewvc/llvm-project?rev=271660&view=rev
Log:
[include-fixer] Don't add missing header if the unindentified symbol isn't from
the main file.
Summary:
The further solution is to add the missing header to the fi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271660: [include-fixer] Don't add missing header if the
unindentified symbol isn't… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20950?vs=59496&id=59529#toc
Repository:
rL
hokein created this revision.
hokein added reviewers: bkramer, ioeric.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20966
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include
hokein added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.py:53
@@ +52,3 @@
+ except Exception:
+if res == '':
+ # choose the top ranked header by default
We can handle the ` ` , `a`, `q` cases after `res=vim.eval(to_eval)` instead
hokein updated this revision to Diff 59721.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20467
Files:
docs/ReleaseNotes.rst
docs/include-fixer.rst
Index: docs/include-fixer.rst
===
hokein added a comment.
In http://reviews.llvm.org/D20467#435685, @Eugene.Zelenko wrote:
> Could you please mention include-fixer in docs/ReleaseNotes.rst? This is
> definitely major new feature in upcoming release.
Done.
http://reviews.llvm.org/D20467
___
hokein updated this revision to Diff 59725.
hokein marked 3 inline comments as done.
hokein added a comment.
Add comments.
http://reviews.llvm.org/D20467
Files:
docs/ReleaseNotes.rst
docs/include-fixer.rst
Index: docs/include-fixer.rst
==
hokein updated this revision to Diff 59838.
hokein added a comment.
Fix typo.
http://reviews.llvm.org/D20467
Files:
docs/ReleaseNotes.rst
docs/include-fixer.rst
Index: docs/include-fixer.rst
===
--- docs/include-fixer.rst
+++
Author: hokein
Date: Tue Jun 7 02:50:48 2016
New Revision: 271989
URL: http://llvm.org/viewvc/llvm-project?rev=271989&view=rev
Log:
[include-fixer] Mention more details in the document.
Reviewers: bkramer
Subscribers: Eugene.Zelenko, cfe-commits, ioeric
Differential Revision: http://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271989: [include-fixer] Mention more details in the
document. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20467?vs=59838&id=59839#toc
Repository:
rL LLVM
http://reviews.l
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D21059
Files:
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
test/clang-tidy/misc-definitions-in-headers-cxx11.hpp
Index: test/clang-tidy/misc-definitions-in-headers-
hokein updated this revision to Diff 59843.
hokein marked an inline comment as done.
hokein added a comment.
Use the existing test file.
http://reviews.llvm.org/D21059
Files:
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
test/clang-tidy/misc-definitions-in-headers.hpp
Index: test/clang-tid
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271991: [clang-tidy] Ignore the deleted function in
misc-definitions-in-headers. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21059?vs=59843&id=59845#toc
Repository:
rL LLV
Author: hokein
Date: Tue Jun 7 03:55:38 2016
New Revision: 271991
URL: http://llvm.org/viewvc/llvm-project?rev=271991&view=rev
Log:
[clang-tidy] Ignore the deleted function in misc-definitions-in-headers.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org
hokein added inline comments.
Comment at: test/clang-tidy/misc-misplaced-const.c:17
@@ +16,3 @@
+ const ip i3 = 0;
+ // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'i3' declared with a
const-qualified typedef type; results in the type being 'int *const' instead of
'const int *'
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:104
@@ -103,3 @@
-// class Bar;
-// Foo foo;
-//
bkramer wrote:
> Does this patch do the right thing for the test case in the comment?
> Otherwise we'll try add includes to s
hokein added inline comments.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
hokein wrote:
> madsravn wrote:
hokein added a comment.
@aaron.ballman, you forgot to add the check in docs/ReleaseNotes.rst.
http://reviews.llvm.org/D21036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added reviewers: bkramer, ioeric.
hokein added a subscriber: cfe-commits.
Currently, removing dot dot in header's path doesn't make include-fixer
minimize path correctly in some cases, for example, specify a relative search
path based on the build directory("-I
Author: hokein
Date: Wed Jun 8 10:10:18 2016
New Revision: 272152
URL: http://llvm.org/viewvc/llvm-project?rev=272152&view=rev
Log:
[include-fixer] Keep dot dot in SymbolInfo file paths.
Summary:
Currently, removing dot dot in header's path doesn't make include-fixer
minimize path correctly in s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272152: [include-fixer] Keep dot dot in SymbolInfo file
paths. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21132?vs=60041&id=60042#toc
Repository:
rL LLVM
http://reviews.
hokein updated this revision to Diff 60041.
hokein added a comment.
Rebase.
http://reviews.llvm.org/D21132
Files:
include-fixer/find-all-symbols/PathConfig.cpp
include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp
test/include-fixer/include_path.cpp
unittests/include-fixer/find-all
hokein created this revision.
hokein added a reviewer: klimek.
hokein added subscribers: cfe-commits, spatel.
A follow-up fix on D21235.
http://reviews.llvm.org/D21278
Files:
lib/Target/X86/X86ISelLowering.cpp
Index: lib/Target/X86/X86ISelLowering.cpp
=
hokein added a comment.
In http://reviews.llvm.org/D21278#455850, @klimek wrote:
> LG. Fix the change description when submitting, though - this is not about an
> enum comparison, right?
Done. This is enumeral mismatch indeed.
http://reviews.llvm.org/D21278
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272539: Fix an enumeral mismatch warning. (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D21278?vs=60494&id=60498#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21278
File
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added subscribers: cfe-commits, ioeric.
http://reviews.llvm.org/D21371
Files:
include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
Author: hokein
Date: Wed Jun 15 06:15:12 2016
New Revision: 272773
URL: http://llvm.org/viewvc/llvm-project?rev=272773&view=rev
Log:
[include-fixer] Correct two wrong header mappings.
Reviewers: bkramer
Subscribers: ioeric, cfe-commits
Differential Revision: http://reviews.llvm.org/D21371
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272773: [include-fixer] Correct two wrong header mappings.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21371?vs=60812&id=60814#toc
Repository:
rL LLVM
http://reviews.llvm
Author: hokein
Date: Thu Jun 16 08:27:02 2016
New Revision: 272890
URL: http://llvm.org/viewvc/llvm-project?rev=272890&view=rev
Log:
A follow-up fixing on cuda-march.cu: Don't match clang to other place.
Modified:
cfe/trunk/test/Driver/cuda-march.cu
Modified: cfe/trunk/test/Driver/cuda-march
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D21470
Files:
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
Index: clang-tidy/misc/DefinitionsInHeadersCheck.cpp
==
hokein added a comment.
A few comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:59
@@ -57,2 +58,3 @@
CheckFactories.registerCheck("modernize-use-nullptr");
+CheckFactories.registerCheck("modernize-use-emplace");
CheckFactories.registerCheck("modern
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks almost good now, a few comments. You'd better await for comments from
@alexfh or @sbenza before committing.
Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst
hokein created this revision.
hokein added a subscriber: cfe-commits.
This is an initial version of fixing namespace issues by adding a missing
namespace prefix to an unidentified symbol.
This version only fixes the first discovered unidentified symbol
In the long run, include-fixer should fix al
hokein updated this revision to Diff 61524.
hokein added a comment.
Fix a typo.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/SymbolIndexManager.cpp
include-fixer/SymbolIndexManager.h
include-fixer/find-all-symbo
Author: hokein
Date: Mon Jun 27 03:04:01 2016
New Revision: 273849
URL: http://llvm.org/viewvc/llvm-project?rev=273849&view=rev
Log:
[clang-tidy] Don't run misc-definitions-in-headers check in failing TUs.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273849: [clang-tidy] Don't run misc-definitions-in-headers
check in failing TUs. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21470?vs=61092&id=61938#toc
Repository:
rL LLV
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D21747
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
Author: hokein
Date: Mon Jun 27 09:47:39 2016
New Revision: 273882
URL: http://llvm.org/viewvc/llvm-project?rev=273882&view=rev
Log:
[clang-tidy] Warning enum unused using declarations.
Reviewers: alexfh, aaron.ballman
Subscribers: aaron.ballman, cfe-commits
Differential Revision: http://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273882: [clang-tidy] Warning enum unused using declarations.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21747?vs=61955&id=61966#toc
Repository:
rL LLVM
http://reviews.ll
hokein added a comment.
In http://reviews.llvm.org/D21603#468717, @djasper wrote:
> Sorry, I completely forgot about this. Will try to review today. Is this part
> about the patch description accurate?
Yes, the description is accurate.
> Specifically, what needs to be implemented in vim to ma
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added subscribers: cfe-commits, Eugene.Zelenko.
Fix PR28350.
http://reviews.llvm.org/D21833
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-u
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D21860
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.c
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22
@@ +21,3 @@
+namespace {
+// FIXME: Move this node matcher to ASTMatcher.
+const internal::VariadicDynCastAllOfMatcher enumType;
Done in D21860.
http://reviews.llvm
hokein updated this revision to Diff 62278.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D21833
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
Author: hokein
Date: Thu Jun 30 02:50:01 2016
New Revision: 274217
URL: http://llvm.org/viewvc/llvm-project?rev=274217&view=rev
Log:
[ASTMatcher] Add a node matcher for EnumType.
Reviewers: aaron.ballman
Subscribers: cfe-commits, klimek
Differential Revision: http://reviews.llvm.org/D21860
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274217: [ASTMatcher] Add a node matcher for EnumType.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21860?vs=62277&id=62340#toc
Repository:
rL LLVM
http://reviews.llvm.org/
hokein updated this revision to Diff 62354.
hokein added a comment.
enumType is already in ASTMatcher now.
http://reviews.llvm.org/D21833
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D21833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:234
@@ +233,3 @@
+ std::string MinimizedFilePath = minimizeInclude(
+ ((FilePath[0] == '"' || FilePath[0] == '<') ? FilePath
+ : "\"" + FileP
hokein updated this revision to Diff 62383.
hokein marked 4 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/SymbolIndexManager.cpp
include-fix
hokein updated this revision to Diff 62473.
hokein marked 5 inline comments as done.
hokein added a comment.
Fix review comments.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/SymbolIndexManager.cpp
include-fixer/S
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:258
@@ +257,3 @@
+
+// Query the symbol based on C++ name Lookup rules.
+// Firstly, lookup the identifier with scoped namespace contexts; If fails,
djasper wrote:
> Could you add som
hokein added a comment.
Friendly ping ;)
http://reviews.llvm.org/D21833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Mon Jul 4 07:01:56 2016
New Revision: 274496
URL: http://llvm.org/viewvc/llvm-project?rev=274496&view=rev
Log:
[clang-tidy] Fix more enum declaration cases in misc-unused-using-decls check.
Summary: Fix PR28350.
Reviewers: alexfh
Subscribers: aaron.ballman, Eugene.Zelenko,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274496: [clang-tidy] Fix more enum declaration cases in
misc-unused-using-decls check. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21833?vs=62354&id=62668#toc
Repository:
hokein updated this revision to Diff 62849.
hokein marked 2 inline comments as done.
hokein added a comment.
Address Ben's comments.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/SymbolIndexManager.cpp
include-fixe
hokein added a comment.
In http://reviews.llvm.org/D21603#475011, @bkramer wrote:
> In the future I'd prefer to have patches like this split up in a part that
> refactors and a part that contains the actual change. Having that in one
> patch makes it really hard to review.
Acknowledged. I'm s
hokein updated this revision to Diff 63043.
hokein marked 3 inline comments as done.
hokein added a comment.
- Address Daniel's comments.
- Add tests for nested classes.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/
hokein added inline comments.
Comment at: unittests/include-fixer/IncludeFixerTest.cpp:144
@@ -141,1 +143,3 @@
+runIncludeFixer("a::b::foo bar;\n",
+/*FixNamespaceQualifiers=*/true, IncludePath));
djasper wrote:
> I think
Author: hokein
Date: Fri Jul 8 04:10:29 2016
New Revision: 274832
URL: http://llvm.org/viewvc/llvm-project?rev=274832&view=rev
Log:
[include-fixer] Add missing namespace qualifiers after inserting a missing
header.
Summary:
This is an initial version of fixing namespace issues by adding missing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274832: [include-fixer] Add missing namespace qualifiers
after inserting a missing… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D21603?vs=63043&id=63189#toc
Repository:
rL
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D22127
Files:
include-fixer/IncludeFixerContext.h
unittests/include-fixer/IncludeFixerTest.cpp
Index: unittests/include-fixer/IncludeFixerTest.cpp
=
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D22100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: hokein
Date: Fri Jul 8 07:05:06 2016
New Revision: 274839
URL: http://llvm.org/viewvc/llvm-project?rev=274839&view=rev
Log:
[clang-rename] fix typo in Python script for Vim integration
Patch by Kirill Bobyrev!
Reviewers: kimgr, alexfh, bkramer, ioeric, hokein
Subscribers: cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274839: [clang-rename] fix typo in Python script for Vim
integration (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22100?vs=63101&id=63203#toc
Repository:
rL LLVM
http://re
Author: hokein
Date: Fri Jul 8 08:11:38 2016
New Revision: 274845
URL: http://llvm.org/viewvc/llvm-project?rev=274845&view=rev
Log:
[include-fixer] Pull out Context implementation code to a cpp file.
Added:
clang-tools-extra/trunk/include-fixer/IncludeFixerContext.cpp
Modified:
clang-too
Author: hokein
Date: Fri Jul 8 09:28:43 2016
New Revision: 274848
URL: http://llvm.org/viewvc/llvm-project?rev=274848&view=rev
Log:
[include-fixer] Don't add qualifiers to symbols which have global scope
operator.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: http://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274848: [include-fixer] Don't add qualifiers to symbols
which have global scope… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22127?vs=63221&id=63223#toc
Repository:
rL LLV
hokein updated this revision to Diff 63221.
hokein added a comment.
Rebase to master.
http://reviews.llvm.org/D22127
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
unittests/include-fixer/IncludeFixerTest.cpp
Index: unittests/include-fixer/IncludeFixerTe
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
Although there is no guarantee of getOptions/getRawOptions receiving an
absolute path, we try to make it if possible. So FileOptionProvider subclasses
don't have to convert the path to an absolut
hokein added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:48
@@ +47,3 @@
+
+ // Assignement slicing: "a = b;" and "a = std::move(b);" variants.
+ const auto SlicesObjectInAssignment =
Looks like you are missing some cases here, like
Author: hokein
Date: Mon Jul 11 02:47:04 2016
New Revision: 275051
URL: http://llvm.org/viewvc/llvm-project?rev=275051&view=rev
Log:
[clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions.
Summary:
Although there is no guarantee of getOptions/getRawOptions receiving an
absol
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275051: [clang-tidy] Pass absolute path to
OptionsProvider::getOptions/getRawOptions. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22154?vs=63282&id=63469#toc
Repository:
r
hokein added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:48
@@ +47,3 @@
+
+ // Assignement slicing: "a = b;" and "a = std::move(b);" variants.
+ const auto SlicesObjectInAssignment =
courbet wrote:
> hokein wrote:
> > Looks like yo
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D22260
Files:
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
test/clang-tidy/misc-definitions-in-headers.hpp
Index: test/clang-tidy/misc-definitions-in-headers.hpp
==
hokein added a comment.
@aaron.ballman, could you take a look on this patch? Alex is on vocation these
days.
http://reviews.llvm.org/D22260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hokein added a subscriber: hokein.
hokein added a comment.
Someone fixed this error r275254 several hours ago.
> List of Clang-tidy checks was not updated for long time (I still don't see
> modernize-use-emplace). May be documentation contains other mistakes?
Are the clang-tools-extra document
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
The patch extends include-fixer's "-output-headers", and "-insert-headers"
command line options to make it dump more information (e.g. QualifiedSymbol),
so that vim-integration can add missing q
hokein updated this revision to Diff 63789.
hokein added a comment.
Remove a debug print statement.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-f
hokein updated this revision to Diff 63796.
hokein marked 6 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
hokein marked an inline comment as done.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+// Only accept an unique header.
+bool IsUniqueHeader =
+std::adjacent_find(HeaderInfos.begin(), HeaderInfos.end(),
You are right. `adja
hokein updated this revision to Diff 63799.
hokein marked 2 inline comments as done.
hokein added a comment.
Add comments for std::equal.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cp
hokein added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:252
@@ +251,3 @@
+assert(!HeaderInfos.empty());
+// Only accept an unique header.
+bool IsUniqueHeader = std::equal(
bkramer wrote:
> In that case adjacent_find was the
Author: hokein
Date: Wed Jul 13 08:55:29 2016
New Revision: 275263
URL: http://llvm.org/viewvc/llvm-project?rev=275263&view=rev
Log:
[clang-tidy] Fix misc-definitions-in-headers misplaced fixing to fully
templated function.
Reviewers: alexfh, aaron.ballman
Subscribers: cfe-commits
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275263: [clang-tidy] Fix misc-definitions-in-headers
misplaced fixing to fully… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22260?vs=63649&id=63802#toc
Repository:
rL LLVM
hokein updated this revision to Diff 63808.
hokein marked an inline comment as done.
hokein added a comment.
Fix nits.
http://reviews.llvm.org/D22299
Files:
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/t
Author: hokein
Date: Wed Jul 13 11:43:54 2016
New Revision: 275279
URL: http://llvm.org/viewvc/llvm-project?rev=275279&view=rev
Log:
[include-fixer] Implement adding missing namespace qualifiers in vim
integration.
Summary:
The patch extends include-fixer's "-output-headers", and "-insert-header
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275279: [include-fixer] Implement adding missing namespace
qualifiers in vim… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22299?vs=63808&id=63818#toc
Repository:
rL LLVM
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
The judgement that checks whether the fully-qualified name has scoped qualifiers
prefix is incorrect. Should always check whether the first matched postion is
the
beginning position.
http://re
hokein added inline comments.
Comment at: include-fixer/IncludeFixerContext.cpp:46
@@ +45,3 @@
+ bool HasScopedQualifiersPrefix =
+ FullyQualifiedName.find(SymbolScopedQualifiers) == 0;
+ if (!HasScopedQualifiersPrefix)
bkramer wrote:
> StringRef(FullyQuali
hokein updated this revision to Diff 63941.
hokein marked an inline comment as done.
hokein added a comment.
Use StringRef::startwith.
http://reviews.llvm.org/D22343
Files:
include-fixer/IncludeFixerContext.cpp
unittests/include-fixer/IncludeFixerTest.cpp
Index: unittests/include-fixer/Inc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275386: [include-fixer] Correct an incorrecst judgement
about prefix scoped qualifiers. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D22343?vs=63941&id=63942#toc
Repository:
Author: hokein
Date: Thu Jul 14 04:39:12 2016
New Revision: 275386
URL: http://llvm.org/viewvc/llvm-project?rev=275386&view=rev
Log:
[include-fixer] Correct an incorrecst judgement about prefix scoped qualifiers.
Summary:
The judgement that checks whether the fully-qualified name has scoped quali
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
A small improvement: for only one suggested header, user don't have to
type ENTER manually after running the python script.
https://reviews.llvm.org/D22351
Files:
include-fixer/tool/clang-in
1901 - 2000 of 3165 matches
Mail list logo
