hokein updated this revision to Diff 48657.
hokein marked an inline comment as done.
hokein added a comment.
- Address review comments.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test
hokein marked 4 inline comments as done.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:120
@@ +119,3 @@
+ bool IsWarningAsError,
+ const std::string &BuildDirectory)
+: BuildDirectory(std::move(BuildDirectory
hokein updated this revision to Diff 48682.
hokein marked an inline comment as done.
hokein added a comment.
- Don't save BuildDirectory for every error in each check.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsu
hokein updated this revision to Diff 48683.
hokein added a comment.
Some cleanup.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/tool/ClangTidyMain.cpp
hokein updated this revision to Diff 48684.
hokein added a comment.
Remove an extra blank line.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/tool/Cla
hokein updated this revision to Diff 48686.
hokein marked an inline comment as done.
hokein added a comment.
Address one comment.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnost
hokein marked 2 inline comments as done.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:122
@@ -121,3 +121,3 @@
IsWarningAsError(IsWarningAsError) {}
// Returns true if GlobList starts with the negative indicator ('-'), removes
it
Done. Now ther
hokein updated this revision to Diff 48924.
hokein added a comment.
Update:
- Update test to apply multiple files and fixes.
- Make it work with multiple files.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cp
hokein updated this revision to Diff 49027.
hokein marked an inline comment as done.
hokein added a comment.
Make apply-fix work on relative path in `command` field of compilation database.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/Cl
hokein updated this revision to Diff 49042.
hokein added a comment.
Save the build directory in each error, making ClangTidyError not rely on
ClangTidyContext.
The benchmark result shows that using StringRef doesn't improve performance
greatly.
http://reviews.llvm.org/D17335
Files:
clang-ti
hokein updated this revision to Diff 49044.
hokein added a comment.
Don't modify unrelevant code.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compilation-databas
hokein added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,1 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_
+Definitions
This should be in one line?
http://reviews.llvm.org
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D17586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hokein accepted this revision.
hokein added a comment.
LGTM. I will commit the patch for you @omtcyf0.
http://reviews.llvm.org/D17602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: docs/clang-tidy/checks/readability-named-parameter.rst:13
@@ -13,2 +12,3 @@
+https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
All parameters should be named, with identical names in the declaration
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261868: [clang-tidy] update links to Google Code Style in
docs (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17602?vs=49048&id=49052#toc
Repository:
rL LLVM
http://reviews.
Author: hokein
Date: Thu Feb 25 08:31:10 2016
New Revision: 261868
URL: http://llvm.org/viewvc/llvm-project?rev=261868&view=rev
Log:
[clang-tidy] update links to Google Code Style in docs
Summary: Because of the recent Google Code shutdown links to the Google Code
Style up there are no longer re
hokein updated this revision to Diff 49054.
hokein added a comment.
Simplify test code.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compilation-database/template
hokein updated this revision to Diff 49060.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/clang-tidy/Inputs/compilation-database/tem
hokein marked 3 inline comments as done.
Comment at: test/clang-tidy/clang-tidy-run-with-database.cpp:16
@@ +15,3 @@
+// RUN: FileCheck -input-file=%T/compilation-database-test/a/b.cpp %s
-check-prefix=CHECK-FIX2
+// RUN: FileCheck -input-file=%T/compilation-database-test/b/b.cpp
hokein updated this revision to Diff 49159.
hokein marked an inline comment as done.
hokein added a comment.
Nit: correct a comment.
http://reviews.llvm.org/D17335
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test/cl
Author: hokein
Date: Fri Feb 26 03:19:33 2016
New Revision: 261991
URL: http://llvm.org/viewvc/llvm-project?rev=261991&view=rev
Log:
[clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.
Summary:
The clang-tidy will trigger an assertion if it's not in the building directo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261991: [clang-tidy] Fix a crash issue when clang-tidy runs
with compilation database. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17335?vs=49159&id=49164#toc
Repository:
hokein updated this revision to Diff 49186.
hokein added a comment.
Correct test code format.
http://reviews.llvm.org/D17640
Files:
clang-tidy/modernize/UseNullptrCheck.cpp
test/clang-tidy/modernize-use-nullptr.cpp
Index: test/clang-tidy/modernize-use-nullptr.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262024: [clang-tidy] Fix an assertion failure in
`modernize-use-nullptr` check. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D17640?vs=49186&id=49187#toc
Repository:
rL LLVM
Author: hokein
Date: Fri Feb 26 09:34:35 2016
New Revision: 262024
URL: http://llvm.org/viewvc/llvm-project?rev=262024&view=rev
Log:
[clang-tidy] Fix an assertion failure in `modernize-use-nullptr` check.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the quick fix!
http://reviews.llvm.org/D19539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
hokein updated this revision to Diff 55170.
hokein added a comment.
Fix remaining nits.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
test/clang-ti
hokein marked 2 inline comments as done.
Comment at: clang-tidy/ClangTidyOptions.h:233
@@ -200,2 +232,3 @@
- ClangTidyOptions getOptions(llvm::StringRef FileName) override;
+ std::vector getRawOptions(
+ llvm::StringRef FileName) override;
alexfh wrote:
>
hokein updated this revision to Diff 55172.
hokein marked 2 inline comments as done.
hokein added a comment.
Update.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include
hokein added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:38
@@ +37,3 @@
+private:
+ ResultReporter *const Reporter;
+};
bkramer wrote:
> nit: move const to the start of the line.
Moving `const` to the start of line will change se
Author: hokein
Date: Wed Apr 27 04:15:01 2016
New Revision: 267683
URL: http://llvm.org/viewvc/llvm-project?rev=267683&view=rev
Log:
[ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes
from.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://rev
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL267683: [ClangTidy] Add an 'explain-checks' option to
diagnose where each checks… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D18694?v
Author: hokein
Date: Wed Apr 27 05:22:31 2016
New Revision: 267687
URL: http://llvm.org/viewvc/llvm-project?rev=267687&view=rev
Log:
Don't search compilation database in explain-check test.
Reviewers: alexfh
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D19583
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267687: Don't search compilation database in explain-check
test. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19583?vs=55177&id=55178#toc
Repository:
rL LLVM
http://review
Author: hokein
Date: Wed Apr 27 07:17:04 2016
New Revision: 267700
URL: http://llvm.org/viewvc/llvm-project?rev=267700&view=rev
Log:
Fix a crash in cppcoreguidelines-pro-type-member-init when checking a type with
a template parameter as a base class.
Summary: Fixed a crash in cppcoreguidelines-p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267700: Fix a crash in
cppcoreguidelines-pro-type-member-init when checking a type… (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D19539?vs=55026&id=55192#toc
Repository:
rL
Author: hokein
Date: Wed Apr 27 08:23:39 2016
New Revision: 267711
URL: http://llvm.org/viewvc/llvm-project?rev=267711&view=rev
Log:
Remove explain-config testcase that detect hard-coded check.
Remove it for now, we need to better way to figure out how to test it.
Modified:
clang-tools-extra
hokein updated this revision to Diff 55220.
hokein marked 13 inline comments as done.
hokein added a comment.
Add Daniel's comments.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbo
hokein added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:22-24
@@ +21,5 @@
+
+using SymbolInfo = clang::find_all_symbols::SymbolInfo;
+using SymbolType = clang::find_all_symbols::SymbolInfo::SymbolType;
+using ContextType = clang::find_all_symbol
hokein updated this revision to Diff 55223.
hokein added a comment.
Fix a nit.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols
hokein updated this revision to Diff 55226.
hokein added a comment.
Fix another nit.
http://reviews.llvm.org/D19482
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllS
Author: hokein
Date: Wed Apr 27 09:27:05 2016
New Revision: 267719
URL: http://llvm.org/viewvc/llvm-project?rev=267719&view=rev
Log:
[include-fixer] Add a find-all-symbols tool for include-fixer.
Summary:
The find-all-symbols tool generates a yaml symbol database for
include-fixer.
The symbol ma
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267719: [include-fixer] Add a find-all-symbols tool for
include-fixer. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19482?vs=55226&id=55227#toc
Repository:
rL LLVM
http://
Author: hokein
Date: Wed Apr 27 11:09:34 2016
New Revision: 267731
URL: http://llvm.org/viewvc/llvm-project?rev=267731&view=rev
Log:
Don't search compilation database in explain-check, fixing buildbot test
failure.
Modified:
clang-tools-extra/trunk/test/clang-tidy/explain-checks.cpp
Modified
Author: hokein
Date: Wed Apr 27 11:39:42 2016
New Revision: 267736
URL: http://llvm.org/viewvc/llvm-project?rev=267736&view=rev
Log:
Fix explain-check failure test on Windows.
Modified:
clang-tools-extra/trunk/test/clang-tidy/explain-checks.cpp
Modified: clang-tools-extra/trunk/test/clang-ti
hokein added a comment.
@chapuni, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D19482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 55398.
hokein added a comment.
Don't append absolute path to build directory.
We will get the absolute file paths in some cases, such as STL.
http://reviews.llvm.org/D19647
Files:
include-fixer/find-all-symbols/FindAllSymbols.cpp
Index: include-fixer/fin
hokein updated this revision to Diff 55412.
hokein added a comment.
Fix a nit.
http://reviews.llvm.org/D19648
Files:
include-fixer/CMakeLists.txt
include-fixer/YamlXrefsDB.cpp
include-fixer/YamlXrefsDB.h
include-fixer/tool/ClangIncludeFixer.cpp
test/include-fixer/Inputs/fake_yaml_db.y
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D19648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Fri Apr 29 04:23:38 2016
New Revision: 268017
URL: http://llvm.org/viewvc/llvm-project?rev=268017&view=rev
Log:
[include-fixer] Add Yaml database integration.
Reviewers: bkramer
Subscribers: cfe-commits, klimek, djasper
Differential Revision: http://reviews.llvm.org/D19648
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268017: [include-fixer] Add Yaml database integration.
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19648?vs=55412&id=3#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: hokein
Date: Fri Apr 29 04:45:09 2016
New Revision: 268019
URL: http://llvm.org/viewvc/llvm-project?rev=268019&view=rev
Log:
[find-all-symbols] Save absolute file path instead of relative file path in
SymbolInfo.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268019: [find-all-symbols] Save absolute file path instead
of relative file path in… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19647?vs=55398&id=6#toc
Repository:
rL
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM with one nit.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:92
@@ +91,3 @@
+/// \brief Write SymbolInfos to a stream (YAML format).
+bool WriteSymbolInf
hokein added inline comments.
Comment at: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp:107
@@ -94,3 +106,3 @@
}
llvm::raw_fd_ostream OS(OutputFile, EC, llvm::sys::fs::F_None);
Don't we need to all 'Pool.wait()' to wait for all working threads
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Just see you updated code. LGTM.
http://reviews.llvm.org/D19720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D19183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hokein added inline comments.
Comment at: clang-tidy/google/DefaultArgumentsCheck.cpp:31
@@ +30,3 @@
+ diag(MatchedDecl->getLocation(),
+ "default argument given for virtual or override method.");
+}
Usually, clang-tidy's warning message is not a sentence,
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D19755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342
@@ +341,3 @@
+
+template
+class PositiveSelfInitialization : NegativeAggregateType
--
hokein accepted this revision.
hokein added a comment.
LGTM with some nits.
Comment at: clang-tidy/modernize/UseUsingCheck.cpp:22
@@ +21,3 @@
+void UseUsingCheck::registerMatchers(MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus)
+return;
Should be Cpl
Author: hokein
Date: Tue May 3 03:11:47 2016
New Revision: 268369
URL: http://llvm.org/viewvc/llvm-project?rev=268369&view=rev
Log:
Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class
that initializes itself as a base
Summary: Fix a crash when a record type initializes i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268369: Fix a crash in
cppcoreguidelines-pro-type-member-init when checking a class… (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D19802?vs=55904&id=55956#toc
Repository:
r
Author: hokein
Date: Tue May 3 03:38:35 2016
New Revision: 268371
URL: http://llvm.org/viewvc/llvm-project?rev=268371&view=rev
Log:
[include-fixer] Abstract includeFixerMain function.
Modified:
clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp
Modified: clang-tools-extra/trun
hokein added inline comments.
Comment at: clang-tidy/modernize/UseUsingCheck.cpp:22
@@ +21,3 @@
+void UseUsingCheck::registerMatchers(MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus)
+return;
Prazek wrote:
> hokein wrote:
> > Should be CplusPlus11 here.
Author: hokein
Date: Tue May 3 06:19:46 2016
New Revision: 268374
URL: http://llvm.org/viewvc/llvm-project?rev=268374&view=rev
Log:
Fix cppcoreguidelines-pro-type-member-init failure test on Windows.
Modified:
clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pro-type-member-init.cp
hokein updated this revision to Diff 56101.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-al
hokein added inline comments.
Comment at: include-fixer/InMemoryXrefsDB.cpp:24-26
@@ +23,5 @@
+for (const auto &Header : Entry.second) {
+ SymbolInfo Info;
+ Info.Name = Names.back();
+ Info.FilePath = Header;
+ for (auto IdentiferContext = Names.rbegin() +
hokein updated this revision to Diff 56120.
hokein added a comment.
Improvements based on offline discussion.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols
hokein updated this revision to Diff 56121.
hokein added a comment.
Fix a nit.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols.h
include-fixer/find-all-sym
hokein updated this revision to Diff 56130.
hokein marked an inline comment as done.
hokein added a comment.
Update.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAll
hokein added inline comments.
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:418
@@ +417,3 @@
+
+ {
+SymbolInfo Symbol =
klimek wrote:
> Any reason for the extra block here?
Because I want to keep consistence with other test case
hokein added a comment.
Not sure whether this is what @klimek expected..
You also need to update the FindAllSymbolsTests code (there is a
CreateSymbolInfo function there).
Comment at: include-fixer/find-all-symbols/SymbolInfo.cpp:91
@@ +90,3 @@
+void SymbolInfo::SetCommonInfo(
hokein added inline comments.
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:92
@@ -107,5 +91,3 @@
-SymbolInfo
-CreateSymbolInfo(StringRef Name, SymbolInfo::SymbolKind Type,
- const std::string FilePath, int LineNumber,
-
hokein added a comment.
It looks good to me now, but need to wait @klimek acceptance.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101
@@ +97,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+
hokein added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:31
@@ +30,3 @@
+// Convenience utility to get a RecordDecl from a QualType.
+const RecordDecl *getCanonicalRecordDecl(const QualType &Type) {
+ if (const auto *RT = Type.getCanonical
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one nit.
Comment at: test/clang-tidy/google-default-arguments.cpp:10
@@ +9,3 @@
+ void f(int I, int J = 5);
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: default a
hokein updated this revision to Diff 56540.
hokein marked 5 inline comments as done.
hokein added a comment.
- Address review comments.
- Ignore using-declarations defined in class definition.
http://reviews.llvm.org/D20018
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/Un
hokein added a comment.
I ran the check on LLVM project. The check found 8 hits:
http://reviews.llvm.org/D20060 (Check all of them, no false positives).
http://reviews.llvm.org/D20018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D19993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hokein added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:39
@@ +38,3 @@
+// Ignores using-declrations defined in class definition.
+if (isa(TargetDecl->getDeclContext()))
+ return;
djasper wrote:
> We should also ignore usin
hokein updated this revision to Diff 56555.
hokein marked 2 inline comments as done.
hokein added a comment.
Update.
http://reviews.llvm.org/D20018
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index:
hokein updated this revision to Diff 56566.
hokein added a comment.
Address remaining comments.
http://reviews.llvm.org/D20018
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Mon May 9 08:37:12 2016
New Revision: 268917
URL: http://llvm.org/viewvc/llvm-project?rev=268917&view=rev
Log:
Support variables and functions types in misc-unused-using-decls.
Summary: Fix PR27429.
Reviewers: djasper
Subscribers: cfe-commits
Differential Revision: http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268917: Support variables and functions types in
misc-unused-using-decls. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20018?vs=56566&id=56568#toc
Repository:
rL LLVM
http
Author: hokein
Date: Mon May 9 08:43:58 2016
New Revision: 268919
URL: http://llvm.org/viewvc/llvm-project?rev=268919&view=rev
Log:
[clang-tidy] new google-default-arguments check
Summary:
To check the google style guide rule here:
https://google.github.io/styleguide/cppguide.html#Default_Argume
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268919: [clang-tidy] new google-default-arguments check
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19534?vs=56529&id=56569#toc
Repository:
rL LLVM
http://reviews.llvm.or
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D20066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hokein updated this revision to Diff 56579.
hokein marked an inline comment as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D19816
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
clang-tidy/misc/UnusedUsingDeclsCheck.h
include-fixer/find-all-symbols/CMakeLists.
hokein marked an inline comment as done.
Comment at: include-fixer/find-all-symbols/PragmaCommentHandler.cpp:27
@@ +26,3 @@
+ SmallVector Matches;
+ if (!llvm::Regex(IWYUPragma).match(Text, &Matches))
+return false;
bkramer wrote:
> Isn't this regex just a c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269024: Fixed cppcoreguidelines-pro-type-member-init when
checking records with… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19993?vs=56439&id=56668#toc
Repository:
rL LLV
Author: hokein
Date: Tue May 10 02:42:19 2016
New Revision: 269024
URL: http://llvm.org/viewvc/llvm-project?rev=269024&view=rev
Log:
Fixed cppcoreguidelines-pro-type-member-init when checking records with
indirect fields
Summary:
Fixed a crash in cppcoreguidelines-pro-type-member-init when check
hokein updated this revision to Diff 56725.
hokein marked an inline comment as done.
hokein added a comment.
Address comments.
http://reviews.llvm.org/D20095
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/XrefsDBManager.cpp
include-fixer/YamlXrefsDB.cpp
include-fixer/find-all-sy
hokein added inline comments.
Comment at: docs/include-fixer.rst:36
@@ +35,3 @@
+
+The include fixer contains :program:`find-all-symbols`, a tool to create a
+symbol database in YAML format from a compilation database by parsing all
A extra space before a.
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269162: [find-all-symbols] Slim SymbolInfo. (authored by
hokein).
Changed prior to commit:
http://reviews.llvm.org/D20095?vs=56725&id=56862#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20095
Fi
Author: hokein
Date: Wed May 11 03:38:21 2016
New Revision: 269162
URL: http://llvm.org/viewvc/llvm-project?rev=269162&view=rev
Log:
[find-all-symbols] Slim SymbolInfo.
Summary:
SymbolInfo has some optional fields, which is a bad-smell
implementation. For now, we
* remove the optional field sinc
hokein updated this revision to Diff 56872.
hokein marked an inline comment as done.
hokein added a comment.
Rebase to master.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbo
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D19816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1601 - 1700 of 3086 matches
Mail list logo
