This revision was automatically updated to reflect the committed changes.
Closed by commit rL287330: [clang-move] Fix not moving using-decls in global
namespace in old.cc (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26844?vs=78491&id=78492#toc
Repository:
rL LLVM
Author: hokein
Date: Fri Nov 18 04:51:16 2016
New Revision: 287330
URL: http://llvm.org/viewvc/llvm-project?rev=287330&view=rev
Log:
[clang-move] Fix not moving using-decls in global namespace in old.cc
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D
hokein accepted this revision.
hokein added a reviewer: hokein.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:33
return;
+ if (!Prev->getLocation().isValid())
+
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
- --new_depend_on_old: new header will include old header
- --old_depend_on_new: old header will include new header.
https://reviews.llvm.org/D26966
Files:
clang-move/ClangMove.cpp
clang-m
hokein updated this revision to Diff 78874.
hokein marked 8 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D26966
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTe
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:309
+ llvm::StringRef FileName, bool IsHeader = false,
+ StringRef OldHeaderInclude = "") {
std::string NewCode;
ioeric wrote:
> How do you h
hokein updated this revision to Diff 79043.
hokein marked 8 inline comments as done.
hokein added a comment.
Update comments.
https://reviews.llvm.org/D26966
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests.cpp
hokein updated this revision to Diff 79046.
hokein marked an inline comment as done.
hokein added a comment.
Fix code indentation.
https://reviews.llvm.org/D26966
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests
Author: hokein
Date: Wed Nov 23 04:04:19 2016
New Revision: 287752
URL: http://llvm.org/viewvc/llvm-project?rev=287752&view=rev
Log:
[clang-move] Add some options allowing to add old/new.h to new/old.h
respectively.
Summary:
* --new_depend_on_old: new header will include old header
* --old_depen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287752: [clang-move] Add some options allowing to add
old/new.h to new/old.h… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26966?vs=79046&id=79047#toc
Repository:
rL LLVM
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
- Add -dump_dels option to dump all declarations from old header. It will allow
clang-move used as a frontend to get declarations from header. Further more,
this will make debugging stuff easie
hokein updated this revision to Diff 79120.
hokein added a comment.
Code style.
https://reviews.llvm.org/D27059
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cp
hokein updated this revision to Diff 79194.
hokein marked 2 inline comments as done.
hokein added a comment.
Add comments && Update test.
https://reviews.llvm.org/D27059
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMo
Author: hokein
Date: Thu Nov 24 04:17:17 2016
New Revision: 287863
URL: http://llvm.org/viewvc/llvm-project?rev=287863&view=rev
Log:
[clang-move] Enable dump all declarations in old header.
Summary:
* Add -dump_dels option to dump all declarations from old header. It
will allow clang-move used
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287863: [clang-move] Enable dump all declarations in old
header. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D27059?vs=79194&id=79201#toc
Repository:
rL LLVM
https://revi
Author: hokein
Date: Fri Dec 2 06:39:39 2016
New Revision: 288498
URL: http://llvm.org/viewvc/llvm-project?rev=288498&view=rev
Log:
[clang-move] some tweaks.
* Don't save SourceManager for each declarations.
* Rename some out-dated methods.
No functionality change.
Modified:
clang-tools-ex
Author: hokein
Date: Mon Dec 12 08:12:10 2016
New Revision: 289431
URL: http://llvm.org/viewvc/llvm-project?rev=289431&view=rev
Log:
[StaticAnalysis] Remove unnecessary parameter in CallGraphNode::addCallee.
Summary:
Remove the CallGraph in addCallee as it is not used in addCallee.
It decouples a
Author: hokein
Date: Tue Dec 13 09:35:47 2016
New Revision: 289541
URL: http://llvm.org/viewvc/llvm-project?rev=289541&view=rev
Log:
[clang-move] Fix incorrect EndLoc for declarations in macros.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D27713
M
Author: hokein
Date: Mon Apr 24 11:41:00 2017
New Revision: 301188
URL: http://llvm.org/viewvc/llvm-project?rev=301188&view=rev
Log:
[clang-tidy] Some Cleanups for performance-faster-string-find check.
NFC
Modified:
clang-tools-extra/trunk/clang-tidy/performance/FasterStringFindCheck.cpp
Mo
Author: hokein
Date: Wed Apr 26 13:13:05 2017
New Revision: 301440
URL: http://llvm.org/viewvc/llvm-project?rev=301440&view=rev
Log:
[clang-tidy] Support detecting for-range loop in inefficient-vector-operation
check.
Summary:
Also add an option "VectorLikeClasses" allowing user specify customiz
Author: hokein
Date: Thu Apr 27 04:20:46 2017
New Revision: 301525
URL: http://llvm.org/viewvc/llvm-project?rev=301525&view=rev
Log:
Don't hard-code "modules-cache-path" in the test.
Modified:
cfe/trunk/test/Modules/malformed-overload.m
Modified: cfe/trunk/test/Modules/malformed-overload.m
U
Author: hokein
Date: Thu Apr 27 07:22:33 2017
New Revision: 301536
URL: http://llvm.org/viewvc/llvm-project?rev=301536&view=rev
Log:
Fix asan failures on OpenMP.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.org/viewvc/llvm-project/
Author: hokein
Date: Tue May 2 07:15:11 2017
New Revision: 301914
URL: http://llvm.org/viewvc/llvm-project?rev=301914&view=rev
Log:
[clang-move] Find template class forward declarations more precisely.
Reviewers: ioeric
Reviewed By: ioeric
Subscribers: cfe-commits
Differential Revision: https
Author: hokein
Date: Fri May 12 14:01:02 2017
New Revision: 302934
URL: http://llvm.org/viewvc/llvm-project?rev=302934&view=rev
Log:
[include-fixer] Don't throw exception when parsing unknown arguments in
vim script.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/run-f
Author: hokein
Date: Mon May 15 13:18:28 2017
New Revision: 303095
URL: http://llvm.org/viewvc/llvm-project?rev=303095&view=rev
Log:
[clang-tidy] Fix a typo: dequeue => deque
Modified:
clang-tools-extra/trunk/clang-tidy/performance/InefficientVectorOperationCheck.cpp
Modified:
clang-tools-
Author: hokein
Date: Tue May 16 05:39:55 2017
New Revision: 303157
URL: http://llvm.org/viewvc/llvm-project?rev=303157&view=rev
Log:
[clang-tidy] Add "emplace_back" detection in inefficient-vector-operation.
Reviewers: alexfh, aaron.ballman
Reviewed By: alexfh
Subscribers: cfe-commits, Prazek,
ber 2016 at 06:01, Haojian Wu via cfe-commits
> > wrote:
> >> + std::string GuardName(FileName);
> >> + if (IsHeader) {
> >> +std::replace(GuardName.begin(), GuardName.end(), '/', '_');
> >> +std::replace(GuardName.begin(), Guar
Author: hokein
Date: Mon Oct 17 10:26:34 2016
New Revision: 284391
URL: http://llvm.org/viewvc/llvm-project?rev=284391&view=rev
Log:
[clang-move] Fix generating illegal header guard.
The filepath might contain some characters (i.e. '@') which are not
illegal in c identifiers. This patch changes a
at 3:44 PM, Tim Northover
> wrote:
>
>> On 14 October 2016 at 13:33, Tim Northover
>> wrote:
>> > On 14 October 2016 at 06:01, Haojian Wu via cfe-commits
>> > wrote:
>> >> + std::string GuardName(FileName);
>> >> + if (IsHeader) {
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
The matcher for matching "class with default constructor" still match
some classes without default constructor, which trigger an assert at
Line 307. Th
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Another fix is to move the whole anonymous namespace declaration
completely instead of moving fun/var declarations only.
https://reviews.llvm.org/D25762
Files:
clang-move/ClangMove.cpp
tes
hokein updated this revision to Diff 75139.
hokein marked 2 inline comments as done.
hokein added a comment.
Address comments.
- Cover type alias declarations.
- Fix an issue of moving function-scope static definitions in non-moved classes.
https://reviews.llvm.org/D25762
Files:
clang-move/C
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:356
Finder->addMatcher(
- namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
-inAnonymousNamespace)
- .bind("decls_in_
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
https://reviews.llvm.org/D25770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: hokein
Date: Wed Oct 19 09:13:21 2016
New Revision: 284592
URL: http://llvm.org/viewvc/llvm-project?rev=284592&view=rev
Log:
[clang-move] Move using-decl in old cc.
Summary:
Another fix is to move the whole anonymous namespace declaration
completely instead of moving fun/var declarations
This revision was automatically updated to reflect the committed changes.
hokein marked 2 inline comments as done.
Closed by commit rL284592: [clang-move] Move using-decl in old cc. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D25762?vs=75139&id=75146#toc
Repository:
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
Yeah, it works for most c
hokein accepted this revision.
hokein added a comment.
LGTM. I will commit for you.
Repository:
rL LLVM
https://reviews.llvm.org/D25649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: hokein
Date: Thu Oct 20 06:32:47 2016
New Revision: 284719
URL: http://llvm.org/viewvc/llvm-project?rev=284719&view=rev
Log:
[Clang-tidy]: Fix modernize-avoid-bind erroneous scope resolution.
Hello, i would like to suggest a fix for one of the checks in clang-tidy and i
should hope this
hokein closed this revision.
hokein added a comment.
Committed in r284719 with some nits fixing.
As @jlebar mentioned above, please consider use `Arcanist`
(http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line)
to upload your patch, which will make the commit stuff eas
Author: hokein
Date: Thu Oct 20 08:15:40 2016
New Revision: 284727
URL: http://llvm.org/viewvc/llvm-project?rev=284727&view=rev
Log:
[clang-tidy] Fix an assertion failure in cppcoreguidelines-pro-type-member-init.
Summary:
The matcher for matching "class with default constructor" still match
some
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284727: [clang-tidy] Fix an assertion failure in
cppcoreguidelines-pro-type-member-init. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25747?vs=75066&id=75291#toc
Repository:
hokein added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30
+AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) {
+ return Node.hasDefaultConstructor();
aaron.ballman wrote:
> I think this should be a public AST matcher
Author: hokein
Date: Fri Oct 21 14:26:43 2016
New Revision: 284859
URL: http://llvm.org/viewvc/llvm-project?rev=284859&view=rev
Log:
[clang-move] Support moving template class forward declarations.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
clang-tools-extra/trunk/unittest
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
[clang-tidy] Don't warn implicit variables in
peformance-unnecessary-copy-initialization.
This will prevent the check warning the variables which have been
implicitly added by compiler, like th
hokein updated this revision to Diff 75595.
hokein added a comment.
Don't mess up with other patches.
https://reviews.llvm.org/D25911
Files:
clang-tidy/performance/UnnecessaryCopyInitialization.cpp
test/clang-tidy/performance-unnecessary-copy-initialization.cpp
Index: test/clang-tidy/perf
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
r285239 changes the behavior of AST CXXDefaultArgExpr node.
Update `modernize-use-nullptr` to handle CXXDefaultArgExpr correctly.
https://reviews.llvm.org/D26301
Files:
clang-tidy/modernize
hokein added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:297
+ const auto &RegisteredCheckers =
+ AnalyzerOptions::getRegisteredCheckers(IncludeExperimentalCheckers);
+ bool AnalyzerChecksEnabled = false;
Since the default argument of this funct
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
ioeric wrote:
> ioeric wr
hokein updated this revision to Diff 77093.
hokein marked 5 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D26236
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/test.h
test/clang-move/move-class.cpp
uni
hokein added a comment.
> The patch summary says "one moved declaration." Why it is just one moved
> declaration? Doesn't this also support moving all classes in one file?
Oh, the patch summary is not totally correct. It actually does what you mention
above. Have updated the summary.
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286156: [clang-tidy] Fix a regression issue introduced by
r285239. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26301?vs=76920&id=77096#toc
Repository:
rL LLVM
https://re
Author: hokein
Date: Mon Nov 7 15:46:24 2016
New Revision: 286156
URL: http://llvm.org/viewvc/llvm-project?rev=286156&view=rev
Log:
[clang-tidy] Fix a regression issue introduced by r285239.
Summary:
r285239 changes the behavior of AST CXXDefaultArgExpr node.
Update `modernize-use-nullptr` to h
hokein added a comment.
friendly ping.
https://reviews.llvm.org/D25911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:297
+ const auto &RegisteredCheckers =
+ AnalyzerOptions::getRegisteredCheckers(IncludeExperimentalCheckers);
+ bool AnalyzerChecksEnabled = false;
alexfh wrote:
> hokein wrote:
> > Since t
hokein accepted this revision.
hokein added a comment.
LGTM, thanks.
https://reviews.llvm.org/D26311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hokein
Date: Mon Nov 7 18:45:34 2016
New Revision: 286186
URL: http://llvm.org/viewvc/llvm-project?rev=286186&view=rev
Log:
[clang-tidy] Don't warn implicit variables in
peformance-unnecessary-copy-initialization.
Summary:
This will prevent the check warning the variables which have be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286186: [clang-tidy] Don't warn implicit variables in
peformance-unnecessary-copy… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25911?vs=75595&id=77122#toc
Repository:
rL
hokein updated this revision to Diff 77208.
hokein marked 2 inline comments as done.
hokein added a comment.
Fix remaining comments.
https://reviews.llvm.org/D26236
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/test.h
test/clang-move/move-class.cpp
unit
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:233
+ const DeclContext *DeclCtx, SourceLocation Loc) {
+ return SM.isBeforeInTranslationUnit(SM.getSpellingLoc(D->getLocation()),
+ SM
hokein updated this revision to Diff 77223.
hokein marked 2 inline comments as done.
hokein added a comment.
Update test to check old header.
https://reviews.llvm.org/D26236
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
test/clang-move/Inputs/test.h
test/clang-move/move-class.c
Author: hokein
Date: Tue Nov 8 13:55:13 2016
New Revision: 286281
URL: http://llvm.org/viewvc/llvm-project?rev=286281&view=rev
Log:
[clang-move] Move all code from old.h/cc directly when moving all class
declarations from old.h.
Summary: When moving all code to new.h/cc, these code also will b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286281: [clang-move] Move all code from old.h/cc directly
when moving all class… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26236?vs=77223&id=77233#toc
Repository:
rL LL
hokein added a comment.
One more comment, otherwise looks good.
Comment at: change-namespace/ChangeNamespace.cpp:275
+ (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front()))
+ .str();
+ auto IsInMovedNs =
Using an invalid name `-` is not
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D26423
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/template_class_test.cpp
test/clang-move/Inputs/template_class_test.h
test/clang-move/move-template-
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one nit.
Comment at: change-namespace/ChangeNamespace.cpp:275
+ (DiffOldNsSplitted.empty() ? "-" : DiffOldNsSplitted.front()))
+ .str();
+ auto IsIn
hokein updated this revision to Diff 77292.
hokein marked 3 inline comments as done.
hokein added a comment.
Add comments.
https://reviews.llvm.org/D26423
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/template_class_test.cpp
test/clang-move/Inputs/template_class_test.h
test/cla
hokein marked 3 inline comments as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
+ else
ioeric wrote:
> `erase(FTD
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL286427: [clang-move] Support template class. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D26423?vs=77292&id=77447#toc
Repository:
Author: hokein
Date: Wed Nov 9 23:33:26 2016
New Revision: 286427
URL: http://llvm.org/viewvc/llvm-project?rev=286427&view=rev
Log:
[clang-move] Support template class.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D26423
Added:
clang-tools-ext
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Add decent blank line between declarations.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTe
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with two nits.
Comment at: change-namespace/ChangeNamespace.cpp:475
+ // If there is no outer namespace (i.e. DiffOldNamespace is empty), the new
+ // namespace will b
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
No functionality change.
This is a refactoring patch, which makes the code more readable and easy
to extend it to support more types.
https://reviews.llvm.org/D26515
Files:
clang-move/Clang
hokein updated this revision to Diff 77521.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
https://reviews.llvm.org/D26515
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
Index: clang-move/ClangMove.h
==
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:144
+ void run(const ast_matchers::MatchFinder::MatchResult &Result) override {
+if (const auto *CMD =
+Result.Nodes.getNodeAs("class_method")) {
ioeric wrote:
> It'd be more read
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:139
+class ClassDeclarationMatcher : public MatchFinder::MatchCallback {
+public:
ioeric wrote:
> Why is this called a Matcher?
Rename it to a better name "Match".
https://reviews.llvm.org/D26
hokein updated this revision to Diff 77788.
hokein marked 2 inline comments as done.
hokein added a comment.
Split to small functions.
https://reviews.llvm.org/D26515
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
Index: clang-move/ClangMove.h
==
hokein updated this revision to Diff 77794.
hokein added a comment.
Add comments and update patch descriptions.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
===
hokein updated this revision to Diff 77803.
hokein marked 2 inline comments as done.
hokein added a comment.
Address remaining comments.
https://reviews.llvm.org/D26515
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
Index: clang-move/ClangMove.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286825: [clang-move] Abstract a ClassMather for matching
class declarations. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26515?vs=77803&id=77804#toc
Repository:
rL LLVM
Author: hokein
Date: Mon Nov 14 08:15:44 2016
New Revision: 286825
URL: http://llvm.org/viewvc/llvm-project?rev=286825&view=rev
Log:
[clang-move] Abstract a ClassMather for matching class declarations.
Summary:
No functionality change.
This is a refactoring patch, which makes the code more reada
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Fix an incorrect range for the functions whose returned value is a macro
(e.g. `bool`). This incorrect range can lead to modifications of an unexpected
file where the macro is in.
We should use
Author: hokein
Date: Mon Nov 14 08:46:48 2016
New Revision: 286833
URL: http://llvm.org/viewvc/llvm-project?rev=286833&view=rev
Log:
[clang-move] Fix an incorrect range for the functions whose returned value is a
macro
Summary:
Fix an incorrect range for the functions whose returned value is a m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286833: [clang-move] Fix an incorrect range for the
functions whose returned value is a… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26609?vs=77806&id=77810#toc
Repository:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:829
"void f() {\n"
- " using na::CA;\n"
-
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
ioeric wrote:
> Wouldn't this create
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
hokein wrote:
> ioeric wrote:
> > Wou
hokein updated this revision to Diff 77820.
hokein marked an inline comment as done.
hokein added a comment.
Fix a corner case, and add a test.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests
hokein updated this revision to Diff 77821.
hokein added a comment.
Remove a trailing blank line.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
=
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
No functional changes in this patch. It is a refactoring (pull out a
structure representing the symbol being queried).
This is a preparing step for inserting missing namespace qualifiers to all
Author: hokein
Date: Tue Jul 19 09:49:04 2016
New Revision: 275980
URL: http://llvm.org/viewvc/llvm-project?rev=275980&view=rev
Log:
[include-fixer] A refactoring of IncludeFixerContext.
Summary:
No functional changes in this patch. It is a refactoring (pull out a
structure representing the symbo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275980: [include-fixer] A refactoring of
IncludeFixerContext. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22510?vs=64481&id=64502#toc
Repository:
rL LLVM
https://reviews
Author: hokein
Date: Wed Jul 20 04:00:22 2016
New Revision: 276096
URL: http://llvm.org/viewvc/llvm-project?rev=276096&view=rev
Log:
[include-fixer] Tweak: remove unintended const.
Modified:
clang-tools-extra/trunk/include-fixer/IncludeFixerContext.cpp
clang-tools-extra/trunk/include-fixe
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D22567
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
hokein updated this revision to Diff 64848.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D22567
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/In
hokein added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:365
@@ +364,3 @@
+ for (const auto &Info : Context.getQuerySymbolInfos()) {
+Replacements->insert({FilePath, Info.Range.getOffset(),
+ Info.Range.getLength(),
-
hokein updated this revision to Diff 64849.
hokein added a comment.
update error message.
https://reviews.llvm.org/D22567
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/Cla
Author: hokein
Date: Thu Jul 21 08:47:09 2016
New Revision: 276280
URL: http://llvm.org/viewvc/llvm-project?rev=276280&view=rev
Log:
[include-fixer] Add mising qualifiers to all instances of an unidentified
symbol.
Reviewers: bkramer
Subscribers: ioeric, cfe-commits
Differential Revision: http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276280: [include-fixer] Add mising qualifiers to all
instances of an unidentified… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22567?vs=64849&id=64877#toc
Repository:
rL
hokein accepted this revision.
hokein added a comment.
Looks good now. Do you need I submit for you?
https://reviews.llvm.org/D21992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1401 - 1500 of 3086 matches
Mail list logo
