[PATCH] D84591: Replace comment by private method

2020-07-25 Thread Hannes Käufler via Phabricator via cfe-commits
hanneskaeufler created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The comment is better served with a small private method, helping scannability of the code and hiding irrelevant details about the private members. Repository: rG LLVM Github Monorepo

[PATCH] D84591: [clang-tidy] Replace comment by private method

2020-07-25 Thread Hannes Käufler via Phabricator via cfe-commits
hanneskaeufler updated this revision to Diff 280699. hanneskaeufler added a comment. Fix syntax error (add return type) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84591/new/ https://reviews.llvm.org/D84591 Files: clang-tools-extra/clang-tidy/

[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

2020-07-26 Thread Hannes Käufler via Phabricator via cfe-commits
hanneskaeufler added a comment. In D84591#2174437 , @aaron.ballman wrote: > LGTM! Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84591/new/ https://reviews.llvm.org/D84591

[PATCH] D84591: [clang-tidy][NFC] Replace comment by private method

2020-07-26 Thread Hannes Käufler via Phabricator via cfe-commits
hanneskaeufler added a comment. In D84591#2174447 , @aaron.ballman wrote: > In D84591#2174442 , @hanneskaeufler > wrote: > > > In D84591#2174437 , @aaron.ballman > > wrote