@@ -627,7 +628,7 @@ class Target : public std::enable_shared_from_this,
// used.
const lldb::ProcessSP &CreateProcess(lldb::ListenerSP listener_sp,
llvm::StringRef plugin_name,
- const FileSpec *cr
@@ -244,9 +245,38 @@ SBProcess SBTarget::LoadCore(const char *core_file,
lldb::SBError &error) {
TargetSP target_sp(GetSP());
if (target_sp) {
FileSpec filespec(core_file);
-FileSystem::Instance().Resolve(filespec);
+auto file = FileSystem::Instance().Open(
+
@@ -3174,8 +3174,17 @@ class TargetCreateFormDelegate : public FormDelegate {
core_file_directory_spec.SetDirectory(core_file_spec.GetDirectory());
target_sp->AppendExecutableSearchPaths(core_file_directory_spec);
-ProcessSP process_sp(target_sp->CreateProcess(
-
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/71769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -194,11 +194,12 @@ void ProcessGDBRemote::Terminate() {
PluginManager::UnregisterPlugin(ProcessGDBRemote::CreateInstance);
}
-lldb::ProcessSP ProcessGDBRemote::CreateInstance(
-lldb::TargetSP target_sp, ListenerSP listener_sp,
-const FileSpec *crash_file_path, boo
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -427,8 +427,17 @@ class CommandObjectTargetCreate : public
CommandObjectParsed {
core_file_dir.SetDirectory(core_file.GetDirectory());
target_sp->AppendExecutableSearchPaths(core_file_dir);
+auto file = FileSystem::Instance().Open(
+core
@@ -102,10 +102,10 @@ void ProcessKDP::Terminate() {
lldb::ProcessSP ProcessKDP::CreateInstance(TargetSP target_sp,
ListenerSP listener_sp,
- const FileSpec *crash_file_path,
+
https://github.com/clayborg commented:
One question I have here: where will the DW_TAG_variable get emitted for these
`constexpr`? For actual static member variables we emit a single
DW_TAG_variable in the file that declares the global variable, but for
`constexpr` we won't be able to do this
clayborg wrote:
> Few minor issues, but looks good to me. (you metnioned somewhere an lldb
> issue I think with this patch when the value is removed from the static
> member declaration inside the class? If that's a problem - probably hold off
> on committing this until lldb's been fixed so th
clayborg wrote:
> > > Few minor issues, but looks good to me. (you metnioned somewhere an lldb
> > > issue I think with this patch when the value is removed from the static
> > > member declaration inside the class? If that's a problem - probably hold
> > > off on committing this until lldb's
clayborg wrote:
> > The DWARFASTParserClang.cpp will try to create the class from the DWARF for
> > the class definition. You will need to find the DW_TAG_variable when we are
> > creating the static field if there is no DW_AT_const_value in the
> > DW_TAG_member. But we also need to support t
clayborg wrote:
I am fine with `-glldb` doing the right thing for LLDB.
That being said, I don't believe that LLDB or GDB use `.debug_pubnames` or
`.debug_pubtypes` as they are incomplete and can't be relied upon. So I would
say we should never emit these tables unless these older GNU tables
clayborg wrote:
I just noticed the naming difference. I am thinking of the standard older
`.debug_pubnames` and `.debug_pubtypes`. Are the `.debug_gnu_pubnames` and
`.debug_gnu_pubtypes` more complete and usable by debuggers? If so, then we
should use the `-dlldb` to disable these GNU specific
https://github.com/clayborg commented:
LGTM, but I will let the code owners here accept
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/79926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/clayborg commented:
Just remove the "--num-threads" option from the test yaml file and this is good
to go.
https://github.com/llvm/llvm-project/pull/79926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
@@ -0,0 +1,108 @@
+## Test converting DWARF using relative path
+
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-gsymutil --convert %t -o %t.gsym --segment-size=10
--num-threads=80 --quiet 2>&1 | FileCheck %s --check-prefix=CONVERT
clayborg wrote:
Don't specify the
clayborg wrote:
Can we add a cmake settings that allows users to add custom target names that
will be added? I would love to use this for my common projects like:
```
-DCMAKE_LLVM_XCODE_TARGETS=lldb;llvm-dwarfdump;llvm-gsymutil;lld
```
And it would add those top level targets?
https://github.co
clayborg wrote:
Great! That will be very useful.
https://github.com/llvm/llvm-project/pull/101243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1423,3 +1423,11 @@ endif()
if (LLVM_INCLUDE_UTILS AND LLVM_INCLUDE_TOOLS)
add_subdirectory(utils/llvm-locstats)
endif()
+
+if (XCODE)
+ set(LLVM_XCODE_EXTRA_TARGET_SCHEMES "" CACHE STRING "Specifies an extra list
of targets to turn into schemes")
claybo
clayborg wrote:
FYI: There is already VTable support in our lldb::SBValue class and it is part
of the public API in LLDB and doesn't require any of this:
```
/// If this value represents a C++ class that has a vtable, return an value
/// that represents the virtual function table.
///
//
22 matches
Mail list logo
