[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

martong accepted this revision. martong added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59595/new/ https://reviews.llvm.org/D59595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. Hi Shafik, Thank you for looking into this. This is indeed a bug, because whenever a we encounter an unnamed EnumDecl in the "from" context then we return with a nameconflict error. However, I think we should fix this differently. First of all, currently HandleNameConfl

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. In D59665#1438911 , @a_sidorin wrote: > Hi Shafik, > > Honestly, I was always wondering what does HandleNameConflict actually do. > Its implementation in ASTImporter is trivial and I don't see any of its > overrides in LLDB code

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. > @martong It's not related to lookup or anything like that, it's just that we > don't have enough information in our debug info AST to allow people to use > meta programming. The custom logic we have in LLDB looks into the std C++ > module to fill out these gaps in the

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong created this revision. martong added reviewers: a_sidorin, shafik, teemperor. Herald added subscribers: cfe-commits, jdoerfert, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong added a parent revision: D55049: Changed every

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added inline comments. Herald added a reviewer: martong. Herald added a project: clang. Comment at: lib/AST/ASTImporter.cpp:7767 + if (!ToDCOrErr) +return ToDCOrErr.takeError(); + auto *ToDC = cast(*ToDCOrErr); Actually, this patch is not merely a `

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added a reviewer: a_sidorin. martong added a comment. Herald added a subscriber: rnkovacs. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___ cfe-commits mailing

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a reviewer: a_sidorin. martong added a subscriber: a_sidorin. martong added a comment. @shafik, @a_sidorin Ping. Could you please take a look? Guys, this and its child patch are very important patches, because without it the error handling of ASTImporter is not completed. This means

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. > I am aware of similar errors like this with other AST nodes. We had a patch > in our fork to fix that in January > (https://github.com/Ericsson/clang/pull/569/files) I am going to prepare a > patch from that cause I see now this affects you guys in LLDB too. Just cre

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. In D59485#1439390 , @teemperor wrote: > > Well, I still don't understand how LLDB synthesis the AST. > > So you have a C++ module in a .pcm file. This means you could create an > > AST from that with ASTReader from it's .clang_a

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. In D59485#1439570 , @martong wrote: > In D59485#1439390 , @teemperor wrote: > > > > Well, I still don't understand how LLDB synthesis the AST. > > > So you have a C++ module in a .pcm file

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. In D59665#1442328 , @shafik wrote: > @martong your idea does not work b/c default construction `DeclarationName()` > treats it the same as being empty. So `if (!Name)` is still `true`. And did you try moving the `push_back` to t

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. Looks good for me now, but we should make a similar change in VisitRecordDecl too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59665/new/ https://reviews.llvm.org/D59665 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2463 if (!ConflictingDecls.empty()) { - Name = Importer.HandleNameConflict(Name, DC, IDNS, + Name = Importer.HandleNameConflict(SearchName, DC, IDNS, Confli

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong marked 5 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2260 ConflictingDecls.push_back(FoundDecl); } a_sidorin wrote: > Do we push the same decl twice? Uhh, thanks, that is rebase error I've made

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong updated this revision to Diff 192263. martong marked 2 inline comments as done. martong added a comment. - Add braces around else - Remove falsely duplicated push_back - Use Expected in HandleNameConflict Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692

[PATCH] D59845: Fix IsStructuralMatch specialization for EnumDecl to prevent re-importing an EnumDecl while trying to complete it

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59845/new/ https://reviews.llvm.org/D59845 ___ cfe-commits mailing list cfe-commit

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59665/new/ https://reviews.llvm.org/D59665 ___ cfe-commits mailing list cfe-commit

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added a comment. In D59485#1444673 , @teemperor wrote: > In D59485#1439628 , @martong wrote: > > > In D59485#1439570 , @martong wrote: > > > > > In D59485#1439390

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:590 + new RedirectingImporter(ToContext, ToFileManager, FromContext, + FromFileManager, MinimalImport, LookupTabl)); +}; teemperor wro

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

martong added a comment. In D59665#1446764 , @a_sidorin wrote: > Hi Shafik, > Thank you for the explanation, it is much more clear to me now. But, as I > see, D59692 is going to discard the changes > this patch introduc

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

martong accepted this revision. martong added a comment. In D59485#1446950 , @a_sidorin wrote: > Hello Raphael, > I think we should accept this change. I don't see an easy way to merge the > LLDB stuff into ASTImporter; also, this patch provides a good e

[PATCH] D58897: [ASTImporter] Make ODR error handling configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rC357394: [ASTImporter] Make ODR error handling configurable (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D58897?vs=192070&id=193086#toc Repository: rC Clang

[PATCH] D59761: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL357402: [ASTImporter] Convert ODR diagnostics inside ASTImporter implementation (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2154 +return NameOrErr.takeError(); } } a_sidorin wrote: > Should we write `else Name = *NameOrError`? Atm, we implement the simplest stra

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

martong added a comment. Ping @shafik @a_sidorin Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong added a comment. Ping @a_sidorin @shafik Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong updated this revision to Diff 194527. martong marked an inline comment as done. martong added a comment. - Put back the call to GetOriginalDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 Files: include/clan

[PATCH] D44352: [Concepts] Constrained template parameters

martong requested changes to this revision. martong added inline comments. This revision now requires changes to proceed. Herald added a subscriber: rnkovacs. Comment at: lib/AST/ASTImporter.cpp:3708 + if (Expr *CE = D->getConstraintExpression()) +R->setConstraintExpression(

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

martong requested changes to this revision. martong added a reviewer: balazske. martong added inline comments. This revision now requires changes to proceed. Comment at: lib/AST/ASTImporter.cpp:5026 +ClassTemplate->findPartialSpecialization(TemplateArgs, +Part

[PATCH] D43357: [Concepts] Function trailing requires clauses

martong requested changes to this revision. martong added inline comments. This revision now requires changes to proceed. Comment at: lib/AST/ASTImporter.cpp:3053 +D->isInlineSpecified(), D->isImplicit(), D->isConstexpr(), +InheritedConstructor(), FromConstructor-

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

martong resigned from this revision. martong added a comment. The changes in `ASTImporter.cpp` looks good to me! And I have no competence about the rest of the change, thus I resign as a reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3126 +auto Imp = +importSeq(FromConstructor->getExplicitSpecifier().getPointer()); +if (!Imp) Why is it needed to import the explicit specifier here again? You al

[PATCH] D43357: [Concepts] Function trailing requires clauses

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. From the `ASTImporter` point of view it looks good, thanks for the changes! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43357/new/ https://reviews.llvm.org

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. From the `ASTImporter` point of view it looks good to me, thanks for the changes! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41910/new/ https://reviews.l

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

martong added a comment. In D60934#1475908 , @Tyker wrote: > Fixed issues form feedback by @martong Thank you for addressing the comments. `ASTImporter.cpp` and `ASTStructuralEquivalence.cpp` looks good to me now. However, about the equivalence check,

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

martong added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:965 auto *Conversion2 = cast(Method2); -if (Conversion1->isExplicit() != Conversion2->isExplicit()) +if (!Conversion1->isEquivalentExplicit(Conversion2->getExplicitSpecifier()))

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. ASTImporter.cpp and ASTStructuralEquivalence.cpp looks good to me now. I am resigning as a reviewer since I don't feel competent enough to review the rest of the change. CHANGES SINCE LAS

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

martong accepted this revision. martong added a comment. Looks good, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:625 + "class shouldNotBeImported {};", Lang_CXX, "class realDecl {};", Lang_CXX, + "shouldNotBeImported", RedirectingImporter::Constructor); + auto *Imported = cast(To); ---

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong created this revision. martong added reviewers: shafik, teemperor, jingham, clayborg, a_sidorin. Herald added subscribers: lldb-commits, cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added projects: clang, LLDB. With LLDB we use localUncac

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong marked 2 inline comments as done. martong added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/c/modules/main.c:8 int b; -} FILE; +} MYFILE; In TestCmodules.py we have `import Darwin` and then `expr *fopen("/dev/zero", "w")`

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D59798: [analyzer] Add analyzer option to limit the number of imported TUs

martong added a reviewer: xazax.hun. martong added a comment. @xazax.hun Could you please take a look? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59798/new/ https://reviews.llvm.org/D59798 ___ cfe-commits mailing

[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Structural equivalence of methods can falsely report false when the exception

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong created this revision. martong added reviewers: shafik, teemperor, aprantl, a_sidorin, balazske. Herald added subscribers: lldb-commits, cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added projects: clang, LLDB. This is the final phase of

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 197948. martong added a comment. - Log and do not assert anywhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter.h clang

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198618. martong added a comment. - Add braces to 'true' cases when 'false' case has braces - Simplify logging and error handling with LLDB_LOG_ERROR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ http

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198623. martong added a comment. - Use LLDB_LOG_ERROR in ImportDefinitionTo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter

[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

martong updated this revision to Diff 198626. martong marked 2 inline comments as done. martong added a comment. - Improve and fix typo in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61424/new/ https://reviews.llvm.org/D61424 Files: c

[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

This revision was automatically updated to reflect the committed changes. Closed by commit rL360261: [ASTImporter] Fix inequivalence of unresolved exception spec (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. Ping @shafik @teemperor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong marked 8 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5039 + if (!ToOrErr) +// FIXME: return the error? +consumeError(ToOrErr.takeError()); aprantl wrote: > We don't typ

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198822. martong marked 3 inline comments as done. martong added a comment. - Remove FIXME and return the error - Use early return where possible and remove redundant else Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198824. martong added a comment. - Remove remaining FIXMEs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AS

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

This revision was automatically updated to reflect the committed changes. Closed by commit rL342384: [ASTImporter] Fix import of VarDecl init (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51597 Files: cfe/trunk/l

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

martong updated this revision to Diff 184694. martong marked 2 inline comments as done. martong added a comment. Herald added a project: clang. - Remove unrelated hunks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57322/new/ https://reviews.llvm.org/D57322 File

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

martong added a comment. Update: I just removed the unrelated changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57322/new/ https://reviews.llvm.org/D57322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 184697. martong added a comment. Herald added a project: clang. - Move hunks into this patch from parent patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Files: include/clang/A

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong added a comment. Herald added a project: clang. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57236/new/ https://reviews.llvm.org/D57236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

martong added a comment. > Previously this was not required since all VarDecls were canonical. Not sure > if this change was intended. I did some digging, but am not familiar enough > with the code base to figure out what changed. Does anyone have an idea about > this? We changed the ASTImport

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

martong added a comment. > I think you should change back to getInit() I am not entirely sure about this because the initalizer may not be attached to the canonical decl. `getInit()` gives the initializer of one given specific Decl, however, `getAnyInitializer()` searches through the whole rede

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

This revision was automatically updated to reflect the committed changes. Closed by commit rC353425: [ASTImporter] Refactor unittests to be able to parameterize them in a more… (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D57322?vs=184694&id=185786#toc

[PATCH] D57901: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. We add a new test to show that redecl chains are not handled properly amongst

[PATCH] D57902: [AST] Fix structural inequivalence of operators

martong created this revision. martong added reviewers: shafik, a_sidorin, aaron.ballman. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. Operators kind was not checked, so we reported e.g. op- to be equal with op+ Repository: rC Cl

[PATCH] D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. This is to check that operators are handled properly in `ASTImporterSpecificL

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong created this revision. martong added reviewers: xazax.hun, a_sidorin, r.stahl. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. If CPP dialects are different then return with error. Consider this STL code: template struct

[PATCH] D57910: [ASTImporter] Find previous friend function template

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57910 Files: lib/AST/AST

[PATCH] D57902: [AST] Fix structural inequivalence of operators

martong marked 2 inline comments as done. martong added inline comments. Comment at: unittests/AST/StructuralEquivalenceTest.cpp:251 + +TEST_F(StructuralEquivalenceFunctionTest, CtorVsDtor) { + auto t = makeDecls( shafik wrote: > Curious, is this test just for c

[PATCH] D57902: [AST] Fix structural inequivalence of operators

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rC353504: [AST] Fix structural inequivalence of operators (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D57902?vs=185793

[PATCH] D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators

martong updated this revision to Diff 185924. martong marked an inline comment as done. martong added a comment. - Add comment above ASSERT_NE Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57905/new/ https://reviews.llvm.org/D57905 Files: unittests/AST/ASTImpo

[PATCH] D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators

This revision was automatically updated to reflect the committed changes. Closed by commit rC353505: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D57905?vs=185924&id=185925#toc

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong updated this revision to Diff 185926. martong marked 4 inline comments as done. martong added a comment. - Revert comment change - Add lang_dialect_mismatch and stats for that Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57906/new/ https://reviews.llvm.o

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:232 + + // We do not support CTU across languages (C vs C++). if (LangTo.CPlusPlus != LangFrom.CPlusPlus) { a_sidorin wrote: > The comment change looks strange. Ok, I reverted thi

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong added a comment. Ping. Please raise your objections if you have any until the 18th of February (that date I am going to commit if there are no objections). Also, please let me know if you find this deadline too strict. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews

[PATCH] D57901: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL353684: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LL

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong added a comment. > How is #if __cplusplus >= 201103L qualitatively different from #ifndef NDEBUG > or #if MYLIB_ABI_VERSION==2 or #if __DATE__ == "2018-04-01"? Ideally, all macros should be the same in the two TUs... If we were very strict then we could check for that, but that might be

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong updated this revision to Diff 186445. martong added a comment. Herald added a subscriber: jdoerfert. - Remove numbers when possible - Use disabled tests instead of commented out tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57236/new/ https://review

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong marked 4 inline comments as done. martong added a comment. Thanks for the review Alexei! Comment at: unittests/AST/ASTImporterTest.cpp:3549 + void TypedTest_ImportDefinitionThenPrototype() { +Decl *FromTU0 = getTuDecl(getDefinition(), Lang_CXX, "input0.cc"); +D

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 186802. martong added a comment. Rebase to master(trunk) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp unittests

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong added a comment. @shafik Thanks for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL354027: [ASTImporter] Check visibility/linkage of functions and variables (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D57910: [ASTImporter] Find previous friend function template

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57910/new/ https://reviews.llvm.org/D57910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. Herald added a subscriber: cfe-commits. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57590/new/ https://reviews.llvm.org/D57590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

This revision was automatically updated to reflect the committed changes. Closed by commit rL354120: [ASTImporter] Import every Decl in lambda record (authored by martong, committed by ). Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM. Changed prior to commit: h

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong updated this revision to Diff 187206. martong marked 2 inline comments as done. martong added a comment. Rebase to master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57236/new/ https://reviews.llvm.org/D57236 Files: unittests/AST/ASTImporterTest.cpp

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL354259: [ASTImporter] Unify redecl chain tests as type parameterized tests (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLV

[PATCH] D57910: [ASTImporter] Find previous friend function template

martong updated this revision to Diff 187211. martong added a comment. - Add FIXME Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57910/new/ https://reviews.llvm.org/D57910 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AS

[PATCH] D57910: [ASTImporter] Find previous friend function template

martong updated this revision to Diff 187212. martong added a comment. Rebase to master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57910/new/ https://reviews.llvm.org/D57910 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittes

[PATCH] D57910: [ASTImporter] Find previous friend function template

This revision was automatically updated to reflect the committed changes. Closed by commit rC354267: [ASTImporter] Find previous friend function template (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D57910?vs=187212&id=187228#toc Repository: rC Clan

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of function templates are not handled well currently. We want t

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, jdoerfert, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of classes and class templates are not handled well

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. Herald added a reviewer: martong. Ping. Please raise your objections if you have any until the 4th of March (that date we are going to commit if there are no objections). Also, please let us know if you find this deadline too strict. Repository: rC Clang CHANGES SI

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4259 static const RecordDecl * getRecordDeclOfFriend(FriendDecl *FD) { QualType Ty = FD->getFriendType()->getType(); + if (auto *Inner = dyn_cast(Ty.g

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

martong updated this revision to Diff 204048. martong marked an inline comment as done. martong added a comment. - Simplify getRecordDeclOfFriend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62064/new/ https://reviews.llvm.org/D62064 Files: cla

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

This revision was automatically updated to reflect the committed changes. Closed by commit rL363062: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong updated this revision to Diff 205093. martong added a comment. - Fix regression of TestFormatters.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333 Files: clang/lib/AST/ASTImporter.cpp clang/un

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

martong added a comment. About the regression of TestFormatters.py: I realized that the problem is about the wrong implementation of the ExternalASTSource interface. In the implementation of FindExternalLexicalDecls of this interface, we simply ignored those cases when the given predicate (passe

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. martong added a parent revision: D62373: [ASTImporte

<    1   2   3   4   5   6   7   8   9   10   >