[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

martong added a comment. @ASDenysPetrov Denis, do you think it would make sense to handle the non-multi-dimensional cases first? I see that you have useful patches in the stack that depends on this change (i.e handling a StringLiteral or a CompoundLiteralExpr) but perhaps they would be meaningf

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:504 + + OrigStdin = findStdStream("stdin", C); + OrigStdout = findStdStream("stdout", C); steakhal wrote: > balazske wrote: > > steakhal wrote: > > > balazske wrote:

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104647/new/ https://reviews.llvm.org/D104647 ___

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks! My concerns are addressed, looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108695/new/ https://reviews.llvm.org/D108695

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Okay, LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108753/new/ https://reviews.llvm.org/D108753 ___ cfe-commits mailing l

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimensionalArray) { aaron.ballman wrote: > +1 f

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

martong added a comment. > And about `checkDeadSymbols`, I get your point, but I am interested why > checker has different behavior on these two examples: > > a1 int main(int argc, char **argv, char *envp[]) { > a2 putenv((char*) "NAME=VALUE"); // envp invalidated > a3 envp[0]; // give

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

martong added a comment. Nice work! Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:159 +// Note: This pointer has type 'const MemRegion *' +REGISTER_TRAIT_WITH_PROGRAMSTATE(EnvPtrRegion, const void *) + Why is it `const void *`? Why ca

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Excellent! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 ___ cfe-commits mailing list

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

martong added a reviewer: teemperor. martong added a comment. Thanks, nice work! I like the direction, however, I'd like to ask comments from @teemperor . Comment at: clang/lib/AST/ASTImporter.cpp:656-671 +// Helper for chaining together multiple imports. If an error is de

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8448 + +class AttrImporter { + Error Err = Error::success(); shafik wrote: > @martong the `ASTImporter` file is quite large as it is and I think it makes > sense to have `AttrImporter` but

[PATCH] D109836: [Analyzer] ConversionChecker: track back the cast expression

martong created this revision. martong added reviewers: steakhal, Szelethus, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of this revision. Hera

<    18   19   20   21   22   23