[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

fridtjof updated this revision to Diff 544142. fridtjof added a comment. I fixed the failing IBOutletCollection.m test - there was code to do special handling for the respective attribute type, which my patch accidentally skipped previously. I reordered the generic attribute handling to come aft

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 549197. fridtjof added a comment. It was the unit test I added - I forgot to properly dispose of the EvalResult there CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 Files: clang/docs/ReleaseNotes.rst

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 545305. fridtjof retitled this revision from "[libclang] Expose arguments of clang::annotate{_type}" to "[libclang] Expose arguments of clang::annotate". fridtjof edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1513

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof added a comment. In D151373#4538604 , @aaron.ballman wrote: > I think we should drop the `annotate_type` functionality from the patch > entirely rather than add it without any test coverage knowing it doesn't seem > to work as expected. Agree

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 545388. fridtjof added a comment. Whoops, forgot to run clang-format on the last diff. Also took the opportunity to just get rid of the template mess now that we're only dealing with AnnotateAttr anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof added a comment. (Whoops, somehow never got a mail for that reply) Yes, please. You can attribute the commit to "fridtjof " CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 ___ cfe-commits m

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

fridtjof created this revision. fridtjof added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. fridtjof requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables easy consumption of arbitrary

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

fridtjof updated this revision to Diff 530219. fridtjof added a comment. - Deduplicated code by using templates (looks a bit ridicilous though) - Release notes entry added - Unit test added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 Files