[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:790 + FeatureFSRM]; + list RKLTuning = ICLTuning; + list RKLFeatures = RKSimon wrote: > Using ICLTuning suggests we should still be avoiding

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:767 + // Rocketlake + list RKLAdditionalFeatures = [FeatureAES, + FeatureXSAVEC, craig.topper wrote: > FreddyYe wrote: > > craig.topper wrote

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336295. FreddyYe added a comment. delete FeatureSGX in the backend since there are no IR intrinsics for SGX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files:

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336301. FreddyYe added a comment. cancel the clang-format in constexpr ProcInfo Processors[] = {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336303. FreddyYe added a comment. revert clang-format and revert deleting FeatureSGX def. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/Basic/Ta

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @craig.topper and @skan , THX for review! I tested that deleting sgx indeed leads to not generating "+sgx" in 'target-features', didn't know before:) '+sgx' is not a recognized feature for this target (ignoring feature) Repository: rG LLVM Github Monorepo CH

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB,

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB,

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. In D100085#2682080 , @craig.topper wrote: > Thanks. I also found this > https://github.com/gcc-mirror/gcc/commit/c422e5f81f42a0fc197f0715f4fcd81f1be90bff >can you create a new patch to do the same for llvm/clang and rebase

[PATCH] D100279: [X86] Remove FeatureCLWB from FeaturesICLClient

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100279 Files: clang

[PATCH] D100279: [X86] Remove FeatureCLWB from FeaturesICLClient

FreddyYe updated this revision to Diff 336735. FreddyYe added a comment. update lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100279/new/ https://reviews.llvm.org/D100279 Files: clang/test/Preprocessor/predefined-arch-macros.c llvm/li

[PATCH] D100279: [X86] Remove FeatureCLWB from FeaturesICLClient

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cb47be41045: [X86] Remove FeatureCLWB from FeaturesICLClient (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100279/new/ https://revi

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336738. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/Basic/Targets/X86.cpp clang/test/CodeGen/attr-target-mv

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @MaskRay, @craig.topper, @skan, reviewers, I've addressed your comments. Any more concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 __

[PATCH] D100085: [X86] Support -march=rocketlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fc1fe8db830: [X86] Support -march=rocketlake (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe created this revision. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/ms-inline-asm.c cl

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2488 + if (Clobber == "eax") { +std::string::size_type position = Constraints.find("={eax}"); +if (position != std::string::npos) { pengfei wrote: > `={eax}` is set in `

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 316324. FreddyYe added a comment. consider "=A" into the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeG

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 318123. FreddyYe added a comment. consider Clobber == "edx" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 318128. FreddyYe added a comment. Fix Lint: Pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe marked an inline comment as done. FreddyYe added a comment. Sorry for late response. Thanks for your comments, @DavidSpickett ! Comment at: clang/test/Misc/target-invalid-cpu-note.c:27 // TUNE_X86_64: error: unknown target CPU 'not-a-cpu' -// TUNE_X86_64: note: valid

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe updated this revision to Diff 378065. FreddyYe added a comment. add {{$}}. add comments at first line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110798/new/ https://reviews.llvm.org/D110798 Files: clang/test/Misc/target-invalid-cpu-

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe updated this revision to Diff 378199. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110798/new/ https://reviews.llvm.org/D110798 Files: clang/test/Mi

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

FreddyYe added inline comments. Comment at: clang/test/Misc/target-invalid-cpu-note.c:1 +// Use CHECK-NEXT instead of CHECK-SAME: ensure outputs between different lines of CHECK-SAME not missing checked. // RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-onl

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d276595d1ce: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c (authored by FreddyYe). Repository: rG LLVM Github Monorepo

[PATCH] D111778: [X86] Update CPU_SPECIFIC list.

FreddyYe created this revision. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Meanwhile update attr-target-mv.c with missing cpu test. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111778 F

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

FreddyYe added a subscriber: RKSimon. FreddyYe added a comment. As mentioned before: In D108422#2957528 , @RKSimon wrote: > There's nothing later than CannonLake here - does Intel need to at least > reference up to Tiger/Rocketlake? I met some issues t

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

FreddyYe added a comment. In D111778#3063891 , @erichkeane wrote: > Supporting these types requires changes to the library so that we can check > these, right? Do you have the library changes for these as well? The > constants used to check for these

<    1   2   3   4