[PATCH] D135937: [X86] Support -march=meteorlake

FreddyYe marked 3 inline comments as done. FreddyYe added a comment. THX for review! Gcc is also recently reviewing related patches. So to align with the compiler-rt and libgcc, let's wait for their land first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/MC/Disassembler/X86/avx-vnni_int8-att.txt:1 +# RUN: llvm-mc --disassemble %s -triple=i686 | FileCheck %s + RKSimon wrote: > I think we'd be better off merging the att

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe updated this revision to Diff 468398. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

FreddyYe created this revision. Herald added a subscriber: pengfei. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. "__cmpccxadd_epi*" -> "_cmpccxadd_epi*" Repository: rG LLVM Github Monorepo https

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

FreddyYe added a comment. In D140281#4004707 , @lebedev.ri wrote: > This patch says what it does, but not why it does what it does. Sorry for not mention. This patch is mainly to align with other intrinsics to follow single leading "_" style. Gcc and i

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe created this revision. Herald added a subscriber: pengfei. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140531 Files: clan

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484759. FreddyYe added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/ReleaseNotes.rst clang/lib/Headers/avx512vl

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484764. FreddyYe marked 4 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/Re

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceMinMaxIntrin.c:1 +// RUN: %clang_cc1 -ffreestanding %s -O0 -triple=x86_64-apple-darwin -target-feature +avx512bw -target-feature +avx512vl -emit-llvm -o - -Wall -Werror | FileCheck %s +

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484784. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/Re

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484998. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/Re

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 485018. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/Re

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:115 + +char test_mm_reduce_mul_epi8(__m128i __W){ +// CHECK-LABEL: @test_mm_reduce_mul_epi8( skan wrote: > skan wrote: > > char has different meaning on different platfor

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68a888012b12: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9816c1912d56: [X86] Rename CMPCCXADD intrinsics. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140281/new/ https://reviews.llvm.org/

[PATCH] D140950: [X86] Support -march=emeraldrapids

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D140950: [X86] Support -march=emeraldrapids

FreddyYe updated this revision to Diff 486163. FreddyYe marked 4 inline comments as done. FreddyYe added a comment. Address comments. Thanks for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140950/new/ https://reviews.llvm.org/D140950 Fil

[PATCH] D140950: [X86] Support -march=emeraldrapids

FreddyYe added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140950/new/ https://reviews.llvm.org/D140950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D140950: [X86] Support -march=emeraldrapids

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27b8f54f5174: [X86] Support -march=emeraldrapids (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 472496. FreddyYe marked an inline comment as done. FreddyYe added a comment. Add X86_CPU_SUBTYPE_ALIAS and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe added a comment. In D135937#3898501 , @FreddyYe wrote: > In D135937#3898228 , @FreddyYe > wrote: > >> For saving capacity of ProcessorSubtypes, gcc decided to not support part of >> compiler features of

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 472822. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 Files: clang/docs/Re

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12940-12941 .Case(STR, {2u, static_cast(llvm::X86::ENUM)}) +#define X86_CPU_SUBTYPE_ALIAS(ENUM, STR) \ + .Case(STR, {2u, static_cast(llvm::X86::ENUM)}) #include

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:94 +X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4,"znver4") +X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST, "sierraforest") +X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS, "graniterapids") --

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:94 +X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4,"znver4") +X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST, "sierraforest") +X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS, "graniterapids") --

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa806fc2767d7: [X86] Support -march=raptorlake, meteorlake (authored by FreddyYe). Changed prior to commit: https://reviews.llvm.org/D135937?vs=472

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474132. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 Files: clang/docs/Re

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474138. FreddyYe added a comment. Rebase and add missing supports in cpu_model.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1528 +ProcessorFeatures.TRMTuning>; +def : ProcModel<"grandridge", SLMModel, ProcessorFeatures.GRRFeatures, +ProcessorFeatures.TRMTuning>; RKSimon wrote: > SLMM

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added a comment. gcc has landed related patch: Sierraforest , Graniterapids and Grandrdige

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474140. FreddyYe added a comment. Added ZHAOXIN_FAM7H. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474146. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comments. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 Files:

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe updated this revision to Diff 474155. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. THX fore review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137153/new/ https://reviews.llvm.org/D137153 Files

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:94 +X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4,"znver4") +X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST, "sierraforest") +X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS, "graniterapids") --

[PATCH] D137153: [X86] Support -march=sierraforest, grandridge, graniterapids.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84a18a260e46: [X86] Support -march=sierraforest, grandridge, graniterapids. (authored by FreddyYe). Changed prior to commit: https://reviews.llvm.

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541340. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address commments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/R

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541343. FreddyYe added a comment. Refine doxygen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Bui

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541373. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/Re

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541392. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/Re

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541495. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Re

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541496. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/Re

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541502. FreddyYe added a comment. Split assembly tests and cover more registers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541503. FreddyYe added a comment. Remove -x86-asm-syntax=intel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 541787. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/Rel

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541792. FreddyYe marked 5 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Re

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:230 +/// \endcode +#define _mm_sm3rnds2_epi32(A, B, C, D) \ + (__m128i) __builtin_ia32_vsm3rnds2((__v4su)A, (__v4su)B, (__v4su)C, (int)D) pengfei w

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 541793. FreddyYe added a comment. Add missing doxygen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basi

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe marked 3 inline comments as done. FreddyYe added a comment. I think we can discuss this issue first in https://reviews.llvm.org/D155662 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 ___

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541815. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Rel

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541824. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Re

[PATCH] D155146: [X86] Add SHA512 instructions.

FreddyYe updated this revision to Diff 542267. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/BuiltinsX86

[PATCH] D155146: [X86] Add SHA512 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3b7874b6c9: [X86] Add SHA512 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 542274. FreddyYe added a comment. rebase and fix lit fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D155147: [X86] Add SM3 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6f66de21af0: [X86] Add SM3 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

FreddyYe added a comment. ping... Anyone help accept? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155145/new/ https://reviews.llvm.org/D155145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D155148: [X86] Add SM4 instructions.

FreddyYe updated this revision to Diff 542305. FreddyYe added a comment. rebase and fix lit fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D155148: [X86] Add SM4 instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG049d6a3f428e: [X86] Add SM4 instructions. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 542360. FreddyYe added a comment. add clang releasenote Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Target

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1922 +// RUN: --target=x86_64 \ +// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_GNRD_M64 // CHECK_GNR_M64: #define __AES__ 1 RKSimon wrote: > Maybe c

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 542446. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/Rel

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

FreddyYe updated this revision to Diff 542476. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155784/new/ https://reviews.llvm.org/D155784 Files: clang/test/Pre

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1925 // CHECK_GNR_M64: #define __AMX_BF16__ 1 -// CHECK_GNR_M64: #define __AMX_COMPLEX__ 1 +// CHECK_GNR_M64-NOT: #define __AMX_COMPLEX__ 1 +//

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1925 // CHECK_GNR_M64: #define __AMX_BF16__ 1 -// CHECK_GNR_M64: #define __AMX_COMPLEX__ 1 +// CHECK_GNR_M64-NOT: #define __AMX_COMPLEX__ 1 +//

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1082 FeaturePREFETCHI, - FeatureSHA512,

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543342. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: cl

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1082 FeaturePREFETCHI, - FeatureSHA512, FeatureAMXCOMPLEX]

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543344. FreddyYe added a comment. Update cpu_specific required features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543797. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/Rel

[PATCH] D155784: [X86] Update features for sierraforest, grandridge

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cc4b1059b28: [X86] Update features for sierraforest, grandridge (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

FreddyYe updated this revision to Diff 543826. FreddyYe added a comment. rebase and fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d23a3faa4e6: [X86] Support -march=graniterapids-d and update -march=graniterapids (authored by FreddyYe). Repository: rG LLVM Github Monorepo CH

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Githu

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe updated this revision to Diff 544159. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 Files: clang/lib/Basi

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: llc

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe marked 3 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: llc

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe updated this revision to Diff 544314. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 Files: clang/lib/Basi

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

FreddyYe updated this revision to Diff 544625. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156239/new/ https://reviews.llvm.org/D156239 Files: clang/lib/Basi

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe created this revision. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. gracemont has some differen

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: RKSimon wrote: > Why not handle this above (below tremont) as the next

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe updated this revision to Diff 551350. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158046/new/ https://reviews.llvm.org/D158046 Files: clang/lib/Basi

[PATCH] D158046: [X86] Support -march=gracemont

FreddyYe added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: RKSimon wrote: > FreddyYe wrote: > > RKSimon wrote: > > > Why not handle this above (below tremont) as the next in

[PATCH] D158046: [X86] Support -march=gracemont

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6acff5390d05: [X86] Support -march=gracemont (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:167 + FEATURE_WP, + FEATURE_LZCNT = 57, + FEATURE_MOVBE, ` = 57` redundant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158329/ne

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13319 +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs), +CharUnits::fromQuantity(4)); Will function multi version als

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13317 + continue; +Value *Idxs[] = {Builder.getInt32(0), Builder.getInt32(i - 1)}; +Value *Features = Builder.CreateAlignedLoad( Don't quite understand why we need to change

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13319 +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs), +CharUnits::fromQuantity(4)); MaskRay wrote: > FreddyYe wrote

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9d92e66387b: [X86] Support -march=arrowlake,arrowlake-s,lunarlake (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe updated this revision to Diff 536495. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment, thanks review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154209/new/ https://reviews.llvm.org/D154209 Files:

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe added a comment. In D154209#4466304 , @RKSimon wrote: > LGTM - but it would be good to fix silvermont / westmere cases as well with > suitable test coverage Thanks review! After D151696 landed, they can be bo

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb026c9eb1051: [X86] Add missing features for ivybridge, sandybridge and knl in… (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 536645. FreddyYe marked an inline comment as done. FreddyYe added a comment. Rebase, especially for D151696 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. gentle ping. If no objections, I'll merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commits mailing list

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:40 ATTR(cpu_specific(knm)) void CPU(void){} +ATTR(cpu_specific(cascadelake)) void CPU(void){} +ATTR(cpu_specific(cooperlake)) void CPU(void){} --

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 537065. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Add comments about Mangling and OnlyForCPUDispatchSpecific, and remove the supporting more/new CPU names for cpu_specific/dispatch feature. Repository: rG LLVM Github Monorepo C

[PATCH] D151696: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7717c0071d7c: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGE

<    1   2   3   4   >