[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn updated this revision to Diff 382128. fhahn marked an inline comment as done. fhahn added a comment. Address comments @aaron.ballman, thanks! The most notable changes are using `UsualArithmeticConversions` for argument conversion and checking the canonical types. Also added a bunch of addi

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn marked 4 inline comments as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16669 +ExprResult Sema::SemaBuiltinElementwiseMath(CallExpr *TheCall, +ExprResult CallResult) { + if (checkArgCount(*this,

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn created this revision. fhahn added reviewers: erichkeane, rjmccall, thegameg, anemet. fhahn requested review of this revision. Herald added a project: clang. At the moment, the various math builtins only accept the scalar types defined by libm. This patch extends __builtin_fminf to also acc

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn added a comment. > This brings Clang more in line with GCC, which already supports math builtins > with ext_vector_type arguments. This is unfortunately not correct. When I tried this with GCC the `ext_vector_type` attribute was dropped and it fell back to `float`. Repository: rG LLVM

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn updated this revision to Diff 369135. fhahn added a comment. Updated to remove stray comment. In D108832#2969512 , @erichkeane wrote: > I think I would want some level of examination/analysis as to whether we want > to do this with all of the vec

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn updated this revision to Diff 369136. fhahn marked 2 inline comments as done. fhahn added a comment. Use ExprError() instead of ExprResult(true). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108832/new/ https://reviews.llvm.org/D108832 File

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16544 + E, AA_Passing)) + return ExprResult(true); + erichkeane wrote: > Doing this as ExprResult(true) is absurdly jarring. Updated, thanks! =

[PATCH] D109137: [clang] NFC: Remove duplicate DependentSizedMatrixType methods

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109137/new/ https://reviews.llvm.org/D109137

<    3   4   5   6   7   8