[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122126/new/ https://reviews.llvm.org/D122126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks for breaking this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

fhahn added a comment. In D124836#3528109 , @vvereschaka wrote: > Hi @void , > > the `zero-call-used-regs.ll` test gets failed on > `llvm-clang-x86_64-expensive-checks-ubuntu` builder with the following errors: > > ... > *** Bad machine code: Illega

[PATCH] D66290: [clang] Pragma vectorize_width() implies vectorize(enable)

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66290/new/ https://reviews.llvm.org/D66290 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D66796: [clang] Loop pragma vectorize(disable)

fhahn added a comment. IMO it is fine to say ` pragma vectorize(disable)` disables the vectorizer completely, including interleaving. @Meinersbur, what do you think? I think it would be good to make that clear in the commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66796/n

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

fhahn added a comment. There seems to be a problem with this patch on macOS. I've XFAIL'd it in rGdb82fc5dd80ff14798e7f1c35dd7e593f6409ba3 . This should unblock the macOS builders, but please take a look at the problem. Repo

[PATCH] D72281: [Matrix] Add matrix type to Clang (WIP).

fhahn created this revision. Herald added a reviewer: martong. Herald added subscribers: tschuett, arphaman. Herald added a project: clang. This patch adds a matrix type to Clang as described in "Matrix Support in Clang" on cfe-dev [1]. The patch is not intended for review yet, just to provide an

[PATCH] D72283: [Matrix] Add __builtin_matrix_insert to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. This patch adds a __builtin_matrix_insert builtin as described in "Matrix Support in Clang" on cfe-dev [1]. The patch is not intended for review yet, just to provide an idea how the implementation coul

[PATCH] D72772: [Matrix] Add __builtin_matrix_extract to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72772 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S

[PATCH] D72773: [Matrix] Add __builtin_matrix_{add,sub} to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72773 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sem

[PATCH] D72774: [Matrix] Add __builtin_matrix_multiply to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72774 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sem

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72778 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72781 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72782 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S

[PATCH] D72785: [Matrix] Add __builtin_matrix_scalar_multiply to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72785 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sem

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb109c42d91c: [DSE] Switch to MemorySSA-backed DSE by default. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn updated this revision to Diff 291176. fhahn added a comment. Update code to limit adding noalias to types with `getArgPassingRestrictions() == RecordDecl::APK_CanPassInRegs`. This rules out problematic types, like ones with non-trivial constructors or ObjC structs with weak pointers. Thank

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2198 +// reference to the underlying object. Mark it accordingly. +Attrs.addAttribute(llvm::Attribute::NoAlias); + rjmccall wrote: > fhah

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn updated this revision to Diff 291183. fhahn marked an inline comment as done. fhahn added a comment. Add check lines for escape examples. Note that for return-by-value we already add noalias to the pointer unconditionally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa874d6334409: [Clang] Add option to allow marking pass-by-value args as noalias. (authored by fhahn). Changed prior to commit: https://reviews.llv

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added inline comments. Comment at: clang/include/clang/Driver/Options.td:4287-4290 +def fpass_by_value_noalias: Flag<["-"], "fpass-by-value-noalias">, + HelpText<"Allows assuming no references to passed by value escape before " + "transferring execution to the ca

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2269674 , @thakis wrote: > The fix-up breaks tests: http://45.33.8.238/linux/27687/step_12.txt Thanks, should already be fixed in d85ac6d577ac Reposi

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2270568 , @uabelho wrote: > Hi, > > I'm seeing what I think is a miscompile with this: Thanks for the reproducer. We have to be more careful around pointers that may reference multiple locations in memory. I pushed f715d8

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2270444 , @thakis wrote: > Heads-up: We're seeing fairly widespread test failures with this in Chromium > that go away when we force this flag off. It's possible that it's due to only > a small number of issues and they m

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2271998 , @dmajor wrote: > In D87163#2270871 , @fhahn wrote: > >> In D87163#2270444 , @thakis wrote: >> >>> Heads-up: We're seeing fairly wid

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2272749 , @asbirlea wrote: > I'd suggest reverting if the failures are blocking, but we do need a > reproducer so it can be recommitted after a fix is in place. +1, but I think ideally we would have reproducers for the re

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2273917 , @thakis wrote: > It's not blocking us because we added an explicit flag to force this off to > our build config for "normal" builds. (We still get the default-on behavior > on our bots that build with trunk clan

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2274549 , @dmajor wrote: > Reduced a bit more: https://godbolt.org/z/j59evK (C++) and > https://godbolt.org/z/8xG688 (IR) -- the store at line 43 of `while.end` has > been removed. Thanks! I reverted the change for now i

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2275058 , @asbirlea wrote: > Yes, the load should have the Phi as the defining access. I'm still looking > into where this information should come from, but it's not hitting the phi > translation. > Thank you for the reve

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2276899 , @dmajor wrote: > In D87163#2275896 , @asbirlea wrote: > >> I checked in a fix in https://reviews.llvm.org/rGfc8200633122, but I haven't >> yet verified it addresses all

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. All reported problems should be fixed now and we also made the fix for the issue @dmajor reported more conservative to catch more problematic cases. I just enabled DSE + MemorySSA again in 9d172c8e9c84 .

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

fhahn added a comment. Surprising this causes only such a small perf regression. I guess it should be OK given that, but here probably are some pathological cases out there where this may cause some noticeable compile-time regressions. IIUC the additional cases this catches come mainly from ful

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2285984 , @dmajor wrote: > I threw as many tests as I could find at 9d172c8e9c84 > , and I > don't see any regressions compared to its parent revision.

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

fhahn added a comment. In D87972#2284060 , @MaskRay wrote: > I have tested this patch internally and seen gains and losses. On one > document search related benchmark 3~5% improvement. One zippy (snappy) there > is 3~5% regression. Perhaps we do need a c

[PATCH] D88265: Fix comma with half vectors.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13936 // arm64). - assert(isVector(RHS.get()->getType(), Context.HalfTy) == - isVector(LHS.get()->getType(), Context.HalfTy) && - "both sides are half vectors or neither sides are"); + asser

[PATCH] D86274: [Constants] Handle FNeg in getWithOperands.

fhahn created this revision. fhahn added reviewers: efriedma, aprantl, arsenm. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. fhahn requested review of this revision. Herald added a subscriber: wdng. Currently ConstantExpr::getWithOperands does not handle FNe

[PATCH] D86274: [Constants] Handle FNeg in getWithOperands.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc72a3ab949e: [Constants] Handle FNeg in getWithOperands. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D86274?vs=286756&

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85473/new/ https://reviews.llvm.org/D85473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85473/new/ https://reviews.llvm.org/D85473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once

fhahn accepted this revision. fhahn added a comment. LGTM, thanks for addressing this! Please wait a bit with committing, in case there are additional comments. Comment at: clang/lib/Sema/SemaExpr.cpp:4598 } // If the base is either a MatrixSubscriptExpr or a matrix type

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn created this revision. fhahn added reviewers: efriedma, dmgreen, asbirlea, reames. Herald added subscribers: cfe-commits, lxfind, nikic, kerbowa, jfb, dexonsmith, steven_wu, george.burgess.iv, modocache, hiraditya, Prazek, nhaehnle, jvesely. Herald added projects: clang, LLVM. fhahn requeste

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn updated this revision to Diff 290140. fhahn added a comment. Adjust limit in description, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/ https://reviews.llvm.org/D87163 Files: clang/test/CodeGen/thinlto-distributed-newpm.

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:115 cl::desc("The number of memory instructions to scan for " "dead store elimination (default = 100)")); static cl::opt MemoryS

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn updated this revision to Diff 290504. fhahn marked an inline comment as done. fhahn added a comment. Change to codegen option, adjust description for option, limit to trivially copyable types in C++, add corresponding test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn added inline comments. Comment at: clang/include/clang/Driver/Options.td:4287-4290 +def fpass_by_value_noalias: Flag<["-"], "fpass-by-value-noalias">, + HelpText<"Allows assuming no references to passed by value escape before " + "transferring execution to the ca

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. Note that we now also have to compute the PostDominatorTree, which adds an extra bit of compile-time overhead. By adjusting the pipeline a bit more, we can re-use ADCE's PDTs in most cases, which gives a `-0.18%` geomean improvement for -O3 D87322

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn updated this revision to Diff 290658. fhahn added a comment. rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/ https://reviews.llvm.org/D87163 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. As another data point, I have collected compile-time numbers for ARM64 with -Os -g LTO & -Oz -g LTO. Geoman changes below. Compile time here is actual execution time on a stabilized system. Compile time code size -Oz RLTO 0.67%

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. It looks like a recently introduced GVN crash is exposed by this change (probably D87061 ). I will commit once this is fixed. In D87163#2263685 , @nikic wrote: > LGTM as well, per llvm-dev discussi

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:312 switch (II->getIntrinsicID()) { default: llvm_unreachable("doesn't pass 'hasAnalyzableMemoryWrite' predicate"); case Intrinsic::lifetime_end: asbirlea

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2264785 , @asbirlea wrote: > I'm running into a crash with this, could you please hold off until tomorrow? > I'm working on getting a reproducer. @asbirlea Thanks for the reproducer, the issue should be sorted out. The GV

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn updated this revision to Diff 291078. fhahn added a comment. Final rebase after new memcpy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/ https://reviews.llvm.org/D87163 Files: clang/test/CodeGen/thinlto-distributed-newpm.l

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2266725 , @asbirlea wrote: > I'm running additional testing in the background. I don't have anything > holding this back at this point. > Either check in and if something shows up, I'll let you know to resolve or > revert

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

fhahn updated this revision to Diff 291083. fhahn added a comment. Also restrict to types that are `isNonTrivialToPrimitiveCopy`, so we do not add noalias for problematic types, like ObjC structs with weak references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

fhahn created this revision. fhahn added reviewers: SjoerdMeijer, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds vcmla and the rotated variants as defi

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

fhahn updated this revision to Diff 310632. fhahn added a comment. Updated to use new VCMLA_ROTS multiclass to define rotated variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92930/new/ https://reviews.llvm.org/D92930 Files: clang/include

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5237 NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1ArgType), + NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1ArgType), NEONMAP1(vcage_v, arm_neon_vacge, 0), t.p.northover wr

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

fhahn updated this revision to Diff 310799. fhahn added a comment. Loop over rotation variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92930/new/ https://reviews.llvm.org/D92930 Files: clang/include/clang/Basic/arm_neon.td clang/lib/Cod

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

fhahn created this revision. fhahn added reviewers: SjoerdMeijer, dmgreen, t.p.northover. Herald added subscribers: danielkiss, kristof.beyls. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds the LANE variants for VCMLA

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4cddb53a7b: [Clang] Add vcmla and rotated variants for Arm ACLE. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D91444: [InstCombine] Preserve !annotation metadata for memory combines.

fhahn updated this revision to Diff 312216. fhahn added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D91444#2394512 , @lebedev.ri wrote: > What about teaching IRBuilder to deal with it like it deals with debugloc? D

[PATCH] D91444: [InstCombine] Preserve !annotation on newly created instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01089c876bff: [InstCombine] Preserve !annotation on newly created instructions. (authored by fhahn). Changed prior to commit: https://reviews.llvm

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:26 // Check br i1 to make sure the loop is gone, there will still be a label branch for the infinite loop. // CHECK-LABEL: Helper This comment needs updating, there's no loop there now

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn added inline comments. Comment at: llvm/test/Other/loop-deletion-printer.ll:17 -define void @deleteme() { +define void @deleteme() willreturn { entry: atmnpatel wrote: > fhahn wrote: > > Is this change related to the patch? Same for the other test change

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2379892 , @thakis wrote: > Very belated update: We've been running with this on our clang/tot bots for a > few weeks now and turned this on (or, more accurately stopped turning it off) > for "normal" builds today. All tes

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

fhahn created this revision. fhahn added reviewers: rjmccall, rsmith, Bigcheese. Herald added a subscriber: tschuett. Herald added a project: clang. fhahn requested review of this revision. The Itanium CXX ABI grammer has been extended to support parameterized vendor extended types [1]. This patc

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3353-3371 + auto &ASTCtx = getASTContext(); + unsigned BitWidth = ASTCtx.getTypeSize(ASTCtx.getSizeType()); + llvm::APSInt Rows(BitWidth); + Rows = T->getNumRows(); + mangleIntegerLiteral(ASTCtx.getSize

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

fhahn updated this revision to Diff 304605. fhahn added a comment. Update comment and fix I and E order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91253/new/ https://reviews.llvm.org/D91253 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3523 mangleType(T->getElementType()); + Out << "I"; } rjmccall wrote: > Your `I`s and `E`s are backwards. Argh, used different orders for comment

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d5daed1997d: [Matrix] Update mangling to use paramterized vendor ext type syntax. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

fhahn created this revision. fhahn added reviewers: thegameg, paquette, jdoerfert, rjmccall. Herald added subscribers: cfe-commits, dexonsmith, jfb, hiraditya. Herald added projects: clang, LLVM. fhahn requested review of this revision. This patch updates Clang's IRGen to add !annotation nodes wit

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1267 assert(!isa(constant)); - emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant); + emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant, true); } jdoerfert wr

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca2e7e59994d: [IRGen] Add !annotation metadata for auto-init stores. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D91417

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dbe44cb2936: Add pass to add !annotate metadata from @llvm.global.annotations. (authored by fhahn). Herald added a project: clang. Herald added a su

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

fhahn marked an inline comment as done. fhahn added a comment. Thanks Jessica & Francis! I committed the initial version, with a small change to only run if the `!annotation` remarks are enabled. Comment at: llvm/include/llvm/Transforms/IPO/Annotation2Metadata.h:1 +//===- SCCP

[PATCH] D91631: [Matrix] Adjust matrix pointer type for inline asm arguments.

fhahn created this revision. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. fhahn requested review of this revision. Matrix types in memory are represented as arrays, but accessed through vector pointers, with the alignment specified on the access operation. For i

[PATCH] D91631: [Matrix] Adjust matrix pointer type for inline asm arguments.

fhahn added a comment. There's still one remaining issue. The backend will still crash when the resulting vector does not fit into the target's vector register directly. But that's the same as with `ext_vector_type` I think. The snippet below should produce the same `asm` call as a `float x 3 x

[PATCH] D91631: [Matrix] Adjust matrix pointer type for inline asm arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG680931af2757: [Matrix] Adjust matrix pointer type for inline asm arguments. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D88265: Fix comma with half vectors.

fhahn added a comment. Could you adjust the commit message to be a bit more descriptive, e.g something like `[Sema] Support Comma operator for fp16 vectors.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265

[PATCH] D88265: Fix comma with half vectors.

fhahn added a comment. In D88265#2303841 , @arames wrote: > In D88265#2302653 , @fhahn wrote: > >> Could you adjust the commit message to be a bit more descriptive, e.g >> something like `[Sema] Support Comma opera

[PATCH] D88265: [Sema] Support Comma operator for fp16 vectors.

This revision was automatically updated to reflect the committed changes. Closed by commit rG700e63293eea: [Sema] Support Comma operator for fp16 vectors. (authored by arames, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/n

[PATCH] D88265: [Sema] Support Comma operator for fp16 vectors.

fhahn accepted this revision. fhahn added a comment. LGTM, thanks. I'll commit this in a minute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 ___ cfe-commits m

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. FYI this has been temporarily reverted again roughly a week ago, because there seems to be a mis-compile, that is caused by LLVM introducing invalid lifetime.end calls and exposed by the more powerful DSE, which @asbirlea is currently trying to narrow down. Repository:

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. I put up an impromptu round-table to discuss MemorySSA related topics, including potential new transformations like MemCpyOpt using MemorySSA: https://whova.com/portal/webapp/llvm_202010/CommunityBoard/topic/342030/ If there's any interest, I think it would be great to sy

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt -vector-library=LIBMVEC-X86 -inject-tli-mappings -loop-vectorize -S < %s | FileChe

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls.ll:1 +; RUN: opt -vector-library=LIBMVEC -inject-tli-mappings -force-vector-width=4 -force-vector-interleave=1 -loop-vectorize -S < %s | FileCheck %s + spatel wrot

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fhahn added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/X86/libm-vector-calls-finite.ll:82 + +!1 = distinct !{!1, !2, !3} +!2 = !{!"llvm.loop.vectorize.width", i32 4} fhahn wrote: > I don't think we need this. You can just pass `-force-vector

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

fhahn added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1096 static_cast(Tok.getAnnotationValue()); - IdentifierInfo *PragmaNameInfo = Info->PragmaName.getIdentifierInfo(); nit: unrelated change? Comment at: clang/lib

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

fhahn added a comment. I think this also fixes https://bugs.llvm.org/show_bug.cgi?id=47397 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436 ___ cfe-commits mailing

[PATCH] D89699: [ExtVector] Make .even/.odd/.lo/.hi return vectors for single elements.

fhahn created this revision. fhahn added reviewers: rjmccall, jfb, scanon, rsmith, hfinkel. Herald added a subscriber: dexonsmith. Herald added a project: clang. fhahn requested review of this revision. Currently the 'swizzle' accessors .even/.odd/.lo/.hi return a scalar instead of a vector with a

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

fhahn added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:144 + assert(ValueExpr && "Attribute must have a valid value expression."); + if (S.CheckLoopHintExpr(ValueExpr, St->getBeginLoc())) +return nullptr; sdesmalen wrote: > dav

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, rsmith, erichkeane. Herald added subscribers: dexonsmith, tschuett. fhahn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. The matrix extension requires the indices

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn created this revision. fhahn added reviewers: jroelofs, ab, scanon, arphaman. Herald added subscribers: dexonsmith, dang. fhahn requested review of this revision. Herald added a project: clang. Support for Darwin's libsystem_m's vector functions has been added to LLVM in 93a9a8a8d90f

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

fhahn created this revision. fhahn added reviewers: jroelofs, ab, scanon, arphaman. fhahn requested review of this revision. Herald added a project: clang. Building on D102489 , default to Darwin_libsystem_m veclib on iOS based targets. Repository: rG LLVM Gi

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:405 break; + case CodeGenOptions::Darwin_libsystem_m: +TLII->addVectorizableFunctionsFromVecLib( arphaman wrote: > Can you add an IRGen testcase that verifies that TLII is settin

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn updated this revision to Diff 345449. fhahn added a comment. Add end-to-end test, as suggested. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102489/new/ https://reviews.llvm.org/D102489 Files: clang/include/clang/Basic/CodeGenOpti

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

fhahn added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492 + // Darwin_libsystem_m for iOS based targets. + if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib)) +CC1Args.push_back("-fveclib=Darwin_libsystem_m"); --

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

fhahn added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:405 break; + case CodeGenOptions::Darwin_libsystem_m: +TLII->addVectorizableFunctionsFromVecLib( arphaman wrote: > fhahn wrote: > > arphaman wrote: > > > Can you add an IRGen tes

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG187a14e1f399: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102489/new/ https:/

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn updated this revision to Diff 345702. fhahn added a comment. Herald added a subscriber: hiraditya. Thanks for taking a look! I added a phase ordering test and updated the pipeline tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

<    1   2   3   4   5   6   7   8   >