Re: Default -fomit-frame-pointer for PowerPC

2019-04-02 Thread Finkel, Hal J. via cfe-commits
On 4/2/19 12:31 PM, Roman Lebedev via cfe-commits wrote: > Best to submit patches to phabricator https://reviews.llvm.org/ Please follow the instructions here: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface - This will make it much easier for us to track this. Th

Re: [PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

2019-05-02 Thread Finkel, Hal J. via cfe-commits
Thanks, Justin. It sees like we have the standard set of options: We can disallow the mismatch. We can allow it with a warning. We can allow it without a warning. We can say that if the mismatch contributes to the type of a kernel function, that's illformed (NDR). In any case, it seems like you

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

2019-10-21 Thread Finkel, Hal J. via cfe-commits
On 10/21/19 4:00 PM, Jordan Rupprecht via cfe-commits wrote: There's also a curious failure caused by this patch (confirmed passing @r374287, failing @r374288): $ cat /tmp/vectorize.cc void a() { #pragma clang loop vectorize(disable) for (;;) ; } $ clang++ -Werror -O3 -c /tmp/vectorize.cc