[PATCH] D66584: [clang-format] Support .mjs module javascript extension in clang-format

2019-08-22 Thread Fergal Daly via Phabricator via cfe-commits
fergald created this revision. fergald added a reviewer: MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR43085. This causes .mjs files to be treated as javascript. .mjs is the extension for module-javascript. Module javascript is not compatible with non-module j

[PATCH] D66584: [clang-format] Support .mjs module javascript extension in clang-format

2019-08-22 Thread Fergal Daly via Phabricator via cfe-commits
fergald added a comment. It seems to do the right thing. E.g. https://crrev.com/c/1767284/5/third_party/blink/renderer/core/script/resources/layered_api/elements/virtual-scroller/visibility-manager.mjs Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66584/new/ htt

[PATCH] D66584: [clang-format] Support .mjs module javascript extension in clang-format

2019-08-22 Thread Fergal Daly via Phabricator via cfe-commits
fergald added a comment. I cannot commit this, please do so, if you're happy with it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66584/new/ https://reviews.llvm.org/D66584 ___ cfe-commits mailing list cfe-commits@

[PATCH] D66584: [clang-format] Support .mjs module javascript extension in clang-format

2019-08-22 Thread Fergal Daly via Phabricator via cfe-commits
fergald added a comment. "why .mjs is so common that it justifies a clang-format change?" I don't have data but Module JS is the future, it's supported by all major browsers for some time and also Node.js, it solves the problem of everything being lumped into one namespace. Why does it need a

[PATCH] D66584: [clang-format] Support .mjs module javascript extension in clang-format

2019-08-22 Thread Fergal Daly via Phabricator via cfe-commits
fergald added a comment. Thanks, I'm happy with that description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66584/new/ https://reviews.llvm.org/D66584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https: