[PATCH] D35718: [clang-tidy] Do not issue fixit for explicit template specializations

flx created this revision. Herald added subscribers: xazax.hun, JDevlieghere. Do not issue fixit in UnnecessaryValueParamCheck if the function is an explicit template specialization as this could cause build breakages. Repository: rL LLVM https://reviews.llvm.org/D35718 Files: clang-tidy/

[PATCH] D35718: [clang-tidy] Do not issue fixit for explicit template specializations

flx updated this revision to Diff 107786. https://reviews.llvm.org/D35718 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp test/clang-tidy/performance-unnecessary-value-param.cpp Index: test/clang-tidy/performance-unnecessary-value-param.cpp =

[PATCH] D35718: [clang-tidy] Do not issue fixit for explicit template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rL309067: [clang-tidy] Do not issue fixit for explicit template specializations (authored by flx). Changed prior to commit: https://reviews.llvm.org/D35718?vs=107786&id=108193#toc Repository: rL LLVM

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

flx created this revision. flx added reviewers: alexfh, sbenza, aaron.ballman. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. flx added a project: clang-tools-extra. Herald added a subscriber: JDevlieghere. This fixes a bug where the performance-unnecessa

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 79550. https://reviews.llvm.org/D27187 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-tidy/utils/DeclRefExprUtils.cpp clang-tidy/utils/DeclRefExprUtils.h test/clang-tidy/performa

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

flx marked an inline comment as done. flx added inline comments. Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127 + match(findAll(declRefExpr(equalsNode(&DeclRef), +unless(hasAncestor(stmt(anyOf( +forSt

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

flx added inline comments. Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127 + match(findAll(declRefExpr(equalsNode(&DeclRef), +unless(hasAncestor(stmt(anyOf( +forStmt(), cxxForRangeStmt(), whileStmt(),

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx created this revision. flx added reviewers: sbenza, alexfh, hokein. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. flx added a project: clang-tools-extra. Herald added a subscriber: JDevlieghere. Virtual method overrides of dependent types cannot be r

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +// marked with ove

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 79732. flx marked an inline comment as done. https://reviews.llvm.org/D27248 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp test/clang-tidy/performance-unnecessary-value-param.cpp Index:

[PATCH] D27187: [clang-tidy] Do not move parameter if only DeclRefExpr occurs inside of a loop

flx added a comment. Do you have any more comments, Alex? https://reviews.llvm.org/D27187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +// marked with ove

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

This revision was automatically updated to reflect the committed changes. Closed by commit rL288502: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as… (authored by flx). Changed prior to commit: https://reviews.llvm.org/D27248?vs=79732&id=80066#toc Repository: r

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

flx added a comment. I'm still seeing build failures. Could you resolve them? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx created this revision. flx added reviewers: aaron.ballman, ymandel, hokein. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. It is not useful to keep the statement around and can lead

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx updated this revision to Diff 344149. flx added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102175/new/ https://reviews.llvm.org/D102175 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializatio

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

flx added a comment. Thanks for improving this check! Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:177-178 const auto &CurrentParam = *FunctionDecl->getParamDecl(Index); +if (IsExplicitTemplateSpecialization && Function != Functi

[PATCH] D116535: [clang-tidy] Fix false positive in modernize-pass-by-value

flx accepted this revision. flx added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp:108 +/// Returns true the given constructor is part of a lvalue/rvalue reference +/// pair, i.e. `Para

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:177-178 const auto &CurrentParam = *FunctionDecl->getParamDecl(Index); +if (IsExplicitTemplateSpecialization && Function != FunctionDecl) + continue;

[PATCH] D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1b1c23a3b5f: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType. (authored by flx). Repository: rG LLVM Github Monorep

[PATCH] D115809: [ASTMatchers] Make ParamIndex unsigned.

flx created this revision. flx added a reviewer: sammccall. Herald added a subscriber: arphaman. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a compiler error/warning in https://lab.llvm.org/buildbot/#/builders/36/builds/1

[PATCH] D115809: [ASTMatchers] Make ParamIndex unsigned.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54ed30fdd63b: [ASTMatchers] Make ParamIndex unsigned. (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D114559: [clang] ASTMatchers: Fix out-of-bounds access in foreachArgumentWithParamType.

flx added a comment. In D114559#3195357 , @mubarizafzal wrote: > Hi, this patch is causing a build failure for clang-ppc64le-rhel > , > can this be reverted? Hi, I just submi

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx created this revision. flx added reviewers: ymandel, aaron.ballman. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. This allows users to be more precise and exclude a type in a specific namespace from triggering the check

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:56 +if (Name.find("::") != std::string::npos) { + return llvm::Regex(Name).match(Node.getQualifiedNameAsString()); +} ymandel wrote: > nit: while this change is not

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:56 +if (Name.find("::") != std::string::npos) { + return llvm::Regex(Name).match(Node.getQualifiedNameAsString()); +} ymandel wrote: > flx wrote: > > ymandel wrote:

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx updated this revision to Diff 331941. flx added a comment. Applied changes suggested by ymandel, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98738/new/ https://reviews.llvm.org/D98738 Files: clang-tools-extra/clang-tidy/utils/Match

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx marked 6 inline comments as done. flx added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:52 AST_MATCHER_P(NamedDecl, matchesAnyListedName, std::vector, NameList) { hokein wrote: > worth some comments on this. Do

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx updated this revision to Diff 335267. flx marked an inline comment as done. flx added a comment. Create a NameMatcher class that handles matching against the best name variant (unqualified, qualified, fully qualified) of the NamedDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

flx marked 2 inline comments as done. flx added a comment. Thanks for the comments, PTAL! Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:79 +llvm::Regex Regex; +bool MatchQualifiedName = false; + }; ymandel wrote: > Worth a comment i think.

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx added a comment. Could someone take a look at this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D98738: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type names when they contain "::".

This revision was automatically updated to reflect the committed changes. Closed by commit rGddebed8e9742: [clang-tidy] performance-* checks: Match AllowedTypes against qualified type… (authored by flx). Changed prior to commit: https://reviews.llvm.org/D98738?vs=335267&id=335632#toc Repositor

<    1   2