[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

MaskRay created this revision. MaskRay added reviewers: Eugene.Zelenko, dblaikie. Herald added a subscriber: cfe-commits. unique_ptr makes the ownership clearer than a raw pointer container. Repository: rC Clang https://reviews.llvm.org/D50945 Files: include/clang/Lex/HeaderMap.h include

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

MaskRay added a comment. Thanks! Repository: rC Clang https://reviews.llvm.org/D50945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50945: [Lex] Make HeaderMaps a unique_ptr vector

This revision was automatically updated to reflect the committed changes. Closed by commit rC340198: [Lex] Make HeaderMaps a unique_ptr vector (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D50945?vs=161391&id=161530#toc Repository: rC Clang https://

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay created this revision. MaskRay added reviewers: rupprecht, alexshap, jhenderson. Herald added a subscriber: cfe-commits. This is to accommodate a change in llvm/lib/Option/OptTable.cpp https://reviews.llvm.org/D51009 Repository: rC Clang https://reviews.llvm.org/D51109 Files: lib/

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay updated this revision to Diff 162478. MaskRay added a comment. Herald added subscribers: atanasyan, jrtc27, sdardis. [Driver] Change MipsLinux default linker from "lld" to "ld.lld" Repository: rC Clang https://reviews.llvm.org/D51109 Files: lib/Driver/ToolChains/MipsLinux.h lib/F

[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

MaskRay created this revision. MaskRay added a reviewer: kzhuravl. Herald added subscribers: cfe-commits, atanasyan, jrtc27, arichardson, sdardis. Repository: rC Clang https://reviews.llvm.org/D51234 Files: lib/Driver/ToolChains/MipsLinux.h Index: lib/Driver/ToolChains/MipsLinux.h

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay updated this revision to Diff 162488. MaskRay added a comment. Sorry I messed up with my branches :( I shall create https://reviews.llvm.org/D51234 but arc diff'ed to a different one Repository: rC Clang https://reviews.llvm.org/D51109 Files: lib/FrontendTool/ExecuteCompilerInvoca

[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

This revision was automatically updated to reflect the committed changes. Closed by commit rL340709: [Driver] Change MipsLinux default linker from "lld" to "ld.lld" (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D5123

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "

MaskRay added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D51109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

MaskRay added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:164 + // - sizeof(dst) + if (Append && isSizeof(LenArg, DstArg)) +return true; george.karpenkov wrote: > george.karpenkov wrote: > > george.karpenkov wrote: > >

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

MaskRay added inline comments. Comment at: test/Analysis/cstring-syntax.c:49 + strlcat(dest, "0123456789", badlen / 2); + strlcat(dest, "0123456789", badlen); // expected-warning {{The third argument allows to potentially copy more bytes than it should. Replace with the value

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay created this revision. MaskRay added reviewers: ruiu, rsmith. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50267 Files: lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp =

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay added a comment. This depends on https://reviews.llvm.org/D50223 Repository: rC Clang https://reviews.llvm.org/D50267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50267: [ASTWriter] Use zlib::compress which operates on std::unique_ptr

MaskRay abandoned this revision. MaskRay added a comment. https://reviews.llvm.org/D50223 has been changed to improve zlib::compress's current SmallVectorImpl interface. This is no longer relevant. Repository: rC Clang https://reviews.llvm.org/D50267 __

[PATCH] D50294: [Driver] Use -gdwarf-3 by default for FreeBSD

MaskRay created this revision. MaskRay added reviewers: brad, emaste, khng300. Herald added subscribers: cfe-commits, JDevlieghere, aprantl. The imported binutils in base supports DWARF 3. Repository: rC Clang https://reviews.llvm.org/D50294 Files: lib/Driver/ToolChains/FreeBSD.h test/Co

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133038. MaskRay added a comment. Update c-index-test.c and clang/test/Index tests Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. In https://reviews.llvm.org/D42895#998617, @yvvan wrote: > I feel quite ok about this patch. > > Can you please add unit-tests? Added // CHECK: [indexEntityReference]: kind: field | name: y | {{.*}} | loc: 70:5 | {{.*}} | role: ref write // CHECK: [index

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133050. MaskRay added a comment. Simplify Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting-literals.m tools/c-index-test/c-index

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133051. MaskRay added a comment. . Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting-literals.m tools/c-index-test/c-index-test.c

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay created this revision. Herald added subscribers: cfe-commits, hintonda, kristof.beyls, xazax.hun, mgorny, aemerson, klimek. Many architectures provide SIMD operations (e.g. x86 SSE/AVX, Power AltiVec/VSX, ARM NEON). It is common that SIMD code implementing the same algorithm, is written i

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay updated this revision to Diff 133083. MaskRay added a comment. Add test/clang-tidy/readability-simd-intrinsics.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp cl

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay added a comment. I haven't used clang-tidy before :) Do you have any suggestions on my workflow? % ninja -C ~/Dev/llvm/build clangTidyReadabilityModule % ~/Dev/llvm/build/bin/clang-tidy -checks='-*,readability-simd-intrinsics' a.cc # for local testing # Ensure tests are correc

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay updated this revision to Diff 133091. MaskRay added a comment. Move CHECK-MESSAGES: to comform to the prevaling style Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133107. MaskRay marked 5 inline comments as done. MaskRay added a comment. LLVM Style Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp c

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:77 +void SIMDIntrinsicsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee(functionDecl(matchesName("^::(_

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133109. MaskRay added a comment. Remove private section Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/SIMDIntr

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133120. MaskRay added a comment. if (!Result.Context->getLangOpts().CPlusPlus11) return; Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133126. MaskRay added a comment. docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/SIMDIntri

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133133. MaskRay marked an inline comment as done. MaskRay added a comment. docs/ReleaseNotes.rst and use StringRef::consume_front Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-ti

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133134. MaskRay marked 2 inline comments as done. MaskRay added a comment. Warning messages of operator+ as operator+ operator- .. are free functions on simd objects. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133233. MaskRay marked 2 inline comments as done. MaskRay added a comment. Fix word order of readability-simd-intrinsics Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readab

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133237. MaskRay added a comment. Add check-specific option `Experimental` StringRef Std; if (Result.Context->getLangOpts().CPlusPlus2a) { Std = "std"; } else if (Result.Context->getLangOpts().CPlusPlus11 && Experimental) { // libcxx implementati

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133239. MaskRay added a comment. Use unnamed namespace to enclose AST_MATCHER and TrySuggest* Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:75 + // libcxx implementation of std::experimental::simd requires at least C++11. + if (!Result.Context->getLangOpts().CPlusPlus11) +return; -

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 3 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:26 + + static const llvm::StringMap Mapping{ +// [simd.alg] lebedev.ri wrote: > You probably want to move `Mapping` out of the

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: include/clang-c/Index.h:6159 + */ + CXSymbolRole role; } CXIdxEntityRefInfo; ilya-biryukov wrote: > Why do we need to store both `CXIdxEntityRefKind` and `CXSymbolRole`? Can

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133255. MaskRay marked an inline comment as done. MaskRay added a comment. readability-simd-intrinsics.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/Readabil

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133441. MaskRay added a comment. Don't deprecate CXIdxEntityRefInfo Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h include/clang/Index/IndexSymbol.h test/Index/index-decls.m test/Index/index-refs.cpp test/In

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay marked 4 inline comments as done. MaskRay added inline comments. Comment at: include/clang-c/Index.h:6159 + */ + CXSymbolRole role; } CXIdxEntityRefInfo; ilya-biryukov wrote: > MaskRay wrote: > > ilya-biryukov wrote: > > > Why do we need to store both

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133455. MaskRay added a comment. Add option `Enabled` which defaults to 0. Suggest std::simd (-std=c++2a) or std::experimental::std (-std=c++11) only if enabled. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/read

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 9 inline comments as done. MaskRay added a comment. The check must be manually enabled now: % clang-tidy -checks='-*,readability-simd-intrinsics' a.cc -- -std=c++2a # Not enabled by default % clang-tidy -checks='-*,readability-simd-intrinsics' -config='{CheckOptions: [{ke

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133457. MaskRay added a comment. Set `Enabled` to 1 in test/clang-tidy/readability-simd-intrinsics.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityT

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133474. MaskRay added a comment. Herald added subscribers: kbarton, nemanjai. Split test/clang-tidy/readability-simd-intrinsics.cpp to x86 and ppc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLis

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133476. MaskRay added a comment. .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/SIMDIntrinsicsCheck.cpp

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133632. MaskRay added a comment. Bring back refkind: Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h include/clang/Index/IndexSymbol.h test/Index/index-refs.cpp test/Index/index-subscripting-literals.m tools/

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. Ping. Now this is a pure API extension to current implicit/direct roles. Is it possible to see this landed before clang+llvm 6 is released? Repository: rC Clang https://reviews.llvm.org/D42895 ___ cfe-commits mailing lis

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL324914: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42895?v

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rC324914: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42895?vs=133632&id=133890#toc Repository: rL

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. Thx! Repository: rL LLVM https://reviews.llvm.org/D42895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133902. MaskRay marked an inline comment as done. MaskRay added a comment. Rename `Enabled` to `UseStdExperimental` and only suggest std::experimental:: (not `std::`) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134076. MaskRay marked an inline comment as done. MaskRay added a comment. Remove UseStdExperimental Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTid

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked 8 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:46 + + static const llvm::StringMap Mapping{ +// [simd.alg] hokein wrote: > consider using `llvm::StringSwitch`? The list is c

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134305. MaskRay marked 2 inline comments as done. MaskRay added a comment. Add an option `Suggest`. Only suggest P0214 alternatives if it is true. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLi

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134446. MaskRay marked 4 inline comments as done. MaskRay added a comment. Update .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134447. MaskRay marked 2 inline comments as done. MaskRay added a comment. Update Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay added inline comments. Comment at: test/clang-tidy/readability-simd-intrinsics-ppc.cpp:3 +// RUN: -config='{CheckOptions: [ \ +// RUN:{key: readability-simd-intrinsics.Suggest, value: 1} \ +// RUN: ]}' -- -target ppc64le -maltivec -std=c++11 hokein

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325272: [clang-tidy] Add `readability-simd-intrinsics` check. (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42983?vs=134447&id=134448#toc Repository: rCTE

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay created this revision. Herald added a subscriber: cfe-commits. DC may sometimes be NULL and getContainerInfo(DC, Container) will fail. Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp Index: tools/libclang/CXIndexDataConsumer.cpp

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay updated this revision to Diff 128148. MaskRay added a comment. DC -> Parent Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp Index: tools/libclang/CXIndexDataConsumer.cpp ===

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay updated this revision to Diff 128149. MaskRay added a comment. DC -> Parent Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp Index: tools/libclang/CXIndexDataConsumer.cpp ===

[PATCH] D41575: [index] Return when Parent is null in handleReference

MaskRay updated this revision to Diff 128150. MaskRay added a comment. Sorry for changing this back and forth. But I do not have a powerful workstation and have to reverse engineer this. Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp I

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. HighCommander4 narrowed it down https://github.com/jacobdufault/cquery/issues/219#issuecomment-354903152 to a much simpler reproduce: c++ template struct actor; template class Actor = actor> struct terminal; This may trigger null pointer dereference of

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D41575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. @akyrtzi When I run `c-index-test core -print-source-symbols -- a.cc` on template struct actor; template class Actor = actor> struct terminal; the issue disappears. It emerges only when `clang_indexTranslationUnit` is called with interactions of other thing

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay updated this revision to Diff 128953. MaskRay added a comment. rebase Repository: rC Clang https://reviews.llvm.org/D41575 Files: tools/libclang/CXIndexDataConsumer.cpp Index: tools/libclang/CXIndexDataConsumer.cpp =

[PATCH] D41575: [index] Return when DC is null in handleReference

This revision was automatically updated to reflect the committed changes. Closed by commit rL322017: [index] Return when DC is null in handleReference (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D41575 Files: cf

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. In https://reviews.llvm.org/D41575#970412, @akyrtzi wrote: > Ah, sorry I mislead you. To test this try using `c-index-test -index-file > /path/to/file`, see other examples in `test/Index`, e.g. > `test/Index/index-file.cpp` Thanks for the command. It is really helpful

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay added a comment. ping Repository: rC Clang https://reviews.llvm.org/D42893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay added a comment. In https://reviews.llvm.org/D42983#1025179, @alexfh wrote: > A late comment here: should this check start a new "portability" module? This > seems to be the main focus of the check rather than making code more readable. SG. Should I rename it? Repository: rCTE Clan

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay created this revision. MaskRay added a reviewer: alexfh. Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clan

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137256. MaskRay added a comment. .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeLists.txt

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay added a comment. In https://reviews.llvm.org/D42983#1028241, @alexfh wrote: > In https://reviews.llvm.org/D42983#1028093, @MaskRay wrote: > > > In https://reviews.llvm.org/D42983#1025179, @alexfh wrote: > > > > > A late comment here: should this check start a new "portability" module? >

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137259. MaskRay added a comment. index.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeList

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137260. MaskRay added a comment. comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeLists.

[PATCH] D44173: [clang-tidy] Add "portability" module and move readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137262. MaskRay added a comment. . Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CMakeLists.txt

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137275. MaskRay added a comment. std::string -> llvm::SmallString Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tid

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141 if (!New.empty()) { std::string Message; // If Suggest is true, give a P0214 alternative, otherwise point it out it ---

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137293. MaskRay marked 2 inline comments as done. MaskRay added a comment. Mention new module `portability` in docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

MaskRay updated this revision to Diff 137406. MaskRay added a comment. ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44173 Files: clang-tidy/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/plugin/ClangTidyPlugin.cpp clang-tidy/portability/CM

[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL326909: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to… (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D51109: [cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..."

MaskRay updated this revision to Diff 168898. MaskRay retitled this revision from "[cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] "" to "[cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..."". MaskRay removed a reviewer: clang. MaskRay removed subscribers: sdar

[PATCH] D51109: [Driver][cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..."

MaskRay updated this revision to Diff 168913. MaskRay retitled this revision from "[cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..."" to "[Driver][cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..."". MaskRay added a comment. Another reference in driver

[PATCH] D51109: [Driver][cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..."

This revision was automatically updated to reflect the committed changes. Closed by commit rL344098: [Driver][cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..." (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://revie

[PATCH] D53060: [clang-move] Remove clang:: qualifier

MaskRay created this revision. MaskRay added a reviewer: hokein. Herald added subscribers: cfe-commits, ioeric. The use sites are enclosed by `namespace clang`, so clang:: is not necessary. Many unqualified names have already been used, e.g. SourceManager SourceLocation LangOptions. This change m

[PATCH] D53060: [clang-move] Remove clang:: qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL344256: [clang-move] Remove clang:: qualifier (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53060 Files: clang-tools-ex

[PATCH] D37726: clang: alias -static-{libstdc++, libgcc} for LLVM variants

MaskRay added a comment. In https://reviews.llvm.org/D37726#1264233, @rsmith wrote: > It would be nice to have a flag here that's agnostic to the value supplied to > `-rtlib` or `-stdlib`. Perhaps `-static-rtlib` (for either libgcc or > compiler-rt) and `-static-stdlib` (for either libc++ or li

[PATCH] D53238: [Driver] Add -static-{rtlib, stdlib} and make -static-{libgcc, libstdc++} their aliases

MaskRay created this revision. MaskRay added reviewers: martell, rsmith. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D53238 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/Darwin.cpp lib/Driver/

[PATCH] D53238: [Driver] Add -static-{rtlib, stdlib} and make -static-{libgcc, libstdc++} their aliases

MaskRay updated this revision to Diff 169538. MaskRay added a comment. Rename local variables Repository: rC Clang https://reviews.llvm.org/D53238 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/Darwin.cpp lib/Driver/ToolChains/Dragon

[PATCH] D53238: [Driver] Add -static-{rtlib, stdlib} and make -static-{libgcc, libstdc++} their aliases

MaskRay added a comment. Greeting from a dev meeting attendee :) Repository: rC Clang https://reviews.llvm.org/D53238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay added a comment. Should `ZNognustack` and `ZExecstack` be unified to a tri-state enum variable? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

MaskRay added a comment. In D54428#1359333 , @tamur wrote: > This patch seems to have broken the compilation. I get the following error on > a linux platform: > [12/14] Linking CXX executable bin/clangd > FAILED: bin/clangd > : && > /usr/local/google

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay added a comment. Friendly ping :) (This is related to FreeBSD, not OpenBSD) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

MaskRay added a comment. > This segment is not supported at all on NetBSD (stack is always > non-executable), and the option is meant to be used to disable emitting it. The string `.note.GNU-stack` takes only a few bytes in `.shstrtab` and a few for an `Elf64_Shdr` instance. Are there any tools

[PATCH] D53922: [clangd] fix non linux build

MaskRay added a comment. I don't even know if this actually does any good. In some libc implementations `pthread_setschedparam` may be a no-op (e.g. in musl) Repository: rL LLVM https://reviews.llvm.org/D53922 ___ cfe-commits mailing list cfe-co

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128 if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bstatic"); + CmdArgs.push_back("-static"); ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); If Fuchsia

[PATCH] D54112: [Driver] Delete redundant -Bdynamic for libc++ on Fuchsia

MaskRay created this revision. MaskRay added reviewers: phosek, EricWF, mcgrathr. Herald added a subscriber: cfe-commits. The surrounding --push-state saves the "-Bdynamic" state across ld.bfd, gold and lld. lld saves the least states, but the intersection of these linkers is --as-needed -Bdynam

[PATCH] D54112: [Driver] Delete redundant -Bdynamic for libc++ on Fuchsia

MaskRay added a comment. I'm unclear if you also want as-needed `-lm` or if you accept static `-lm` Repository: rC Clang https://reviews.llvm.org/D54112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer.

MaskRay added inline comments. Comment at: clangd/index/Index.h:84 inline bool operator==(const SymbolLocation &L, const SymbolLocation &R) { - return std::tie(L.FileURI, L.Start, L.End) == - std::tie(R.FileURI, R.Start, R.End); + return std::make_tuple(llvm::StringRef

[PATCH] D54805: [Driver] Use --push/pop-state with Sanitizer link deps

MaskRay added a comment. In https://reviews.llvm.org/D54805#1305749, @pcc wrote: > Unfortunately it looks like the Android NDK uses some ancient version of gold > that doesn't support `--push-state`, so we probably can't rely on being able > to use it. > > http://lab.llvm.org:8011/builders/sa

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

MaskRay added a comment. https://reviews.llvm.org/rC347417 makes `constexpr string_view service = "HELLO WORD SERVICE"` (P0426) broken with libstdc++ % cat a.cc constexpr bool __constant_string_p(const char *__s) { while (__builtin_constant_p(*__s) && *__s) __s++; return __buil

  1   2   3   4   5   6   7   8   9   10   >