Author: faisalv
Date: Wed Sep 27 18:50:23 2017
New Revision: 314372
URL: http://llvm.org/viewvc/llvm-project?rev=314372&view=rev
Log:
[NFC] Modernize MacroArgs using TrailingObjects
Refactor MacroArgs to use TrailingObjects when creating a variably sized object
on the heap to store the unexpande
Author: faisalv
Date: Wed Sep 27 19:00:40 2017
New Revision: 314373
URL: http://llvm.org/viewvc/llvm-project?rev=314373&view=rev
Log:
[NFC] Don't use C++17 standard lib variable template helper traits, instead use
::value.
Modified:
cfe/trunk/lib/Lex/MacroArgs.cpp
Modified: cfe/trunk/lib/Le
ll doesn't work on some compilers, because
> std::is_trivially_copyable isn't available:
> http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/265/steps/build/logs/stdio
>
> On Wed, Sep 27, 2017 at 10:00 PM, Faisal Vali via cfe-commits
> wr
Author: faisalv
Date: Thu Sep 28 19:17:31 2017
New Revision: 314483
URL: http://llvm.org/viewvc/llvm-project?rev=314483&view=rev
Log:
[NFC] Rename variable 'Arguments' to 'Parameters' when lexing the Macro
Definition.
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
Modified: cfe/trunk/lib/Lex/
Author: faisalv
Date: Thu Sep 28 19:43:22 2017
New Revision: 314484
URL: http://llvm.org/viewvc/llvm-project?rev=314484&view=rev
Log:
[NFC] Replace 'arguments' with 'parameters' in comments relating to lexing a
macro definition.
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
Modified: cfe/tru
Author: faisalv
Date: Sat Sep 30 06:58:38 2017
New Revision: 314593
URL: http://llvm.org/viewvc/llvm-project?rev=314593&view=rev
Log:
[NFC] Remove superfluous parameter
- MacroArgs already knows the maximum number of arguments that can be supplied
to the macro. No need to pass MacroInfo (infor
Author: faisalv
Date: Sat Sep 30 07:36:00 2017
New Revision: 314595
URL: http://llvm.org/viewvc/llvm-project?rev=314595&view=rev
Log:
[NFC] Sync function call with changes to interface made in r314593.
Modified:
clang-tools-extra/trunk/modularize/PreprocessorTracker.cpp
Modified: clang-tools
Author: faisalv
Date: Sat Sep 30 12:34:27 2017
New Revision: 314600
URL: http://llvm.org/viewvc/llvm-project?rev=314600&view=rev
Log:
[NFC] Add assertion that we assume a valid macro argument index.
Modified:
cfe/trunk/lib/Lex/MacroArgs.cpp
Modified: cfe/trunk/lib/Lex/MacroArgs.cpp
URL:
htt
Author: faisalv
Date: Mon Oct 2 17:52:14 2017
New Revision: 314747
URL: http://llvm.org/viewvc/llvm-project?rev=314747&view=rev
Log:
[NFC] Refactor PasteTokens so that it can be passed the Token Stream and Index
to start concatenating at.
In passing:
- change the name of the function to pa
Author: faisalv
Date: Mon Oct 2 18:20:40 2017
New Revision: 314748
URL: http://llvm.org/viewvc/llvm-project?rev=314748&view=rev
Log:
Remove an assertion I added from the refactoring of pasteTokens
(https://reviews.llvm.org/rL314747).
- it made the bots v angry!
I'm not exactly sure why the as
Author: faisalv
Date: Mon Oct 2 18:33:36 2017
New Revision: 314753
URL: http://llvm.org/viewvc/llvm-project?rev=314753&view=rev
Log:
Add parens around the boolean condition of one of the added asserts in r314747
...
... in the hopes of teaching the bots the gift of silence ;)
For quick refere
Author: faisalv
Date: Sat Oct 14 18:26:26 2017
New Revision: 315840
URL: http://llvm.org/viewvc/llvm-project?rev=315840&view=rev
Log:
[c++2a] Implement P0306 __VA_OPT__ (Comma omission and comma deletion)
This patch implements an extension to the preprocessor:
__VA_OPT__(contents) --> which expa
Author: faisalv
Date: Sat Oct 14 19:13:17 2017
New Revision: 315842
URL: http://llvm.org/viewvc/llvm-project?rev=315842&view=rev
Log:
[c++2a] Fix failing regression test related to not adding the extension warning
to a diagnostic group (in r315840)
In passing also complete a comment that I left
Author: faisalv
Date: Sun Oct 22 07:45:08 2017
New Revision: 316292
URL: http://llvm.org/viewvc/llvm-project?rev=316292&view=rev
Log:
[C++17] Fix PR34970 - tweak overload resolution for class template
deduction-guides in line with WG21's p0620r0.
In order to identify the copy deduction candidate
Author: faisalv
Date: Sun Oct 22 15:29:52 2017
New Revision: 316304
URL: http://llvm.org/viewvc/llvm-project?rev=316304&view=rev
Log:
[c++2a] Update cxx_status w __VA_OPT__ marked as completed in SVN.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http:
Author: faisalv
Date: Thu Dec 21 19:50:55 2017
New Revision: 321339
URL: http://llvm.org/viewvc/llvm-project?rev=321339&view=rev
Log:
Diagnose the various invalid decl-specifiers on nontype template parameters.
The standard correctly forbids various decl-specifiers that dont make sense on
non-ty
Author: faisalv
Date: Sat Dec 23 10:56:34 2017
New Revision: 321409
URL: http://llvm.org/viewvc/llvm-project?rev=321409&view=rev
Log:
[NFC] Update the template-parameter parsers and analyzers to return NamedDecl
(vs Decl)
This patch addresses a FIXME and has the template-parameter processing
fu
Author: faisalv
Date: Sat Dec 23 11:27:07 2017
New Revision: 321410
URL: http://llvm.org/viewvc/llvm-project?rev=321410&view=rev
Log:
[NFC] Remove a cast rendered unnecessary by r321409
See https://reviews.llvm.org/rC321409 for additional context.
Modified:
cfe/trunk/lib/Parse/ParseTemplate
Author: faisalv
Date: Mon Dec 25 14:23:20 2017
New Revision: 321449
URL: http://llvm.org/viewvc/llvm-project?rev=321449&view=rev
Log:
Add a fixit for attributes incorrectly placed prior to 'struct/class/enum'
keyword.
Suggest moving the following erroneous attrib list (based on location)
[[]] st
Author: faisalv
Date: Thu Dec 28 21:41:00 2017
New Revision: 321546
URL: http://llvm.org/viewvc/llvm-project?rev=321546&view=rev
Log:
[NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum.
Note, we don't do any bitwise manipulations when using them.
Modified:
cfe/trunk/
Author: faisalv
Date: Fri Dec 29 20:15:27 2017
New Revision: 321574
URL: http://llvm.org/viewvc/llvm-project?rev=321574&view=rev
Log:
[NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum
UnqualifiedIdKind.
Modified:
cfe/trunk/include/clang/Sema/DeclSpec.h
cfe/trunk/lib/Parse/
Author: faisalv
Date: Sat Dec 30 16:06:40 2017
New Revision: 321590
URL: http://llvm.org/viewvc/llvm-project?rev=321590&view=rev
Log:
[NFC] Modernize enum DeclSpecContext into a scoped enum.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/ParseDecl.cpp
cfe/trunk/l
Author: faisalv
Date: Sun Dec 31 18:19:52 2017
New Revision: 321614
URL: http://llvm.org/viewvc/llvm-project?rev=321614&view=rev
Log:
[NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType
into scoped enums.
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/tr
Author: faisalv
Date: Sun Dec 31 18:35:43 2017
New Revision: 321615
URL: http://llvm.org/viewvc/llvm-project?rev=321615&view=rev
Log:
Add scope specifiers to updated scoped-enums (that I somehow missed in r321614)
Modified:
cfe/trunk/lib/AST/TypeLoc.cpp
cfe/trunk/lib/Serialization/ASTWrit
Author: faisalv
Date: Sun Dec 31 18:49:17 2017
New Revision: 321616
URL: http://llvm.org/viewvc/llvm-project?rev=321616&view=rev
Log:
Revert r321614 and r321615
- the enum changes to TypeSpecifierType are breaking some tests - and will
require a more careful integration.
Sorry about rushing th
Author: faisalv
Date: Mon Jan 1 07:42:13 2018
New Revision: 321622
URL: http://llvm.org/viewvc/llvm-project?rev=321622&view=rev
Log:
[NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType
into scoped enums with underlying types.
- Since these enums are used as bit-fiel
Author: faisalv
Date: Mon Jan 1 08:36:47 2018
New Revision: 321625
URL: http://llvm.org/viewvc/llvm-project?rev=321625&view=rev
Log:
Use 'unsigned int' instead of enum bit-fields to silence some warnings from
r321622
- bots were complaining that the bit-field width was less than the width of
Author: faisalv
Date: Mon Jan 1 10:23:28 2018
New Revision: 321628
URL: http://llvm.org/viewvc/llvm-project?rev=321628&view=rev
Log:
Again reverting an attempt to convert the DeclSpec enums into scoped enums.
- reverts r321622, r321625, and r321626.
- the use of bit-fields is still resulting
Author: faisalv
Date: Fri Aug 25 11:24:20 2017
New Revision: 311788
URL: http://llvm.org/viewvc/llvm-project?rev=311788&view=rev
Log:
[NFC] Remove a cstyle cast and replace some uses of Decl with NamedDecl during
the processing of TemplateParameterLists.
Modified:
cfe/trunk/include/clang/Par
Author: faisalv
Date: Sat Aug 26 19:21:21 2017
New Revision: 311839
URL: http://llvm.org/viewvc/llvm-project?rev=311839&view=rev
Log:
Pass the correct object argument when a member call to an 'unrelated' class is
made.
Prior to this patch, clang would do the wrong thing here (see inline comments
Author: faisalv
Date: Sun Aug 27 09:49:47 2017
New Revision: 311851
URL: http://llvm.org/viewvc/llvm-project?rev=311851&view=rev
Log:
Don't see through 'using member-declarations' when determining the relation of
any potential implicit object expression to the parent class of the member
function
Author: faisalv
Date: Sun Aug 27 12:00:08 2017
New Revision: 311855
URL: http://llvm.org/viewvc/llvm-project?rev=311855&view=rev
Log:
revert changes from r311851.
The right answers here (and how clang needs to be tweaked) require further
analysis (ongoing cwg thread).
sorry.
Modified:
cfe/
Author: faisalv
Date: Mon Aug 28 20:04:13 2017
New Revision: 311975
URL: http://llvm.org/viewvc/llvm-project?rev=311975&view=rev
Log:
revert r311839 (ongoing cwg discussion)
apologies.
Modified:
cfe/trunk/lib/Sema/SemaExprMember.cpp
cfe/trunk/test/SemaCXX/member-expr.cpp
Modified: cfe/t
Author: faisalv
Date: Sun Sep 17 08:37:51 2017
New Revision: 313487
URL: http://llvm.org/viewvc/llvm-project?rev=313487&view=rev
Log:
Fix the second half of PR34266: Don't implicitly capture '*this' if the
members are found in a class unrelated to the enclosing class.
https://bugs.llvm.org/show
thanks!
Faisal Vali
On Mon, Sep 18, 2017 at 4:10 AM, NAKAMURA Takumi wrote:
> Seems fixed! Thanks!
>
> On Mon, Sep 18, 2017 at 5:27 PM Vitaly Buka via cfe-commits
> wrote:
>>
>> Author: vitalybuka
>> Date: Mon Sep 18 01:26:01 2017
>> New Revision: 313521
>>
>> URL: http://llvm.org/viewvc/llvm-
Author: faisalv
Date: Tue Apr 24 19:42:26 2018
New Revision: 330794
URL: http://llvm.org/viewvc/llvm-project?rev=330794&view=rev
Log:
[c++2a] [concepts] Add rudimentary parsing support for template concept
declarations
This patch is a tweak of changyu's patch: https://reviews.llvm.org/D40381. I
Author: faisalv
Date: Tue Apr 24 20:28:23 2018
New Revision: 330796
URL: http://llvm.org/viewvc/llvm-project?rev=330796&view=rev
Log:
Fix rC330794 - a parameter that should have been dependent was inadvertently
not -
and compiled in MSVC - but not so for the other bots.
The fix was to make it d
Author: faisalv
Date: Tue Apr 24 20:54:20 2018
New Revision: 330798
URL: http://llvm.org/viewvc/llvm-project?rev=330798&view=rev
Log:
[NFC] Make dependent parameter non-deducible, so that we are forced to use the
default template parameter.
This might provide users with more graceful diagnostics
That should work - although i wonder if we still need makeArrayRef
once we explicitly declare an array - either way thank you for fixing
it Bjorn!!
Faisal Vali
On Wed, Apr 25, 2018 at 4:16 AM, Björn Pettersson A
wrote:
> Hello Faisal.
>
> Lots of buildbots have failed after your commit "[c++2a]
On Wed, Apr 25, 2018 at 3:37 PM, Richard Smith wrote:
> On 24 April 2018 at 19:42, Faisal Vali via cfe-commits
> wrote:
>>
>> Author: faisalv
>> Date: Tue Apr 24 19:42:26 2018
>> New Revision: 330794
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=33
Author: faisalv
Date: Wed Apr 25 17:42:40 2018
New Revision: 330888
URL: http://llvm.org/viewvc/llvm-project?rev=330888&view=rev
Log:
Revert rC330794 and some dependent tiny bug fixes
See Richard's humbling feedback here:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180423/226482.h
Author: faisalv
Date: Wed Apr 25 18:05:05 2018
New Revision: 330889
URL: http://llvm.org/viewvc/llvm-project?rev=330889&view=rev
Log:
Fix a merge conflict that was inadvertently introduced in r330888
- during the reversion of r330794
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Modified: c
Author: faisal vali
Date: 2020-05-16T15:08:30-05:00
New Revision: 0ee46e857d81ea815e5b11d266c0c118a2c2e714
URL:
https://github.com/llvm/llvm-project/commit/0ee46e857d81ea815e5b11d266c0c118a2c2e714
DIFF:
https://github.com/llvm/llvm-project/commit/0ee46e857d81ea815e5b11d266c0c118a2c2e714.diff
L
Author: faisal vali
Date: 2020-05-16T15:12:04-05:00
New Revision: accd9af838b071ff6e8ba4ff3c99a2542cd0ce25
URL:
https://github.com/llvm/llvm-project/commit/accd9af838b071ff6e8ba4ff3c99a2542cd0ce25
DIFF:
https://github.com/llvm/llvm-project/commit/accd9af838b071ff6e8ba4ff3c99a2542cd0ce25.diff
L
Author: faisalv
Date: Fri Aug 18 20:43:07 2017
New Revision: 311224
URL: http://llvm.org/viewvc/llvm-project?rev=311224&view=rev
Log:
[c++2a] Implement P0409R2 - Allow lambda capture [=,this] (by hamzasood)
This patch, by hamzasood, implements P0409R2, and allows [=, this] pre-C++2a as
an extens
Author: Faisal Vali
Date: 2020-11-10T23:40:12-06:00
New Revision: e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9
URL:
https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9
DIFF:
https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9.diff
L
yay!
Thanks Thorsten - if no one else does it - i'll try and commit this for you
later today :)
Faisal Vali
On Sat, Nov 14, 2020 at 11:08 AM Thorsten via Phabricator <
revi...@reviews.llvm.org> wrote:
> tschuett added a comment.
>
> I started with specifiers.h here: https://reviews.llvm.org/D
Author: Faisal Vali
Date: 2020-11-21T09:49:52-06:00
New Revision: 9930d4dff31a130890f21a64f43d530a83ae3d0a
URL:
https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a
DIFF:
https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a.diff
L
I'll try and look into it this weekend and have some sort of updated news
for you by monday?
Faisal Vali
On Thu, Jan 12, 2023 at 10:40 PM Shafik Yaghmour via Phabricator <
revi...@reviews.llvm.org> wrote:
> shafik added a comment.
>
> Is this PR still workable or does it need a major rework and
Author: faisal vali
Date: 2023-09-16T13:29:59-05:00
New Revision: 5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea
URL:
https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea
DIFF:
https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea.diff
L
Author: faisalv
Date: Sat Nov 11 10:02:29 2017
New Revision: 317984
URL: http://llvm.org/viewvc/llvm-project?rev=317984&view=rev
Log:
Adjust r316292 - remove the anonymous union for sharing a bitfield in
FunctionDecl.
The anonymous union did NOT save us storage, but instead behaved as if we adde
Author: faisalv
Date: Sun Jan 8 12:56:11 2017
New Revision: 291397
URL: http://llvm.org/viewvc/llvm-project?rev=291397&view=rev
Log:
[cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the
expression-evaluator to evaluate the static-invoker.
This patch has been sitting in rev
Author: faisalv
Date: Sun Jan 8 21:02:53 2017
New Revision: 291416
URL: http://llvm.org/viewvc/llvm-project?rev=291416&view=rev
Log:
[cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda
expressions.
Add a visitor for lambda expressions to RecordExprEvaluator in ExprCon
On Mon, Jan 9, 2017 at 12:13 AM, Richard Smith wrote:
> On 8 January 2017 at 19:02, Faisal Vali via cfe-commits
> wrote:
>>
>> Author: faisalv
>> Date: Sun Jan 8 21:02:53 2017
>> New Revision: 291416
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=2
Author: faisalv
Date: Mon Jan 9 05:47:51 2017
New Revision: 291439
URL: http://llvm.org/viewvc/llvm-project?rev=291439&view=rev
Log:
[cxx1z-constexpr-lambda] [NFC] Add a FIXME to reinstate certain restrictions on
constexpr lambdas from appearing within function-signatures (CWG1607)
For further
Author: faisalv
Date: Mon Jan 9 19:29:41 2017
New Revision: 291525
URL: http://llvm.org/viewvc/llvm-project?rev=291525&view=rev
Log:
[NFC] Rename RAII ExpressionEvaluationContext variable from Unevaluated to
ConstantEvaluated when parsing a constant expression.
This renaming makes it consistent
faisalv removed rL LLVM as the repository for this revision.
faisalv updated this revision to Diff 68091.
faisalv added a comment.
Updated the patch per Richard's direction (which helped clarify my thinking
about this): Check only the current call frame - if the VarDecl is contained
within the c
faisalv marked an inline comment as done.
faisalv added a comment.
https://reviews.llvm.org/D23493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv closed this revision.
faisalv added a comment.
Closed by http://llvm.org/viewvc/llvm-project?view=revision&revision=278771
https://reviews.llvm.org/D23485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
faisalv updated this revision to Diff 68644.
faisalv marked 4 inline comments as done.
faisalv added a comment.
Address Richard's comments.
https://reviews.llvm.org/D23493
Files:
lib/AST/ExprConstant.cpp
lib/Sema/SemaTemplateInstantiateDecl.cpp
test/SemaCXX/constant-expression-cxx11.cpp
faisalv added a comment.
Address Richard's comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:190
@@ -189,3 +189,3 @@
if (A->getCond()->isValueDependent() && !Cond->isValueDependent() &&
- !Expr::isPotentialConstantExprUnevaluated(Cond, cast(Tmpl),
+ !Ex
Author: faisalv
Date: Sat Apr 1 16:30:49 2017
New Revision: 299316
URL: http://llvm.org/viewvc/llvm-project?rev=299316&view=rev
Log:
[NFC, Scoped Enum] Convert Sema::ExpressionEvaluationContext into a scoped Enum
- also replace direct equality checks against the ConstantEvaluated enumerator
wi
Author: faisalv
Date: Sat Jul 15 17:23:04 2017
New Revision: 308118
URL: http://llvm.org/viewvc/llvm-project?rev=308118&view=rev
Log:
[c++2a] Add option -std=c++2a to enable support for potential/transitional
C++2a features
- as usual C++2a implies all the C++'s that came before it.
Thank you A
Author: faisalv
Date: Sun Jul 16 18:27:53 2017
New Revision: 308157
URL: http://llvm.org/viewvc/llvm-project?rev=308157&view=rev
Log:
[NFC] Refactor the Preprocessor function that handles Macro definitions and
rename Arguments to Parameters in Macro Definitions.
- Extracted the reading of the
Author: faisalv
Date: Sun Jul 16 19:03:21 2017
New Revision: 308158
URL: http://llvm.org/viewvc/llvm-project?rev=308158&view=rev
Log:
Revert changes from my previous refactoring - will need to fix dependencies in
clang's extra tooling (such as clang-tidy etc.).
Sorry about that.
Modified:
c
Author: faisalv
Date: Mon Jul 17 10:18:43 2017
New Revision: 308190
URL: http://llvm.org/viewvc/llvm-project?rev=308190&view=rev
Log:
[NFC] Refactor the Preprocessor function that handles Macro definitions and
rename Arguments to Parameters in Macro Definitions.
- Extracted the reading of the
Author: faisalv
Date: Mon Jul 17 10:20:57 2017
New Revision: 308191
URL: http://llvm.org/viewvc/llvm-project?rev=308191&view=rev
Log:
[NFC] Update function call names as changed in MacroInfo that should refer to
Parameters (as opposed to Arguments).
This syncs them up with clang commit r308190
Author: faisalv
Date: Wed Jul 19 18:10:56 2017
New Revision: 308574
URL: http://llvm.org/viewvc/llvm-project?rev=308574&view=rev
Log:
[NFC] Update local variable names to upper-case as per LLVM Coding Standards.
Modified:
cfe/trunk/lib/Lex/TokenLexer.cpp
Modified: cfe/trunk/lib/Lex/TokenLexe
Author: faisalv
Date: Sat Jul 22 05:04:37 2017
New Revision: 308823
URL: http://llvm.org/viewvc/llvm-project?rev=308823&view=rev
Log:
[NFC, documentation] Prefer the term expansion instead of macro instantiation
... in the few remaining places where this was not corrected.
Modified:
cf
Author: faisalv
Date: Mon Jul 24 20:15:36 2017
New Revision: 308948
URL: http://llvm.org/viewvc/llvm-project?rev=308948&view=rev
Log:
[NFC] Use RAII to un-poison and then re-poison __VA_ARGS__
- This will also be used for the forthcoming __VA_OPT__ feature approved for
C++2a.
- recommended by
Author: faisalv
Date: Wed Feb 15 22:12:21 2017
New Revision: 295279
URL: http://llvm.org/viewvc/llvm-project?rev=295279&view=rev
Log:
[cxx1z-constexpr-lambda] Implement captures - thus completing implementation of
constexpr lambdas.
Enable evaluation of captures within constexpr lambdas by using
Of course Richard - I'll be happy to bump that value for C++1z
hopefully later today.
Thanks!
Faisal Vali
On Wed, Feb 15, 2017 at 10:30 PM, Richard Smith wrote:
> On 15 February 2017 at 20:12, Faisal Vali via cfe-commits
> wrote:
>>
>> Author: faisalv
>> Date: We
faisalv updated this revision to Diff 77926.
faisalv marked an inline comment as done.
faisalv added a comment.
Simplify the check for zero captures in a lambda expression (within the assert)
by comparing the begin and end pointers directly (as opposed to using distance)
- thanks to Akira!
htt
Author: faisalv
Date: Fri Apr 28 22:49:17 2017
New Revision: 301735
URL: http://llvm.org/viewvc/llvm-project?rev=301735&view=rev
Log:
Fix PR32831: 'this capture while instantiating generic lambda call operator
specialization
When computing the appropriate cv-qualifiers for the 'this' capture, we
Author: faisalv
Date: Tue May 2 15:56:34 2017
New Revision: 301972
URL: http://llvm.org/viewvc/llvm-project?rev=301972&view=rev
Log:
Fix PR32831 (Try Again): 'this' capture while instantiating generic lambda call
operator specialization
When computing the appropriate cv-qualifiers for the 'this
Author: faisalv
Date: Tue May 2 16:02:46 2017
New Revision: 301973
URL: http://llvm.org/viewvc/llvm-project?rev=301973&view=rev
Log:
[NFC] Add original test that triggered crash post r301735
- this is added just for completeness sake (though the general case should be
represented by the test ad
Author: faisalv
Date: Mon May 8 23:17:15 2017
New Revision: 302507
URL: http://llvm.org/viewvc/llvm-project?rev=302507&view=rev
Log:
Fix PR32638 : Make sure we switch Sema's CurContext to the substituted
FunctionDecl when instantiating the exception specification.
This fixes the bug: https://bu
Author: faisalv
Date: Sun May 14 20:49:19 2017
New Revision: 303026
URL: http://llvm.org/viewvc/llvm-project?rev=303026&view=rev
Log:
Fix PR32933: crash on lambda capture of VLA
https://bugs.llvm.org/show_bug.cgi?id=32933
Turns out clang wasn't really handling vla's (*) in C++11's for-range enti
Author: faisalv
Date: Sun May 14 20:54:02 2017
New Revision: 303027
URL: http://llvm.org/viewvc/llvm-project?rev=303027&view=rev
Log:
[NFC] Remove some comments (IR aid) from a test file erroneous committed in
r303026
Modified:
cfe/trunk/test/CodeGenCXX/vla.cpp
Modified: cfe/trunk/test/Code
Author: faisalv
Date: Sun May 14 21:56:02 2017
New Revision: 303030
URL: http://llvm.org/viewvc/llvm-project?rev=303030&view=rev
Log:
Silence buildbots by tweaking an IR codegen test to be less specific w register
names.
Modified:
cfe/trunk/test/CodeGenCXX/vla.cpp
Modified: cfe/trunk/test/C
Author: faisalv
Date: Sat May 20 14:58:04 2017
New Revision: 303492
URL: http://llvm.org/viewvc/llvm-project?rev=303492&view=rev
Log:
Fix PR25627: constant expressions being odr-used in template arguments.
This patch ensures that clang processes the expression-nodes that are generated
when disam
Author: faisalv
Date: Mon May 22 20:07:12 2017
New Revision: 303594
URL: http://llvm.org/viewvc/llvm-project?rev=303594&view=rev
Log:
[NFC, Refactor] Modernize TemplateIdAnnotation using TrailingObjects
A refactoring of TemplateIdAnnotation that uses TrailingObjects to create a
variably-sized ob
Author: faisalv
Date: Sun Nov 13 00:09:16 2016
New Revision: 286748
URL: http://llvm.org/viewvc/llvm-project?rev=286748&view=rev
Log:
Fix PR28366: Handle variables from enclosing local scopes more gracefully
during constant expression evaluation.
Only look for a variable's value in the constant
faisalv closed this revision.
faisalv added a comment.
Fixed by commit: r286748
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161107/176865.html
Thanks for the review!
https://reviews.llvm.org/D23493
___
cfe-commits mailing list
cfe-comm
faisalv removed rL LLVM as the repository for this revision.
faisalv updated this revision to Diff 77767.
faisalv marked 4 inline comments as done.
faisalv added a comment.
Addressed Aaron's requests regarding improving formatting and assert messages.
Thanks!
https://reviews.llvm.org/D22997
Fi
Author: faisalv
Date: Sun Aug 23 08:14:42 2015
New Revision: 245812
URL: http://llvm.org/viewvc/llvm-project?rev=245812&view=rev
Log:
Add a missing 'classof' to AST Node TypoExpr to identify its 'Kind'.
I'm not sure why TypoExpr had its classof left out - but I expect every AST
node should fulfi
faisalv added inline comments.
Comment at: include/clang/AST/Decl.h:1577
@@ -1576,2 +1576,3 @@
bool IsConstexpr : 1;
+ bool IsConcept : 1;
My inclination would have been to add this bit to FunctionTemplateDecl, instead
of to every FunctionDecl - since not e
faisalv updated this revision to Diff 65026.
faisalv added a comment.
Factor out the diagnostic builder RAII creation (through Sema.Diag) and reduce
repetition.
https://reviews.llvm.org/D22662
Files:
include/clang/AST/DeclCXX.h
lib/Sema/SemaType.cpp
test/SemaCXX/cxx1z-constexpr-lambdas.c
Author: faisalv
Date: Fri Jul 22 23:05:19 2016
New Revision: 276514
URL: http://llvm.org/viewvc/llvm-project?rev=276514&view=rev
Log:
[cxx1z-constexpr-lambda] Make a lambda's closure type eligible as a
literal-type in C++1z
Additionally, for pre-C++1z, instead of forbidding a lambda's closure t
faisalv accepted this revision.
faisalv added a reviewer: faisalv.
faisalv added a comment.
This revision is now accepted and ready to land.
Thanks Richard. Your request to separate out and centralize the diagnostic
portion of the patch certainly seems like a good idea - and I shall do so
separ
faisalv created this revision.
faisalv added a reviewer: rsmith.
faisalv added a subscriber: cfe-commits.
Currently the following code triggers diagnostics that match:
auto L = []{ }; //expected-note{{'' is not literal}}
constexpr int f(decltype(L)) { return 0; } //expected-error{{not a literal
faisalv updated this revision to Diff 65654.
faisalv added a comment.
Refactored the common code from each insertion operator into a single template
function called: addNameDeclOrItsTypeToDiagnostic(...).
https://reviews.llvm.org/D22844
Files:
include/clang/AST/Decl.h
lib/AST/ASTContext.cp
faisalv created this revision.
faisalv added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman,
erik.pilkington.
faisalv added a subscriber: cfe-commits.
faisalv set the repository for this revision to rL LLVM.
faisalv added a project: clang-c.
Add a visitor for lambda expressions to Recor
Author: faisalv
Date: Sat Jul 30 20:19:17 2016
New Revision: 277287
URL: http://llvm.org/viewvc/llvm-project?rev=277287&view=rev
Log:
[NFC] Rearrange an example-file so the c++14 specific example is on top.
This makes it easier to add C++1z examples to the bottom, just before the
#endif.
Modifi
faisalv created this revision.
faisalv added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman,
erik.pilkington.
faisalv added a subscriber: cfe-commits.
faisalv set the repository for this revision to rL LLVM.
faisalv added a project: clang-c.
This patch enables the following code:
au
On Thu, Aug 11, 2016 at 1:07 PM, Richard Smith wrote:
> Yes, this should be merged. It's not quite right, but it's certainly better
> than what we had before.
I would agree that the comment is broken - but, unless i'm missing
something subtle, the subsequent logic and call to
adjustCVQualifiersF
faisalv created this revision.
faisalv added reviewers: hans, rsmith.
faisalv added a subscriber: cfe-commits.
Per Richard's request here:
https://llvm.org/bugs/show_bug.cgi?id=28366#c10
This patch essentially reverses all the changes from the following commit:
https://reviews.llvm.org/rL264513
faisalv added a comment.
Everything compiles - and all tests in clang/test pass.
https://reviews.llvm.org/D23485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv created this revision.
faisalv added reviewers: rsmith, hans.
faisalv added a subscriber: cfe-commits.
faisalv set the repository for this revision to rL LLVM.
Fix the following Bug:
https://llvm.org/bugs/show_bug.cgi?id=28366
This patch teaches the constant expression evaluator to search
Author: faisalv
Date: Sun Feb 21 20:24:29 2016
New Revision: 261506
URL: http://llvm.org/viewvc/llvm-project?rev=261506&view=rev
Log:
Fix PR24473 : Teach clang to remember to substitute into member variable
templates referred to within dependent qualified ids.
In passing also fix a semi-related
1 - 100 of 174 matches
Mail list logo
