https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/72068
Fixes #71852
From 54743ceec9845cdc450d5c163a293e73884a8df9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 12 Nov 2023 16:07:13 -0500
Subject: [PATCH] [clang-tidy] Improve
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/72068
From 649c7b8b936d848100b58e733dd358fa1d5914fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 12 Nov 2023 16:07:13 -0500
Subject: [PATCH] [clang-tidy] Improved readability-
felix642 wrote:
Hi @firewave, I think you are referencing a different issue. If I test #71852
with PR #72050 I do not get the expected behavior.
https://github.com/llvm/llvm-project/pull/72068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/72068
From 649c7b8b936d848100b58e733dd358fa1d5914fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 12 Nov 2023 16:07:13 -0500
Subject: [PATCH 1/2] [clang-tidy] Improved readabil
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/72068
From 649c7b8b936d848100b58e733dd358fa1d5914fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 12 Nov 2023 16:07:13 -0500
Subject: [PATCH 1/2] [clang-tidy] Improved readabil
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/72068
From 649c7b8b936d848100b58e733dd358fa1d5914fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 12 Nov 2023 16:07:13 -0500
Subject: [PATCH 1/3] [clang-tidy] Improved readabil
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/72068
From 65eaa9e01bcd32dccf1e0c9bd3f2bdd3e53ccb2a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 12 Nov 2023 16:07:13 -0500
Subject: [PATCH 1/3] [clang-tidy] Improved readabil
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 01/11] =?UTF-8?q?[clang-tidy]=C2=A0
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 01/12] =?UTF-8?q?[clang-tidy]=C2=A0
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/73069
This checks find usages of the inline keywork where it is already implicitly
defined by the compiler and suggests it's removal.
Fixes #72397
From 894c3c837725c75f8ad19a185139d07b10fb2e0a Mon Sep 17 00:00:00 20
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/73069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH] =?UTF-8?q?[clang-tidy]=C2=A0Added=
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 1/2] =?UTF-8?q?[clang-tidy]=C2=A0Ad
@@ -0,0 +1,113 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
clang-tidy===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 01/13] =?UTF-8?q?[clang-tidy]=C2=A0
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 1/3] =?UTF-8?q?[clang-tidy]=C2=A0Ad
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 1/4] =?UTF-8?q?[clang-tidy]=C2=A0Ad
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 1/5] =?UTF-8?q?[clang-tidy]=C2=A0Ad
@@ -0,0 +1,99 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
+// clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
@@ -0,0 +1,25 @@
+.. title:: clang-tidy - readability-redundant-inline-specifier
+
+readability-redundant-inline-specifier
+==
+
+Checks for instances of the ``inline`` keyword in code where it is redundant
felix642 wrote:
I ap
@@ -0,0 +1,109 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
clang-tidy===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,109 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
clang-tidy===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 1/6] =?UTF-8?q?[clang-tidy]=C2=A0Ad
@@ -0,0 +1,109 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
clang-tidy===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,109 @@
+//===--- RedundantInlineSpecifierCheck.cpp -
clang-tidy===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 1/7] =?UTF-8?q?[clang-tidy]=C2=A0Ad
@@ -0,0 +1,25 @@
+.. title:: clang-tidy - readability-redundant-inline-specifier
+
+readability-redundant-inline-specifier
+==
+
+Checks for instances of the ``inline`` keyword in code where it is redundant
felix642 wrote:
Righ
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 1/8] =?UTF-8?q?[clang-tidy]=C2=A0Ad
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 1/9] =?UTF-8?q?[clang-tidy]=C2=A0Ad
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/73069
From 89281ccb5354e3d6349d10e6f9446194d2d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 16 Nov 2023 22:03:15 -0500
Subject: [PATCH 01/10] =?UTF-8?q?[clang-tidy]=C2=A0
@@ -0,0 +1,110 @@
+// RUN: %check_clang_tidy %s readability-redundant-inline-specifier %t
+
+template inline T f()
+// CHECK-MESSAGES: :[[@LINE-1]]:23: warning: function 'f' has inline specifier
but is implicitly inlined [readability-redundant-inline-specifier]
+// CHECK-FIXES:
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/76315
The check currently emits warnings for the following code:
`uint64_t fn() { return 1024 * 1024; }`
But the code generated after applying the notes will look like this:
`uint64_t fn() { return static_cast
felix642 wrote:
A patch that proposed a similar fix was previously submitted for this issue but
never landed : https://reviews.llvm.org/D141058
https://github.com/llvm/llvm-project/pull/76315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/76350
Rewriter would not properly fix files if they were symlinked and using --fix
with clang-tidy would overwrite the symlink with the corrections rather than
the file.
With these changes the Rewriter now properly
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/76350
From 0a5ae9bfff7597794889c93e4da5789714be3a4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 24 Dec 2023 21:01:32 -0500
Subject: [PATCH] [clang][tidy] Fixed clang-tidy rew
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/76350
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/85591
Specifying checks using the literal style (|) in the clang-tidy config file is
currently supported but was not implemented for the --verify-config options.
This means that clang-tidy would work properly but, us
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From e67122cb2c17395e863725cc25d99afe6c7bb48c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH] [clang-tidy] Improved modernize-us
felix642 wrote:
@PiotrZSL I've squashed my changed. When you'll have time, I think we can merge
this PR.
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/85591
From f015496c511b4c2898b9f4d65ebfe39a34c5119c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 17 Mar 2024 20:50:17 -0400
Subject: [PATCH 1/3] [clang-tidy] Improved --verify
felix642 wrote:
Thank you for the review @SimplyDanny, as per your suggestion, I've rewrote
part of my fix to unify the parsing logic rather than updating the duplicated
code. The method now uses the GlobList which already handles correctly the
regexes generation from the list of checks.
http
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From 72f2b398d6f41372dc84579a83d273398884c869 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH] [clang-tidy] Improved modernize-us
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/85591
From f015496c511b4c2898b9f4d65ebfe39a34c5119c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 17 Mar 2024 20:50:17 -0400
Subject: [PATCH 1/4] [clang-tidy] Improved --verify
@@ -454,52 +454,31 @@ static constexpr StringLiteral VerifyConfigWarningEnd = "
[-verify-config]\n";
static bool verifyChecks(const StringSet<> &AllChecks, StringRef CheckGlob,
StringRef Source) {
- llvm::StringRef Cur, Rest;
+ GlobList Globs(CheckG
@@ -454,52 +454,31 @@ static constexpr StringLiteral VerifyConfigWarningEnd = "
[-verify-config]\n";
static bool verifyChecks(const StringSet<> &AllChecks, StringRef CheckGlob,
StringRef Source) {
- llvm::StringRef Cur, Rest;
+ GlobList Globs(CheckG
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/85591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/85591
From f015496c511b4c2898b9f4d65ebfe39a34c5119c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 17 Mar 2024 20:50:17 -0400
Subject: [PATCH 1/5] [clang-tidy] Improved --verify
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/81423
Updated the check to ignore point static data members with in class initializer
since removing the inline specifier would generate a compilation error
Fixes #80684
From 45c89e269bd37e298dd12035dc78c986fa47e8
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/81423
From 0fa56a4176205337270d15049dc34a8508488905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 8 Feb 2024 17:07:38 -0500
Subject: [PATCH] =?UTF-8?q?[clang-tidy]=C2=A0Removed
@@ -88,12 +91,14 @@ void
RedundantInlineSpecifierCheck::registerMatchers(MatchFinder *Finder) {
this);
if (getLangOpts().CPlusPlus17) {
-Finder->addMatcher(
-varDecl(isInlineSpecified(),
-anyOf(isInternalLinkage(StrictMode),
-
@@ -47,6 +47,9 @@ AST_POLYMORPHIC_MATCHER_P(isInternalLinkage,
return VD->isInAnonymousNamespace();
llvm_unreachable("Not a valid polymorphic type");
}
+
+AST_MATCHER(clang::VarDecl, hasInitialization) { return Node.hasInit(); }
felix642 wrote:
Simply di
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/81423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/81423
From 0fa56a4176205337270d15049dc34a8508488905 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Thu, 8 Feb 2024 17:07:38 -0500
Subject: [PATCH 1/2] =?UTF-8?q?[clang-tidy]=C2=A0Rem
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/3] [clang-tidy] Improved moderniz
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/4] [clang-tidy] Improved moderniz
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From f1d957413bcc81e9ced06ad40570859769f4c1c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/5] [clang-tidy] Improved moderniz
https://github.com/felix642 ready_for_review
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
Thank you for the quick review @PiotrZSL. I've implemented the proposed changes
and rebased on top of main. We can wait a few days to see if someone else has
some comments to add and then we should be ready to merge
https://github.com/llvm/llvm-project/pull/82947
_
https://github.com/felix642 converted_to_draft
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From f1d957413bcc81e9ced06ad40570859769f4c1c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/6] [clang-tidy] Improved moderniz
https://github.com/felix642 ready_for_review
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/82947
The check needs a parent decl to match but if the typedef is in a function, the
parent is a declStmt which is not a decl by itself. Improved the matcher to
match on either a decl or a declstmt and extract the d
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH] [clang-tidy] Improved modernize-us
https://github.com/felix642 created
https://github.com/llvm/llvm-project/pull/82952
The parameter `CheckedReturnTypes` now supports regexes
Fixes #63107
From 86bc8a57fd56a6b2593af8bcf85d50bbc0ce984e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82947
From d1cbed0e2e83bd3544067fd25d7e811f1ab3f095 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 20:20:59 -0500
Subject: [PATCH 1/2] [clang-tidy] Improved moderniz
https://github.com/felix642 converted_to_draft
https://github.com/llvm/llvm-project/pull/82947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82952
From 86bc8a57fd56a6b2593af8bcf85d50bbc0ce984e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 22:05:08 -0500
Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82952
From 5e30d84368a05bab31a26c413fdc8092449f4111 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 22:05:08 -0500
Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82952
From 00885ea60007a1da88f9d476e14252f950f358a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 22:05:08 -0500
Subject: [PATCH] [clang-tidy] bugprone-unused-retur
felix642 wrote:
> Rebase, and could be merged.
Done, thank you for the quick review.
https://github.com/llvm/llvm-project/pull/82952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
Nevermind I broke the documentation.. Hold on
https://github.com/llvm/llvm-project/pull/82952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/82952
From 00885ea60007a1da88f9d476e14252f950f358a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 25 Feb 2024 22:05:08 -0500
Subject: [PATCH 1/2] [clang-tidy] bugprone-unused-r
https://github.com/felix642 approved this pull request.
LGTM,
There is still some work to do to support more cases like ternary operators and
if/else statements, but I think we have a decent foundation to work on and we
can add these cases later in other PRs.
https://github.com/llvm/llvm-proj
felix642 wrote:
@11happy I was testing with `d5b8dc25598` but this seems to be working
properly now. I would assume that this has been fixed in your latest commits
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commi
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 requested changes to this pull request.
Looks good! I was able run your code on llvm's project and I'm happy with the
changes that I see. There is maybe one more use case that we should check
before I am ready to approve (Except what Piotr has already highlighted)
@@ -0,0 +1,137 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 deleted
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 requested changes to this pull request.
Added a few more comments regarding some nits but we're almost there
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
@@ -0,0 +1,195 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,195 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,195 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,238 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/felix642 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,238 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,189 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,189 @@
+//===--- UseStdMinMaxCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,27 @@
+// RUN: %check_clang_tidy %s readability-ConditionalToStdMinMax %t
+
+void foo() {
+ int value1,value2;
+
+ // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use std::max instead of <
[readability-ConditionalToStdMinMax]
+ if (value1 < value2)
+value1 = value2;
@@ -18,7 +18,7 @@ char *t0(char *base, int a, int b) {
// CHECK-NOTES-CXX: static_cast( )
// CHECK-NOTES-ALL: :[[@LINE-5]]:17: note: perform multiplication in a wider
type
// CHECK-NOTES-C:(ptrdiff_t)
- // CHECK-NOTES-CXX:
felix642 wrote:
@PiotrZSL thank you for the review.
I would greatly appreciate if you could merge this PR for me since I do not
have the rights to do it.
https://github.com/llvm/llvm-project/pull/76315
___
cfe-commits mailing list
cfe-commits@lists.l
felix642 wrote:
ping @EugeneZelenko
https://github.com/llvm/llvm-project/pull/73069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 approved this pull request.
https://github.com/llvm/llvm-project/pull/74891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
felix642 wrote:
LGTM !
You'll need to update your branch with master but the PR looks good.
The only thing that seems odd is the changes that you've made to the method
`areParensNeededForOverloadedOperator` where the Operators `OO_New`,
`OO_Delete`, `OO_Array_New` and `OO_ArrayDelete` now nee
https://github.com/felix642 approved this pull request.
https://github.com/llvm/llvm-project/pull/74891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 requested changes to this pull request.
Overall looks good, but left a few comments regarding some nits that I think
should be addressed before landing this PR.
https://github.com/llvm/llvm-project/pull/77816
___
cfe-commit
1 - 100 of 159 matches
Mail list logo
