Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, probinson.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This fix should solve problem with parallel configure build introduced in
D12700 as suggested by
Author: eugenezelenko
Date: Wed Nov 25 13:16:34 2015
New Revision: 254081
URL: http://llvm.org/viewvc/llvm-project?rev=254081&view=rev
Log:
Fix problem with Clang-tidy parallel configure build.
Differential revision: http://reviews.llvm.org/D14964
Modified:
clang-tools-extra/trunk/clang-tidy
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I fixed Clang-tidy modernize-loop-convert. Autos are used for pointer variables
assigned via c
Eugene.Zelenko removed rL LLVM as the repository for this revision.
Eugene.Zelenko updated this revision to Diff 42087.
Eugene.Zelenko added a comment.
I fixed two loops and don't use auto instead of bool.
Auto is also used for results of new.
http://reviews.llvm.org/D15251
Files:
lib/Serial
Eugene.Zelenko added inline comments.
Comment at: lib/Serialization/ASTReader.cpp:5074
@@ -5087,3 +5073,3 @@
bool operator()(ModuleFile &M) {
- HeaderFileInfoLookupTable *Table
+ auto *Table
= static_cast(M.HeaderFileInfoTable);
I don't thi
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I fixed Clang-tidy modernize-loop-convert and modernize-use-auto. Autos are
also used for poin
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I fixed Clang-tidy modernize-loop-convert and modernize-use-auto. Autos are
also used for poin
Author: eugenezelenko
Date: Tue Dec 8 12:00:11 2015
New Revision: 255033
URL: http://llvm.org/viewvc/llvm-project?rev=255033&view=rev
Log:
Use range loops and autos in lib/Serialization/ASTWriter.cpp.
Differential revision: http://reviews.llvm.org/D15311
Modified:
cfe/trunk/lib/Serializatio
Eugene.Zelenko removed rL LLVM as the repository for this revision.
Eugene.Zelenko updated this revision to Diff 42192.
Eugene.Zelenko added a comment.
Replaced const auto with auto as suggested by Aaron.
http://reviews.llvm.org/D15313
Files:
utils/TableGen/ClangAttrEmitter.cpp
Index: utils/
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I fixed Clang-tidy modernize-use-auto warnings. Autos are also used for pointer
variables assi
Author: eugenezelenko
Date: Tue Dec 8 12:49:01 2015
New Revision: 255042
URL: http://llvm.org/viewvc/llvm-project?rev=255042&view=rev
Log:
Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp and generated
code.
Differential revision: http://reviews.llvm.org/D15313
Modified:
cf
Eugene.Zelenko added inline comments.
Comment at: lib/AST/ASTContext.cpp:429
@@ -432,2 +428,3 @@
+ auto *CFC = new (*this) comments::FullComment(FC->getBlocks(), ThisDeclInfo);
return CFC;
}
jroelofs wrote:
> return new ...
Will fix in commit.
Repository:
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
This check partially implements PR19419. Could it be extended to variables?
http://reviews.llvm.org/D15332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Autos are also used for pointer variables assigned via casts or memory
allocation. Patch inclu
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Autos are also used for pointer variables assigned via casts or memory
allocation. Patch inclu
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15332#306831, @danielmarjamaki wrote:
> In http://reviews.llvm.org/D15332#306097, @Eugene.Zelenko wrote:
>
> > This check partially implements PR19419. Could it be extended to variables?
>
>
> Yes, I don't see any technical reasons why t
Eugene.Zelenko added inline comments.
Comment at: lib/AST/ASTImporter.cpp:5855
@@ -5888,3 +5854,3 @@
}
- else if (ObjCProtocolDecl *PD = dyn_cast(D)) {
+ else if (auto *PD = dyn_cast(D)) {
if (!PD->getDefinition())
aaron.ballman wrote:
> Can you fix the
Eugene.Zelenko added inline comments.
Comment at: lib/AST/Expr.cpp:1956
@@ -1967,1 +1955,3 @@
+for (const auto &I : InitExprs) {
+ if (Stmt *S = I) {
Beg = S->getLocStart();
aaron.ballman wrote:
> Is this line still required? I thought InitExprs
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Should be moved to Clang-tidy, since clang-modernize is deprecated.
http://reviews.llvm.org/D15444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D15444#308573, @adek05 wrote:
> I don't see any tests for AddOverride in tests/clang-tidy yet. Is clang-tidy
> linking everything that clang-modernizer has? If so, I can create another
> patch which just moves these tests over.
Clanag
501 - 520 of 520 matches
Mail list logo