Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. Which links should I use, since it should point to release specific location, but 3.9 is not branched yet? Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko updated this revision to Diff 52163. Eugene.Zelenko added a comment. Addressed Alex and Richard comments except links. Also fixed spotted issues in checks documentation. Looks like better documentation proofreading during code review is needed. Repository: rL LLVM http://revi

Re: [PATCH] D18649: [clang-tidy] cppcoreguidelines-interfaces-global-init

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention new check in docs/ReleaseNotes.rst. http://reviews.llvm.org/D18649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko updated this revision to Diff 52253. Eugene.Zelenko added a comment. Updated per Etienne comments. Links are still need to be added, but I'm not clear about address. Repository: rL LLVM http://reviews.llvm.org/D18582 Files: docs/ReleaseNotes.rst docs/clang-tidy/checks/mis

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko updated this revision to Diff 52303. Eugene.Zelenko added a comment. Added links. Fix typo spotted by Alexander. Repository: rL LLVM http://reviews.llvm.org/D18582 Files: docs/ReleaseNotes.rst docs/clang-tidy/checks/misc-dangling-handle.rst docs/clang-tidy/checks/perform

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. I align them as in 3.8 changes, to first `. If you think that alignment should be other way, I'll change it. Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko updated this revision to Diff 52306. Eugene.Zelenko added a comment. Updated to trunk. Changed per Alexander comments. Repository: rL LLVM http://reviews.llvm.org/D18582 Files: docs/ReleaseNotes.rst docs/clang-tidy/checks/misc-dangling-handle.rst docs/clang-tidy/checks/p

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. I fixed indentation. Should I commit changes? Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please use single ` around check name and also add link. See http://reviews.llvm.org/D18582 as example. http://reviews.llvm.org/D18509 ___ cfe-commits mailing list c

[clang-tools-extra] r265072 - Update release notes with list of checks added since 3.8.

Author: eugenezelenko Date: Thu Mar 31 18:09:42 2016 New Revision: 265072 URL: http://llvm.org/viewvc/llvm-project?rev=265072&view=rev Log: Update release notes with list of checks added since 3.8. Fix some checks documentation style. Differential revision: http://reviews.llvm.org/D18582 Modifi

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Implicit conversions to bool should be handled by readability-implicit-bool-cast. http://reviews.llvm.org/D18703 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/misc-suspicious-string-compare.rst:12 @@ +11,3 @@ +Example: + if (strcmp(...)) // Implicitly compare to zero + if (!strcmp(...)) // Won't warn I don't know documentation markup w

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D18703#389706, @etienneb wrote: > As pointed by Eugene, > > The following code seems to produce multiple errors. > > int foo() { > if (strcmp(A, "a") == true) > return 0; > return 1; > } > > > Results: > > /home/etienn

[PATCH] D18717: [Clang-tidy] Improve checks documentation consistency

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman, LegalizeAdulthood. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I tried to make using of `` and ` more consistent. Two Google checks chang

Re: [PATCH] D18717: [Clang-tidy] Improve checks documentation consistency

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D18717#390151, @alexfh wrote: > Also, could you, please, next time generate diffs with full context as > documented in > http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > (or use arcanist, which does thi

[clang-tools-extra] r265205 - [Clang-tidy] Improve checks documentation consistency.

Author: eugenezelenko Date: Fri Apr 1 20:07:18 2016 New Revision: 265205 URL: http://llvm.org/viewvc/llvm-project?rev=265205&view=rev Log: [Clang-tidy] Improve checks documentation consistency. Differential revision: http://reviews.llvm.org/D18717 Modified: clang-tools-extra/trunk/docs/clan

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

Eugene.Zelenko added a comment. Please also mention check in docs/ReleaseNotes.rst. Comment at: docs/clang-tidy/checks/readability-non-const-parameter.rst:15 @@ +14,3 @@ + + // warning here; the declaration "const char *p" would make the function + // interface safer. ---

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

Eugene.Zelenko added a comment. I think will be good idea to convert !strcmp(...) to strcmp(...) == 0. http://reviews.llvm.org/D18703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18745: [clang-tidy] Adds misc-use-bool-literals check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Isn't readability-implicit-bool-cast¶ should catch such issues? If not, I think will be good idea to improve that check instead of introducing new one. http://reviews.llvm.org/D18745 __

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst. http://reviews.llvm.org/D18783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:161 @@ -156,1 +160,3 @@ + truncation or invalid character escaping. + Fixed bugs: I think will be good idea to sort check alphabetically. At least I did so :-) http://reviews.llvm.org/D187

[PATCH] D18797: [Clang-tidy] Mention readability-static-definition-in-anonymous-namespace in release notes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D18797 Files: docs/ReleaseNotes.rst Index: docs/R

Re: [PATCH] D18424: [Clang] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

Eugene.Zelenko added inline comments. Comment at: include/clang-c/Index.h:19 @@ -18,1 +18,3 @@ +#ifdef __cplusplus +#include aaron.ballman wrote: > Is this produced by the deprecated headers check? If not, what value does > ctime add over time.h? Yes, since fi

[PATCH] D18810: [Clang-tidy] Fix readability-static-definition-in-anonymous-namespace warnings; other minor fixes.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Some Include What You Use suggestions were used too. I checked this patch on my own build on

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D18745#391210, @Prazek wrote: > In http://reviews.llvm.org/D18745#390739, @Eugene.Zelenko wrote: > > > Isn't readability-implicit-bool-cast¶ should catch such issues? If not, I > > think will be good idea to improve that check instead of

[clang-tools-extra] r265698 - Mention readability-static-definition-in-anonymous-namespace in release notes.

Author: eugenezelenko Date: Thu Apr 7 12:28:35 2016 New Revision: 265698 URL: http://llvm.org/viewvc/llvm-project?rev=265698&view=rev Log: Mention readability-static-definition-in-anonymous-namespace in release notes. Consistency in using ` and ``. Differential revision: http://reviews.llvm.org

[clang-tools-extra] r265813 - [Release Notes] Sort checks alphabetically.

Author: eugenezelenko Date: Fri Apr 8 12:21:27 2016 New Revision: 265813 URL: http://llvm.org/viewvc/llvm-project?rev=265813&view=rev Log: [Release Notes] Sort checks alphabetically. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). http://reviews.llvm.org/D18914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/readability-redundant-inline.rst:6 @@ +5,3 @@ + +This check flags redundant 'inline' specifiers. +It flags 'inline' on member functions defined inside a class definition like Please use `` fo

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D18961: Add a readability-deleted-default clang-tidy check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). http://reviews.llvm.org/D18961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D19014: [clang-tidy] Add new checker for suspicious sizeof expressions

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/ReleaseNotes.rst:100 @@ -99,1 +99,3 @@ +- New `misc-sizeof-expression + `_ check Please put this check after misc-mi

Re: [PATCH] D19118: [clang-tidy] Add checker for operations between integrals and pointers

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/clang-tidy/checks/misc-pointer-and-integral-operation.rst:9 @@ +8,3 @@ +object is compare to an object with integral type. + + Looks like excessive line. Comment at: docs/clang-t

[clang-tools-extra] r266455 - [Release Notes] mention Clang-tidy misc-multiple-statement-macro check.

Author: eugenezelenko Date: Fri Apr 15 12:32:19 2016 New Revision: 266455 URL: http://llvm.org/viewvc/llvm-project?rev=266455&view=rev Log: [Release Notes] mention Clang-tidy misc-multiple-statement-macro check. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-ex

[libcxxabi] r266635 - [CMake] Fix misleading error message in CMakeLists.txt.

Author: eugenezelenko Date: Mon Apr 18 12:40:18 2016 New Revision: 266635 URL: http://llvm.org/viewvc/llvm-project?rev=266635&view=rev Log: [CMake] Fix misleading error message in CMakeLists.txt. Differential revision: http://reviews.llvm.org/D17117 Modified: libcxxabi/trunk/CMakeLists.txt

[clang-tools-extra] r266770 - [Release Notes] Mention Clang-tidy misc-unused-using-decls check.

Author: eugenezelenko Date: Tue Apr 19 12:31:58 2016 New Revision: 266770 URL: http://llvm.org/viewvc/llvm-project?rev=266770&view=rev Log: [Release Notes] Mention Clang-tidy misc-unused-using-decls check. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/tr

[clang-tools-extra] r266795 - [Clang-tidy] Fix extra semicolon warning in cppcoreguidelines/ProTypeMemberInitCheck.cpp.

Author: eugenezelenko Date: Tue Apr 19 13:49:21 2016 New Revision: 266795 URL: http://llvm.org/viewvc/llvm-project?rev=266795&view=rev Log: [Clang-tidy] Fix extra semicolon warning in cppcoreguidelines/ProTypeMemberInitCheck.cpp. Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguideline

[clang-tools-extra] r267026 - [Release Notes] Mention Clang-tidy misc-string-constructor and misc-suspicious-string-compare checks.

Author: eugenezelenko Date: Thu Apr 21 13:13:09 2016 New Revision: 267026 URL: http://llvm.org/viewvc/llvm-project?rev=267026&view=rev Log: [Release Notes] Mention Clang-tidy misc-string-constructor and misc-suspicious-string-compare checks. Fix excessive line in misc-string-constructor document

[clang-tools-extra] r267228 - [Clang-tidy] Fix Clang warning in misc/StringConstructorCheck.h.

Author: eugenezelenko Date: Fri Apr 22 16:33:33 2016 New Revision: 267228 URL: http://llvm.org/viewvc/llvm-project?rev=267228&view=rev Log: [Clang-tidy] Fix Clang warning in misc/StringConstructorCheck.h. Using LLVM_ENABLE_WARNINGS=ON is good idea. Modified: clang-tools-extra/trunk/clang-tid

Re: [PATCH] D19451: [clang-tidy] New checker for redundant expressions.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Will check catch more complicated cases, like if ((Point1.x < Point2.x) && (Point1.x < Point2.x)) ? Will be good idea to add such case

[PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein, etienneb. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLV

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 58803. Eugene.Zelenko added a comment. More diff content. Repository: rL LLVM http://reviews.llvm.org/D20714 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticCo

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. Point of Include What You Use suggestions to rely on explicit dependencies, not implicit ones. Comment at: clang-tidy/utils/OptionsUtils.cpp:1 @@ -1,2 +1,2 @@ //===--- DanglingHandleCheck.cpp - clang-tidy--===// //

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. There is a way to tell IWYU about compound headers with pragmas . I also suggested to make this possible via file with compound headers list. But person who knows LLVM/C

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. See https://github.com/include-what-you-use/include-what-you-use/issues/292 and https://github.com/include-what-you-use/include-what-you-use/issues/301. Repository: rL LLVM http://reviews.llvm.org/D20714 ___ cfe-c

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

Eugene.Zelenko added a comment. I think single check will be better from user's point of view. Comment at: docs/clang-tidy/checks/modernize-explicit-operator-bool.rst:12 @@ +11,3 @@ +have no ``operator ==`` overloads, an implicit ``operator bool`` would allow +``a == b`` to comp

Re: [PATCH] D20917: [clang-tidy] Add RemoveStars option to the modernize-use-auto check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/clang-tidy/checks/modernize-use-auto.rst:155 @@ +154,3 @@ +-- +If the option is set to non-zero (default is ``0``), the check will remove stars +from the non-typedef pointer types when replacing t

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to try this check with LLVM STL too. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:47 @@ +46,3 @@ + +In this case the calls of push_back won't be replaced.

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D20964#448525, @Prazek wrote: > In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > > > I think will be good idea to try this check with LLVM STL too. > > > You mean llvm::SmallVector stuff? No, I meant to build example w

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. It'll be good idea to mention improvement in docs/ReleaseNotes.rst. Please close PR23198 after commit. http://reviews.llvm.org/D21020 ___ cfe-commits mailing list c

Re: [PATCH] D21050: [clang-tidy] correct clang-tidy-diff.py help message

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-tidy/tool/clang-tidy-diff.py:42 @@ -41,3 +41,3 @@ help='path to clang-tidy binary') parser.add_argument('-p', metavar='NUM', default=0, help='strip the smallest pr

[clang-tools-extra] r272038 - [Clang-tidy] Documentation style consistency.

Author: eugenezelenko Date: Tue Jun 7 13:29:15 2016 New Revision: 272038 URL: http://llvm.org/viewvc/llvm-project?rev=272038&view=rev Log: [Clang-tidy] Documentation style consistency. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/clang-tidy/checks/

[clang-tools-extra] r272042 - [Clang-tidy] Alphabetical checks order in release notes.

Author: eugenezelenko Date: Tue Jun 7 13:38:42 2016 New Revision: 272042 URL: http://llvm.org/viewvc/llvm-project?rev=272042&view=rev Log: [Clang-tidy] Alphabetical checks order in release notes. Highlight return statement in misc-unconventional-assign-operator documentation. Modified: clan

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:262 @@ -261,1 +261,3 @@ +- Updated `readability-identifier-naming-check + `_ Please put this not in alphab

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Repository: rL LLVM http://reviews.llvm.org/D21134 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. See also http://reviews.llvm.org/D20964. I think modernize is better place for such check. http://reviews.llvm.org/D21185 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a comment. There are alternative implementation in http://reviews.llvm.org/D21185. Will be good idea to how one which take the best from both :-) http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D21298: [Clang-tidy] delete null check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). I think misc-delete-null-pointer will be better name. Repository: rL LLVM http://reviews.llvm.org/D21298 _

Re: [PATCH] D21298: [Clang-tidy] delete null check

Eugene.Zelenko added a comment. Will be good idea to change some if statements in regression test to (p != nullptr) (for C++11) and (p != NULL) (pre-C+11). See http://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-cast.html. Repository: rL LLVM http://reviews.llvm.org/D212

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/ReleaseNotes.rst:238 @@ +237,3 @@ + + This check finds places where we are returning object of a different type than + the function return type. In such places, we should use std::move, otherwise --

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Eugene.Zelenko added a comment. Since http://reviews.llvm.org/D20964 was committed, I think we should close this. http://reviews.llvm.org/D21185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a comment. Please see PR28334. I'm not sure if Krystyna has Bugzilla account, so I report problem here. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D21992: [clang-tidy] new cppcoreguidelines-slicing

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). http://reviews.llvm.org/D21992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D22046: [clang-tidy] Add dependency on clang-headers

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r274751. http://reviews.llvm.org/D22046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). http://reviews.llvm.org/D0 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D22263: [clang-tidy] Fix syntax error in modernize-use-emplace.rst

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. List of Clang-tidy checks was not updated for long time (I still don't see modernize-use-emplace). May be documentation contains other mistakes? http://reviews.llvm.org/D22263 _

Re: [PATCH] D17586: Add a new check, readability-redundant-string-init, that checks unnecessary string initializations.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Sorry for arriving late to party :-) Thank you for great check! I found a quite lot of such problems in my code base, but I'd like to make suggestion for further improvements: PR26756. Repository: rL LLVM htt

Re: [PATCH] D17811: [clang-tidy] Add check to detect dangling references in value handlers.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Does it make http://reviews.llvm.org/D17772 obsolete? http://reviews.llvm.org/D17811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[clang-tools-extra] r263726 - Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes.

Author: eugenezelenko Date: Thu Mar 17 12:02:25 2016 New Revision: 263726 URL: http://llvm.org/viewvc/llvm-project?rev=263726&view=rev Log: Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D18231 Modified: clang-tools-ext

Re: [PATCH] D18274: [clang-tidy] Add boost module

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think you also need to add new module to clang-tidy/plugin/CMakeLists.txt. http://reviews.llvm.org/D18274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D18231: [Clang-tools-extra] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be reasonable to merge misc-assign-operator-return and misc-assign-operator-signature into one check. http://reviews.llvm.org/D18265 ___ cfe-commits mai

Re: [PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

Eugene.Zelenko added a comment. As user I could tell that it's much easier to have one check which will check all nuances of particular language construction then multiple checks. http://reviews.llvm.org/D18265 ___ cfe-commits mailing list cfe-comm

[PATCH] D18424: [Clang] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. Some Include What You Use suggestions were used too. I chec

Re: [PATCH] D18475: [clang-tidy] Add more detection rules for redundant c_str calls.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Thank you for enhancement! I think will be good idea to extend check for any function call that receives .c_str(), since it mat be in other classes could have methods which receives both C++ or C strings. See als

Re: [PATCH] D15814: Implicit conversion from float->bool

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This seems to me as specific case of Clang-tidy readability-implicit-bool-cast. May be this check should be entirely moved to Clang? http://reviews.llvm.org/D15814 _

[clang-tools-extra] r256780 - Fix typo.

Author: eugenezelenko Date: Mon Jan 4 15:25:10 2016 New Revision: 256780 URL: http://llvm.org/viewvc/llvm-project?rev=256780&view=rev Log: Fix typo. Modified: clang-tools-extra/trunk/docs/index.rst Modified: clang-tools-extra/trunk/docs/index.rst URL: http://llvm.org/viewvc/llvm-project/cl

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. It'll be great to finalize fix before 3.8 branching (planned at January 13). http://reviews.llvm.org/D15506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. This check is duplicate of clang-analyzer-alpha.cplusplus.VirtualCall. From my point of view, Clang-tidy is better place, since such calls doesn't depend of run-time paths. I think will be good idea to try to est

Re: [PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

Eugene.Zelenko added a comment. See http://reviews.llvm.org/D14779 for discussion about Clang-tidy vs Static Analyzer. Repository: rL LLVM http://reviews.llvm.org/D16008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r257562 - Install scan-build and scan-view only if Static Analyzer was enabled.

Author: eugenezelenko Date: Tue Jan 12 20:03:50 2016 New Revision: 257562 URL: http://llvm.org/viewvc/llvm-project?rev=257562&view=rev Log: Install scan-build and scan-view only if Static Analyzer was enabled. Modified: cfe/trunk/tools/CMakeLists.txt Modified: cfe/trunk/tools/CMakeLists.txt

[PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Just to reduce number of uncategorized checks, since Clang-tidy has dedicated cat

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:1 @@ -1,2 +1,2 @@ -.. title:: clang-tidy - misc-inefficient-algorithm +.. title:: clang-tidy - performance-inefficient-algorithm alexfh wrote: > I'd le

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Thank you for this check! https://llvm.org/bugs/show_bug.cgi?id=21984 waited to be implemented for so looong time :-) By the word, other return related readability check idea: https://llvm.org/bugs/show_bug.cgi?i

Re: [PATCH] D16259: Add clang-tidy readability-redundant-return check

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16259#328834, @LegalizeAdulthood wrote: > I didn't know about the bug reports. I created this check because I have > encountered such redundant control flow in real code bases. Bug report was reflection on my code base, but I also sp

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko updated the summary for this revision. Eugene.Zelenko removed rL LLVM as the repository for this revision. Eugene.Zelenko updated this revision to Diff 45209. Eugene.Zelenko added a comment. Add redirect documentation for old check name. http://reviews.llvm.org/D16248 Files: cl

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/clang-tidy/checks/misc-long-cast.rst:6 @@ +5,3 @@ + +This checker will warn when there is a explicit redundant cast of a calculation +result to a bigger type. If the intention of the cast is to avoid loss of -

Re: [PATCH] D16248: [Clang-tidy] rename misc-inefficient-algorithm to performance-inefficient-algorithm

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:3 @@ -2,3 +2,3 @@ -misc-inefficient-algorithm +performance-inefficient-algorithm == alexfh wrote: > After reading this check n

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

Eugene.Zelenko added a comment. Clang-tidy has 6 cast related checks. May be this is good time to introduce dedicated category for them? Repository: rL LLVM http://reviews.llvm.org/D16310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: [PATCH] D16259: Add clang-tidy readability-redundant-control-flow check

Eugene.Zelenko added a comment. Just encountered next situation in my work code base: void Function() { ... if (Condition) { } else return; } http://reviews.llvm.org/D16259 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

[PATCH] D16567: [Clang] Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. I checked this patch on my own build on RHEL 6. Regressions

r258836 - Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

Author: eugenezelenko Date: Tue Jan 26 13:01:06 2016 New Revision: 258836 URL: http://llvm.org/viewvc/llvm-project?rev=258836&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D16567 Modified: cfe/trunk/include/clan

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

Eugene.Zelenko added inline comments. Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101 @@ -100,3 +100,3 @@ : IncludeInserterCheckBase(CheckName, Context) {} - virtual ~CXXSystemIncludeInserterCheck() {} + ~CXXSystemIncludeInserterCheck() override = default;

[clang-tools-extra] r258870 - Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes.

Author: eugenezelenko Date: Tue Jan 26 16:32:24 2016 New Revision: 258870 URL: http://llvm.org/viewvc/llvm-project?rev=258870&view=rev Log: Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes. Differential revision: http://reviews.llvm

[libcxx] r259091 - Remove autoconf support.

Author: eugenezelenko Date: Thu Jan 28 15:00:21 2016 New Revision: 259091 URL: http://llvm.org/viewvc/llvm-project?rev=259091&view=rev Log: Remove autoconf support. Differential revision: http://reviews.llvm.org/D16651 Removed: libcxx/trunk/Makefile Removed: libcxx/trunk/Makefile URL: http

[PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, piotrdz, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This is fix for PR26295. I added configuration option to readab

Re: [PATCH] D14592: Qt (version 4 or 5) signal/method checker

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. There are dedicated project to Qt checks: https://github.com/KDE/clazy. http://reviews.llvm.org/D14592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D14779: Adding checker to detect excess padding in records

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I may be mistaken, but this check looks more appropriate for Clang-tidy. http://reviews.llvm.org/D14779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D12700: [clang-tidy] install helper scripts in CMake build

Eugene.Zelenko added a comment. I think will be good idea to ask specialist in configure build to look on make file. I used other Clang or LLVM make file as example. Frankly, I don't see anything bad with it. However this fix was backported to 3.7.x and configure build is still supported there

<    1   2   3   4   5   6   >