[clang-tools-extra] r276371 - Restructure release notes.

Author: eugenezelenko Date: Thu Jul 21 19:34:42 2016 New Revision: 276371 URL: http://llvm.org/viewvc/llvm-project?rev=276371&view=rev Log: Restructure release notes. Differential revision: https://reviews.llvm.org/D22605 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: cla

Re: [PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

Eugene.Zelenko updated this revision to Diff 65004. Eugene.Zelenko added a comment. Full context diff. Repository: rL LLVM https://reviews.llvm.org/D22656 Files: clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp Index: clang-apply-replacements/tool/ClangApplyReplacementsMain.cp

Re: [PATCH] D22654: [Clang-rename] Remove custom version, fix extra space in error message

Eugene.Zelenko added a comment. It's used for DiagnosticIDs.. However, in https://reviews.llvm.org/D22656 Alexander told that DiagnosticIDs.h should be treated as part of Diagnostic.h. Repository: rL LLVM https://reviews.llvm.org/D22654 ___ cfe-

Re: [PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

Eugene.Zelenko updated this revision to Diff 65099. Eugene.Zelenko added a comment. Don't include DiagnosticIDs.h. Repository: rL LLVM https://reviews.llvm.org/D22656 Files: clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp Index: clang-apply-replacements/tool/ClangApplyReplace

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

Eugene.Zelenko added a comment. Since rule name is different in C++98/03 and C++11 or newer it will make sense to create two checks which will work only for their respective versions (of course, implementation should be shared). Or create alias name. Check is still not mentioned in docs/Releas

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). May be modernize will be better place then misc? https://reviews.llvm.org/D22725 ___ cfe-

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:70 @@ +69,3 @@ + + Replaces calls to memcpy with std::copy. + Please highlight memcpy and std::copy with `` as it done in documentation. Repository: rL LLVM https://reviews.llvm.org/D227

Re: [PATCH] D22654: [Clang-rename] Remove custom version, fix extra space in error message

Eugene.Zelenko updated this revision to Diff 65379. Eugene.Zelenko added a comment. Don't include DiagnosticIDs.h Repository: rL LLVM https://reviews.llvm.org/D22654 Files: clang-rename/tool/ClangRename.cpp test/clang-rename/InvalidNewName.cpp Index: test/clang-rename/InvalidNewName.cpp

[clang-tools-extra] r276684 - [Clang-rename] Remove custom version, fix extra space in error message.

Author: eugenezelenko Date: Mon Jul 25 15:30:13 2016 New Revision: 276684 URL: http://llvm.org/viewvc/llvm-project?rev=276684&view=rev Log: [Clang-rename] Remove custom version, fix extra space in error message. Also fixed some Include What You Use Warnings. Differential revision: https://review

Re: [PATCH] D22513: [clang-tidy] add check cppcoreguidelines-rule-of-five-and-zero

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst:4 @@ +3,3 @@ +cppcoreguidelines-special-member-functions +=== + Size should be same as size of name above.

Re: [PATCH] D23006: [clang-rename] add basic Emacs integration

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please add install rule for clang-rename.el. See clang-rename CMakeLists.txt as example. https://reviews.llvm.org/D23006 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D23045: [Include-fixer] Install executables and support scripts

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: ioeric, bkramer, hokein. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I tested this changes on my RHEL 6 build. Repository: rL LLVM https://reviews.llvm.org/

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

Eugene.Zelenko added inline comments. Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22 @@ +21,2 @@ + DESTINATION share/clang + COMPONENT find-all-symbols) hokein wrote: > I think we can put it in `clang-include-fixer` as find-all-symbols is a >

Re: [PATCH] D23130: Add a check for definitions in the global namespace.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). https://reviews.llvm.org/D23130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

Eugene.Zelenko added a comment. Please see PR28836. In some cases check should recommend to use insert(). Repository: rL LLVM https://reviews.llvm.org/D20196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[libunwind] r278029 - CMakeLists.txt cleanups: synchronize version and CMake minimum required version with rest of LLVM, consistent spacing.

Author: eugenezelenko Date: Mon Aug 8 12:56:28 2016 New Revision: 278029 URL: http://llvm.org/viewvc/llvm-project?rev=278029&view=rev Log: CMakeLists.txt cleanups: synchronize version and CMake minimum required version with rest of LLVM, consistent spacing. Differential revision: https://review

[libcxxabi] r278030 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

Author: eugenezelenko Date: Mon Aug 8 12:59:02 2016 New Revision: 278030 URL: http://llvm.org/viewvc/llvm-project?rev=278030&view=rev Log: CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing. Differential revision: https://reviews.llvm.org/D23092 Modified: li

[libcxx] r278032 - CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing.

Author: eugenezelenko Date: Mon Aug 8 13:01:50 2016 New Revision: 278032 URL: http://llvm.org/viewvc/llvm-project?rev=278032&view=rev Log: CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent spacing. Differential revision: https://reviews.llvm.org/D23091 Modified: li

Re: [PATCH] D23279: clang-reorder-fields

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Do we really need standalone tool for this purpose? If I'm not mistaken, Static Analyzer already has clang-analyzer-optin.performance.Padding check, which is also available through Clang-tidy. https://reviews.ll

Re: [PATCH] D23279: clang-reorder-fields

Eugene.Zelenko added a comment. May be this could be Clang-rename mode? My concern is that every added tool is ~ 15-20 MB on Linux and there are no CMake options to link part of them dynamically. Repository: rL LLVM https://reviews.llvm.org/D23279

Re: [PATCH] D23279: clang-reorder-fields

Eugene.Zelenko added a comment. I would prefer CMake option to link rarely used tools (list should be adjustable) with libclang, which contain a lot of LLVM/Clang code already. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits

[clang-tools-extra] r278198 - [Documentation] Fix spelling mistakes in docs/clang-tidy/index.rst.

Author: eugenezelenko Date: Tue Aug 9 20:55:51 2016 New Revision: 278198 URL: http://llvm.org/viewvc/llvm-project?rev=278198&view=rev Log: [Documentation] Fix spelling mistakes in docs/clang-tidy/index.rst. Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified: clang-tools-ex

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/ReleaseNotes.rst:75 @@ +74,3 @@ + + This check warns if an object is used after it has been moved, without an + intervening reinitialization. Please remove //This check// and capitalize //warns/

[clang-tools-extra] r278255 - [Documentation] Fix grammar mistakes in docs/clang-tidy/index.rst spotted by Alexander Kornienko.

Author: eugenezelenko Date: Wed Aug 10 13:02:15 2016 New Revision: 278255 URL: http://llvm.org/viewvc/llvm-project?rev=278255&view=rev Log: [Documentation] Fix grammar mistakes in docs/clang-tidy/index.rst spotted by Alexander Kornienko. Modified: clang-tools-extra/trunk/docs/clang-tidy/inde

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/ReleaseNotes.rst:78 @@ -77,1 +77,3 @@ +- Bugfix for `modernize-make-unique + `_ I think will be better to have //Fixed

[clang-tools-extra] r278262 - [Release Notes] Consistency in Clang-tidy entries' style.

Author: eugenezelenko Date: Wed Aug 10 13:15:51 2016 New Revision: 278262 URL: http://llvm.org/viewvc/llvm-project?rev=278262&view=rev Log: [Release Notes] Consistency in Clang-tidy entries' style. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs

[clang-tools-extra] r278263 - [Documentation] Highlighting consistency and spelling mistake fix in Clang-tidy readability-else-after-return description.

Author: eugenezelenko Date: Wed Aug 10 13:30:14 2016 New Revision: 278263 URL: http://llvm.org/viewvc/llvm-project?rev=278263&view=rev Log: [Documentation] Highlighting consistency and spelling mistake fix in Clang-tidy readability-else-after-return description. Modified: clang-tools-extra/

[clang-tools-extra] r278279 - [Documentation] Fix style and grammar mistake in Clang-tidy readability-else-after-return description spotted by Alexander Kornienko.

Author: eugenezelenko Date: Wed Aug 10 14:49:38 2016 New Revision: 278279 URL: http://llvm.org/viewvc/llvm-project?rev=278279&view=rev Log: [Documentation] Fix style and grammar mistake in Clang-tidy readability-else-after-return description spotted by Alexander Kornienko. Modified: clang-t

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:512 @@ +511,3 @@ +} +void UseAfterMoveFinder::getReinits( +const CFGBlock *Block, const ValueDecl *MovedVariable, Please insert empty line before. Repository: rL LLVM

[clang-tools-extra] r278295 - [Documentation] Improve consistency.

Author: eugenezelenko Date: Wed Aug 10 17:00:49 2016 New Revision: 278295 URL: http://llvm.org/viewvc/llvm-project?rev=278295&view=rev Log: [Documentation] Improve consistency. Mention Clang-rename Emacs integration in release notes. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst

Re: [PATCH] D23423: [Clang-tidy] Comparison Function Address

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). If I'm not mistaken, GCC or Clang has warning that result of comparison is always true for such situations. Comment at: clang-tidy/misc/ComparisonFunctionAddressCheck.h:

Re: [PATCH] D23423: [Clang-tidy] Comparison Function Address

Eugene.Zelenko added a comment. Clang-tidy terminology use //checks//, not //checkers//. Repository: rL LLVM https://reviews.llvm.org/D23423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/cert-msc50-cpp.rst:4 @@ +3,3 @@ +cert-msc-50 +=== + Should be same length as section name above. =

Re: [PATCH] D23427: [Clang-tidy] Comparison Misuse

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Please run Clang-format on newly added files. Test case is definitely needs it. Comment at: clang-tidy/misc/ComparisonM

Re: [PATCH] D23427: [Clang-tidy] Comparison Misuse

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/ComparisonMisuseCheck.cpp:21 @@ +20,3 @@ +void ComparisonMisuseCheck::registerMatchers(MatchFinder *Finder) { + + Finder->addMatcher( Please remove this line. Repository: rL LLVM https://revie

Re: [PATCH] D23423: [Clang-tidy] Comparison Function Address

Eugene.Zelenko added a comment. This check looks like specific case of https://reviews.llvm.org/D23427. May be they should be merged? Repository: rL LLVM https://reviews.llvm.org/D23423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

Eugene.Zelenko added a comment. Ping. I could not proceed until my question answered. Repository: rL LLVM https://reviews.llvm.org/D23045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D23471: [Documentation] Improve checks groups descriptions in clang-tidy/index.rst

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Use table to avoid tautology. List all existing checks groups. Use alphabetical order. Rece

r278586 - Fix build broken after llvm/ADT/DenseMap.h replacement of climits with limits.

Author: eugenezelenko Date: Fri Aug 12 20:05:35 2016 New Revision: 278586 URL: http://llvm.org/viewvc/llvm-project?rev=278586&view=rev Log: Fix build broken after llvm/ADT/DenseMap.h replacement of climits with limits. Modified: cfe/trunk/lib/Basic/FileManager.cpp Modified: cfe/trunk/lib/Bas

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. Committed as fix for build failure after llvm/ADT/DenseMap.h in r278583. Repository: rL LLVM https://reviews.llvm.org/D22555 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang-tools-extra] r278686 - [Documentation] Improve checks groups descriptions in clang-tidy/index.rst

Author: eugenezelenko Date: Mon Aug 15 12:44:29 2016 New Revision: 278686 URL: http://llvm.org/viewvc/llvm-project?rev=278686&view=rev Log: [Documentation] Improve checks groups descriptions in clang-tidy/index.rst Use table to avoid tautology. List all existing checks groups. Use alphabetical o

Re: [clang-tools-extra] r278295 - [Documentation] Improve consistency.

Hi, Miklos! Sorry, I was not aware about documentation source. But I think will be good idea to improve punctuation consistency in tool itself. Eugene. On Mon, Aug 15, 2016 at 12:24 PM, Miklos Vajna wrote: > Hi Eugene, > > On Wed, Aug 10, 2016 at 10:00:50PM -0000, Eugene Zelenk

[clang-tools-extra] r259393 - Sort checks alphabetically in ReadabilityTidyModule.cpp.

Author: eugenezelenko Date: Mon Feb 1 13:47:24 2016 New Revision: 259393 URL: http://llvm.org/viewvc/llvm-project?rev=259393&view=rev Log: Sort checks alphabetically in ReadabilityTidyModule.cpp. Modified: clang-tools-extra/trunk/clang-tidy/readability/ReadabilityTidyModule.cpp Modified: c

[PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This fix for PR25894. I checked it on my work code base. Build and regres

[PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. This fix for PR26332. I checked it on my work code base. Build and regres

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. I'll wait for global options implementation. Repository: rL LLVM http://reviews.llvm.org/D16700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. I didn't notice test cases for included files for other checkers. So it's hard to tell for should special test case introduced for this specific problem or not. Repository: rL LLVM http://reviews.llvm.org/D16786

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. I didn't notice test cases for included files for other checkers. So it's hard to tell for should special test case introduced for this specific problem or not. Repository: rL LLVM http://reviews.llvm.org/D16794

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. I think proper solution will be to create tests for included files ot the fly, bu renaming main test to .h and creating dummy source file. But this is task for scripts wizards :-) Repository: rL LLVM http://reviews.llvm.org/D16786 _

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. I think proper solution will be to create tests for included files ot the fly, bu renaming main test to .h and creating dummy source file. But this is task for scripts wizards :-) Repository: rL LLVM http://reviews.llvm.org/D16794 _

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16786#342074, @aaron.ballman wrote: > In http://reviews.llvm.org/D16786#342072, @Eugene.Zelenko wrote: > > > I think proper solution will be to create tests for included files ot the > > fly, bu renaming main test to .h and creating dum

Re: [PATCH] D16700: [Clang-tidy] Make null pointer literals for fixes configurable for two checks

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:32 @@ -30,1 +31,3 @@ +Options.get("NullPointerLiteral", +Context->getLangOpts().CPlusPlus11 ? "nullptr" : "0")) {} void registerMatchers(ast_matchers::MatchF

Re: [PATCH] D16794: [Clang-tidy] Make readability-simplify-boolean-expr working with included files

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D16794#343652, @LegalizeAdulthood wrote: > Again, isn't this already assigned to me in the bug tracker? > > In general, my assumption in bug trackers is that if someone has assigned the > bug to themselves, then they are working on it.

Re: [PATCH] D16786: [Clang-tidy] Make modernize-redundant-void-arg working with included files

Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. Obsoleted by http://reviews.llvm.org/D16953. Repository: rL LLVM http://reviews.llvm.org/D16786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM ht

Re: [PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 47415. Eugene.Zelenko added a comment. More fixes. Repository: rL LLVM http://reviews.llvm.org/D17060 Files: include/clang/Analysis/Analyses/ThreadSafetyUtil.h lib/ARCMigrate/ObjCMT.cpp lib/AST/ASTDiagnostic.cpp lib/AST/CommentLexer.cpp

r260414 - Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Author: eugenezelenko Date: Wed Feb 10 13:11:58 2016 New Revision: 260414 URL: http://llvm.org/viewvc/llvm-project?rev=260414&view=rev Log: Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D17060 Modified: cfe

[PATCH] D17218: [Clang] Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM ht

r260757 - Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Author: eugenezelenko Date: Fri Feb 12 16:53:10 2016 New Revision: 260757 URL: http://llvm.org/viewvc/llvm-project?rev=260757&view=rev Log: Fix remaining Clang-tidy readability-redundant-control-flow warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D17218 Modified:

[PATCH] D17434: [Clang-tidy] Make readability-container-size-empty working with STL string

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, xazax.hun, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. While working with LLDB code I noticed that readability-container-size-empty does

Re: [PATCH] D17434: [Clang-tidy] Make readability-container-size-empty working with STL string

Eugene.Zelenko added a comment. Also I agree that testing is good idea, it doesn't make sense in current incarnation which test only vector and set and only with containers' code snippets instead of real implementations. I wrote about last issue in cfe-dev, but idea was rejected. Other issue i

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

Eugene.Zelenko added a comment. Thank you for implementing this check! However, I think will be good idea to always wrap header name in <> for warning and FixIt. http://reviews.llvm.org/D17484 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

Eugene.Zelenko added a comment. Another idea: to replace limits.h with limits and also replace its defines with their C++ counterparts. For example, INT_MIN with numeric_limits::min(). Will be definitely useful for LLDB code modernization. http://reviews.llvm.org/D17484

[clang-tools-extra] r267576 - [Release notes] Mention Clang-tidy misc-fold-init-type check.

Author: eugenezelenko Date: Tue Apr 26 12:54:00 2016 New Revision: 267576 URL: http://llvm.org/viewvc/llvm-project?rev=267576&view=rev Log: [Release notes] Mention Clang-tidy misc-fold-init-type check. Highlighting consistency in Clang-tidy misc-fold-init-type check documentation. Modified:

Re: [PATCH] D19586: Misleading Indentation check

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). What about for ans while statements? Comment at: docs/clang-tidy/checks:10 @@ +9,3 @@ + +The way to avoid dangling else

Re: [PATCH] D19577: [clang-tidy] Enhance misc-suspicious-string-compare by matching string.compare

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please add check options descriptions to documentation. http://reviews.llvm.org/D19577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. It'll be good idea to run Include What You Use to make sure that all dependencies are explicit. http://reviews.llvm.org/D19698 __

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

Eugene.Zelenko added a comment. > I was hoping that maybe "Include What You Use" had a fix-it mode. I'll look > into this further tonight. It has fix_includes.py script, but I encountered quite a lot of false positives, so I prefer to fix problems manually. http://reviews.llvm.org/D19698

[clang-tools-extra] r268140 - [Release Notes] Mention Clang-tidy cert-err34-c check.

Author: eugenezelenko Date: Fri Apr 29 19:11:10 2016 New Revision: 268140 URL: http://llvm.org/viewvc/llvm-project?rev=268140&view=rev Log: [Release Notes] Mention Clang-tidy cert-err34-c check. Fix order and style of Boost related notes. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.r

[PATCH] D19755: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: bkramer, hokein, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository:

[clang-tools-extra] r268262 - [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings.

Author: eugenezelenko Date: Mon May 2 12:49:00 2016 New Revision: 268262 URL: http://llvm.org/viewvc/llvm-project?rev=268262&view=rev Log: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings. Differential revision: http://reviews.llvm.org/D19755 Modifie

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a comment. Check is still not mentioned in docs/ReleaseNotes.rst. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] r268349 - [Clang-tidy] Fix Clang-tidy modernize-use-override and some Include What You Use warnings in modernize/MakeSmartPtrCheck.h.

Author: eugenezelenko Date: Mon May 2 20:13:27 2016 New Revision: 268349 URL: http://llvm.org/viewvc/llvm-project?rev=268349&view=rev Log: [Clang-tidy] Fix Clang-tidy modernize-use-override and some Include What You Use warnings in modernize/MakeSmartPtrCheck.h. Modified: clang-tools-extra/

[PATCH] D19947: [Clang] Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM ht

[clang-tools-extra] r268659 - [Documentation] List Clang-tidy checks alphabetically.

Author: eugenezelenko Date: Thu May 5 13:25:53 2016 New Revision: 268659 URL: http://llvm.org/viewvc/llvm-project?rev=268659&view=rev Log: [Documentation] List Clang-tidy checks alphabetically. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified: clang-tools-extra/tru

r268674 - Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings.

Author: eugenezelenko Date: Thu May 5 15:15:31 2016 New Revision: 268674 URL: http://llvm.org/viewvc/llvm-project?rev=268674&view=rev Log: Fix some Clang-tidy readability-simplify-boolean-expr and Include What You Use warnings. Differential revision: http://reviews.llvm.org/D19947 Modified:

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). http://reviews.llvm.org/D20053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang-tools-extra] r269229 - [Clang-tidy] modernize-use-bool-literals: documentation style.

Author: eugenezelenko Date: Wed May 11 15:31:50 2016 New Revision: 269229 URL: http://llvm.org/viewvc/llvm-project?rev=269229&view=rev Log: [Clang-tidy] modernize-use-bool-literals: documentation style. Fix readability-redundant-control-flow warnings in regression test. Modified: clang-tools

Re: [PATCH] D18424: [Clang] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 56959. Eugene.Zelenko added a comment. Herald added subscribers: dschuff, jfb. Updated from trunk. More Include What You Use warnings fixes. Repository: rL LLVM http://reviews.llvm.org/D18424 Files: include/clang-c/Index.h include/clang/Analys

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added inline comments. Comment at: clang-tidy/modernize/UseUsingCheck.cpp:13 @@ +12,3 @@ +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + Prazek wrote: > Is this required? It'll be reasonable to run Include What You Use at least on new fi

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/performance-inefficient-string-addition.rst:8 @@ +7,3 @@ +-- +This ch

[PATCH] D20213: [Clang] Fix Clang-tidy modernize-use-bool-literals in generated code.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Reduce space in empty constructors and between data members and first public section. Fix som

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:197 @@ +196,3 @@ + + Replaces dynamic exception specifications with noexcept. + Please highlight noexcept with ``. Comment at: docs/clang-tidy/checks/modernize-use-noexcept.

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32 @@ +31,3 @@ +``noexcept(false)``. Additinally, users can also use +:option:``ReplacementString`` to specify a macro to use instead of +``noexcept``. This is useful when maintai

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32 @@ +31,3 @@ +``noexcept(false)``. Additinally, users can also use +:option:``ReplacementString`` to specify a macro to use instead of +``noexcept``. This is useful when maintai

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:50 @@ +49,2 @@ + +if the `ReplacementString` option is set to `NOEXCEPT`. Actually :option: still need to prepend `ReplacementString`. http://reviews.llvm.org/D18

Re: [PATCH] D20213: [Clang] Fix Clang-tidy modernize-use-bool-literals in generated code.

Eugene.Zelenko updated this revision to Diff 57106. Eugene.Zelenko added a comment. Implement Hans' suggestion. Repository: rL LLVM http://reviews.llvm.org/D20213 Files: utils/TableGen/ClangAttrEmitter.cpp Index: utils/TableGen/ClangAttrEmitter.cpp

r269371 - Fix Clang-tidy modernize-use-bool-literals in generated code.

Author: eugenezelenko Date: Thu May 12 17:27:08 2016 New Revision: 269371 URL: http://llvm.org/viewvc/llvm-project?rev=269371&view=rev Log: Fix Clang-tidy modernize-use-bool-literals in generated code. Reduce space in empty constructors and between data members and first public section. Fix som

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:191 @@ +190,3 @@ + This check is to warn about the performance overhead arising from concatenating + strings, using the operator+, instead of operator+=. + Please highlight operator+ and

[PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Fix some Include What You Use warnings. I checked this patch on my own build on RHEL 6. Regres

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

Eugene.Zelenko updated this revision to Diff 57250. Eugene.Zelenko added a comment. Include mode context. Repository: rL LLVM http://reviews.llvm.org/D20254 Files: include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/IdentifierTable.h lib/Basic/FileManager.cpp Index: lib/Basic/

[clang-tools-extra] r269517 - [Release notes] Mention Clang-tidy modernize-avoid-bind check.

Author: eugenezelenko Date: Fri May 13 18:35:56 2016 New Revision: 269517 URL: http://llvm.org/viewvc/llvm-project?rev=269517&view=rev Log: [Release notes] Mention Clang-tidy modernize-avoid-bind check. Fix some problems in its documentation. Modified: clang-tools-extra/trunk/docs/ReleaseNot

Re: [PATCH] D15089: Patch to google checks in clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please update you patch to current code. Looks like addresses were fixed in files where they existed, but still need to be added to files without them. Repository: rL LLVM http://reviews.llvm.org/D15089 ___

Re: [PATCH] D7982: Add readability-duplicate-include check to clang-tidy

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Include What You Use detect duplicated include directives. I think will be good idea to use it instead of Clang-tidy for much deeper analysis. http://reviews.llvm.org/D7982

Re: [PATCH] D20467: [include-fixer] Mention more details in the document.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Could you please mention include-fixer in docs/ReleaseNotes.rst? This is definitely major new feature in upcoming release. http://reviews.llvm.org/D20467 ___ cfe-co

[PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman, sbenza, etienne.bergeron. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Descriptions of checks were extracted from docu

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please add information about this check in docs/ReleaseNotes.rst. http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

Eugene.Zelenko added a comment. It's much better to add information in release notes in same patch as check itself. See also http://reviews.llvm.org/D18509 for related add_new_check.py improvement. http://reviews.llvm.org/D18575 ___ cfe-commits ma

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. Which style I should use? Suggested by Richard or just provide links to documentation as in updated version? Repository: rL LLVM http://reviews.llvm.org/D18582 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [PATCH] D18582: [Clang-tidy] Update release notes with list of checks added since 3.8

Eugene.Zelenko added a comment. Sections headers are not problem :-) See newly added "Clang-tidy changes from 3.7 to 3.8" section. It contains only names of checks with link to documentation page without brief description. Repository: rL LLVM http://reviews.llvm.org/D18582 __

<    1   2   3   4   5   6   >