[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/altera-kernel-name-restriction.rst:4 +altera-kernel-name-restriction + + Please make same length as text above. CHANGES SINCE LAST ACTION h

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. Please fix Clang-tidy warnings and mention changes in Release Notes. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:317 + if (Style.Case == IdentifierNamingCheck::CaseType::CT_HungarianNotation) { +const auto

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. It'll be good idea to add test case. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +* Added: Add IdentifierNamingCheck::CaseType, CT_HungarianNotation, supporting naming check with Hungarian notation. + Please move to

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. In D86671#2244236 , @dougpuob wrote: > In D86671#2243788 , @Eugene.Zelenko > wrote: > >> It'll be good idea to add test case. > > Hi @Eugene.Zelenko, > I have created a `readability-

[PATCH] D86838: Improved for suggestions of code review. 1. Moved release notes to `Changes in existing checks` section. [Eugene.Zelenko] 2. Modified release notes can be describe user-facing. [Eu

Eugene.Zelenko added a comment. You need just upload new diff into existing Phabricator revision, not create new one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86838/new/ https://reviews.llvm.org/D86838 ___

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:73 +- Added: Support variables could be checked with Hungarian Notation which the + prefix encodes the actual data type of the variable. See examples for entry format bel

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. By the word, you must mention new option in documentation too. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:73 +- Added: Support variables could be checked with Hungarian Notation which the + prefix encodes the actual data type of the v

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. In D86671#2246486 , @dougpuob wrote: > In D86671#2246480 , @Eugene.Zelenko > wrote: > >> By the word, you must mention new option in documentation too. > > Hi @Eugene.Zelenko, > Is t

[PATCH] D66564: [clang-tidy] new altera struct pack align check

Eugene.Zelenko added a comment. In D66564#2256423 , @ffrankies wrote: > @Eugene.Zelenko I don't have commit access to the repository, could you > please commit this check on our behalf? Sorry, I don't have it either. @aaron.ballman or @njames93 could do

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

Eugene.Zelenko added a comment. Please add entry in Release Notes. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:26 +namespace { +constexpr StringRef SignalFun = "signal"; +constexpr StringRef AbortFun = "abort"; Only type definitions sho

[PATCH] D92992: [clang-tidy] Add make_unique_for_overwrite/make_shared_for_overwrite check.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:143 +- New :doc:`modernize-make-shared-for-overwrite + ` check. Please keep alphabetical order. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

Eugene.Zelenko added a comment. Maybe Clang's `-Wformat` should be extended to cover Linux kernel-specific format options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93182/new/ https://reviews.llvm.org/D93182 __

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:31 + is not included). Default is ``POSIX``. \ No newline at end of file Please add newline. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:76 +- The run-clang-tidy.py helper script is now installed in bin/ as + run-clang-tidy. It was previously installed in share/clang/. Please enclose run-clang-tidy.py, bin

[PATCH] D91000: [clang-tidy] CERT MSC24-C Obsolescent Functions check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ObsolescentFunctionsCheck.cpp:19 +namespace { +static Preprocessor *PP; +} Why this could not be member of check class? Comment at: clang-tools-extra/clang-tidy

[PATCH] D91037: [clang-tidy][bugprone-use-after-mnove] Warn on std::move for consts

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:87 + if (!BinOpCond) +if (auto *ExprWithCleanupsCond = +dyn_cast_or_null(InnerIf->getCond())) Please fix warning. Reposit

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MacroTrailingSemiCheck.cpp:31 +const MacroDirective *MD) override { +auto *MI = MD->getMacroInfo(); + Please don't use auto when type is not spelle

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

Eugene.Zelenko added a comment. Does this check make sense in content of other style guides? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831 ___ cfe-commits maili

[PATCH] D89407: [clang-tidy] Add scoped enum constants to identifier naming check

Eugene.Zelenko added a comment. I think will be good idea to add test for suffix/prefix too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89407/new/ https://reviews.llvm.org/D89407 ___ cfe-commits maili

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

Eugene.Zelenko added a comment. Please add test case for new command-line option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91908/new/ https://reviews.llvm.org/D91908 ___ cfe-commits mailing list cfe

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:614 + if (CRD->isUnion()) +return ""; + Returning {} as default initializer will be better. Same in other places. Repository: rG LLVM Gi

[PATCH] D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop

Eugene.Zelenko added a comment. Please mention renaming in Release Notes. Comment at: clang-tools-extra/clang-tidy/performance/ImplicitConversionCheck.cpp:1 -//===--- ImplicitConversionInLoopCheck.cpp - clang-tidy===// +//===--- ImplicitConversionCheck.cpp

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 _

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

Eugene.Zelenko added a comment. I think CLang should do this job, since it has two related warnings already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90180/new/ https://reviews.llvm.org/D90180 ___ c

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

Eugene.Zelenko added a comment. In D90180#2357178 , @trixirt wrote: > Discussion of change on LKML > https://lkml.org/lkml/2020/10/27/2538 > > On why the existing clang fixit is not practical. > tl;dr > 10,000 changes to look for a treewide fix > The fixi

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualBaseClassDestructorCheck.cpp:38 + + const auto Destructor = MatchedClassOrStruct->getDestructor(); + Please don't use auto unless type is spelled in same sta

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/VirtualBaseClassDestructorCheck.cpp:22 +void VirtualBaseClassDestructorCheck::registerMatchers(MatchFinder *Finder) { + ast_matchers::internal::Matcher inheritsVirtualMethod = +

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:114 + + Checks if a do-while loop exists and flags it. + Please highlight do-while with double back-ticks. Comment at: clang-tools-extra/docs/clang-tidy

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

Eugene.Zelenko added a comment. Frankly, I don't think that length-based criteria is reasonable one. Readability of code is much more important than line/file length. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:633 + if (!Descriptor.ElemType.isNull

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

Eugene.Zelenko added a comment. New check must be mentioned in Release Notes. Comment at: clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp:1 +//===--- UselessReturnValueCheck.cpp - clang-tidy +//---===// Please m

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

Eugene.Zelenko added a comment. In D96082#2544778 , @steveire wrote: > @Eugene.Zelenko Why did you remove me from the reviewers list? Only project's maintainers should be reviewers and approve patch. Sure, nobody prevents you from making comments. Repo

[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

Eugene.Zelenko added a comment. I think it'll be much more reasonable to use `clang-format` and filter its output to select only changes with stars in build rule. `clang-format-diff` is another method to introduce formatting changes gradually. Comment at: clang-tools-extra/c

[PATCH] D96725: [clang-tidy] Fix modernize-use-using in extern C code

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp:19 +AST_MATCHER(Decl, isInExternC) { + return Node.getDeclContext()->isExternCContext(); This matcher may be useful for other checks, for example, `mode

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 -The improvements are... +- New :doc:`bugprone-thread-canceltype-asynchronous + ` check. Please add subsections for new checks and aliases. Looks like they were remove

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:73 + +New checks +^^ Please rebase from trunk. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:79 + +Finds calls to ``new`` that may throw exc

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

Eugene.Zelenko added a comment. Please mention new option in Release Notes. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-easily-swappable-parameters.rst:89 +warning about the two parameters are silenced. +Defaults to ``1``. +Might be any positive i

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-easily-swappable-parameters.rst:89 +warning about the two parameters are silenced. +Defaults to ``1``. +Might be any positive integer. whisperity wrot

[PATCH] D97361: [clang-tidy] Add misc-redundant-using check

Eugene.Zelenko added a comment. I think this check belongs to `readability` module. Comment at: clang-tools-extra/clang-tidy/misc/RedundantUsingCheck.cpp:1 +//===--- RedundantUsingCheck.cpp - clang-tidy +//===// Please make singl

[PATCH] D104112: [clang-tidy] cppcoreguidelines-avoid-init-default-constructors: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidInitDefaultConstructorsCheck.h:28 + bool isLanguageVersionSupported(const LangOptions &LangOpts) const override { +return LangOpts.CPlusPlus; + } Shouldn'

[PATCH] D104112: [clang-tidy] cppcoreguidelines-avoid-init-default-constructors: a new check

Eugene.Zelenko added a comment. What about bit filed members - their initialization is supported only in C++20. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104112/new/ https://reviews.llvm.org/D104112

[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.cpp:57 +namespace { +bool isSharedPtr(const QualType &T) { + if (auto R = T->getAsCXXRecordDecl()) Please use `static`, not anonymous namespace f

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

Eugene.Zelenko added a comment. Please mention improvement in Release Notes, in `Changes in existing checks` section. See example . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Eugene.Zelenko added a comment. Please wait for @aaron.ballman approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://reviews.llvm.org/D113201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

Eugene.Zelenko added a comment. If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe just to remove `readability-deleted-default`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97491/new/ https://reviews.llvm.org/D97491

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

Eugene.Zelenko added a comment. In D97491#2589097 , @njames93 wrote: > In D97491#2588835 , @Eugene.Zelenko > wrote: > >> If `Wdefaulted-function-deleted` was introduced in 12.0, I think it's safe >> just to remove

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

Eugene.Zelenko added a comment. In D97361#2589673 , @balazske wrote: > You can look into **misc/UnusedUsingDeclsCheck.cpp** (if not done yet), that > check handles `using` too. And that check is related to this check, the > module should be the same too

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-uniqueptr-delete-release.rst:24 + + If ``true``, refactor by calling the reset member function instead of + assigning to ``nullptr``. Default value is ``false``.

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp:22 +: ClangTidyCheck(Name, Context), + Inserter(Options.getLocalOrGlobal("IncludeStyle", +utils::IncludeSorter::IS_L

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-variable-length.rst:9 + +Loop counter variables are expected to have a length of at least +`MinimumLoopCounterNameLength` characters (default is 2). Additionally, `i`,

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-variable-length.rst:21 + +Loop counter variables are expected to have a length of at least +`MinimumLoopCounterNameLength` characters (default is `2`).

[PATCH] D72235: [clang-tidy] new altera unroll loops check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/altera-unroll-loops.rst:15 + +- This check is unable to determine the number of iterations in a `while` or + `do..while` loop; hence if such a loop is fully unrolled, a note is emitted ---

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

Eugene.Zelenko added a comment. I think call stack may be useful for other checks too. May be code should be moved to utilities? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://reviews.llvm.org/D97960

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyContext.cpp:40 +#include +using namespace clang; +using namespace tidy; Shouldn't namespaces be used instead? Comment at: clang-tools-extra/clang-tidy/Clan

[PATCH] D113946: [libc][clang-tidy] fix namespace check for externals

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:13 +#include + Should be `` and without newline separation form rest of headers. Comment at: clang-tools-extra/clang-tidy/llvml

[PATCH] D114602: [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC]

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:31 + + + Two excessive newlines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:161 since they cannot be explicitly defaulted. The check also skips copy assignment operators - with nonstandard return types. The check is restricted to c++11-or-later. + with nonstan

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:161 since they cannot be explicitly defaulted. The check also skips copy assignment operators - with nonstandard return types. The check is restricted to c++11-or-later. + with nonstan

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

Eugene.Zelenko added a comment. Will be good idea to mention changes in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134588/new/ https://reviews.llvm.org/D134588 ___ cfe-commits mailing l

[PATCH] D128372: [Clang-Tidy] Empty Check

Eugene.Zelenko added a comment. In D128372#3883214 , @denik wrote: > @Eugene.Zelenko , could you please stamp the patch if you don't have any > other concerns? Please wait for developers approval. I look only for trivial issues. Repository: rG LLVM

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

Eugene.Zelenko added a comment. Please mention changes in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131780/new/ https://reviews.llvm.org/D131780 ___ cfe-commits mailing list cfe-commit

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

Eugene.Zelenko added a comment. In D131780#3720896 , @carlosgalvezp wrote: > In D131780#3719881 , > @Eugene.Zelenko wrote: > >> Please mention changes in Release Notes. > > Thanks for the quick review, @Eugene.Z

[PATCH] D131859: [clang-tidy] Adds QualifierAlignment to misc-const-correctness.

Eugene.Zelenko added a comment. Shouldn't `east/west` added as aliases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131859/new/ https://reviews.llvm.org/D131859 ___ cfe-commits mailing list cfe-commits

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

Eugene.Zelenko added a comment. Please add documentation and mention new check in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131985/new/ https://reviews.llvm.org/D131985 ___ cfe-commits

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

Eugene.Zelenko added a comment. Entry in Release Notes is still missing. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/return-with-redundant-parens.rst:4 +readability-return-with-redundant-parens += + Please make same

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:110 + + Checks for `return` statements with redundant parenthesis. + Please use double back-ticks for language constructs. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D131985: clang-tidy: strip useless parens from `return` statements

Eugene.Zelenko added a comment. In D131985#3727544 , @oleg.smolsky wrote: > In D131985#3727436 , @njames93 > wrote: > >> The idea of this check is good, but restricting it to only return statements >> seems baf

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

Eugene.Zelenko added a comment. Please mention changes in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132290/new/ https://reviews.llvm.org/D132290 ___ cfe-commits mailing list cfe-commit

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SprintfWithFixedSizeBufferCheck.cpp:13 +#include "clang/ASTMatchers/ASTMatchFinder.h" + +#include "clang/Lex/Lexer.h" Unnecessary newline. Comment at: cla

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SprintfWithFixedSizeBufferCheck.h:29 + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + Yoorkin wrote: > Eugene.Zelenko wrote: > > Please add

[PATCH] D132294: [clang-tidy] Add check of sprintf with fixed size buffer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/sprintf-with-fixed-size-buffer.rst:6 + +Find usage of ``sprintf``, which write output string into a fixed-size array. It +will suggest ``snprintf`` instead. Sho

[PATCH] D128372: [Clang-Tidy] Empty Check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:127 + + Warns when `empty()` is used on a range and the result is ignored. Suggests `clear()` as an alternative + if it is an existing member function. Please synchronize

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-do-while.rst:6 + +This check warns when using ``do-while`` loops. They are less readable than +plain ``while`` loops since the termination condition is at the end a

[PATCH] D134592: [clang-tidy] Add option to control floating point binary operators in readability-simplify-boolean-expr

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:155 + + Added an option SafeFloatComparisons to control negating binary operators + with floating point operands. Please enclose `SafeFloatComparisons` into single back-t

[PATCH] D134588: [clang-tidy] Fix bugprone-exception-escape warn on noexcept calls

Eugene.Zelenko added a comment. It'll be good idea to mention change in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134588/new/ https://reviews.llvm.org/D134588 ___ cfe-commits mailing l

[PATCH] D130130: [clang-tidy] Add an IgnoreMacros option to readability-avoid-const-params-in-decls

Eugene.Zelenko added a comment. Could you please rebase from `main` and upload patch here before commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130130/new/ https://reviews.llvm.org/D130130 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D130130: [clang-tidy] Add an IgnoreMacros option to readability-avoid-const-params-in-decls

Eugene.Zelenko added a comment. Thank you! Just wanted to ensure alphabetical order in `Changes in existing checks` :-) Fine to merge. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130130/new/ https://reviews.llvm.org/D130130 ___ cfe-commit

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst:54 constructor could hide in this case. We also suppress warnings for constructors -like C3 and C4 that are guarded with an ``enable_if``, assum

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

Eugene.Zelenko added a subscriber: MyDeveloperDay. Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/forwarding-reference-overload.rst:54 constructor could hide in this case. We also suppress warnings for constructors -like C3 a

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:68 + + auto BPointeeUQTy = BPointeeTy->getUnqualifiedDesugaredType(); + auto TPointeeUQTy = TPointeeTy->getUnqualifiedDesugaredType(); Please don'

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-inline-const-variables-in-headers.rst:5 +=== + + Excessive newline. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StaticDeclarationInHeaderCheck.cpp:46 +: ClangTidyCheck(Name, Context), + RawStringHeaderFileExtensions(Options.getLocalOrGlobal( + "HeaderFileExtensions", utils::defaultHeaderF

[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/static-declaration-in-header.rst:39 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

Eugene.Zelenko added a comment. It'll be good idea to mention change in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 ___ cfe-commits mailing l

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

Eugene.Zelenko added a comment. I just look into check documentation, new feature should be described with example there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 _

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

Eugene.Zelenko added a comment. In D140760#4019708 , @ccotter wrote: > In D140760#4019680 , > @Eugene.Zelenko wrote: > >> I just look into check documentation, new feature should be described with >> example the

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-reference-coroutine-parameters.rst:9 + +This check implements +[CppCoreGuideline CP.53](http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines). -

[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:26 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;hh;hpp;hxx

[PATCH] D140894: [clang-tidy] Don't emit misc-unused-using-decl warnings for header files.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/unused-using-decls.rst:26 + A semicolon-separated list of filename extensions of header files (the filename + extensions should not include "." prefix). Default is ";h;hh;hpp;hxx

[PATCH] D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StrlenStringCStrCheck.cpp:1 +//===- StrlenStringCStrCheck.cpp - Check for strlen(string::c_str()) calls +//-===// Please make it single string. Comme

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions option

Eugene.Zelenko added a comment. Looks OK for me, but probably will be good idea to remove check-specific options in same commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000 __

[PATCH] D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StrlenStringCStrCheck.h:1 +//===--- StrlenStringCStrCheck.h - clang-tidy *- C++ -*-===// +// Should be 80 characters long. See other checks as example. Re

[PATCH] D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:107 << E->getSourceRange(); +auto LocForEndOfToken = +Lexer::getLocForEndOfToken(E->getEndLoc(), 0, SM, LangOpts);

[PATCH] D141118: [clang-tidy][NFC] Remove unused User argument in misc-misleading-bidirectional check

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me, but please wait for more active developers' opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141118/new/

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:115 + Warns when lambda specify a capture default and capture ``this``. The check also + offers FixIts. + `fix-it`. Comment at: clang-tools-extra/docs

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

Eugene.Zelenko accepted this revision. Eugene.Zelenko added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:142 e.g. --config-file=/some/path/myTidyConfigFile -

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. But will be good idea to wait for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llv

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureThisWithCaptureDefaultCheck.cpp:32 + if (Capture.getCaptureKind() == LCK_ByRef) { +SourceManager &SourceMgr = Context.getSourceManager(); +SourceLoca

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Eugene.Zelenko added a comment. It'll be good idea to check that `HeaderFileExtensions` and `ImplementationFileExtensions` do not overlap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141000/new/ https://reviews.llvm.org/D141000

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:219 +- Improved :doc:`modernize-loop-convert ` to + refactor container based for loops that initialize iterators with free function calls Please keep alphabetical order

[PATCH] D141391: [NFC] [clang-tools-extra] Alphabetize clang-tidy release notes

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Thank you for fix! Such issues may be result of rebase artifacts and slip into code base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

<    1   2   3   4   5   6   7   8   9   10   >