[PATCH] D72635: Add "context" capability to Thread Safety Analysis

2020-01-13 Thread Etienne Pierre-Doray via Phabricator via cfe-commits
eti-p-doray created this revision. eti-p-doray added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Main use case: Chromium has runtime "SequenceChecker" and "ThreadChecker" that enforce sequenced task context. Thread safety analysis can be used

[PATCH] D72635: Add "context" capability to Thread Safety Analysis

2020-01-15 Thread Etienne Pierre-Doray via Phabricator via cfe-commits
eti-p-doray added a comment. I added an example in the description. From doc https://clang.llvm.org/docs/ThreadSafetyAnalysis.html, it sounds like we should be allowed to declare our class with CAPABILITY("context"), but it turns out that only "mutex" and "role" are allowed. I could otherwise

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

2020-01-17 Thread Etienne Pierre-Doray via Phabricator via cfe-commits
eti-p-doray updated this revision to Diff 238782. eti-p-doray retitled this revision from "Add "context" capability to Thread Safety Analysis" to "Allow arbitrary capability name in Thread Safety Analysis". eti-p-doray added a comment. Allow arbitrary capability CHANGES SINCE LAST ACTION http

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

2020-01-17 Thread Etienne Pierre-Doray via Phabricator via cfe-commits
eti-p-doray added a comment. Thank you for checking! I updated the changes to lift the restriction. PTAnL? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

2020-01-21 Thread Etienne Pierre-Doray via Phabricator via cfe-commits
eti-p-doray updated this revision to Diff 239362. eti-p-doray added a comment. Added test with custom capability name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Diagnos

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

2020-01-21 Thread Etienne Pierre-Doray via Phabricator via cfe-commits
eti-p-doray added a comment. Thanks! I don't I have commit access. Can you commit on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org