etienneb created this revision.
etienneb added reviewers: rnk, kcc.
etienneb added subscribers: cfe-commits, chrisha.
The ASAN unittests are failing (check-asan-dynamic) due to an incorrect symbol
name:
```
LINK : error LNK2001: unresolved external symbol ___asan_seh_interceptor
```
On win64, th
Author: etienneb
Date: Fri Sep 23 09:07:47 2016
New Revision: 282251
URL: http://llvm.org/viewvc/llvm-project?rev=282251&view=rev
Log:
[asan] Fix incorrect SEH symbol mangling on win64.
Summary:
The ASAN unittests are failing (check-asan-dynamic) due to an incorrect symbol
name:
```
LINK : error
Author: etienneb
Date: Tue Aug 30 13:38:25 2016
New Revision: 280127
URL: http://llvm.org/viewvc/llvm-project?rev=280127&view=rev
Log:
typo + indentation [NFC]
Modified:
cfe/trunk/lib/Driver/MSVCToolChain.cpp
cfe/trunk/lib/Driver/ToolChains.h
Modified: cfe/trunk/lib/Driver/MSVCToolChain.
etienneb added a comment.
drive-by, some comments.
Thanks for the check
Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:20
@@ +19,3 @@
+// Return the number of EnumConstantDecls in an EnumDecl.
+static int enumLen(const EnumDecl *EnumDec) {
+ int Counter = 0;
h
etienneb added a comment.
some nits
Comment at: docs/clang-tidy/checks/misc-enum-misuse.rst:37
@@ +36,3 @@
+unsigned flag;
+flag = A | H; //OK, disjoint value intervalls in the enum types > probably
good use
+flag = B | F; //warning, have common values so they are probably misu
etienneb added a subscriber: etienneb.
etienneb added a comment.
thx for the check
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:25
@@ +24,3 @@
+ const SourceManager &SM = Context->getSourceManager();
+ const LangOptions LangOpts = Context->getLangOpts();
+
etienneb added a comment.
In https://reviews.llvm.org/D22725#494167, @Prazek wrote:
> hmm It seems that I mislead you, I suck at C api - memmove source and
> destination can overlap, but std::move can't. So I guess you have to remove
> the memmove support. Sorry.
On windows (MSVC CRT), both f
etienneb added inline comments.
Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:73
@@ +72,3 @@
+ Finder->addMatcher(
+ callExpr(allOf(callee(functionDecl(matchesName("::memcpy"))),
+ argumentCountIs(3)))
It's more efficient to use
Author: etienneb
Date: Tue Aug 2 17:51:46 2016
New Revision: 277539
URL: http://llvm.org/viewvc/llvm-project?rev=277539&view=rev
Log:
[clang-tidy] Fix missing dependency to static analyzer
Summary:
This patch is fixing the build bot broken for a missing dependency.
The missing dependency is bre
etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, cfe-commits.
The append operator on a shell command for quick command-line is
causing trouble on windows. [NFC]
The easiest way to fix them is to avoid using them.
This patch is an attempt to fix
Author: etienneb
Date: Wed Aug 3 01:10:15 2016
New Revision: 277576
URL: http://llvm.org/viewvc/llvm-project?rev=277576&view=rev
Log:
[clang/test] Fix a flaky unittest on windows
Summary:
The append operator on a shell command for quick command-line is
causing trouble on windows. [NFC]
The easie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277576: [clang/test] Fix a flaky unittest on windows
(authored by etienneb).
Changed prior to commit:
https://reviews.llvm.org/D23105?vs=66615&id=66616#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: etienneb
Date: Wed Aug 3 01:59:46 2016
New Revision: 277578
URL: http://llvm.org/viewvc/llvm-project?rev=277578&view=rev
Log:
[extra-tools] Fix extra tools build bot warnings due to incorrect doc
/home/llvmbb/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/clang-
etienneb added inline comments.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:21
@@ +20,3 @@
+
+static bool AreIdenticalExpr(const Expr *Left, const Expr *Right) {
+ if (!Left || !Right)
alexfh wrote:
> This is to some degree similar to comparing `llvm
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
The text is mis-aligned.
http://reviews.llvm.org/D19541
Files:
docs/UndefinedBehaviorSanitizer.rst
Index: docs/UndefinedBehaviorSanitizer.rst
==
etienneb added a comment.
This got fixed.
Abandoning this change.
http://reviews.llvm.org/D19541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: etienneb
Date: Tue Apr 26 12:30:30 2016
New Revision: 267574
URL: http://llvm.org/viewvc/llvm-project?rev=267574&view=rev
Log:
[clang-tidy] New checker for redundant expressions.
Summary:
This checker finds redundant expression on both side of a binary operator.
The current implementatio
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
Arguments can be swapped using fixit when they are not in macros.
This is the same implementation than SwappedArguments. Some code
got lifted to be reused.
Others checks are not safe to b
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This patch added the support for method "compare" on string-like classes.
The LLVM stringRef is supported. The checker assume that StringRef is returning
-1, 0 or 1.
Which is not the case
etienneb updated this revision to Diff 55240.
etienneb marked an inline comment as done.
etienneb added a comment.
address alexfh comments, add a macro FP.
http://reviews.llvm.org/D19577
Files:
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
test/clang-tidy/misc-suspicious-string-compare.c
etienneb added a comment.
In http://reviews.llvm.org/D19577#413526, @alexfh wrote:
> I'm somewhat reluctant to add LLVM-specific checks to misc-. I would prefer
> either to split the LLVM-specific part to a separate check in llvm/ (which
> might derive from this check or somehow reuse the logic
etienneb added inline comments.
Comment at: clang-tidy/misc/StringConstructorCheck.cpp:110
@@ -106,2 +109,3 @@
if (Result.Nodes.getNodeAs("swapped-parameter")) {
-diag(Loc, "constructor parameters are probably swapped");
+assert(E->getNumArgs() == 2 && "Invalid number o
etienneb updated this revision to Diff 55242.
etienneb added a comment.
address alexfh comments.
http://reviews.llvm.org/D19547
Files:
clang-tidy/misc/StringConstructorCheck.cpp
clang-tidy/misc/SwappedArgumentsCheck.cpp
clang-tidy/utils/FixItHintUtils.cpp
clang-tidy/utils/FixItHintUtils
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This patch is adding support for conditional expression and overloaded
operators.
To decrease false-positive, this patch is adding a list of banned macro names
that
has multiple variant
etienneb updated this revision to Diff 55514.
etienneb added a comment.
nit
http://reviews.llvm.org/D19703
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
docs/clang-tidy/checks/misc-redundant-expression.rst
test/clang-tidy/misc-redundant-expression.cpp
Index: test/clang-tidy/misc-re
etienneb updated this revision to Diff 55526.
etienneb added a comment.
adding unittests
http://reviews.llvm.org/D19703
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
docs/clang-tidy/checks/misc-redundant-expression.rst
test/clang-tidy/misc-redundant-expression.cpp
Index: test/clang
etienneb requested changes to this revision.
etienneb added a comment.
This revision now requires changes to proceed.
Could you lift some logics to the matcher instead of the check.
Comment at: clang-tidy/readability/MisleadingIndentationCheck.cpp:22
@@ +21,3 @@
+const Match
etienneb added a comment.
You should not limit the checker to "if".
The for-statement and while-statement are also wrong for the same reasons:
while (x)
statement1();
statement2();
for (...)
statement1();
statement2();
You should test your code over large code base.
You sh
etienneb added a comment.
In http://reviews.llvm.org/D19586#417063, @xazax.hun wrote:
> In http://reviews.llvm.org/D19586#417053, @etienneb wrote:
>
> > The rule also apply for statements in a same compound:
> >
> > {
> > statement1();
> > statement2();
> > statement3();
> >
> >
>
etienneb added a comment.
If you are interested to a quick chat on this Checker, ping me. I know other
cases that should be filtered and I'm lacking time to implement them. Here is a
common one I would lie to see happening (base on comments):
const char* A[] = {
// This is a entry
"en
etienneb added a comment.
this is cool :)
It's a simple and precise rule to avoid using the probabilistic heuristic.
Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:94
@@ -93,3 +93,3 @@
Finder->addMatcher(StringsInitializerList.bind("list"), this);
}
--
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
The goal of the patch is to bring checkers in their appropriate namespace.
This path doesn't change any behavior.
http://reviews.llvm.org/D19811
Files:
clang-tidy/cert/CERTTidyModule.cp
Author: etienneb
Date: Mon May 2 13:00:29 2016
New Revision: 268264
URL: http://llvm.org/viewvc/llvm-project?rev=268264&view=rev
Log:
[clang-tidy] Cleaning namespaces to be more consistant across checkers.
Summary:
The goal of the patch is to bring checkers in their appropriate namespace.
This p
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This is a step forward cleaning up the namespaces in clang-tidy/utils.
There is no behavior change.
http://reviews.llvm.org/D19819
Files:
clang-tidy/cppcoreguidelines/ProBoundsConstantA
etienneb updated this revision to Diff 55858.
etienneb added a comment.
add missing case
http://reviews.llvm.org/D19819
Files:
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h
clang-tidy/cppcoreguidelines/Pro
etienneb updated this revision to Diff 55876.
etienneb added a comment.
fix unittests
http://reviews.llvm.org/D19819
Files:
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp
clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h
clang-tidy/cppcoreguidelines/ProTyp
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This patch is lifting matchers used by more than one checkers
to the common namespace.
http://reviews.llvm.org/D19841
Files:
clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp
cla
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
Lift some common code used by multiple checkers.
This function is also used by checkers that are coming.
It is quite common for a checker to parse a list of names.
http://reviews.llvm.org
Author: etienneb
Date: Mon May 2 21:54:05 2016
New Revision: 268356
URL: http://llvm.org/viewvc/llvm-project?rev=268356&view=rev
Log:
[clang-tidy] Cleanup namespace in utils folder.
Summary:
This is a step forward cleaning up the namespaces in clang-tidy/utils.
There is no behavior change.
Revi
etienneb added a comment.
Who is the owner of ASTMatcher?
If he is willing to receive these matchers in ASTMatcher, I'll lift them.
Otherwise, we should at least lift them within clang-tidy.
http://reviews.llvm.org/D19841
___
cfe-commits mailing li
etienneb created this revision.
etienneb added reviewers: alexfh, sbenza, klimek.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This AST matcher will match a given CastExpr kind.
It's an narrowing matcher on CastExpr.
http://reviews.llvm.org/D19871
Files:
include
etienneb added a comment.
In http://reviews.llvm.org/D19871#419947, @aaron.ballman wrote:
> Is this required for some purpose?
It's used in clang-tidy checkers.
see http://reviews.llvm.org/D19841
> I'm not keen on adding new AST matchers that we cannot expose via the dynamic
> API, so
etienneb added a comment.
> It's good to have that context in a review for functionality that isn't part
> of the proposed patch. :-) Looking at the other patch, I would prefer to keep
> this matcher narrowed to just clang-tidy unless you can also solve how to
> expose it via the dynamic regist
etienneb added a comment.
> I agree that when possible, matchers should be available via the dynamic
> matchers API. It doesn't seem overly complicated to add this support here. As
> far as I understand, we just need to register the matcher in
> lib/ASTMatchers/Dynamic/Registry.cpp and add su
etienneb added a comment.
> though I would love if someday we could expose actual enumerations somehow
> instead of string literals
I would like too. Ditto for "equals" which is missing :)
http://reviews.llvm.org/D19871
___
cfe-commits mailing li
etienneb updated this revision to Diff 56022.
etienneb added a comment.
add dynamic parsing
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unitte
etienneb updated this revision to Diff 56023.
etienneb added a comment.
nit
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/
etienneb created this revision.
etienneb added reviewers: alexfh, sbenza, aaron.ballman, klimek.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This patch is adding support for a matcher to check string literal length.
This matcher is used in clang-tidy checkers and
etienneb updated this revision to Diff 56025.
etienneb added a comment.
fix doc
http://reviews.llvm.org/D19876
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittest
etienneb added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1578
@@ +1577,3 @@
+/// \endcode
+AST_MATCHER_P(StringLiteral, lengthIs, unsigned, N) {
+ return Node.getLength() == N;
aaron.ballman wrote:
> Perhaps we can adjust the `hasSize()
etienneb updated this revision to Diff 56173.
etienneb marked 4 inline comments as done.
etienneb added a comment.
address alexfh comments
http://reviews.llvm.org/D19846
Files:
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/performance/
etienneb added a comment.
Aaron? could you comment on it?
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
aaron.ballman wrote:
> Split these onto two lines?
I
etienneb added a comment.
Other opinions?
I'll proceed to the cleanup if no one else has comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
aaron.ballm
etienneb added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102
@@ +101,3 @@
+ static clang::CastKind getCastKind(llvm::StringRef AttrKind) {
+return llvm::StringSwitch(AttrKind)
+ .Case("CK_Dependent", CK_Dependent)
aaron.ballman w
etienneb requested changes to this revision.
etienneb added a comment.
This revision now requires changes to proceed.
If the 'original' size is available, the checkers should by-pass the heuristic.
Can you check if there is a way to get the original size.
Comment at: clang-tidy/
etienneb added a comment.
In http://reviews.llvm.org/D19769#422317, @szdominik wrote:
> The original size is available - but from the decleration, not from the
> initListExpr.
Let do the copy paste (correctly):
clang-query> match namedDecl(hasName("listA"))
Match #1:
Binding for "
etienneb added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1578
@@ +1577,3 @@
+/// \endcode
+AST_MATCHER_P(StringLiteral, lengthIs, unsigned, N) {
+ return Node.getLength() == N;
etienneb wrote:
> aaron.ballman wrote:
> > etienneb wrote:
etienneb updated this revision to Diff 56423.
etienneb added a comment.
merging hasSize
http://reviews.llvm.org/D19876
Files:
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/AST
etienneb updated this revision to Diff 56425.
etienneb added a comment.
fix unittests
http://reviews.llvm.org/D19876
Files:
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMa
etienneb added a comment.
Aaron? minus re-generation of the doc.
Is that what you want to see?
note: returned types for both getLength are not the same (APInt vs unsigned
int).
I took the 'hasSize'-Matcher approach to let overloaded operators do the job
for dispatching types.
note: there is a
etienneb updated this revision to Diff 56427.
etienneb added a comment.
revert to previous solution
http://reviews.llvm.org/D19871
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/AS
etienneb updated this revision to Diff 56428.
etienneb added a comment.
fix unittests
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: un
etienneb added a comment.
Get back to this solution.
comments?
http://reviews.llvm.org/D19871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb updated this revision to Diff 56723.
etienneb added a comment.
fix alexfh comments (renaming)
http://reviews.llvm.org/D19846
Files:
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/performance/FasterStringFindCheck.cpp
clang-ti
etienneb marked an inline comment as done.
etienneb added a comment.
renaming done, landing.
http://reviews.llvm.org/D19846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: etienneb
Date: Tue May 10 10:31:15 2016
New Revision: 269065
URL: http://llvm.org/viewvc/llvm-project?rev=269065&view=rev
Log:
[clang-tidy] Lift parsing of sequence of names functions to utils.
Summary:
Lift some common code used by multiple checkers.
This function is also used by checke
etienneb updated this revision to Diff 56781.
etienneb marked 3 inline comments as done.
etienneb added a comment.
add unittests
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/Fixit.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Fixit.cpp
unittests/Tooling/CMakeLists.txt
unitte
etienneb updated this revision to Diff 56790.
etienneb added a comment.
more unittests
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/Fixit.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Fixit.cpp
unittests/Tooling/CMakeLists.txt
unittests/Tooling/FixitTest.cpp
Index: unittest
etienneb updated this revision to Diff 56825.
etienneb marked 5 inline comments as done.
etienneb added a comment.
address alexfh comments
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/FixIt.h
lib/Tooling/CMakeLists.txt
lib/Tooling/FixIt.cpp
unittests/Tooling/CMakeLists.tx
etienneb updated this revision to Diff 56826.
etienneb added a comment.
nits
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/FixIt.h
lib/Tooling/CMakeLists.txt
lib/Tooling/FixIt.cpp
unittests/Tooling/CMakeLists.txt
unittests/Tooling/FixItTest.cpp
Index: unittests/Tooling/
etienneb updated this revision to Diff 56907.
etienneb marked an inline comment as done.
etienneb added a comment.
fix nits
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/FixIt.h
lib/Tooling/CMakeLists.txt
lib/Tooling/FixIt.cpp
unittests/Tooling/CMakeLists.txt
unittests/T
etienneb added a comment.
I added the "using statements".
landing.
Comment at: include/clang/Tooling/Fixit.h:35
@@ +34,3 @@
+///used by the following template abstractions.
+inline SourceRange getSourceRange(const SourceRange &Range) { return Range; }
+
etienneb updated this revision to Diff 56911.
etienneb marked an inline comment as done.
etienneb added a comment.
Herald added a subscriber: klimek.
use new API
http://reviews.llvm.org/D19703
Files:
include/clang/Tooling/FixIt.h
lib/Tooling/CMakeLists.txt
lib/Tooling/FixIt.cpp
unittest
etienneb updated this revision to Diff 56912.
etienneb added a comment.
fix bad upload
http://reviews.llvm.org/D19703
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
docs/clang-tidy/checks/misc-redundant-expression.rst
test/clang-tidy/misc-redundant-expression.cpp
Index: test/clang-t
Author: etienneb
Date: Wed May 11 09:31:39 2016
New Revision: 269188
URL: http://llvm.org/viewvc/llvm-project?rev=269188&view=rev
Log:
[tooling] FixItHint Tooling refactoring
Summary:
This is the refactoring to lift some FixItHint into tooling.
used by: http://reviews.llvm.org/D19807
Reviewers:
etienneb updated this revision to Diff 56919.
etienneb marked an inline comment as done.
etienneb added a comment.
use new API. code simplification
http://reviews.llvm.org/D19547
Files:
clang-tidy/misc/StringConstructorCheck.cpp
test/clang-tidy/misc-string-constructor.cpp
Index: test/clang
etienneb added a comment.
> We should add a hasAnyOverloadedOperatorName matcher at some point.
I proposed it to sbenza@ and he told me that the reason he did HasAnyName was
for speed issue.
I can't tell if that one has speed issue too.
But, otherwise, I agree... for code readability... we s
etienneb updated this revision to Diff 56935.
etienneb marked an inline comment as done.
etienneb added a comment.
remove useless set creation
http://reviews.llvm.org/D19703
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
docs/clang-tidy/checks/misc-redundant-expression.rst
test/clang
etienneb updated this revision to Diff 56937.
etienneb added a comment.
fix naming nits
http://reviews.llvm.org/D19703
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
docs/clang-tidy/checks/misc-redundant-expression.rst
test/clang-tidy/misc-redundant-expression.cpp
Index: test/clang-
etienneb added a comment.
+ Removed copy of a vector to a set
+ Fixed some minor coding-style issues
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:140
@@ +139,3 @@
+ const LangOptions &LO = Finder->getASTContext().getLangOpts();
+ std::set Names(NameRefs.begin(), Na
Author: etienneb
Date: Wed May 11 12:32:12 2016
New Revision: 269208
URL: http://llvm.org/viewvc/llvm-project?rev=269208&view=rev
Log:
[clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.
Summary:
Arguments can be swapped using fixit when they are not in macros.
This is th
Author: etienneb
Date: Wed May 11 12:38:22 2016
New Revision: 269210
URL: http://llvm.org/viewvc/llvm-project?rev=269210&view=rev
Log:
[clang-tidy] Refactoring of FixHintUtils
Summary:
Refactor some checkers to use the tooling re-writing API.
see: http://reviews.llvm.org/D19941
Reviewers: klimek
etienneb updated this revision to Diff 56942.
etienneb added a comment.
re-generating doc
http://reviews.llvm.org/D19876
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTMatchersTest
etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The missing keyword "inline" is causing some buildbot to fail.
The symbol is not available.
see:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-mult
Author: etienneb
Date: Wed May 11 15:09:17 2016
New Revision: 269224
URL: http://llvm.org/viewvc/llvm-project?rev=269224&view=rev
Log:
[tooling] Fix missing inline keyworkd, breaking build bot.
Summary:
The missing keyword "inline" is causing some buildbot to fail.
The symbol is not available.
s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269224: [tooling] Fix missing inline keyworkd, breaking
build bot. (authored by etienneb).
Changed prior to commit:
http://reviews.llvm.org/D20180?vs=56949&id=56954#toc
Repository:
rL LLVM
http://re
etienneb created this revision.
etienneb added reviewers: alexfh, rnk.
etienneb added a subscriber: cfe-commits.
The new API for fixit is in libtooling and the library misc in clang-tidy
didn't had the appropriate dependency.
This commit was breaking some build bots:
http://reviews.llvm.org/D1954
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269240: [clang-tidy] Add missing dependency of libtooling to
misc module (authored by etienneb).
Changed prior to commit:
http://reviews.llvm.org/D20182?vs=56963&id=56966#toc
Repository:
rL LLVM
htt
Author: etienneb
Date: Wed May 11 16:32:29 2016
New Revision: 269240
URL: http://llvm.org/viewvc/llvm-project?rev=269240&view=rev
Log:
[clang-tidy] Add missing dependency of libtooling to misc module
Summary:
The new API for fixit is in libtooling and the library misc in clang-tidy
didn't had the
etienneb added a comment.
I'm sure you're right: they are redundant keywords.
I'm preparing the revert patch, and I'm running tests over multiple build types.
Repository:
rL LLVM
http://reviews.llvm.org/D20180
___
cfe-commits mailing list
cfe-com
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The inline keywords are redundant.
Introduce by this commit to try to fix broken build bots:
http://reviews.llvm.org/D20180
Tested on Debug and Release
etienneb added a comment.
In http://reviews.llvm.org/D20180#427893, @rnk wrote:
> In http://reviews.llvm.org/D20180#427840, @alexfh wrote:
>
> > `inline` seems to be completely redundant here. Can you try removing it and
> > running whatever build configurations were failing without
> > http://
Author: etienneb
Date: Wed May 11 19:22:28 2016
New Revision: 269257
URL: http://llvm.org/viewvc/llvm-project?rev=269257&view=rev
Log:
[tooling] Remove redundant inline keyword
Summary:
The inline keywords are redundant.
Introduce by this commit to try to fix broken build bots:
http://reviews.l
Author: etienneb
Date: Wed May 11 23:20:04 2016
New Revision: 269274
URL: http://llvm.org/viewvc/llvm-project?rev=269274&view=rev
Log:
Add an AST matcher for string-literal length
Summary:
This patch is adding support for a matcher to check string literal length.
This matcher is used in clang-ti
Author: etienneb
Date: Wed May 11 23:32:47 2016
New Revision: 269275
URL: http://llvm.org/viewvc/llvm-project?rev=269275&view=rev
Log:
[clang-tidy] Improve misc-redundant-expression and decrease false-positive
Summary:
This patch is adding support for conditional expression and overloaded
operat
etienneb created this revision.
etienneb added reviewers: klimek, aaron.ballman.
etienneb added subscribers: cfe-commits, alexfh, sbenza.
This patch moves the enum definitions to a definition (.def) file.
These modifications provide way to list enumerator of a given type.
As an example, this all
etienneb updated this revision to Diff 57043.
etienneb added a comment.
Herald added a subscriber: klimek.
rebase over AST modifications
http://reviews.llvm.org/D20207
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
etienneb updated this revision to Diff 57044.
etienneb marked an inline comment as done.
etienneb added a comment.
rebase over AST modifications
http://reviews.llvm.org/D19871
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Regi
etienneb updated this revision to Diff 57045.
etienneb added a comment.
remove incorrect patch upload (sorry)
http://reviews.llvm.org/D20207
Files:
include/clang/AST/OperationKinds.def
include/clang/AST/OperationKinds.h
include/clang/module.modulemap
lib/AST/Expr.cpp
Index: lib/AST/Exp
etienneb marked 3 inline comments as done.
etienneb added a comment.
This patch has been modified to support dynamic matchers.
It rely on : http://reviews.llvm.org/D20207
Comments?
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102
@@ +101,3 @@
+ static clang::CastKind getC
1 - 100 of 329 matches
Mail list logo
