[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen updated this revision to Diff 79322. vangyzen added a comment. Handle multibyte thousands_sep; do not reference possibly stale locale data https://reviews.llvm.org/D26979 Files: projects/libcxx/test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pa

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added a comment. I'm glad you mentioned a multibyte thousands_sep, because it //is// multibyte in fr_FR.UTF-8 on FreeBSD 11. Specifically, it's a no-break space (U+00A0). https://reviews.llvm.org/D26979 ___ cfe-commits mailing list cfe-co

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added inline comments. Comment at: projects/libcxx/test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp:42 +assert(std::setlocale(LC_NUMERIC, LOCALE_en_US_UTF_8) != NULL); +char *expected = strdup(std::localecon

[PATCH] D27167: [libc++] Support multibyte decimal_point and thousands_sep

vangyzen created this revision. vangyzen added a subscriber: cfe-commits. Herald added a subscriber: emaste. Herald added a reviewer: EricWF. numpunct_byname assumed that decimal_point and thousands_sep were ASCII and simply copied the first byte from them. Add support for multibyte strings in th

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added inline comments. Comment at: projects/libcxx/test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:79 const std::numpunct& np = std::use_facet >(l); -assert(np.thousands_sep() == L','); +

[PATCH] D27167: [libc++] Support multibyte decimal_point and thousands_sep

vangyzen added a comment. A unit test change in https://reviews.llvm.org/D26979 found this and will continue to test it (on some OSes). https://reviews.llvm.org/D27167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D26920: [libc++] Add validation to Stage 2 of num_get

vangyzen updated this revision to Diff 79625. vangyzen added a comment. Herald added a subscriber: emaste. Restore support for a sign character preceding a "nan" I accidentally broke +nan and -nan. Add unit test cases for these, and update my change to support them. https://reviews.llvm.org/D2

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added a comment. @EricWF Do you have time and interest to review this again? https://reviews.llvm.org/D26979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added a comment. > @EricWF Do you have time and interest to review this again? I should ask, do you have time and interest to //commit// this? https://reviews.llvm.org/D26979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D24218: [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname and numpunct_byname.

vangyzen added inline comments. Comment at: src/locale.cpp:4339 if (loc == nullptr) __throw_runtime_error("numpunct_byname::numpunct_byname" " failed to construct for " + string(nm)); While you're here, you m

[PATCH] D27167: [libc++] Support multibyte decimal_point and thousands_sep

vangyzen abandoned this revision. vangyzen added a comment. I'm abandoning this revision because https://reviews.llvm.org/D24218 is clearly superior. https://reviews.llvm.org/D27167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis