ioeric updated this revision to Diff 80613.
ioeric added a comment.
- address review comment.
https://reviews.llvm.org/D27523
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288919: [change-namespace] don't fix using shadow decls in
classes. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27523?vs=80613&id=80615#toc
Repository:
rL LLVM
https://r
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D27615
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289203: [clang-format] calculate MaxInsertOffset in the
original code correctly. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27615?vs=80878&id=80888#toc
Repository:
rL LL
ioeric added a comment.
First round of comments.
Comment at: clang-move/ClangMove.cpp:492
+ isDefinition(), unless(InMovedClass), InOldCC,
+ anyOf(isStaticStorageClass(), hasParent(namespaceDecl(isAnonymous();
+ auto HelperFuncOrVar = namedDecl(anyOf(functionDecl
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
https://reviews.llvm.org/D27713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
https://reviews.llvm.org/D27758
Files:
change-namespace/ChangeNamespace.cpp
test/change-namespace/lambda-function.cpp
Index: test/change-namespace/lambda-function.cpp
==
ioeric added a comment.
Could you add the following test case for dumping all decls?
template
class Foo {
public:
Foo() {}
};
typedef Foo Foo_i;
https://reviews.llvm.org/D32741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lgtm. Looks like the test case should already be covered.
https://reviews.llvm.org/D32741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302624: Add ASTMatchRefactorer and ReplaceNodeWithTemplate
to RefactoringCallbacks (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D29621?vs=98203&id=98412#toc
Repository:
rL
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D33061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
1501 - 1511 of 1511 matches
Mail list logo