[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

2016-12-07 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 80613. ioeric added a comment. - address review comment. https://reviews.llvm.org/D27523 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp =

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

2016-12-07 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL288919: [change-namespace] don't fix using shadow decls in classes. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27523?vs=80613&id=80615#toc Repository: rL LLVM https://r

[PATCH] D27615: [clang-format] calculate MaxInsertOffset in the original code correctly.

2016-12-09 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D27615 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp ==

[PATCH] D27615: [clang-format] calculate MaxInsertOffset in the original code correctly.

2016-12-09 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289203: [clang-format] calculate MaxInsertOffset in the original code correctly. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27615?vs=80878&id=80888#toc Repository: rL LL

[PATCH] D27673: [clang-move] Only move used helper declarations.

2016-12-13 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. First round of comments. Comment at: clang-move/ClangMove.cpp:492 + isDefinition(), unless(InMovedClass), InOldCC, + anyOf(isStaticStorageClass(), hasParent(namespaceDecl(isAnonymous(); + auto HelperFuncOrVar = namedDecl(anyOf(functionDecl

[PATCH] D27713: [clang-move] Fix incorrect EndLoc for declarations in macros.

2016-12-13 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg https://reviews.llvm.org/D27713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D27758: [change-namespace] don't crash when type reference is in function type parameter list.

2016-12-14 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D27758 Files: change-namespace/ChangeNamespace.cpp test/change-namespace/lambda-function.cpp Index: test/change-namespace/lambda-function.cpp ==

[PATCH] D32741: [clang-move] Find template class forward declarations more precisely.

2017-05-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Could you add the following test case for dumping all decls? template class Foo { public: Foo() {} }; typedef Foo Foo_i; https://reviews.llvm.org/D32741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32741: [clang-move] Find template class forward declarations more precisely.

2017-05-02 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lgtm. Looks like the test case should already be covered. https://reviews.llvm.org/D32741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

2017-05-10 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL302624: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D29621?vs=98203&id=98412#toc Repository: rL

[PATCH] D33061: [tooling] RefactoringCallbacks code cleanup

2017-05-11 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D33061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

<    11   12   13   14   15   16