[libcxx] r292867 - Merge r292830 - Fix GCC C++03 build by hiding default template argument in C++03

2017-01-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jan 23 19:03:36 2017 New Revision: 292867 URL: http://llvm.org/viewvc/llvm-project?rev=292867&view=rev Log: Merge r292830 - Fix GCC C++03 build by hiding default template argument in C++03 Modified: libcxx/branches/release_40/include/string Modified: libcxx/branches/

Re: [libcxx] r292830 - Fix GCC C++03 build by hiding default template argument in C++03

2017-01-23 Thread Eric Fiselier via cfe-commits
> It fixes a bug introduced to the 4.0 branch in r292354 > > (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216054). > > > > /Eric > > > > On Mon, Jan 23, 2017 at 2:24 PM, Eric Fiselier via cfe-commits > > wrote: > >> > >> Author: e

[libcxx] r292869 - Merge r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

2017-01-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jan 23 19:05:56 2017 New Revision: 292869 URL: http://llvm.org/viewvc/llvm-project?rev=292869&view=rev Log: Merge r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS. Modified: libcxx/branches/release_40/include/__con

Re: [libcxx] r292822 - Fixed a typo in __config that prevented the aligned new/delete tests from passing on Mac OS.

2017-01-23 Thread Eric Fiselier via cfe-commits
r292869. On Mon, Jan 23, 2017 at 3:00 PM, Hans Wennborg wrote: > Ok, go ahead. > > On Mon, Jan 23, 2017 at 1:54 PM, Eric Fiselier wrote: > > This patch needs to get merged into 4.0 since the offending commit with > the > > misspelling is in the 4.0 branch. > > > > /Eric > > > > > > On Mon, Jan

[libcxx] r292883 - [libcxx] Never use within libc++

2017-01-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jan 23 22:57:33 2017 New Revision: 292883 URL: http://llvm.org/viewvc/llvm-project?rev=292883&view=rev Log: [libcxx] Never use within libc++ Summary: It is my opinion that libc++ should never use ``, including in the `dylib`. This patch remove all uses of `assert` from

[libcxx] r292901 - Remove all usages of REQUIRES-ANY in the test suite.

2017-01-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jan 24 03:11:08 2017 New Revision: 292901 URL: http://llvm.org/viewvc/llvm-project?rev=292901&view=rev Log: Remove all usages of REQUIRES-ANY in the test suite. Pending LIT changes are about to remove the REQUIRES-ANY keyword in place of supporting boolean && and || withi

[libcxx] r292905 - Fix bad XFAIL which recent LIT changes diagnosed

2017-01-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jan 24 04:19:32 2017 New Revision: 292905 URL: http://llvm.org/viewvc/llvm-project?rev=292905&view=rev Log: Fix bad XFAIL which recent LIT changes diagnosed Modified: libcxx/trunk/test/std/utilities/meta/meta.unary.prop.query/void_t.pass.cpp Modified: libcxx/trunk/t

[libcxxabi] r292906 - Remove all usages of REQUIRES-ANY in the test suite.

2017-01-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jan 24 04:28:23 2017 New Revision: 292906 URL: http://llvm.org/viewvc/llvm-project?rev=292906&view=rev Log: Remove all usages of REQUIRES-ANY in the test suite. Pending LIT changes are about to remove the REQUIRES-ANY keyword in place of supporting boolean && and || withi

[libcxx] r292908 - Revert yet another accidental change caused by r292684

2017-01-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jan 24 04:38:46 2017 New Revision: 292908 URL: http://llvm.org/viewvc/llvm-project?rev=292908&view=rev Log: Revert yet another accidental change caused by r292684 Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL:

[libcxx] r292923 - Revert "[libcxx] Never use within libc++"

2017-01-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jan 24 06:26:01 2017 New Revision: 292923 URL: http://llvm.org/viewvc/llvm-project?rev=292923&view=rev Log: Revert "[libcxx] Never use within libc++" This reverts commit r292883. Unfortunately uses _LIBCPP_ASSERT in a way which is not compatible with the C++11 dylib bui

Re: [libcxx] r293197 - Disable thread safety analysis for some functions in __thread_support

2017-01-29 Thread Eric Fiselier via cfe-commits
I'm OK with this. On Sun, Jan 29, 2017 at 10:18 AM, Dimitry Andric wrote: > I'd like to merge this to the release_40 branch. Eric, you OK with that? > > -Dimitry > > > On 26 Jan 2017, at 19:37, Dimitry Andric via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: dim > > Date: T

[libcxx] r294099 - Undefine min/max in __tree

2017-02-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 4 14:27:46 2017 New Revision: 294099 URL: http://llvm.org/viewvc/llvm-project?rev=294099&view=rev Log: Undefine min/max in __tree Added: libcxx/trunk/test/libcxx/containers/associative/undef_min_max.pass.cpp Modified: libcxx/trunk/include/__tree Modified: li

Re: [libcxx] r294099 - Undefine min/max in __tree

2017-02-04 Thread Eric Fiselier via cfe-commits
I'm going to merge this into v4.0 in order to fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216772 /Eric On Sat, Feb 4, 2017 at 1:27 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Sat Feb 4 14:27:46 2017 > New Revi

[libcxx] r294100 - Mark basic_string::assign templates as inline to improve ABI stability.

2017-02-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 4 14:38:35 2017 New Revision: 294100 URL: http://llvm.org/viewvc/llvm-project?rev=294100&view=rev Log: Mark basic_string::assign templates as inline to improve ABI stability. Visible definitions for basic_string::assign are sometimes emitted in the dylib depending on

[libcxx] r294103 - Merge r294099 - Undefine min/max in __tree

2017-02-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 4 16:36:27 2017 New Revision: 294103 URL: http://llvm.org/viewvc/llvm-project?rev=294103&view=rev Log: Merge r294099 - Undefine min/max in __tree Added: libcxx/branches/release_40/test/libcxx/containers/associative/undef_min_max.pass.cpp Modified: libcxx/bra

Re: [libcxx] r294099 - Undefine min/max in __tree

2017-02-04 Thread Eric Fiselier via cfe-commits
Merged in r294103. On Sat, Feb 4, 2017 at 1:39 PM, Eric Fiselier wrote: > I'm going to merge this into v4.0 in order to fix > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216772 > > /Eric > > On Sat, Feb 4, 2017 at 1:27 PM, Eric Fiselier via cfe-commits < &g

[libcxx] r294106 - Fix inconsistency in tuple's SFINAE. Patch from Andrey Khalyavin"

2017-02-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 4 16:57:01 2017 New Revision: 294106 URL: http://llvm.org/viewvc/llvm-project?rev=294106&view=rev Log: Fix inconsistency in tuple's SFINAE. Patch from Andrey Khalyavin" Modified: libcxx/trunk/include/tuple Modified: libcxx/trunk/include/tuple URL: http://llvm.o

[libcxx] r294107 - Recommit [libcxx] Never use within libc++

2017-02-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 4 17:22:28 2017 New Revision: 294107 URL: http://llvm.org/viewvc/llvm-project?rev=294107&view=rev Log: Recommit [libcxx] Never use within libc++ It is my opinion that libc++ should never use ``, including in the `dylib`. This patch remove all uses of `assert` from

[libcxx] r294115 - Fix typo in docs

2017-02-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 4 19:16:25 2017 New Revision: 294115 URL: http://llvm.org/viewvc/llvm-project?rev=294115&view=rev Log: Fix typo in docs Modified: libcxx/trunk/docs/DesignDocs/DebugMode.rst Modified: libcxx/trunk/docs/DesignDocs/DebugMode.rst URL: http://llvm.org/viewvc/llvm-pr

[libcxx] r294116 - Remove CMake hack

2017-02-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 4 19:19:02 2017 New Revision: 294116 URL: http://llvm.org/viewvc/llvm-project?rev=294116&view=rev Log: Remove CMake hack Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists

Re: [clang-tools-extra] r291892 - Fix the build of the include-fixer plugin for some shared cmake builds and MSVC.

2017-02-04 Thread Eric Fiselier via cfe-commits
Hi Ben, This change doesn't work when doing out-of-tree builds since `PTHREAD_LIB` is defined by LLVM's `config-ix.cmake` and therefore isn't defined during out-of-tree builds. It looks like the pthread configuration needs to be lifted out of LLVM's `config-ix.cmake` and placed somewhere the insta

[libcxx] r294139 - Adjust Apple ABI list after r294133

2017-02-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Feb 5 14:17:41 2017 New Revision: 294139 URL: http://llvm.org/viewvc/llvm-project?rev=294139&view=rev Log: Adjust Apple ABI list after r294133 Modified: libcxx/trunk/lib/abi/x86_64-apple-darwin16.abilist Modified: libcxx/trunk/lib/abi/x86_64-apple-darwin16.abilist U

[libcxx] r294141 - Fix variant build errors with GCC 7

2017-02-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Feb 5 14:36:07 2017 New Revision: 294141 URL: http://llvm.org/viewvc/llvm-project?rev=294141&view=rev Log: Fix variant build errors with GCC 7 Modified: libcxx/trunk/include/variant Modified: libcxx/trunk/include/variant URL: http://llvm.org/viewvc/llvm-project/lib

[libcxx] r294165 - Implement LWG 2773 - std::ignore should be constexpr.

2017-02-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Feb 5 19:25:31 2017 New Revision: 294165 URL: http://llvm.org/viewvc/llvm-project?rev=294165&view=rev Log: Implement LWG 2773 - std::ignore should be constexpr. In addition to the PR for LWG 2773 this patch also ensures that each of std::ignores constructors or assignmen

[libcxx] r294167 - Mark LWG 2765 as complete. No changes needed

2017-02-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Feb 5 20:41:49 2017 New Revision: 294167 URL: http://llvm.org/viewvc/llvm-project?rev=294167&view=rev Log: Mark LWG 2765 as complete. No changes needed Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/vi

Re: [libcxx] r294107 - Recommit [libcxx] Never use within libc++

2017-02-06 Thread Eric Fiselier via cfe-commits
tal/filesystem/fs.op.funcs/fs.op.status/status.pass.cpp > libc++ :: > std/experimental/filesystem/fs.op.funcs/fs.op.symlink_ > status/symlink_status.pass.cpp > libc++ :: > std/experimental/filesystem/fs.op.funcs/fs.op.temp_dir_ > path/temp_directory_path.pass.cpp > > The

[libcxx] r294353 - Fix test failures when using modules.

2017-02-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Feb 7 15:20:31 2017 New Revision: 294353 URL: http://llvm.org/viewvc/llvm-project?rev=294353&view=rev Log: Fix test failures when using modules. Modified: libcxx/trunk/test/libcxx/debug/containers/db_associative_container_tests.pass.cpp libcxx/trunk/test/libcxx

[libcxx] r294355 - fix python3 syntax error

2017-02-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Feb 7 15:21:17 2017 New Revision: 294355 URL: http://llvm.org/viewvc/llvm-project?rev=294355&view=rev Log: fix python3 syntax error Modified: libcxx/trunk/test/support/filesystem_dynamic_test_helper.py Modified: libcxx/trunk/test/support/filesystem_dynamic_test_help

[libcxx] r294360 - Fix bugs in filesystem detected by _LIBCPP_ASSERT.

2017-02-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Feb 7 15:51:58 2017 New Revision: 294360 URL: http://llvm.org/viewvc/llvm-project?rev=294360&view=rev Log: Fix bugs in filesystem detected by _LIBCPP_ASSERT. Recently I turned on libc++'s debug mode assertions when CMake is configured with -DLIBCXX_ENABLE_ASSERTIONS=ON.

Re: [libcxx] r294107 - Recommit [libcxx] Never use within libc++

2017-02-07 Thread Eric Fiselier via cfe-commits
; std/experimental/filesystem/fs.op.funcs/fs.op.remove_all/rem >> ove_all.pass.cpp >> libc++ :: >> std/experimental/filesystem/fs.op.funcs/fs.op.resize_file/re >> size_file.pass.cpp >> libc++ :: >> std/experimental/filesystem/fs.op.funcs/fs.op.space/space.pass.cpp &g

[libcxx] r294391 - Prevent UBSAN from generating unsigned overflow diagnostics in the hashing internals

2017-02-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Feb 7 18:10:10 2017 New Revision: 294391 URL: http://llvm.org/viewvc/llvm-project?rev=294391&view=rev Log: Prevent UBSAN from generating unsigned overflow diagnostics in the hashing internals Added: libcxx/trunk/test/libcxx/utilities/function.objects/unord.hash/

[libcxx] r294393 - Add missing include in

2017-02-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Feb 7 18:14:13 2017 New Revision: 294393 URL: http://llvm.org/viewvc/llvm-project?rev=294393&view=rev Log: Add missing include in Modified: libcxx/trunk/include/numeric Modified: libcxx/trunk/include/numeric URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/in

[libcxx] r294501 - Update info for LWG 2665 in upcoming_meeting.html

2017-02-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Feb 8 13:04:18 2017 New Revision: 294501 URL: http://llvm.org/viewvc/llvm-project?rev=294501&view=rev Log: Update info for LWG 2665 in upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http:

[libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 13:01:22 2017 New Revision: 294612 URL: http://llvm.org/viewvc/llvm-project?rev=294612&view=rev Log: Fix PR31916 - std::visit rejects visitors accepting lvalue arguments A static assertion was misfiring since it checked is_callable.value)>. However the decltype exp

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

2017-02-09 Thread Eric Fiselier via cfe-commits
t 12:01 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Thu Feb 9 13:01:22 2017 > New Revision: 294612 > > URL: http://llvm.org/viewvc/llvm-project?rev=294612&view=rev > Log: > Fix PR31916 - std::visit rejects visitor

[libcxx] r294644 - Start libc++ python cleanup and consolidation.

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 16:53:14 2017 New Revision: 294644 URL: http://llvm.org/viewvc/llvm-project?rev=294644&view=rev Log: Start libc++ python cleanup and consolidation. Libc++ frequently creates and uses utilities written in python. Currently there are python modules under both libcxx/

[libcxx] r294660 - add missing python import

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 17:29:08 2017 New Revision: 294660 URL: http://llvm.org/viewvc/llvm-project?rev=294660&view=rev Log: add missing python import Modified: libcxx/trunk/utils/libcxx/util.py Modified: libcxx/trunk/utils/libcxx/util.py URL: http://llvm.org/viewvc/llvm-project/lib

[libcxxabi] r294671 - Fix path to libc++'s python test module

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 17:58:54 2017 New Revision: 294671 URL: http://llvm.org/viewvc/llvm-project?rev=294671&view=rev Log: Fix path to libc++'s python test module Modified: libcxxabi/trunk/test/lit.cfg Modified: libcxxabi/trunk/test/lit.cfg URL: http://llvm.org/viewvc/llvm-project

[libcxx] r294673 - Add missing libc++ import

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 18:01:01 2017 New Revision: 294673 URL: http://llvm.org/viewvc/llvm-project?rev=294673&view=rev Log: Add missing libc++ import Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL: http://llvm.org/viewvc/ll

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

2017-02-09 Thread Eric Fiselier via cfe-commits
> > I'll merge these changes later today if there are no objections, and once > > all the bots pass. > > > > /Eric > > > > On Thu, Feb 9, 2017 at 12:01 PM, Eric Fiselier via cfe-commits > > wrote: > >> > >> Author: ericwf > >

[libcxx] r294681 - Merge r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 18:37:47 2017 New Revision: 294681 URL: http://llvm.org/viewvc/llvm-project?rev=294681&view=rev Log: Merge r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments A static assertion was misfiring since it checked is_callable.value)>. However

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

2017-02-09 Thread Eric Fiselier via cfe-commits
Looks like it is just this change. I merged it in r294681. /Eric ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r294690 - [CMake] Fix pthread handling for out-of-tree builds

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 19:59:20 2017 New Revision: 294690 URL: http://llvm.org/viewvc/llvm-project?rev=294690&view=rev Log: [CMake] Fix pthread handling for out-of-tree builds LLVM defines `PTHREAD_LIB` which is used by AddLLVM.cmake and various projects to correctly link the threading l

[libcxx] r307117 - Implement LWG 2937 - equivalent("dne", "exists") is not an error

2017-07-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 4 20:37:05 2017 New Revision: 307117 URL: http://llvm.org/viewvc/llvm-project?rev=307117&view=rev Log: Implement LWG 2937 - equivalent("dne", "exists") is not an error This patch speculatively implements the PR for LWG 2937, which fixes two issues with equivalent. (

[libcxx] r307118 - Add dummy CMake target for *.pass.cpp tests when LIBCXX_CONFIGURE_IDE=ON.

2017-07-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 4 20:50:03 2017 New Revision: 307118 URL: http://llvm.org/viewvc/llvm-project?rev=307118&view=rev Log: Add dummy CMake target for *.pass.cpp tests when LIBCXX_CONFIGURE_IDE=ON. In order for IDE's like CLion to correctly parse and highlight the tests it needs to know

[libcxx] r307119 - Fix equivalent test on OS X and FreeBSD

2017-07-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 4 20:54:38 2017 New Revision: 307119 URL: http://llvm.org/viewvc/llvm-project?rev=307119&view=rev Log: Fix equivalent test on OS X and FreeBSD Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.equivalent/equivalent.pass.cpp Modified: li

[libcxx] r307218 - Suppress -Waligned-allocation-unavailable warning in libc++ test suite

2017-07-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 5 15:40:58 2017 New Revision: 307218 URL: http://llvm.org/viewvc/llvm-project?rev=307218&view=rev Log: Suppress -Waligned-allocation-unavailable warning in libc++ test suite Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/t

[libcxxabi] r307230 - Fix incomplete type test on OS X; workaround weird DYLD_LIBRARY_PATH behavior

2017-07-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jul 5 17:29:09 2017 New Revision: 307230 URL: http://llvm.org/viewvc/llvm-project?rev=307230&view=rev Log: Fix incomplete type test on OS X; workaround weird DYLD_LIBRARY_PATH behavior Modified: libcxxabi/trunk/test/incomplete_type.sh.cpp Modified: libcxxabi/trunk/t

[libcxx] r307450 - Fix diagnostic in verify test to match new Clang output

2017-07-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 7 16:02:30 2017 New Revision: 307450 URL: http://llvm.org/viewvc/llvm-project?rev=307450&view=rev Log: Fix diagnostic in verify test to match new Clang output Modified: libcxx/trunk/test/std/thread/futures/futures.task/futures.task.members/ctor2.fail.cpp Modifi

[libcxx] r307461 - Fix filesystem build on platforms with weird time_t types.

2017-07-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 7 21:18:41 2017 New Revision: 307461 URL: http://llvm.org/viewvc/llvm-project?rev=307461&view=rev Log: Fix filesystem build on platforms with weird time_t types. 32-bit powerpc provides a 64 bit time_t type and older ppc64 systems provide time_t as a floating point t

[libcxx] r307510 - Fix test failure to to new/delete ellisions

2017-07-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 9 15:20:07 2017 New Revision: 307510 URL: http://llvm.org/viewvc/llvm-project?rev=307510&view=rev Log: Fix test failure to to new/delete ellisions Modified: libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.members/allocate.pass.cpp Modified:

r307513 - [coroutines] Include the implicit object parameter type when looking up coroutine_traits for member functions.

2017-07-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 9 18:27:22 2017 New Revision: 307513 URL: http://llvm.org/viewvc/llvm-project?rev=307513&view=rev Log: [coroutines] Include the implicit object parameter type when looking up coroutine_traits for member functions. This patch was originally from Toby Allsopp, but I h

r307514 - Remove non-ascii characters introduced in r307513

2017-07-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 9 19:52:34 2017 New Revision: 307514 URL: http://llvm.org/viewvc/llvm-project?rev=307514&view=rev Log: Remove non-ascii characters introduced in r307513 Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp URL: http://ll

r307515 - Remove incorrect FIXME comment; the FIXME was addressed before the changes were committed

2017-07-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 9 19:59:26 2017 New Revision: 307515 URL: http://llvm.org/viewvc/llvm-project?rev=307515&view=rev Log: Remove incorrect FIXME comment; the FIXME was addressed before the changes were committed Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp Modified: cfe/trunk/l

[libcxx] r307517 - Work around PR31864 - ATOMIC_LLONG_LOCK_FREE is incorrect in 32 bit builds

2017-07-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 9 21:16:50 2017 New Revision: 307517 URL: http://llvm.org/viewvc/llvm-project?rev=307517&view=rev Log: Work around PR31864 - ATOMIC_LLONG_LOCK_FREE is incorrect in 32 bit builds Modified: libcxx/trunk/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp M

[libcxx] r307518 - Fix issues with UBSAN test configuration.

2017-07-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 9 21:32:21 2017 New Revision: 307518 URL: http://llvm.org/viewvc/llvm-project?rev=307518&view=rev Log: Fix issues with UBSAN test configuration. On Apple the test feature 'sanitizer-new-delete' was incorrectly getting added to the LIT feature set, which mistakenly ca

[libcxx] r307746 - Revert "[libc++] Refactoring __sync_* builtins; NFC (Reland)"

2017-07-11 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 11 18:16:33 2017 New Revision: 307746 URL: http://llvm.org/viewvc/llvm-project?rev=307746&view=rev Log: Revert "[libc++] Refactoring __sync_* builtins; NFC (Reland)" This reverts commit r307595. The commit had some issues that needed to first be addressed in review.

[libcxxabi] r307748 - Remove dependancy on __refstring header; use local copy instead.

2017-07-11 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 11 18:34:21 2017 New Revision: 307748 URL: http://llvm.org/viewvc/llvm-project?rev=307748&view=rev Log: Remove dependancy on __refstring header; use local copy instead. This patch removes the dependancy on libc++'s __refstring header, which was only a header in the fi

[libcxx] r307749 - Remove <__refstring> header; Move it into source directory.

2017-07-11 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jul 11 18:38:35 2017 New Revision: 307749 URL: http://llvm.org/viewvc/llvm-project?rev=307749&view=rev Log: Remove <__refstring> header; Move it into source directory. The libc++ <__refstring> headers has no real reason why it should be a public header that libc++ ships.

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

2018-01-11 Thread Eric Fiselier via cfe-commits
I'm hitting the same issue as well. Please let me know if there is anything I can do to get this fixed quickly. /Eric On Wed, Jan 3, 2018 at 5:20 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Vedant, > > I'm looking into it. > > > On Wed, Jan 3, 2018 at 11:12 AM, Veda

Re: r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

2018-01-11 Thread Eric Fiselier via cfe-commits
Thanks for the correction Richard. /Eric On Tue, Jan 9, 2018 at 8:03 PM, Richard Smith wrote: > On 9 January 2018 at 18:46, Bruno Cardoso Lopes via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi Eric, >> >> On Mon, Jan 8, 2018 at 9:31 PM, Eric Fiselier wrote: >> > I haven't done a

r322334 - Add `__reference_binds_to_temporary` trait for checking safe reference initialization.

2018-01-11 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jan 11 16:09:37 2018 New Revision: 322334 URL: http://llvm.org/viewvc/llvm-project?rev=322334&view=rev Log: Add `__reference_binds_to_temporary` trait for checking safe reference initialization. Summary: The STL types `std::pair` and `std::tuple` can both store reference

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

2018-01-12 Thread Eric Fiselier via cfe-commits
Seems to be working now. Thank you! On Thu, Jan 11, 2018 at 9:46 PM, Richard Trieu wrote: > Hi Vedant and Eric, > > Please retry after r322350. I suspect an interaction between templates > and friend functions is causing this issue. This revision disables hashing > for friend functions for no

[libcxxabi] r322768 - Fix standalone test-suite run.

2018-01-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 17 14:07:09 2018 New Revision: 322768 URL: http://llvm.org/viewvc/llvm-project?rev=322768&view=rev Log: Fix standalone test-suite run. This patch updates libc++abi's HandleOutOfTreeLLVM.cmake to match libc++'s -- and more importantly, to fix a bug where llvm-lit wasn'

[libcxx] r322776 - Fix nodiscard failure tests on compilers w/o -verify.

2018-01-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 17 14:48:09 2018 New Revision: 322776 URL: http://llvm.org/viewvc/llvm-project?rev=322776&view=rev Log: Fix nodiscard failure tests on compilers w/o -verify. Previously .fail.cpp tests for nodiscard were run with -Wunused-result being a warning, not an error, when the

[libcxx] r322810 - Fix most GCC test failures.

2018-01-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 17 19:41:06 2018 New Revision: 322810 URL: http://llvm.org/viewvc/llvm-project?rev=322810&view=rev Log: Fix most GCC test failures. This patch fixes almost all currently failing tests when using GCC ToT. The specific changes are: (A) Workaround gcc.gnu.org/PR83921 w

[libcxx] r323380 - [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

2018-01-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 24 14:14:01 2018 New Revision: 323380 URL: http://llvm.org/viewvc/llvm-project?rev=323380&view=rev Log: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple. Summary: See https://bugs.llvm.org/show_bug.cgi?id=20855 Libc++ goes

Re: [libcxx] r323380 - [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

2018-01-24 Thread Eric Fiselier via cfe-commits
__can_bind_reference() { > ^ > 1 error generated. > > It looks like if the #if in __can_bind_reference is false, the function > will be empty. Can you take a look? > > Richard > > On Wed, Jan 24, 2018 at 2:14 PM, Eric Fiselier via cfe-commits < > cfe-commits@l

Re: [libcxx] r323380 - [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

2018-01-24 Thread Eric Fiselier via cfe-commits
nction >> will be empty. Can you take a look? >> >> Richard >> >> On Wed, Jan 24, 2018 at 2:14 PM, Eric Fiselier via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: ericwf >>> Date: Wed Jan 24 14:14:01 2018 >&

[libcxx] r323389 - Fix missing return in __tuple_leaf::__can_bind_reference when __reference_binds_to_temporary added in r323380.

2018-01-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 24 15:10:02 2018 New Revision: 323389 URL: http://llvm.org/viewvc/llvm-project?rev=323389&view=rev Log: Fix missing return in __tuple_leaf::__can_bind_reference when __reference_binds_to_temporary added in r323380. Modified: libcxx/trunk/include/tuple Modified:

Re: [PATCH] D41977: [libc++] Fix PR20855 -- libc++ incorrectly diagnoses illegal reference binding in std::tuple.

2018-01-24 Thread Eric Fiselier via cfe-commits
Yes, it should. That was a silly mistake, and should already have been fixed in trunk. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r323390 - Fix PR35564 - std::list splice/erase incorrectly throw in debug mode.

2018-01-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jan 24 16:02:48 2018 New Revision: 323390 URL: http://llvm.org/viewvc/llvm-project?rev=323390&view=rev Log: Fix PR35564 - std::list splice/erase incorrectly throw in debug mode. There was a bug in the implementation of splice where the container sizes were updated before

r323712 - [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

2018-01-29 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jan 29 15:52:57 2018 New Revision: 323712 URL: http://llvm.org/viewvc/llvm-project?rev=323712&view=rev Log: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object. Summary: Fix NRVO for Gro variable. Previously, we only marked the GRO declaration as an

r323717 - Revert "[coroutines] Fix application of NRVO to Coroutine "Gro" or return object."

2018-01-29 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jan 29 16:32:25 2018 New Revision: 323717 URL: http://llvm.org/viewvc/llvm-project?rev=323717&view=rev Log: Revert "[coroutines] Fix application of NRVO to Coroutine "Gro" or return object." This reverts commit r323712. It's causing some test failures on certain machine

r324037 - [coroutines] Fix application of NRVO to Coroutine "Gro" or return object.

2018-02-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 1 15:47:54 2018 New Revision: 324037 URL: http://llvm.org/viewvc/llvm-project?rev=324037&view=rev Log: [coroutines] Fix application of NRVO to Coroutine "Gro" or return object. Summary: Fix NRVO for Gro variable. Previously, we only marked the GRO declaration as an

r324127 - Emit label names according to -discard-value-names.

2018-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 2 11:58:34 2018 New Revision: 324127 URL: http://llvm.org/viewvc/llvm-project?rev=324127&view=rev Log: Emit label names according to -discard-value-names. Summary: Previously, Clang only emitted label names in assert builds. However there is a CC1 option -discard-va

r324134 - Make __has_unique_object_representations reject empty union types.

2018-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 2 12:30:39 2018 New Revision: 324134 URL: http://llvm.org/viewvc/llvm-project?rev=324134&view=rev Log: Make __has_unique_object_representations reject empty union types. Summary: Clang incorrectly reports empty unions as having a unique object representation. Howeve

[libcxx] r324153 - Fix has_unique_object_representation after Clang commit r324134.

2018-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 2 14:39:59 2018 New Revision: 324153 URL: http://llvm.org/viewvc/llvm-project?rev=324153&view=rev Log: Fix has_unique_object_representation after Clang commit r324134. Clang previously reported an empty union as having a unique object representation. This was incorre

Re: r324062 - [Sema] Add implicit members even for invalid CXXRecordDecls

2018-02-02 Thread Eric Fiselier via cfe-commits
This causes some stray diagnostics to be emitted in certian cases where a base class is already invalid: Reproducer: https://gist.github.com/EricWF/588a361030edeaebbbc1155b8347cab0 On Fri, Feb 2, 2018 at 1:40 AM, Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryu

[libcxx] r324164 - Work around Clang bug introduced in r324062

2018-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 2 17:45:35 2018 New Revision: 324164 URL: http://llvm.org/viewvc/llvm-project?rev=324164&view=rev Log: Work around Clang bug introduced in r324062 When Clang encounters an already invalid class declaration, it can emit incorrect diagnostics about the exception specif

[libcxx] r324165 - Work around GCC constexpr initialization bug

2018-02-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 2 17:48:21 2018 New Revision: 324165 URL: http://llvm.org/viewvc/llvm-project?rev=324165&view=rev Log: Work around GCC constexpr initialization bug Modified: libcxx/trunk/test/std/algorithms/alg.sorting/alg.lex.comparison/lexicographical_compare_comp.pass.cpp M

[libcxx] r324182 - [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types.

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 17:03:08 2018 New Revision: 324182 URL: http://llvm.org/viewvc/llvm-project?rev=324182&view=rev Log: [libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default constructible types. Summary: This patch fixes llvm.org/PR35491 and LWG2157 (https:/

[libcxx] r324185 - Make array non-CopyAssignable and make swap and fill ill-formed.

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 18:17:02 2018 New Revision: 324185 URL: http://llvm.org/viewvc/llvm-project?rev=324185&view=rev Log: Make array non-CopyAssignable and make swap and fill ill-formed. The standard isn't exactly clear how std::array should handle zero-sized arrays with const element

[libcxx] r324186 - correct comment about C++03 assignment operators

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 18:22:33 2018 New Revision: 324186 URL: http://llvm.org/viewvc/llvm-project?rev=324186&view=rev Log: correct comment about C++03 assignment operators Modified: libcxx/trunk/test/std/containers/sequences/array/array.cons/implicit_copy.pass.cpp Modified: libcx

[libcxx] r324187 - Address LWG 2849 and fix missing failure condition in copy_file.

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 18:43:32 2018 New Revision: 324187 URL: http://llvm.org/viewvc/llvm-project?rev=324187&view=rev Log: Address LWG 2849 and fix missing failure condition in copy_file. Previously copy_file didn't handle the case where the input and output were the same file. Modifie

[libcxx] r324188 - Mark issue 2851 as complete

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 18:45:33 2018 New Revision: 324188 URL: http://llvm.org/viewvc/llvm-project?rev=324188&view=rev Log: Mark issue 2851 as complete Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm

[libcxx] r324189 - Implement LWG2989: path's streaming operators allow everything under the sun.

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 19:10:53 2018 New Revision: 324189 URL: http://llvm.org/viewvc/llvm-project?rev=324189&view=rev Log: Implement LWG2989: path's streaming operators allow everything under the sun. Because path can be constructed from a ton of different types, including string and wi

[libcxx] r324190 - Remove debug println from rec.dir.itr.increment test

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 19:26:55 2018 New Revision: 324190 URL: http://llvm.org/viewvc/llvm-project?rev=324190&view=rev Log: Remove debug println from rec.dir.itr.increment test Modified: libcxx/trunk/test/std/experimental/filesystem/class.rec.dir.itr/rec.dir.itr.members/increment.pa

[libcxx] r324191 - Mark LWG 3013 as already complete. See r316941

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 23:29:53 2018 New Revision: 324191 URL: http://llvm.org/viewvc/llvm-project?rev=324191&view=rev Log: Mark LWG 3013 as already complete. See r316941 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://l

[libcxx] r324192 - Implement LWG 3014 - Fix more noexcept issues in filesystem.

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 23:35:36 2018 New Revision: 324192 URL: http://llvm.org/viewvc/llvm-project?rev=324192&view=rev Log: Implement LWG 3014 - Fix more noexcept issues in filesystem. This patch removes the noexcept declaration from filesystem operations which require creating temporary

[libcxx] r324193 - Mark LWG 3014 as complete. No code changes needed

2018-02-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Feb 3 23:37:09 2018 New Revision: 324193 URL: http://llvm.org/viewvc/llvm-project?rev=324193&view=rev Log: Mark LWG 3014 as complete. No code changes needed Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http:

[libcxx] r324194 - Fix initialization of array with GCC.

2018-02-04 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Feb 4 00:02:35 2018 New Revision: 324194 URL: http://llvm.org/viewvc/llvm-project?rev=324194&view=rev Log: Fix initialization of array with GCC. Previously, when handling zero-sized array of const objects we used a const version of aligned_storage_t, which is not an arra

[libcxx] r294699 - Attempt to fix finding clang++ on Windows

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 21:20:02 2017 New Revision: 294699 URL: http://llvm.org/viewvc/llvm-project?rev=294699&view=rev Log: Attempt to fix finding clang++ on Windows Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL: http://ll

[libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 22:25:33 2017 New Revision: 294707 URL: http://llvm.org/viewvc/llvm-project?rev=294707&view=rev Log: Split exception.cpp and new.cpp implementation into different files for different runtimes. exception.cpp is a bloody mess. It's full of confusing #ifdef branches

[libcxx] r294712 - Correctly default to using the system libc++abi on Apple.

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Feb 9 23:07:03 2017 New Revision: 294712 URL: http://llvm.org/viewvc/llvm-project?rev=294712&view=rev Log: Correctly default to using the system libc++abi on Apple. This patch fixes a regression where libc++ didn't correctly select the system libc++abi when no in-tree ve

Re: [libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

2017-02-09 Thread Eric Fiselier via cfe-commits
pecify -DLIBCXX_CXX_ABI=libcxxabi -DLIBCXX_CXX_ABI_INCLUDE_PATHS="". If these changes cannot be made easily and quickly then please let me know, and I'll implement a temporary workaround in libc++. /Eric On Thu, Feb 9, 2017 at 9:25 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.ll

[libcxx] r294718 - properly escape compiler path in .sh.cpp tests

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 10 00:38:02 2017 New Revision: 294718 URL: http://llvm.org/viewvc/llvm-project?rev=294718&view=rev Log: properly escape compiler path in .sh.cpp tests Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL: http

[libcxx] r294721 - Properly escape ShellTest subsitutions on Windows. Try 2

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 10 00:59:07 2017 New Revision: 294721 URL: http://llvm.org/viewvc/llvm-project?rev=294721&view=rev Log: Properly escape ShellTest subsitutions on Windows. Try 2 Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py

Re: [libcxx] r294696 - Fully qualify (preprend ::) calls to math functions from libc

2017-02-09 Thread Eric Fiselier via cfe-commits
I'm a bit paranoid one of the names we just qualified will end up being defined as a macro. Conceivably could have tolerated macros for names it uses but doesn't overload (ex, modff), however would have always blown up. /Eric ___ cfe-commits mailing li

[libcxx] r294727 - Revert "Split exception.cpp and new.cpp implementation into different files for different runtimes."

2017-02-09 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Feb 10 01:43:08 2017 New Revision: 294727 URL: http://llvm.org/viewvc/llvm-project?rev=294727&view=rev Log: Revert "Split exception.cpp and new.cpp implementation into different files for different runtimes." The compiler-rt CMake configuration needs some tweaking before

<    5   6   7   8   9   10   11   12   13   14   >