[libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

2016-10-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 14 03:47:09 2016 New Revision: 284214 URL: http://llvm.org/viewvc/llvm-project?rev=284214&view=rev Log: XFAIL aligned allocation tests for older Clang versions Modified: libcxx/trunk/test/libcxx/test/config.py libcxx/trunk/test/std/language.support/support.dy

[libcxx] r284216 - Remove dead CMake target

2016-10-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 14 04:06:38 2016 New Revision: 284216 URL: http://llvm.org/viewvc/llvm-project?rev=284216&view=rev Log: Remove dead CMake target Modified: libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/cmake/Modules/Ha

[libcxxabi] r284217 - Mark test as unsupported without threads

2016-10-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 14 04:12:53 2016 New Revision: 284217 URL: http://llvm.org/viewvc/llvm-project?rev=284217&view=rev Log: Mark test as unsupported without threads Modified: libcxxabi/trunk/test/libcxxabi/test/config.py libcxxabi/trunk/test/thread_local_destruction_order.pass.cp

[PATCH] D25603: [libc++] Fix modules build - Rework __refstring definition

2016-10-14 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. `__libcpp_refstring` currently has two different definitions. First there is the complete definition in `<__refstring>` but there is also a second in ``. The historical reason for this s

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

2016-10-14 Thread Eric Fiselier via cfe-commits
EricWF added a comment. I just spoke with Jonathan Wakely about this change, and he believes that it should be ABI safe. https://reviews.llvm.org/D25593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[libcxx] r284225 - Work around Clang driver segfault when --coverage is used with -c and /dev/null

2016-10-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 14 05:30:33 2016 New Revision: 284225 URL: http://llvm.org/viewvc/llvm-project?rev=284225&view=rev Log: Work around Clang driver segfault when --coverage is used with -c and /dev/null Modified: libcxx/trunk/test/libcxx/compiler.py Modified: libcxx/trunk/test/libc

[PATCH] D25568: [libcxx] [cmake] Use -print-libgcc-file-name option to find compiler runtime

2016-10-14 Thread Eric Fiselier via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. This doesn't seem right seeing as `print-libgcc_file-name` prints the `libgcc.a` path, and we were previously linking `libgcc_s`. https://reviews.llvm.org/D25568 ___

[PATCH] D25431: [libcxx] [CMake] Build Solaris compat as separate C lib, to avoid -std= issues

2016-10-14 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Why not just compile the sources files as C++ by changing their extensions? This change seems all kinds of wrong because we're throwing away *all* of our flags, including things like `-m32` or `-target `. https://reviews.llvm.org/D25431 __

[PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

2016-10-14 Thread Eric Fiselier via cfe-commits
EricWF abandoned this revision. EricWF added a comment. Another fix was committed. https://reviews.llvm.org/D23524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r284230 - Disable Modules when building the libc++ sources.

2016-10-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 14 07:56:52 2016 New Revision: 284230 URL: http://llvm.org/viewvc/llvm-project?rev=284230&view=rev Log: Disable Modules when building the libc++ sources. Libc++ will not build with modules enabled. In order to support an in-tree libc++ when LLVM_ENABLE_MODULES is ON w

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

2016-10-14 Thread Eric Fiselier via cfe-commits
nguage.support/support.dynamic/new.delete/new.delete. > single/new_align_val_t_nothrow.pass.cpp > > Am I holding something wrong, or are these XFAILs wrong? > > On Fri, Oct 14, 2016 at 4:47 AM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> A

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Eric Fiselier via cfe-commits
2016 at 11:49 AM, Richard Smith wrote: > On Fri, Oct 14, 2016 at 12:49 AM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ericwf >> Date: Fri Oct 14 02:49:15 2016 >> New Revision: 284210 >> >> URL: http://llvm.

[libcxx] r284282 - Clarify XFAIL comments

2016-10-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 14 16:30:35 2016 New Revision: 284282 URL: http://llvm.org/viewvc/llvm-project?rev=284282&view=rev Log: Clarify XFAIL comments Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/delete_align_val_t_replace.pass.cpp li

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Eric Fiselier via cfe-commits
nd Clang will remove the > calls when compiling with optimizations enabled. > > On Fri, Oct 14, 2016 at 2:38 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> UBSAN may not be replacing the function, but it is doing something weird >> at th

[libcxx] r284289 - Prevent new/delete replacement tests from being optimized away.

2016-10-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Oct 14 17:47:08 2016 New Revision: 284289 URL: http://llvm.org/viewvc/llvm-project?rev=284289&view=rev Log: Prevent new/delete replacement tests from being optimized away. Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/de

Re: [libcxx] r284210 - XFAIL aligned allocation test failures with UBSAN

2016-10-14 Thread Eric Fiselier via cfe-commits
Thanks Richard. I've fixed the tests in r284289. On Fri, Oct 14, 2016 at 4:40 PM, Richard Smith wrote: > On Fri, Oct 14, 2016 at 3:34 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Oh, I have another idea: could it be that you're al

[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

2016-10-14 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Has the fix been merged into the 3.9 branch? Does re-adding this attribute mean that Clang 4.0 is required to build LLVM w/ libc++? https://reviews.llvm.org/D25624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

2016-10-15 Thread Eric Fiselier via cfe-commits
gt;> Am I holding something wrong, or are these XFAILs wrong? >> >> On Fri, Oct 14, 2016 at 4:47 AM, Eric Fiselier via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: ericwf >>> Date: Fri Oct 14 03:47:09 2016 >>>

[libcxx] r284309 - Update the status of issues

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 15:58:51 2016 New Revision: 284309 URL: http://llvm.org/viewvc/llvm-project?rev=284309&view=rev Log: Update the status of issues Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm

[libcxx] r284310 - Implement LWG2664 and update its status

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 16:29:44 2016 New Revision: 284310 URL: http://llvm.org/viewvc/llvm-project?rev=284310&view=rev Log: Implement LWG2664 and update its status Added: libcxx/trunk/test/libcxx/experimental/filesystem/class.path/path.member/ libcxx/trunk/test/libcxx/experiment

[libcxx] r284313 - Implement modified LWG 2665

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 17:37:42 2016 New Revision: 284313 URL: http://llvm.org/viewvc/llvm-project?rev=284313&view=rev Log: Implement modified LWG 2665 Modified: libcxx/trunk/include/experimental/filesystem libcxx/trunk/src/experimental/filesystem/path.cpp libcxx/trunk/test/

[libcxx] r284314 - Implement LWG 2672.

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 18:05:04 2016 New Revision: 284314 URL: http://llvm.org/viewvc/llvm-project?rev=284314&view=rev Log: Implement LWG 2672. Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.is_em

[libcxx] r284315 - Mark LWG 2680 as done

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 18:12:30 2016 New Revision: 284315 URL: http://llvm.org/viewvc/llvm-project?rev=284315&view=rev Log: Mark LWG 2680 as done Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-proje

[libcxx] r284316 - Implement LWG 2681 and 2682

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 19:29:22 2016 New Revision: 284316 URL: http://llvm.org/viewvc/llvm-project?rev=284316&view=rev Log: Implement LWG 2681 and 2682 Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.

[libcxx] r284318 - Implement LWG 2712 and update other issues status

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 19:47:59 2016 New Revision: 284318 URL: http://llvm.org/viewvc/llvm-project?rev=284318&view=rev Log: Implement LWG 2712 and update other issues status Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp libcxx/trunk/test/std/experimental/file

[libcxx] r284319 - Update notes for LWG 2678

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 19:49:33 2016 New Revision: 284319 URL: http://llvm.org/viewvc/llvm-project?rev=284319&view=rev Log: Update notes for LWG 2678 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-p

[libcxx] r284321 - Update issue status for LWG 2768 and 2769

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 20:43:43 2016 New Revision: 284321 URL: http://llvm.org/viewvc/llvm-project?rev=284321&view=rev Log: Update issue status for LWG 2768 and 2769 Added: libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/any_cast_request_invalid_value_category.fail.cpp R

[libcxx] r284322 - Update issue status for LWG 2744

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 21:51:50 2016 New Revision: 284322 URL: http://llvm.org/viewvc/llvm-project?rev=284322&view=rev Log: Update issue status for LWG 2744 Added: libcxx/trunk/test/libcxx/utilities/utility/utility.inplace/__is_inplace_tag.pass.cpp Removed: libcxx/trunk/test/li

[libcxx] r284323 - Update status for std::optional LWG issues and fix an optional SFINAE bug

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 22:21:35 2016 New Revision: 284323 URL: http://llvm.org/viewvc/llvm-project?rev=284323&view=rev Log: Update status for std::optional LWG issues and fix an optional SFINAE bug Modified: libcxx/trunk/include/experimental/optional libcxx/trunk/include/optional

[libcxx] r284324 - Update LWG 2767 and add test case

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 22:45:06 2016 New Revision: 284324 URL: http://llvm.org/viewvc/llvm-project?rev=284324&view=rev Log: Update LWG 2767 and add test case Modified: libcxx/trunk/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp libcxx/trunk/www/upcoming_meeting.h

[libcxx] r284325 - Fix use of non-constexpr C++14 addressof

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 22:49:18 2016 New Revision: 284325 URL: http://llvm.org/viewvc/llvm-project?rev=284325&view=rev Log: Fix use of non-constexpr C++14 addressof Modified: libcxx/trunk/include/experimental/optional Modified: libcxx/trunk/include/experimental/optional URL: http:/

[libcxx] r284326 - Update LWG 2754 status

2016-10-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Oct 15 22:52:48 2016 New Revision: 284326 URL: http://llvm.org/viewvc/llvm-project?rev=284326&view=rev Log: Update LWG 2754 status Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-proj

[PATCH] D25654: [Sema] Don't perform aggregate initialization for types with explicit constructors

2016-10-16 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added a reviewer: rsmith. EricWF added a subscriber: cfe-commits. The C++17 rules for aggregate initialization changed to disallow types with explicit constructors [dcl.init.aggr]p1. This patch implements that new rule. https://reviews.llvm.org/D25654 Files

[libcxx] r284333 - Make any_cast(nullptr) compile

2016-10-16 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Oct 16 06:56:38 2016 New Revision: 284333 URL: http://llvm.org/viewvc/llvm-project?rev=284333&view=rev Log: Make any_cast(nullptr) compile Modified: libcxx/trunk/include/any libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/any_cast_pointer.pass.cpp Mo

[libcxx] r318865 - [libcxx] Implement std::to_address for C++20

2017-11-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Nov 22 11:49:21 2017 New Revision: 318865 URL: http://llvm.org/viewvc/llvm-project?rev=318865&view=rev Log: [libcxx] Implement std::to_address for C++20 Summary: Now implements P0653R2 - Utility to convert to raw pointer. Reviewers: mclow.lists, EricWF Reviewed By: Eric

[libcxx] r318989 - Fix installation of cxxabi.h through libc++.

2017-11-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Nov 25 15:39:17 2017 New Revision: 318989 URL: http://llvm.org/viewvc/llvm-project?rev=318989&view=rev Log: Fix installation of cxxabi.h through libc++. Previously, the install command for the cxxabi headers specified the wrong component, and therefore they were not being

[libcxx] r309527 - Mark LWG 2961 as complete

2017-07-30 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 30 15:16:30 2017 New Revision: 309527 URL: http://llvm.org/viewvc/llvm-project?rev=309527&view=rev Log: Mark LWG 2961 as complete Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://llvm.org/viewvc/llvm-project/l

[libcxx] r309528 - Mark LWG 2942 as complete

2017-07-30 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 30 15:28:08 2017 New Revision: 309528 URL: http://llvm.org/viewvc/llvm-project?rev=309528&view=rev Log: Mark LWG 2942 as complete Modified: libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.weak/util.smartptr.weak.obs/owner_before_shared_ptr.pass

r309530 - [Sema] Fix operator lookup to consider local extern declarations.

2017-07-30 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Jul 30 17:24:28 2017 New Revision: 309530 URL: http://llvm.org/viewvc/llvm-project?rev=309530&view=rev Log: [Sema] Fix operator lookup to consider local extern declarations. Summary: Previously Clang was not considering operator declarations that occur at function scope.

r309545 - [coroutines] Evaluate the operand of void `co_return` expressions.

2017-07-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Jul 31 00:48:13 2017 New Revision: 309545 URL: http://llvm.org/viewvc/llvm-project?rev=309545&view=rev Log: [coroutines] Evaluate the operand of void `co_return` expressions. Summary: Previously Clang incorrectly ignored the expression of a void `co_return`. This patch a

[libcxx] r309917 - Add system header pragma to BSD locale fallback headers.

2017-08-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Aug 2 19:50:43 2017 New Revision: 309917 URL: http://llvm.org/viewvc/llvm-project?rev=309917&view=rev Log: Add system header pragma to BSD locale fallback headers. This prevent leaking warnings to the user about use of C++11 extensions in C++03. Modified: libcxx/tru

[libcxx] r309920 - Fix libcxx build with glibc 2.26+ by removing xlocale.h include.

2017-08-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Aug 2 21:28:10 2017 New Revision: 309920 URL: http://llvm.org/viewvc/llvm-project?rev=309920&view=rev Log: Fix libcxx build with glibc 2.26+ by removing xlocale.h include. Patch by Khem Raj. Reviewed as D35697. Also see PR33729. Modified: libcxx/trunk/include/__loc

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

2017-08-17 Thread Eric Fiselier via cfe-commits
probably shouldn't merge this then. On Aug 17, 2017 4:54 PM, "Petr Hosek via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > This broke our build of WebKit with the following build failure: > > ../../buildtools/linux-x64/clang/bin/clang++ -MD -MF > obj/apps/web_view/web_view_test.test_webview

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

2017-08-18 Thread Eric Fiselier via cfe-commits
I'm OK merging it then. On Fri, Aug 18, 2017 at 2:32 PM, Hans Wennborg wrote: > Eric, sounds like there are no known issues with this, then. What do > you think about merging it? > > On Thu, Aug 17, 2017 at 5:30 PM, Petr Hosek wrote: > > Confirmed, this changes is harmless. The failure we're se

Re: [PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

2020-03-11 Thread Eric Fiselier via cfe-commits
On Wed, Mar 11, 2020 at 8:35 PM Arthur O'Dwyer via Phabricator < revi...@reviews.llvm.org> wrote: > Quuxplusone added inline comments. > > > > Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:27 > +class UnintendedADLCheck : public ClangTidyCheck { > + const

[clang-tools-extra] 020ed67 - [clang-tidy] Fix check for Abseil internal namespace access

2020-01-21 Thread Eric Fiselier via cfe-commits
Author: Eric Fiselier Date: 2020-01-21T15:21:53-05:00 New Revision: 020ed6713d889a95f8c98d7725c87b458d99f6b3 URL: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3 DIFF: https://github.com/llvm/llvm-project/commit/020ed6713d889a95f8c98d7725c87b458d99f6b3.diff

r328134 - [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

2018-03-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Mar 21 12:19:48 2018 New Revision: 328134 URL: http://llvm.org/viewvc/llvm-project?rev=328134&view=rev Log: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions. Summary: Libc++'s default allocator uses `__built

[libcxx] r328180 - Fix PR22634 - std::allocator doesn't respect over-aligned types.

2018-03-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Mar 21 21:42:56 2018 New Revision: 328180 URL: http://llvm.org/viewvc/llvm-project?rev=328180&view=rev Log: Fix PR22634 - std::allocator doesn't respect over-aligned types. This patch fixes std::allocator, and more specifically, all users of __libcpp_allocate and __libcpp

[libcxx] r328182 - Fix dynarray test failures after changing __libcpp_allocate/deallocate

2018-03-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Mar 21 22:44:48 2018 New Revision: 328182 URL: http://llvm.org/viewvc/llvm-project?rev=328182&view=rev Log: Fix dynarray test failures after changing __libcpp_allocate/deallocate Modified: libcxx/trunk/include/experimental/dynarray Modified: libcxx/trunk/include/expe

[libcxx] r328185 - Correct TEST_HAS_NO_ALIGNED_ALLOCATION macro definition

2018-03-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Mar 21 23:21:07 2018 New Revision: 328185 URL: http://llvm.org/viewvc/llvm-project?rev=328185&view=rev Log: Correct TEST_HAS_NO_ALIGNED_ALLOCATION macro definition Modified: libcxx/trunk/test/support/test_macros.h Modified: libcxx/trunk/test/support/test_macros.h URL

[libcxx] r328186 - commit temporary workaround for new Clang exception warning

2018-03-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Mar 22 00:53:47 2018 New Revision: 328186 URL: http://llvm.org/viewvc/llvm-project?rev=328186&view=rev Log: commit temporary workaround for new Clang exception warning Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.

Re: r328134 - [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

2018-03-22 Thread Eric Fiselier via cfe-commits
; > Galina > > > On Wed, Mar 21, 2018 at 12:19 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ericwf >> Date: Wed Mar 21 12:19:48 2018 >> New Revision: 328134 >> >> URL: http://llvm.org/viewvc/llvm-pr

[libcxx] r328229 - Un-XFAIL a test under new GCC version; the GCC bug has been fixed

2018-03-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Mar 22 12:18:08 2018 New Revision: 328229 URL: http://llvm.org/viewvc/llvm-project?rev=328229&view=rev Log: Un-XFAIL a test under new GCC version; the GCC bug has been fixed Modified: libcxx/trunk/test/std/utilities/function.objects/comparisons/constexpr_init.pass.cp

Re: r328134 - [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

2018-03-22 Thread Eric Fiselier via cfe-commits
SemaCXX/builtin-operator-new-delete.cpp >> >> Please have a look? >> >> It is not good idea to keep the bot red for too long. This hides new >> problem which later hard to track down. >> >> Thanks >> >> Galina >> >> >> On We

r328243 - Fix test failure on Windows caused by different underlying enumeration type rules

2018-03-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Mar 22 14:17:07 2018 New Revision: 328243 URL: http://llvm.org/viewvc/llvm-project?rev=328243&view=rev Log: Fix test failure on Windows caused by different underlying enumeration type rules Modified: cfe/trunk/test/SemaCXX/builtin-operator-new-delete.cpp Modified: c

[libcxx] r328245 - Use DoNotOptimize to prevent new/delete elision.

2018-03-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Mar 22 14:28:09 2018 New Revision: 328245 URL: http://llvm.org/viewvc/llvm-project?rev=328245&view=rev Log: Use DoNotOptimize to prevent new/delete elision. The new/delete tests, in particular those which test replacement functions, often fail when the optimizer is enable

[libcxx] r328261 - Workaround GCC bug PR78489 - SFINAE order is not respected.

2018-03-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Mar 22 15:32:55 2018 New Revision: 328261 URL: http://llvm.org/viewvc/llvm-project?rev=328261&view=rev Log: Workaround GCC bug PR78489 - SFINAE order is not respected. This patch works around variant test failures which are new to GCC 8. GCC 8 either doesn't perform SFINA

[libcxx] r328265 - Avoid Clang error about throwing _LIBCPP_ASSERT in noexcept function.

2018-03-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Mar 22 16:01:08 2018 New Revision: 328265 URL: http://llvm.org/viewvc/llvm-project?rev=328265&view=rev Log: Avoid Clang error about throwing _LIBCPP_ASSERT in noexcept function. This fixes a couple of tests which produced a warning that a 'throw' occurred in a noexcept fu

[libcxx] r328268 - Add temporary printouts to test to help debug failures.

2018-03-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Mar 22 16:14:20 2018 New Revision: 328268 URL: http://llvm.org/viewvc/llvm-project?rev=328268&view=rev Log: Add temporary printouts to test to help debug failures. Some debian libc++ bots started having failures in the locale tests due to what I assume is a change in the

[libcxx] r328388 - Partially Revert "Workaround GCC bug PR78489 - SFINAE order is not respected."

2018-03-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 23 16:42:30 2018 New Revision: 328388 URL: http://llvm.org/viewvc/llvm-project?rev=328388&view=rev Log: Partially Revert "Workaround GCC bug PR78489 - SFINAE order is not respected." This partially reverts commit r328261. The GCC bug has been fixed in trunk and has ne

Re: [libcxx] r328245 - Use DoNotOptimize to prevent new/delete elision.

2018-03-24 Thread Eric Fiselier via cfe-commits
cpp > > For the same reason : new optimized away. > > > On Thu, Mar 22, 2018 at 5:28 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ericwf >> Date: Thu Mar 22 14:28:09 2018 >> New Revision: 328245 >> >

[libcxx] r328445 - avoid new/delete ellision in construct.pass.cpp

2018-03-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Mar 24 20:00:42 2018 New Revision: 328445 URL: http://llvm.org/viewvc/llvm-project?rev=328445&view=rev Log: avoid new/delete ellision in construct.pass.cpp Modified: libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.members/construct.pass.cpp Modifi

Re: [libcxx] r328245 - Use DoNotOptimize to prevent new/delete elision.

2018-03-24 Thread Eric Fiselier via cfe-commits
I am seeing failure on this test too. >>> test\std\utilities\memory\default.allocator\allocator.member >>> s\construct.pass.cpp >>> >>> For the same reason : new optimized away. >>> >>> >>> On Thu, Mar 22, 2018 at 5:28 PM, Eric Fiseli

[libcxx] r328476 - Implement filesystem::perm_options specified in NB comments.

2018-03-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Mar 25 23:23:55 2018 New Revision: 328476 URL: http://llvm.org/viewvc/llvm-project?rev=328476&view=rev Log: Implement filesystem::perm_options specified in NB comments. The NB comments for filesystem changed permissions and added a new enum `perm_options` which control ho

[libcxx] r328477 - Fix test case initialization issues in permissions test

2018-03-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Mar 26 00:06:25 2018 New Revision: 328477 URL: http://llvm.org/viewvc/llvm-project?rev=328477&view=rev Log: Fix test case initialization issues in permissions test Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.permissions/permissions.pass.

r328602 - Fix unused expression warning in co_await.

2018-03-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Mar 26 17:58:16 2018 New Revision: 328602 URL: http://llvm.org/viewvc/llvm-project?rev=328602&view=rev Log: Fix unused expression warning in co_await. Previously, anytime the result of the resume expression in operator co_await was unused, a warning was generated. This pa

r328606 - [coroutines] Fix invalid source range in co_await call expressions.

2018-03-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Mar 26 20:15:46 2018 New Revision: 328606 URL: http://llvm.org/viewvc/llvm-project?rev=328606&view=rev Log: [coroutines] Fix invalid source range in co_await call expressions. Summary: Currently an invalid source range is generated for the member call expressions of `co_

r328607 - [coroutines] Fix unused warning on result of co_yield.

2018-03-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Mar 26 20:33:06 2018 New Revision: 328607 URL: http://llvm.org/viewvc/llvm-project?rev=328607&view=rev Log: [coroutines] Fix unused warning on result of co_yield. This patch follows up on r328602, which fixed the spurious unused result warning for `co_await`. Modified:

[libcxx] r328751 - Fix PR36914 - num_get::get(unsigned) incorrectly handles negative numbers.

2018-03-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Mar 28 18:18:53 2018 New Revision: 328751 URL: http://llvm.org/viewvc/llvm-project?rev=328751&view=rev Log: Fix PR36914 - num_get::get(unsigned) incorrectly handles negative numbers. This patch corrects num_get for unsigned types to support strings with a leading `-` char

[libcxx] r328758 - Move libc++ pair/tuple assign test to libcxx/ test directory.

2018-03-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Mar 28 20:30:00 2018 New Revision: 328758 URL: http://llvm.org/viewvc/llvm-project?rev=328758&view=rev Log: Move libc++ pair/tuple assign test to libcxx/ test directory. Libc++ implements the pair& operator=(pair) assignment operator using a single template that handles a

[libcxx] r328760 - fix typo in align_const_pair_U_V.pass.cpp

2018-03-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Mar 28 20:44:01 2018 New Revision: 328760 URL: http://llvm.org/viewvc/llvm-project?rev=328760&view=rev Log: fix typo in align_const_pair_U_V.pass.cpp Modified: libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/assign_const_pair_U_V.pass.cpp Modified: libcxx/

r328923 - Add missing include to Visibility.h

2018-03-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Mar 31 17:31:14 2018 New Revision: 328923 URL: http://llvm.org/viewvc/llvm-project?rev=328923&view=rev Log: Add missing include to Visibility.h Modified: cfe/trunk/include/clang/Basic/Visibility.h Modified: cfe/trunk/include/clang/Basic/Visibility.h URL: http://llvm

r328924 - Add missing include to ContinuousRangeMap.h

2018-03-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Mar 31 17:33:51 2018 New Revision: 328924 URL: http://llvm.org/viewvc/llvm-project?rev=328924&view=rev Log: Add missing include to ContinuousRangeMap.h Modified: cfe/trunk/include/clang/Serialization/ContinuousRangeMap.h Modified: cfe/trunk/include/clang/Serializatio

[libcxx] r329031 - Implement P0430R2 - File system library on non-POSIX systems.

2018-04-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 2 16:35:24 2018 New Revision: 329031 URL: http://llvm.org/viewvc/llvm-project?rev=329031&view=rev Log: Implement P0430R2 - File system library on non-POSIX systems. This patch implements P0430R2, who's largest change is adding the path::format enumeration for support

[libcxx] r329038 - Fix fs::proximate tests on platforms where /net exists.

2018-04-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 2 18:52:12 2018 New Revision: 329038 URL: http://llvm.org/viewvc/llvm-project?rev=329038&view=rev Log: Fix fs::proximate tests on platforms where /net exists. The proximate tests depended on `/net` not being a valid path, however, on OS X it is. Correct the tests to

[libcxx] r329143 - Fix locale test data for GLIBC 2.27 and newer.

2018-04-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 3 21:00:14 2018 New Revision: 329143 URL: http://llvm.org/viewvc/llvm-project?rev=329143&view=rev Log: Fix locale test data for GLIBC 2.27 and newer. GLIBC 2.27 changed the locale data for fr_FR and ru_RU. In particular they change the decimal and thousands separator

[libcxx] r329144 - Touch up tests for new header; fix module.modulemap.

2018-04-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 3 21:21:54 2018 New Revision: 329144 URL: http://llvm.org/viewvc/llvm-project?rev=329144&view=rev Log: Touch up tests for new header; fix module.modulemap. This patch does some housekeeping for the new header. It adds it to the module.modulemap, and the double_incl

[libcxx] r329145 - Update Clang version on Appveyor bots

2018-04-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 3 21:33:09 2018 New Revision: 329145 URL: http://llvm.org/viewvc/llvm-project?rev=329145&view=rev Log: Update Clang version on Appveyor bots Modified: libcxx/trunk/appveyor-reqs-install.cmd Modified: libcxx/trunk/appveyor-reqs-install.cmd URL: http://llvm.org/v

[libcxx] r329148 - Fix undefined macro issue in locale tests

2018-04-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 3 21:39:38 2018 New Revision: 329148 URL: http://llvm.org/viewvc/llvm-project?rev=329148&view=rev Log: Fix undefined macro issue in locale tests Modified: libcxx/trunk/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/decimal_poi

[libcxx] r329149 - Fix undefined macro issue in locale tests; Try 2

2018-04-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 3 21:48:26 2018 New Revision: 329149 URL: http://llvm.org/viewvc/llvm-project?rev=329149&view=rev Log: Fix undefined macro issue in locale tests; Try 2 Modified: libcxx/trunk/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money

r329151 - Fix typo in ASTStructuralEquivalence.cpp for UnaryTransform types.

2018-04-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 3 23:31:21 2018 New Revision: 329151 URL: http://llvm.org/viewvc/llvm-project?rev=329151&view=rev Log: Fix typo in ASTStructuralEquivalence.cpp for UnaryTransform types. Previously UnaryTransformType nodes were comparing the same node for structural equivalence. This

[libcxx] r329460 - Implement P0768r1: Library support for the Spaceship Operator.

2018-04-06 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Apr 6 14:37:23 2018 New Revision: 329460 URL: http://llvm.org/viewvc/llvm-project?rev=329460&view=rev Log: Implement P0768r1: Library support for the Spaceship Operator. this patch adds the header and implements all of it except for [comp.alg]. As I understand it, the

[libcxx] r329474 - Work around missing braces in init warning

2018-04-06 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Apr 6 18:28:54 2018 New Revision: 329474 URL: http://llvm.org/viewvc/llvm-project?rev=329474&view=rev Log: Work around missing braces in init warning Modified: libcxx/trunk/include/compare Modified: libcxx/trunk/include/compare URL: http://llvm.org/viewvc/llvm-proj

[libcxx] r329484 - Use void() to create a void expression type

2018-04-06 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Apr 6 21:28:11 2018 New Revision: 329484 URL: http://llvm.org/viewvc/llvm-project?rev=329484&view=rev Log: Use void() to create a void expression type Modified: libcxx/trunk/include/compare Modified: libcxx/trunk/include/compare URL: http://llvm.org/viewvc/llvm-pro

r329517 - [Sema] Fix PR22637 - IndirectFieldDecl's discard qualifiers during template instantiation.

2018-04-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 7 22:11:59 2018 New Revision: 329517 URL: http://llvm.org/viewvc/llvm-project?rev=329517&view=rev Log: [Sema] Fix PR22637 - IndirectFieldDecl's discard qualifiers during template instantiation. Summary: Currently Clang fails to propagate qualifiers from the `CXXThis

r329518 - [Sema] Remove dead code in BuildAnonymousStructUnionMemberReference. NFCI

2018-04-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 7 22:12:55 2018 New Revision: 329518 URL: http://llvm.org/viewvc/llvm-project?rev=329518&view=rev Log: [Sema] Remove dead code in BuildAnonymousStructUnionMemberReference. NFCI Summary: This patch cleans up a bunch of dead or unused code in BuildAnonymousStructUnion

r329519 - [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

2018-04-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 7 22:50:01 2018 New Revision: 329519 URL: http://llvm.org/viewvc/llvm-project?rev=329519&view=rev Log: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases. Summary: Currently clang doesn't do qualified lookup when building indirect fi

r329520 - Revert "[Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases."

2018-04-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 7 23:05:33 2018 New Revision: 329520 URL: http://llvm.org/viewvc/llvm-project?rev=329520&view=rev Log: Revert "[Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases." This reverts commit r329519. There are some unaddressed test failures

r329521 - [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases.

2018-04-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 7 23:21:33 2018 New Revision: 329521 URL: http://llvm.org/viewvc/llvm-project?rev=329521&view=rev Log: [Sema] Fix PR35832 - Ambiguity accessing anonymous struct/union with multiple bases. Summary: Currently clang doesn't do qualified lookup when building indirect fi

[libcxx] r329541 - [test] Fix Container::insert(value_type const&) tests

2018-04-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Apr 8 14:57:35 2018 New Revision: 329541 URL: http://llvm.org/viewvc/llvm-project?rev=329541&view=rev Log: [test] Fix Container::insert(value_type const&) tests Patch from Joe Loser. Several unit tests meaning to test the behavior of lvalue insertion incorrectly pass rv

[libcxx] r316939 - Fix PR35078 - recursive directory iterator's increment method throws incorrectly.

2017-10-30 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Oct 30 11:43:21 2017 New Revision: 316939 URL: http://llvm.org/viewvc/llvm-project?rev=316939&view=rev Log: Fix PR35078 - recursive directory iterator's increment method throws incorrectly. The guts of the increment method for recursive_directory_iterator was failing to

[libcxx] r316941 - Implement LWG 3013 - some filesystem members should not be noexcept.

2017-10-30 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Oct 30 11:59:59 2017 New Revision: 316941 URL: http://llvm.org/viewvc/llvm-project?rev=316941&view=rev Log: Implement LWG 3013 - some filesystem members should not be noexcept. LWG 3013 points out that the constructors and increment members of the directory iterators need

[libcxx] r317610 - Change test suite to support c++17 dialect flag instead of c++1z.

2017-11-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Nov 7 12:20:58 2017 New Revision: 317610 URL: http://llvm.org/viewvc/llvm-project?rev=317610&view=rev Log: Change test suite to support c++17 dialect flag instead of c++1z. This patch changes the test suite to attempt and prefer -std=c++17 over -std=c++1z. It also fixes

[libcxx] r317611 - Teach test suite about C++2a dialect flag.

2017-11-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Nov 7 12:26:23 2017 New Revision: 317611 URL: http://llvm.org/viewvc/llvm-project?rev=317611&view=rev Log: Teach test suite about C++2a dialect flag. This patch teaches the test suite configuration about the -std=c++2a flag. And, since it's the newest dialect, change the

[libcxx] r318247 - Update Appveyor LLVM install link to be current and non-broken

2017-11-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Nov 14 17:37:11 2017 New Revision: 318247 URL: http://llvm.org/viewvc/llvm-project?rev=318247&view=rev Log: Update Appveyor LLVM install link to be current and non-broken Modified: libcxx/trunk/appveyor-reqs-install.cmd Modified: libcxx/trunk/appveyor-reqs-install.cm

[libcxx] r318618 - Fix nodiscard test when modules are enabled

2017-11-18 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Nov 18 19:50:35 2017 New Revision: 318618 URL: http://llvm.org/viewvc/llvm-project?rev=318618&view=rev Log: Fix nodiscard test when modules are enabled Modified: libcxx/trunk/test/libcxx/diagnostics/nodiscard.pass.cpp Modified: libcxx/trunk/test/libcxx/diagnostics/no

[libcxx] r318621 - [libc++] Shrink variant's index type when possible

2017-11-18 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Nov 18 20:19:44 2017 New Revision: 318621 URL: http://llvm.org/viewvc/llvm-project?rev=318621&view=rev Log: [libc++] Shrink variant's index type when possible Summary: Currently `std::variant` always uses an unsigned int to store the variant index. However this isn't nes

[libcxx] r318622 - Fix min/max usage in variant

2017-11-18 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Nov 18 20:57:22 2017 New Revision: 318622 URL: http://llvm.org/viewvc/llvm-project?rev=318622&view=rev Log: Fix min/max usage in variant Modified: libcxx/trunk/include/variant Modified: libcxx/trunk/include/variant URL: http://llvm.org/viewvc/llvm-project/libcxx/tru

[libcxx] r318625 - Attempt to fix template depth test failures on older Clang versions

2017-11-19 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Nov 19 01:46:34 2017 New Revision: 318625 URL: http://llvm.org/viewvc/llvm-project?rev=318625&view=rev Log: Attempt to fix template depth test failures on older Clang versions Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test

[libcxx] r318690 - Fix std::string::data() symbol during library build.

2017-11-20 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Nov 20 12:23:27 2017 New Revision: 318690 URL: http://llvm.org/viewvc/llvm-project?rev=318690&view=rev Log: Fix std::string::data() symbol during library build. The non-const data() member of std::string is only exposed in C++17 and beyond. However std::string is external

<    1   2   3   4   5   6   7   8   9   10   >