gt;>> wrote:
>>>>>
>>>>>> Hey Eric - thanks for the fix - but could you explain the issue here
>>>>>> in a bit more detail, as I'm a bit confused (& really interested in
>>>>>> understanding any layering problems
On Thu, Oct 4, 2018 at 11:42 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Perhaps libc++ could provide a __version file that contains the headers,
> and use #include <__version> internally? We'd still need a header
> that just includes <__version> for conformance, but t
Author: ericwf
Date: Fri Feb 1 13:19:20 2019
New Revision: 352919
URL: http://llvm.org/viewvc/llvm-project?rev=352919&view=rev
Log:
Don't use ASTContext in DeclOpenMP.h because it's still incomplete.
Modified:
cfe/trunk/include/clang/AST/DeclOpenMP.h
cfe/trunk/lib/AST/DeclOpenMP.cpp
Mod
Author: ericwf
Date: Fri Feb 1 14:06:02 2019
New Revision: 352927
URL: http://llvm.org/viewvc/llvm-project?rev=352927&view=rev
Log:
Improve diagnostic to tell you a type is incomplete.
I recently ran into this code:
```
\#include
void foo(const std::string &s, const std::string& = "");
\#includ
Author: ericwf
Date: Sat Feb 2 19:44:31 2019
New Revision: 352980
URL: http://llvm.org/viewvc/llvm-project?rev=352980&view=rev
Log:
Fix handling of usual deallocation functions in various configuratios.
Clang allows users to enable or disable various types of allocation
and deallocation regardle
Author: ericwf
Date: Sat Feb 2 20:10:38 2019
New Revision: 352983
URL: http://llvm.org/viewvc/llvm-project?rev=352983&view=rev
Log:
Correct test my *really really* overaligning a type.
Modified:
cfe/trunk/test/SemaCXX/extended-usual-deallocation-functions.cpp
Modified: cfe/trunk/test/SemaCX
Author: ericwf
Date: Sun Sep 10 16:12:33 2017
New Revision: 312890
URL: http://llvm.org/viewvc/llvm-project?rev=312890&view=rev
Log:
Fix PR34298 - Allow std::function with an incomplete return type.
This patch fixes llvm.org/PR34298. Previously libc++ incorrectly evaluated
the __invokable trait v
Author: ericwf
Date: Sun Sep 10 16:37:47 2017
New Revision: 312891
URL: http://llvm.org/viewvc/llvm-project?rev=312891&view=rev
Log:
Revert "Fix PR34298 - Allow std::function with an incomplete return type."
This reverts commit r312890 because the test case fails to compile for
older versions of
Author: ericwf
Date: Sun Sep 10 16:41:20 2017
New Revision: 312892
URL: http://llvm.org/viewvc/llvm-project?rev=312892&view=rev
Log:
Fix PR34298 - Allow std::function with an incomplete return type.
This patch fixes llvm.org/PR34298. Previously libc++ incorrectly evaluated
the __invokable trait v
On Wed, Sep 13, 2017 at 1:02 PM, Richard Smith
wrote:
> On 13 October 2015 at 15:12, Eric Fiselier via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: ericwf
>> Date: Tue Oct 13 17:12:02 2015
>> New Revision: 250235
>>
>> URL: http:/
Author: ericwf
Date: Thu Sep 14 15:19:28 2017
New Revision: 313304
URL: http://llvm.org/viewvc/llvm-project?rev=313304&view=rev
Log:
[libc++abi] Fix ASAN build with older compiler-rt versions.
Summary:
compiler-rt recently added the `__asan_handle_no_return()` function that
libc++abi needs to us
Author: ericwf
Date: Thu Sep 14 15:37:34 2017
New Revision: 313308
URL: http://llvm.org/viewvc/llvm-project?rev=313308&view=rev
Log:
Fix ASAN build with older compiler-rt versions.
compiler-rt recently added the __asan_handle_no_return() function that libc++abi
needs to use, however older version
Author: ericwf
Date: Thu Sep 14 17:31:38 2017
New Revision: 313324
URL: http://llvm.org/viewvc/llvm-project?rev=313324&view=rev
Log:
Fix accidental ADL in std::allocator_traits meta-programming.
There were a number of cases where __double_underscore functions,
for example __has_construct_test, we
I'll correct them.
/Eric
On Sat, Sep 16, 2017 at 6:28 PM, Richard Smith
wrote:
> This is a bug in the libc++ tests. It's OK for them to check that the
> static_assert message is produced, but not that they're prefixed with the
> exact string "static_assert failed:".
>
> On 16 September 2017 at
Author: ericwf
Date: Sun Sep 17 13:57:05 2017
New Revision: 313499
URL: http://llvm.org/viewvc/llvm-project?rev=313499&view=rev
Log:
Fix failing -verify tests due to change in Clangs static_assert message.
Clang recently changed the way it outputs static assert diagnostics.
This patch fixes libc+
Fixed in r313499.
/Eric
On Sun, Sep 17, 2017 at 2:04 PM, Eric Fiselier wrote:
> I'll correct them.
>
> /Eric
>
> On Sat, Sep 16, 2017 at 6:28 PM, Richard Smith
> wrote:
>
>> This is a bug in the libc++ tests. It's OK for them to check that the
>> static_assert message is produced, but not that
Author: ericwf
Date: Sun Sep 17 13:59:43 2017
New Revision: 313500
URL: http://llvm.org/viewvc/llvm-project?rev=313500&view=rev
Log:
ABI: Fix for undefined "___cxa_deleted_virtual" symbol in MacOSX
Patch from Eddie Elizondo. Reviewed as D37830 (https://reviews.llvm.org/D37830).
On MacOSX the fol
Author: ericwf
Date: Sun Sep 17 14:00:27 2017
New Revision: 313501
URL: http://llvm.org/viewvc/llvm-project?rev=313501&view=rev
Log:
Update changelog revision
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT
URL:
http://llvm.org/viewvc/llvm-project/l
Author: ericwf
Date: Sun Sep 17 14:50:59 2017
New Revision: 313502
URL: http://llvm.org/viewvc/llvm-project?rev=313502&view=rev
Log:
Fix two failing -verify tests to tolerate old and new clang versions
Modified:
libcxx/trunk/test/std/utilities/any/any.nonmembers/any.cast/const_correctness.fa
Author: ericwf
Date: Mon Sep 18 15:01:18 2017
New Revision: 313576
URL: http://llvm.org/viewvc/llvm-project?rev=313576&view=rev
Log:
Fix failing ASAN test
Modified:
libcxx/trunk/test/libcxx/language.support/cxa_deleted_virtual.pass.cpp
Modified: libcxx/trunk/test/libcxx/language.support/cxa_
Author: ericwf
Date: Mon Jul 29 14:38:56 2019
New Revision: 367263
URL: http://llvm.org/viewvc/llvm-project?rev=367263&view=rev
Log:
[clang-tidy]: Google: new check 'google-upgrade-googletest-case'
Introduce a new check to upgrade user code based on API changes in Googletest.
The check finds use
Author: ericwf
Date: Thu May 16 14:04:15 2019
New Revision: 360937
URL: http://llvm.org/viewvc/llvm-project?rev=360937&view=rev
Log:
Implement __builtin_LINE() et. al. to support source location capture.
Summary:
This patch implements the source location builtins `__builtin_LINE(),
`__builtin_FU
Author: ericwf
Date: Thu May 16 14:51:39 2019
New Revision: 360943
URL: http://llvm.org/viewvc/llvm-project?rev=360943&view=rev
Log:
Fix PCC test failures for source location builtins
Modified:
cfe/trunk/test/CodeGenCXX/builtin-source-location.cpp
cfe/trunk/test/CodeGenCXX/builtin_LINE.cp
Author: ericwf
Date: Thu May 16 15:21:42 2019
New Revision: 360947
URL: http://llvm.org/viewvc/llvm-project?rev=360947&view=rev
Log:
Fix failing source location test on Windows
Modified:
cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp
Modified: cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp
U
Author: ericwf
Date: Thu May 16 16:07:45 2019
New Revision: 360951
URL: http://llvm.org/viewvc/llvm-project?rev=360951&view=rev
Log:
Remove unneeded alignment spec from builtin_FUNCTION.cpp test
Modified:
cfe/trunk/test/CodeGenCXX/builtin_FUNCTION.cpp
Modified: cfe/trunk/test/CodeGenCXX/buil
Author: ericwf
Date: Thu May 23 16:34:43 2019
New Revision: 361571
URL: http://llvm.org/viewvc/llvm-project?rev=361571&view=rev
Log:
Fix hang during constant evaluation of union assignment.
HandleUnionActiveMemberChange forgot to walk over a nop implicit
conversion node and got stuck in the proce
The alignment check can just be removed.
On Mon., May 27, 2019, 7:57 p.m. Ulrich Weigand via Phabricator, <
revi...@reviews.llvm.org> wrote:
> uweigand added a comment.
>
> Looks like this test is failing on SystemZ since it was added, making all
> our build bots red:
>
>
> /home/uweigand/sandbox
* The alignment check can be removed, and I'll do so tomorrow if someone
doesn't beat me to it.
On Tue, May 28, 2019 at 1:54 AM Eric Fiselier wrote:
> The alignment check can just be removed.
>
> On Mon., May 27, 2019, 7:57 p.m. Ulrich Weigand via Phabricator, <
> revi...@reviews.llvm.org> wrote
Author: ericwf
Date: Tue May 28 20:15:36 2019
New Revision: 361920
URL: http://llvm.org/viewvc/llvm-project?rev=361920&view=rev
Log:
Make __has_builtin work with __builtin_LINE and friends.
The source location builtins are implemented as keywords, but
__has_builtin should still report true for th
Author: ericwf
Date: Wed Dec 12 13:50:55 2018
New Revision: 348977
URL: http://llvm.org/viewvc/llvm-project?rev=348977&view=rev
Log:
[AST] Store "UsesADL" information in CallExpr.
Summary:
Currently the Clang AST doesn't store information about how the callee of a
CallExpr was found. Specificall
Author: ericwf
Date: Fri Dec 14 13:11:28 2018
New Revision: 349195
URL: http://llvm.org/viewvc/llvm-project?rev=349195&view=rev
Log:
[Clang] Add __builtin_launder
Summary:
This patch adds `__builtin_launder`, which is required to implement
`std::launder`. Additionally GCC provides `__builtin_lau
Woops. Submitted that last comment too early. Editing it on Phab.
On Fri, May 4, 2018 at 2:31 AM, Eric Fiselier via Phabricator <
revi...@reviews.llvm.org> wrote:
> EricWF added a comment.
>
> In https://reviews.llvm.org/D45476#1087446, @cfe-commits wrote:
>
> > I think you and Richard agreed tha
Author: ericwf
Date: Mon May 7 16:15:34 2018
New Revision: 331697
URL: http://llvm.org/viewvc/llvm-project?rev=331697&view=rev
Log:
Fix failing codegen test on non-x86_64 platforms
Modified:
cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp
Modified: cfe/trunk/test/CodeGenCXX/cxx2a-compare.cpp
UR
Author: ericwf
Date: Mon May 7 17:52:19 2018
New Revision: 331707
URL: http://llvm.org/viewvc/llvm-project?rev=331707&view=rev
Log:
[C++2a] Implement operator<=>: Address bugs and post-commit review comments
after r331677.
This patch addresses some mostly trivial post-commit review comments rec
Author: ericwf
Date: Mon May 7 19:28:47 2018
New Revision: 331713
URL: http://llvm.org/viewvc/llvm-project?rev=331713&view=rev
Log:
[C++2a] operator<=>: Fix incorrect use of Twine.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp
URL:
http://llvm.or
Author: ericwf
Date: Tue May 8 00:56:05 2018
New Revision: 331745
URL: http://llvm.org/viewvc/llvm-project?rev=331745&view=rev
Log:
[C++2a] Implement operator<=>: Fix another bug in the code gen tests.
Sorry for the failures. I'm quite new at writing code gen tests, and
I'm not sure the best way
Author: ericwf
Date: Wed Jul 4 04:14:18 2018
New Revision: 336261
URL: http://llvm.org/viewvc/llvm-project?rev=336261&view=rev
Log:
Add missing include for size_t
Modified:
cfe/trunk/include/clang/Basic/Stack.h
Modified: cfe/trunk/include/clang/Basic/Stack.h
URL:
http://llvm.org/viewvc/llv
Author: ericwf
Date: Wed Jul 4 13:16:05 2018
New Revision: 336297
URL: http://llvm.org/viewvc/llvm-project?rev=336297&view=rev
Log:
Remove old workaround that is no longer needed
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http
Author: ericwf
Date: Mon Jul 9 21:11:22 2018
New Revision: 336636
URL: http://llvm.org/viewvc/llvm-project?rev=336636&view=rev
Log:
Add new string benchmarks
Modified:
libcxx/trunk/benchmarks/string.bench.cpp
Modified: libcxx/trunk/benchmarks/string.bench.cpp
URL:
http://llvm.org/viewvc/ll
Author: ericwf
Date: Tue Jul 10 06:25:26 2018
New Revision: 33
URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev
Log:
Remove BUILD file from google-benchmark
Removed:
libcxx/trunk/utils/google-benchmark/test/BUILD
Removed: libcxx/trunk/utils/google-benchmark/test/BUILD
URL:
h
Author: ericwf
Date: Mon Jul 16 13:01:59 2018
New Revision: 337205
URL: http://llvm.org/viewvc/llvm-project?rev=337205&view=rev
Log:
Fix PR38160 - init_priority attribute not supported by GCC on Apple.
This patch guards the use of __attribute__((init_priority(101)))
within memory_resource.cpp whe
Author: ericwf
Date: Mon Jul 16 22:48:48 2018
New Revision: 337235
URL: http://llvm.org/viewvc/llvm-project?rev=337235&view=rev
Log:
Address "always inline function is not always inlinable" warning with GCC.
When an always_inline function is used prior to the functions definition,
the compiler ma
Author: Eric Fiselier
Date: 2020-04-16T18:38:32-04:00
New Revision: af2968e37f4c95846ffe287b64a4fcd72c765bee
URL:
https://github.com/llvm/llvm-project/commit/af2968e37f4c95846ffe287b64a4fcd72c765bee
DIFF:
https://github.com/llvm/llvm-project/commit/af2968e37f4c95846ffe287b64a4fcd72c765bee.diff
EricWF added inline comments.
Comment at: include/__config:340
@@ -339,3 +344,1 @@
#if !defined(_LIBCPP_HAS_MUSL_LIBC)
-# include
-#if __GLIBC_PREREQ(2, 15)
What happened to this include? I believe it's needed to get `__GLIBC_PREREQ`.
Repository:
rL LLVM
ht
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
In https://reviews.llvm.org/D18639#514991, @hfinkel wrote:
> In https://reviews.llvm.org/D18639#491232, @mclow.lists wrote:
>
> > And is there any reason why `__libcpp_isinf` can't just
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing the MUSL libc comment.
Comment at: include/__config:90
@@ +89,3 @@
+#if defined(__linux__)
+#include
+#if !defined(__GLIBC_PREREQ)
Does
I'll look at these first thing next week. If you remember please ping me.
(It's Cppcon this week)
Sorry I haven't reviewed this already. Thank you for working on this.
On Sep 18, 2016 11:55 PM, "Igor Kudrin" wrote:
> ikudrin added a comment.
>
> Hi,
>
> Ping.
>
> The patch is under review for a
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'll take your word for it. Thanks for the patch.
https://reviews.llvm.org/D24879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
Libc++ still uses per-feature configuration macros when configuring for C++11.
However libc++ requires a feature-complete C++11 compiler so there is no reason
to check individual features.
Author: ericwf
Date: Sat Sep 24 22:14:13 2016
New Revision: 282345
URL: http://llvm.org/viewvc/llvm-project?rev=282345&view=rev
Log:
Use __attribute__((internal_linkage)) when available.
Summary:
This patch has been a long time coming (Thanks @eugenis). It changes
`_LIBCPP_INLINE_VISIBILITY` to
EricWF updated this revision to Diff 72410.
EricWF added a comment.
Actually remove _LIBCPP_HAS_NO_STATIC_ASSERT.
https://reviews.llvm.org/D24895
Files:
include/__config
include/iterator
include/memory
include/ratio
include/scoped_allocator
include/type_traits
src/string.cpp
tes
EricWF updated this revision to Diff 72411.
EricWF added a comment.
Fix merge conflicts.
https://reviews.llvm.org/D24895
Files:
include/__config
include/iterator
include/memory
include/ratio
include/scoped_allocator
include/type_traits
test/std/containers/associative/map/map.cons/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282347: [libc++] Remove various C++03 feature test macros
(authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D24895?vs=72411&id=72412#toc
Repository:
rL LLVM
https://reviews.llv
Author: ericwf
Date: Sat Sep 24 22:34:28 2016
New Revision: 282347
URL: http://llvm.org/viewvc/llvm-project?rev=282347&view=rev
Log:
[libc++] Remove various C++03 feature test macros
Summary:
Libc++ still uses per-feature configuration macros when configuring for C++11.
However libc++ requires a
Author: ericwf
Date: Sat Sep 24 23:05:46 2016
New Revision: 282349
URL: http://llvm.org/viewvc/llvm-project?rev=282349&view=rev
Log:
Fix missing _LIBCPP_INLINE_VISIBILITY macro on C++03 specific __hash_table
function
Modified:
libcxx/trunk/include/__hash_table
Modified: libcxx/trunk/include
Author: ericwf
Date: Sun Sep 25 03:30:05 2016
New Revision: 282352
URL: http://llvm.org/viewvc/llvm-project?rev=282352&view=rev
Log:
Update -verify test to use new static assert message
Modified:
libcxx/trunk/test/std/containers/sequences/array/array.tuple/get.fail.cpp
Modified:
libcxx/trun
EricWF added reviewers: mclow.lists, rsmith.
EricWF added subscribers: mclow.lists, rsmith.
EricWF added a comment.
Adding reviewers @mclow.lists and @rsmith since he originally wrote the C
wrappers.
https://reviews.llvm.org/D24903
___
cfe-commits
EricWF added inline comments.
Comment at: include/stdint.h:24
@@ +23,3 @@
+*/
+#if __cplusplus >= 201103L && !defined(__STDC_LIMIT_MACROS)
+# define __STDC_LIMIT_MACROS
Please take a look at how `clang/lib/Headers/stdint.h` handles forwarding this
header, an
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Please remove the `LIBCXX` macros before committing.
Comment at: include/stdint.h:118
@@ +117,3 @@
+# define __STDC_CONSTANT_MACROS
+# define __STDC_CONSTANT_MACROS_
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing the inline comments.
Comment at: src/fallback_malloc.cpp:58
@@ +57,3 @@
+
+#define HEAP_SIZE 512
+char heap [ HEAP_SIZE ];
A static co
EricWF added a comment.
FYI `std::move` and `std::forward` are now constexpr in C++11. There is no need
to use `__forward`.
Repository:
rL LLVM
https://reviews.llvm.org/D24372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: ericwf
Date: Mon Sep 26 15:55:02 2016
New Revision: 282439
URL: http://llvm.org/viewvc/llvm-project?rev=282439&view=rev
Log:
[libc++] Extension: Make `move` and `forward` constexpr in C++11.
Summary:
`std::move` and `std::forward` were not marked constexpr in C++11. This can be
very dam
Author: ericwf
Date: Mon Sep 26 17:19:41 2016
New Revision: 282449
URL: http://llvm.org/viewvc/llvm-project?rev=282449&view=rev
Log:
Expect DLL builds on Windows by default and require a custom __config for static
builds.
On Windows the __declspec(dllimport) and __declspec(dllexport) attributes
r
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
I fixed this with a slightly different patch in r282449. I hope you don't mind
that I didn't use this patch, I just wanted to add support for generating
custom __config headers for static builds on Win
EricWF added a comment.
LGTM other than the inline comments. I'll give it a final once over tonight or
tomorrow.
Comment at: include/__cxxabi_config.h:36
@@ -35,1 +35,3 @@
#endif
+ #if defined(_MSC_VER) && !defined(__clang__)
+ // Using Microsoft Visual C++ compiler
Author: ericwf
Date: Mon Sep 26 20:28:47 2016
New Revision: 282466
URL: http://llvm.org/viewvc/llvm-project?rev=282466&view=rev
Log:
Remove out of date items in TODO.txt
Modified:
libcxx/trunk/TODO.TXT
Modified: libcxx/trunk/TODO.TXT
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/TOD
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing inline comments. Unfortunately libc++abi doesn't have a
way to make `_LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT` persistent, but this
solution works for now.
===
EricWF added a comment.
> Stop stripping -m32 from the user-supplied flags. There is no valid reason to
> do that, stripping it silently is thoroughly confusing and makes it
> impossible to do distribution multi-ABI builds without resorting to ugly
> hacks.
The reason for stripping it is conf
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the patch.
https://reviews.llvm.org/D24119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: ericwf
Date: Mon Sep 26 21:13:27 2016
New Revision: 282468
URL: http://llvm.org/viewvc/llvm-project?rev=282468&view=rev
Log:
Fix possible division by zero
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experimental/filesystem/operations.c
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo inline comments.
Comment at: CMakeLists.txt:310
@@ -309,4 +309,3 @@
-# Remove flags that may have snuck in.
-remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG
-
Author: ericwf
Date: Wed Sep 28 16:16:58 2016
New Revision: 282634
URL: http://llvm.org/viewvc/llvm-project?rev=282634&view=rev
Log:
Improve 'last_write_time(...)' accuracy and detect overflow errors.
The ::stat struct on Linux, FreeBSD, and OS X provides the access and
modification times as an
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo inline comments.
Comment at: include/new:129
@@ +128,3 @@
+/*
+ * NOTE: When using the Microsoft CRT, the operator new and delete
+ * family of functions are defin
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM once the `_POSIX_THREADS` comment is addressed.
Comment at: src/config.h:46
@@ +45,3 @@
+defined(__linux__) || \
+defined(__APPLE__) || \
+defined(__CloudABI_
Author: ericwf
Date: Wed Sep 28 17:08:13 2016
New Revision: 282640
URL: http://llvm.org/viewvc/llvm-project?rev=282640&view=rev
Log:
Mark libc++ internal globals with _LIBCPP_SAFE_STATIC.
This patch applies the _LIBCPP_SAFE_STATIC attribute to internal globals,
most of which are locking primitive
Author: ericwf
Date: Wed Sep 28 20:01:26 2016
New Revision: 282660
URL: http://llvm.org/viewvc/llvm-project?rev=282660&view=rev
Log:
Partially revert overflow checking in last_write_time
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experimental
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
If there is an error finding the `coroutine_traits` template when building a
coroutine AST nodes we throw away the remainder of the assignment
Author: ericwf
Date: Thu Sep 29 16:47:39 2016
New Revision: 282792
URL: http://llvm.org/viewvc/llvm-project?rev=282792&view=rev
Log:
[Coroutines] Fix assertion about uncorrected typos in
co_await/co_yield/co_return expressions
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
cfe/trunk/test
On Sep 29, 2016 8:23 PM, "Gor Nishanov" wrote:
>
> You beat me to it, Eric. :) I'll add mine for review, too. Let's see
which one Richard will respond :) .
>
> 1. Remove __has_feature
> 2. Rename fcoroutines => fcoroutines_TS
> 3. Rename __cpp_coroutines => __cpp_experimental_coroutines
The TS sp
EricWF updated this revision to Diff 73000.
EricWF added a comment.
Run patch through clang-format.
https://reviews.llvm.org/D25068
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaCoroutine.cpp
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/coroutines.c
EricWF added a comment.
Hijacked to address review comments. @GorNishanov feel free to commandeer this
revision back.
https://reviews.llvm.org/D25068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Committed in r282792.
https://reviews.llvm.org/D25060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
The title says it all.
https://reviews.llvm.org/D25078
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
te
EricWF added a comment.
@rmaprath I'll merge this if needed. Feel free to commit your patch first.
@tavianator Do you need somebody to merge this for you?
https://reviews.llvm.org/D21803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: ericwf
Date: Fri Sep 30 17:38:31 2016
New Revision: 282973
URL: http://llvm.org/viewvc/llvm-project?rev=282973&view=rev
Log:
[coroutines] Diagnose when 'main' is declared as a coroutine.
Summary: The title says it all.
Reviewers: rsmith, GorNishanov
Subscribers: mehdi_amini, cfe-commits
EricWF updated this revision to Diff 73181.
EricWF added a comment.
Address comments about caching the std::experimental namespace. @rsmith could
you please double check that `lookupStdExperimentalNamespace()` is correct?
https://reviews.llvm.org/D25068
Files:
include/clang/Basic/Diagnostic
EricWF marked an inline comment as done.
EricWF added inline comments.
> rsmith wrote in SemaDeclCXX.cpp:8157-8160
> If you're going to track the namespace on creation, you need to add
> serialization code for your `Sema::StdExperimentalNamespace` storage. But I'd
> suggest taking a different a
EricWF added a comment.
This LGTM but I can't approve Clang patches, so it'll have to wait on @rsmith .
https://reviews.llvm.org/D25130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm OK accepting this, but I'm going to weak it before committing so that
`test_macros.h` define `TEST_STACK_ALLOCATOR_WORKAROUND` for non-libc++ builds.
https://reviews.llvm.org/D22973
__
EricWF created this revision.
EricWF added reviewers: mclow.lists, howard.hinnant, STL_MSFT.
EricWF added a subscriber: cfe-commits.
To quote STL the problems with stack allocator are"
> "stack_allocator is seriously nonconformant to N4582 17.6.3.5
> [allocator.requirements].
> First, it lacks
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Nevermind. I decided to just fix stack_allocator so this patch is no longer
needed. Please let me know if the stack allocator fix doesn't work
https://reviews.llvm.org/D22973
__
Author: ericwf
Date: Sat Oct 1 05:34:13 2016
New Revision: 283030
URL: http://llvm.org/viewvc/llvm-project?rev=283030&view=rev
Log:
Replace test_throw.h header with a single test macro
Removed:
libcxx/trunk/test/support/test_throw.h
Modified:
libcxx/trunk/test/std/utilities/memory/speci
Author: ericwf
Date: Sat Oct 1 05:46:01 2016
New Revision: 283032
URL: http://llvm.org/viewvc/llvm-project?rev=283032&view=rev
Log:
Remove all instances of _LIBCPP_HAS_NO_RVALUE_REFERENCES from test/std/utilities
Modified:
libcxx/trunk/test/std/utilities/allocator.adaptor/allocator.adaptor.
Author: ericwf
Date: Tue Oct 4 16:25:51 2016
New Revision: 283260
URL: http://llvm.org/viewvc/llvm-project?rev=283260&view=rev
Log:
[libcxx] [test] Guard __has_include usage with a macro
Summary: There's a macro scheme already being used for __has_feature etc. Use
it for __has_include too, whic
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Although I would have thought the first half of the conjunction would
have prevented MSVC's PP from seeing the `__has_include`.
I'll get to the rest of the patches tomorrow.
https://re
EricWF added a comment.
r283260.
https://reviews.llvm.org/D25251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Feel free to send them in 10-20 at a time. It'll be much faster to review that
way.
https://reviews.llvm.org/D24562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
The title says it all. Additionally this patch refactors the diagnostic code
into a separate function.
https://reviews.llvm.org/D25292
File
EricWF added a comment.
In https://reviews.llvm.org/D24562#562339, @rmaprath wrote:
> First batch of XFAIL fixes.
>
> I've changed some XFAILs to UNSUPPORTED where the test is all about exception
> handling. In other cases, I've used the test macro TEST_HAS_NO_EXCEPTIONS to
> conditionally excl
Author: ericwf
Date: Wed Oct 5 17:55:10 2016
New Revision: 283408
URL: http://llvm.org/viewvc/llvm-project?rev=283408&view=rev
Log:
Fix strict-aliasing violation in typeinfo::hash_code()
Summary:
The current implementation of `hash_code()` for uniqued RTTI strings violates
strict aliasing by de
201 - 300 of 2677 matches
Mail list logo
