[libcxx] r303836 - Add

2017-05-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 24 23:36:24 2017 New Revision: 303836 URL: http://llvm.org/viewvc/llvm-project?rev=303836&view=rev Log: Add This patch adds the library portions of the coroutines PDTS, which should now be supported by Clang. Added: libcxx/trunk/include/experimental/coroutine

[libcxx] r303837 - Disable the coroutines tests until Clang bumps __cpp_coroutines to reflect recent changes

2017-05-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 00:11:40 2017 New Revision: 303837 URL: http://llvm.org/viewvc/llvm-project?rev=303837&view=rev Log: Disable the coroutines tests until Clang bumps __cpp_coroutines to reflect recent changes Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/

[libcxx] r303838 - Remove from the module map for now. It doesn't work unless modules are enabled

2017-05-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 00:30:05 2017 New Revision: 303838 URL: http://llvm.org/viewvc/llvm-project?rev=303838&view=rev Log: Remove from the module map for now. It doesn't work unless modules are enabled Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include

r303867 - [coroutines] Bump __cpp_coroutines version

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 09:58:46 2017 New Revision: 303867 URL: http://llvm.org/viewvc/llvm-project?rev=303867&view=rev Log: [coroutines] Bump __cpp_coroutines version Summary: This patch is needed so that Libc++ can actually tess if Clang supports coroutines, instead of just paying lip

r303868 - [coroutines] Diagnose when promise types fail to declare either return_void or return_value.

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 09:59:39 2017 New Revision: 303868 URL: http://llvm.org/viewvc/llvm-project?rev=303868&view=rev Log: [coroutines] Diagnose when promise types fail to declare either return_void or return_value. Summary: According to the PDTS it's perfectly legal to have a promise

r303871 - Make git-clang-format python 3 compatible

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 10:24:04 2017 New Revision: 303871 URL: http://llvm.org/viewvc/llvm-project?rev=303871&view=rev Log: Make git-clang-format python 3 compatible Summary: This patch attempts to make `git-clang-format` both python2 and python3 compatible. Currently it only works in p

[libcxx] r303895 - Update coroutine_handle::promise to reflect N4663.

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 13:52:34 2017 New Revision: 303895 URL: http://llvm.org/viewvc/llvm-project?rev=303895&view=rev Log: Update coroutine_handle::promise to reflect N4663. This patch updates the promise() member to match the current spec. Specifically it removes the non-const overload

[libcxx] r303900 - Update more coroutine_handle signatures to reflect N4663.

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 14:04:55 2017 New Revision: 303900 URL: http://llvm.org/viewvc/llvm-project?rev=303900&view=rev Log: Update more coroutine_handle signatures to reflect N4663. Thanks to Casey Carter for pointing out the out-of-date tests and implementation. Modified: libcxx/tr

[libcxx] r303929 - Correct typo: LIBCXXABI_BUILTINS_LIBRARY -> LIBCXX_BUILTINS_LIBRARY

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 17:43:42 2017 New Revision: 303929 URL: http://llvm.org/viewvc/llvm-project?rev=303929&view=rev Log: Correct typo: LIBCXXABI_BUILTINS_LIBRARY -> LIBCXX_BUILTINS_LIBRARY Modified: libcxx/trunk/cmake/config-ix.cmake Modified: libcxx/trunk/cmake/config-ix.cmake U

[libcxx] r303936 - Re-add to the module map.

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 18:39:29 2017 New Revision: 303936 URL: http://llvm.org/viewvc/llvm-project?rev=303936&view=rev Log: Re-add to the module map. The original issues were caused because didn't correctly #ifdef out enough of the header, which caused incomplete types to be used. Thi

[libcxx] r303953 - Remove incorrect #ifdef guards around variant tests.

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 20:27:08 2017 New Revision: 303953 URL: http://llvm.org/viewvc/llvm-project?rev=303953&view=rev Log: Remove incorrect #ifdef guards around variant tests. The tests were previously guarded by #if defined(_LIBCPP_VER) || defined(_MSVC_STL_VER), which is both incorre

[libcxx] r303956 - Guard against older Clang versions.

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 20:52:59 2017 New Revision: 303956 URL: http://llvm.org/viewvc/llvm-project?rev=303956&view=rev Log: Guard against older Clang versions. Clang started providing -fcoroutines and defining __cpp_coroutines way before it implemented the __builtin_coro_foo functions.

[libcxx] r303963 - Get working in C++03.

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 22:02:54 2017 New Revision: 303963 URL: http://llvm.org/viewvc/llvm-project?rev=303963&view=rev Log: Get working in C++03. Clang supports coroutines in all dialects; Therefore libc++ should too, otherwise the Clang extension is unusable. I'm not convinced extendi

[libcxx] r303966 - Workaround debug info bug in Clangs coroutine implementation

2017-05-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu May 25 23:09:38 2017 New Revision: 303966 URL: http://llvm.org/viewvc/llvm-project?rev=303966&view=rev Log: Workaround debug info bug in Clangs coroutine implementation Modified: libcxx/trunk/test/libcxx/experimental/language.support/support.coroutines/dialect_suppor

r304054 - [coroutines] Support "coroutines" feature in module map requires clause

2017-05-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri May 26 21:46:17 2017 New Revision: 304054 URL: http://llvm.org/viewvc/llvm-project?rev=304054&view=rev Log: [coroutines] Support "coroutines" feature in module map requires clause Summary: In order for libc++ to add `` to its module map, there has to be a feature that ca

r304057 - Revert "[coroutines] Support "coroutines" feature in module map requires clause"

2017-05-26 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri May 26 22:04:51 2017 New Revision: 304057 URL: http://llvm.org/viewvc/llvm-project?rev=304057&view=rev Log: Revert "[coroutines] Support "coroutines" feature in module map requires clause" This reverts commit r304054. Removed: cfe/trunk/test/Modules/Inputs/DependsOnM

r304094 - [coroutines] Diagnose invalid result types for `await_resume` and `await_suspend` and add missing conversions.

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun May 28 13:21:12 2017 New Revision: 304094 URL: http://llvm.org/viewvc/llvm-project?rev=304094&view=rev Log: [coroutines] Diagnose invalid result types for `await_resume` and `await_suspend` and add missing conversions. Summary: The expression `await_ready` is required t

[libcxx] r304101 - [coroutines] Add end-to-end tests within libc++

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun May 28 14:38:21 2017 New Revision: 304101 URL: http://llvm.org/viewvc/llvm-project?rev=304101&view=rev Log: [coroutines] Add end-to-end tests within libc++ This patch adds end-to-end/breathing tests for coroutines into libc++. The tests aren't specifically to test libc++

[libcxx] r304102 - Remove XFAIL's for recently fixed bug

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun May 28 15:25:41 2017 New Revision: 304102 URL: http://llvm.org/viewvc/llvm-project?rev=304102&view=rev Log: Remove XFAIL's for recently fixed bug Modified: libcxx/trunk/test/libcxx/experimental/language.support/support.coroutines/dialect_support.sh.cpp Modified: li

[libcxx] r304103 - Add hack to allow test to run w/o C++17 copy elision

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun May 28 15:30:18 2017 New Revision: 304103 URL: http://llvm.org/viewvc/llvm-project?rev=304103&view=rev Log: Add hack to allow test to run w/o C++17 copy elision Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/fullexpr-dtor.

[libcxx] r304105 - Fix use of uninitialized memory

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun May 28 15:49:13 2017 New Revision: 304105 URL: http://llvm.org/viewvc/llvm-project?rev=304105&view=rev Log: Fix use of uninitialized memory Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/expected.sh.cpp Modified: libcxx/

[libcxx] r304104 - XFAIL tests which trigger coroutine debug info crash in Clang

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun May 28 15:49:11 2017 New Revision: 304104 URL: http://llvm.org/viewvc/llvm-project?rev=304104&view=rev Log: XFAIL tests which trigger coroutine debug info crash in Clang Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_

[libcxx] r304106 - Correct XFAIL's in coroutine tests to only list ubsan

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun May 28 15:56:16 2017 New Revision: 304106 URL: http://llvm.org/viewvc/llvm-project?rev=304106&view=rev Log: Correct XFAIL's in coroutine tests to only list ubsan Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_await_su

r304107 - [coroutines] Support "coroutines" feature in module map requires clause

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun May 28 16:07:22 2017 New Revision: 304107 URL: http://llvm.org/viewvc/llvm-project?rev=304107&view=rev Log: [coroutines] Support "coroutines" feature in module map requires clause Summary: In order for libc++ to add `` to its module map, there has to be a feature that ca

[libcxx] r304124 - Fix multiple bugs in coroutine tests.

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon May 29 00:00:24 2017 New Revision: 304124 URL: http://llvm.org/viewvc/llvm-project?rev=304124&view=rev Log: Fix multiple bugs in coroutine tests. Modified: libcxx/trunk/include/experimental/coroutine libcxx/trunk/test/libcxx/experimental/language.support/support.

[libcxx] r304131 - Fix coroutine test failures caused by API misusages.

2017-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon May 29 01:42:01 2017 New Revision: 304131 URL: http://llvm.org/viewvc/llvm-project?rev=304131&view=rev Log: Fix coroutine test failures caused by API misusages. More tests to come. I think that from_address overload should be deleted or ill-formed, except for the 'void*'

[libcxx] r304172 - [coroutines] Make coroutine_handle::from_address ill-formed for everything but void*.

2017-05-29 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon May 29 14:24:25 2017 New Revision: 304172 URL: http://llvm.org/viewvc/llvm-project?rev=304172&view=rev Log: [coroutines] Make coroutine_handle::from_address ill-formed for everything but void*. from_address requires that the provided pointer refer to the suspended corou

[libcxx] r304173 - Fix in C++03

2017-05-29 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon May 29 14:46:16 2017 New Revision: 304173 URL: http://llvm.org/viewvc/llvm-project?rev=304173&view=rev Log: Fix in C++03 Modified: libcxx/trunk/include/experimental/coroutine Modified: libcxx/trunk/include/experimental/coroutine URL: http://llvm.org/viewvc/llvm-pro

[libcxx] r304180 - Add missing 'requires coroutines' to module map

2017-05-29 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon May 29 18:17:28 2017 New Revision: 304180 URL: http://llvm.org/viewvc/llvm-project?rev=304180&view=rev Log: Add missing 'requires coroutines' to module map Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL: http://ll

r304331 - [coroutines] Fix assertion during -Wuninitialized analysis

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 14:36:59 2017 New Revision: 304331 URL: http://llvm.org/viewvc/llvm-project?rev=304331&view=rev Log: [coroutines] Fix assertion during -Wuninitialized analysis Summary: @rsmith Is there a better place to put this test? Reviewers: GorNishanov, rsmith Reviewed By:

[libcxx] r304348 - Remove uses of _UI because Windows is evil and tchar.h #define's it

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 16:20:18 2017 New Revision: 304348 URL: http://llvm.org/viewvc/llvm-project?rev=304348&view=rev Log: Remove uses of _UI because Windows is evil and tchar.h #define's it Modified: libcxx/trunk/include/algorithm libcxx/trunk/include/random libcxx/trunk/te

[libcxx] r304351 - Transform the libc++ coroutine shell tests into normal .pass.cpp tests.

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 16:34:43 2017 New Revision: 304351 URL: http://llvm.org/viewvc/llvm-project?rev=304351&view=rev Log: Transform the libc++ coroutine shell tests into normal .pass.cpp tests. The shell test versions didn't get all of the flags normal tests do, specifically warning fl

[libcxx] r304352 - Guard against more macros in tchar.h

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 16:39:54 2017 New Revision: 304352 URL: http://llvm.org/viewvc/llvm-project?rev=304352&view=rev Log: Guard against more macros in tchar.h Modified: libcxx/trunk/test/support/nasty_macros.hpp Modified: libcxx/trunk/test/support/nasty_macros.hpp URL: http://llv

[libcxx] r304357 - [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 17:07:49 2017 New Revision: 304357 URL: http://llvm.org/viewvc/llvm-project?rev=304357&view=rev Log: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows Summary: This patch improves how libc++ handles min/max macros within the headers. Pr

[libcxxabi] r304359 - Remove requirement for libunwind sources. Patch by Shiz.

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 17:11:42 2017 New Revision: 304359 URL: http://llvm.org/viewvc/llvm-project?rev=304359&view=rev Log: Remove requirement for libunwind sources. Patch by Shiz. As per r241993, libunwind_ext.h is not used anymore, and thus only the public libunwind includes are neede

[libcxx] r304360 - Fix Libc++ build with MinGW64

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 17:14:05 2017 New Revision: 304360 URL: http://llvm.org/viewvc/llvm-project?rev=304360&view=rev Log: Fix Libc++ build with MinGW64 Summary: This patch corrects the build errors I encountered when building on MinGW64. Reviewers: mati865, rnk, compnerd, smeenai, bc

[libcxx] r304364 - Fix silly mistakes in recent changes made to coroutine test

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 17:20:42 2017 New Revision: 304364 URL: http://llvm.org/viewvc/llvm-project?rev=304364&view=rev Log: Fix silly mistakes in recent changes made to coroutine test Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/fullexp

[libcxx] r304372 - Define -DNOMINMAX when running the tests on Windows

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 18:27:25 2017 New Revision: 304372 URL: http://llvm.org/viewvc/llvm-project?rev=304372&view=rev Log: Define -DNOMINMAX when running the tests on Windows Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL:

r304373 - [coroutines] Fix checking for prvalue-ness of `await_suspend` return type

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 18:41:11 2017 New Revision: 304373 URL: http://llvm.org/viewvc/llvm-project?rev=304373&view=rev Log: [coroutines] Fix checking for prvalue-ness of `await_suspend` return type Summary: @rsmith Does this correctly address the issues mentioned in https://reviews.llvm

Re: r304376 - PR33232: implement support for MSVC's __is_trivially_destructible trait.

2017-05-31 Thread Eric Fiselier via cfe-commits
I'm assuming libc++ should move to this trait instead? /Eric On Wed, May 31, 2017 at 6:28 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed May 31 19:28:16 2017 > New Revision: 304376 > > URL: http://llvm.org/viewvc/llvm-project?rev=304376&view=r

[libcxx] r304377 - Upgrade Clang version used by appveyor

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 20:00:59 2017 New Revision: 304377 URL: http://llvm.org/viewvc/llvm-project?rev=304377&view=rev Log: Upgrade Clang version used by appveyor Modified: libcxx/trunk/appveyor-reqs-install.cmd Modified: libcxx/trunk/appveyor-reqs-install.cmd URL: http://llvm.org/

[libcxx] r304382 - Rename unreserved names in tuple

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 21:14:21 2017 New Revision: 304382 URL: http://llvm.org/viewvc/llvm-project?rev=304382&view=rev Log: Rename unreserved names in tuple Modified: libcxx/trunk/include/tuple Modified: libcxx/trunk/include/tuple URL: http://llvm.org/viewvc/llvm-project/libcxx/tru

[libcxx] r304383 - Fix more unreserved names

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 21:29:37 2017 New Revision: 304383 URL: http://llvm.org/viewvc/llvm-project?rev=304383&view=rev Log: Fix more unreserved names Modified: libcxx/trunk/include/limits libcxx/trunk/include/memory libcxx/trunk/include/stdexcept libcxx/trunk/include/stri

[libcxx] r304384 - Fix name used in -verify diagnostic to match trunk

2017-05-31 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed May 31 21:31:01 2017 New Revision: 304384 URL: http://llvm.org/viewvc/llvm-project?rev=304384&view=rev Log: Fix name used in -verify diagnostic to match trunk Modified: libcxx/trunk/test/libcxx/utilities/tuple/tuple.tuple/diagnose_reference_binding.fail.cpp Modified

Re: r304376 - PR33232: implement support for MSVC's __is_trivially_destructible trait.

2017-06-02 Thread Eric Fiselier via cfe-commits
I've been using !__is_identifier to test for things like that. It seems to be the most consistent way. Is there some problem with this? /Eric On Thu, Jun 1, 2017 at 6:46 PM, Richard Smith wrote: > On 31 May 2017 at 17:41, Eric Fiselier wrote: > >> I'm assuming libc++ should move to this trait

r304620 - [coroutines] Fix rebuilding of dependent coroutine parameters

2017-06-02 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jun 2 19:22:18 2017 New Revision: 304620 URL: http://llvm.org/viewvc/llvm-project?rev=304620&view=rev Log: [coroutines] Fix rebuilding of dependent coroutine parameters Summary: We were not handling correctly rebuilding of parameter and were not creating copies for them

Re: [PATCH] D33660: [coroutines] Fix assertion during -Wuninitialized analysis

2017-06-07 Thread Eric Fiselier via cfe-commits
Yes, the thing that it's supposed to be testing is -Wuninitialized and other analysis warnings. I'll re-name the test and add more test cases to this effect shortly. Thanks for the input. On Mon, Jun 5, 2017 at 10:33 AM, David Blaikie wrote: > > > On Mon, May 29, 2017 at 3:28 PM Eric Fiselier v

[libcxx] r304883 - Fix test with exceptions disabled

2017-06-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 7 04:06:05 2017 New Revision: 304883 URL: http://llvm.org/viewvc/llvm-project?rev=304883&view=rev Log: Fix test with exceptions disabled Modified: libcxx/trunk/test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp Modified: libcxx/trunk/test/

[libcxx] r304942 - Fix compile error with Bionic's PTHREAD_MUTEX_INITIALIZER

2017-06-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 7 15:47:42 2017 New Revision: 304942 URL: http://llvm.org/viewvc/llvm-project?rev=304942&view=rev Log: Fix compile error with Bionic's PTHREAD_MUTEX_INITIALIZER On Bionic PTHREAD_MUTEX_INITIALIZER contains the expression " & ", which causes ADL to perform name looku

[libcxx] r304955 - Fix class template deduction for scoped_lock.

2017-06-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 7 19:38:56 2017 New Revision: 304955 URL: http://llvm.org/viewvc/llvm-project?rev=304955&view=rev Log: Fix class template deduction for scoped_lock. r304862 changed how CTD handles deducing a non-primary class template using a non-dependent constructor of the primary

[libcxx] r304966 - Revert r304955 - Fix class template deduction for scoped_lock.

2017-06-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jun 8 02:18:15 2017 New Revision: 304966 URL: http://llvm.org/viewvc/llvm-project?rev=304966&view=rev Log: Revert r304955 - Fix class template deduction for scoped_lock. Richard decided to fix these cases in Clang, even though they are representative of a larger problem

[libcxx] r304967 - Add tests for class template deduction on std::tuple.

2017-06-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jun 8 02:18:17 2017 New Revision: 304967 URL: http://llvm.org/viewvc/llvm-project?rev=304967&view=rev Log: Add tests for class template deduction on std::tuple. Added: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/implicit_deduction_guides.pass.cpp M

[libcxx] r304969 - XFAIL tuple deduction guide test on GCC

2017-06-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jun 8 03:03:35 2017 New Revision: 304969 URL: http://llvm.org/viewvc/llvm-project?rev=304969&view=rev Log: XFAIL tuple deduction guide test on GCC Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/implicit_deduction_guides.pass.cpp Modified:

r305363 - [coroutines] Fix co_await for range statement

2017-06-13 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 13 22:24:55 2017 New Revision: 305363 URL: http://llvm.org/viewvc/llvm-project?rev=305363&view=rev Log: [coroutines] Fix co_await for range statement Summary: Currently we build the co_await expressions on the wrong implicit statements of the implicit ranged for; Spe

r305437 - [clang-format] Allow git-clang-format to handle empty extensions.

2017-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 14 19:54:08 2017 New Revision: 305437 URL: http://llvm.org/viewvc/llvm-project?rev=305437&view=rev Log: [clang-format] Allow git-clang-format to handle empty extensions. Most of libc++'s header files don't use extension. This prevents using git-clang-format on them, w

[libcxx] r305442 - Move external instantiation for __vector_base_common to vector.cpp

2017-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 14 20:53:12 2017 New Revision: 305442 URL: http://llvm.org/viewvc/llvm-project?rev=305442&view=rev Log: Move external instantiation for __vector_base_common to vector.cpp Previously the explicit instantiation for this was in locale.cpp, but that didn't make much sense

[libcxx] r305446 - Add hack to get --param=enable_modules=true working with a __config_site header

2017-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 14 21:54:15 2017 New Revision: 305446 URL: http://llvm.org/viewvc/llvm-project?rev=305446&view=rev Log: Add hack to get --param=enable_modules=true working with a __config_site header Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils

[libcxx] r305445 - Fix test when modules are enabled

2017-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 14 21:54:12 2017 New Revision: 305445 URL: http://llvm.org/viewvc/llvm-project?rev=305445&view=rev Log: Fix test when modules are enabled Modified: libcxx/trunk/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.cxx1z.pass.cpp Modi

[libcxx] r305447 - remove incorrectly committed assertion

2017-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 14 22:02:43 2017 New Revision: 305447 URL: http://llvm.org/viewvc/llvm-project?rev=305447&view=rev Log: remove incorrectly committed assertion Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL: http://llvm.

[libcxx] r305448 - Fix another test with modules enabled

2017-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 14 22:03:45 2017 New Revision: 305448 URL: http://llvm.org/viewvc/llvm-project?rev=305448&view=rev Log: Fix another test with modules enabled Modified: libcxx/trunk/test/libcxx/depr/depr.function.objects/depr.adaptors.cxx1z.pass.cpp Modified: libcxx/trunk/test/

r305450 - Correct documentation about the AfterClass clang-format option

2017-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 14 22:38:08 2017 New Revision: 305450 URL: http://llvm.org/viewvc/llvm-project?rev=305450&view=rev Log: Correct documentation about the AfterClass clang-format option Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/ClangFormatStyleOp

[libcxx] r305451 - attempt to fix GCC ToT build failures

2017-06-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 14 22:50:02 2017 New Revision: 305451 URL: http://llvm.org/viewvc/llvm-project?rev=305451&view=rev Log: attempt to fix GCC ToT build failures Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llvm-project

r305496 - [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

2017-06-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jun 15 14:43:36 2017 New Revision: 305496 URL: http://llvm.org/viewvc/llvm-project?rev=305496&view=rev Log: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile Summary: The title says it all. Reviewers: GorNishanov, rsmith Reviewed By

r305498 - [coroutines] Remove pass-through operator co_await; Replace it with the input expression

2017-06-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jun 15 15:00:54 2017 New Revision: 305498 URL: http://llvm.org/viewvc/llvm-project?rev=305498&view=rev Log: [coroutines] Remove pass-through operator co_await; Replace it with the input expression Reviewers: GorNishanov, rsmith Reviewed By: GorNishanov Differential Rev

[libcxxabi] r305500 - Use _LIBCPP_FALLTHROUGH() to avoid warnings about [[gnu::fallthrough]] being unsupported

2017-06-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jun 15 15:18:10 2017 New Revision: 305500 URL: http://llvm.org/viewvc/llvm-project?rev=305500&view=rev Log: Use _LIBCPP_FALLTHROUGH() to avoid warnings about [[gnu::fallthrough]] being unsupported Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/tr

[libcxx] r305536 - Allow coroutine_handle to support creation from const references to the promise_type

2017-06-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jun 15 19:36:17 2017 New Revision: 305536 URL: http://llvm.org/viewvc/llvm-project?rev=305536&view=rev Log: Allow coroutine_handle to support creation from const references to the promise_type It seems conceivable that a user would need to get a coroutine handle having o

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

2017-06-15 Thread Eric Fiselier via cfe-commits
It *shouldn't* include , that's a given. IIRC, and Marshall would know better, I believe it was untenable to maintain a version of that didn't depend on after making the changes required for C++17. However inspecting now it does seem possible that the entanglement is avoidable.Though it's also

[libcxx] r305539 - Allow the libc++ C header wrappers to be included when compiling C.

2017-06-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jun 15 20:57:41 2017 New Revision: 305539 URL: http://llvm.org/viewvc/llvm-project?rev=305539&view=rev Log: Allow the libc++ C header wrappers to be included when compiling C. C99 at least. C89 still fails due to the use of block comments. NOTE: Having libc++ on the incl

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

2017-06-15 Thread Eric Fiselier via cfe-commits
On Thu, Jun 15, 2017 at 8:38 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > I just started working on a patch to add #if guards, and the first > interesting thing I found was the basic_string constructor: > > template > template > basic_string<_CharT, _Traits, _Allocator>::basic_st

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

2017-06-15 Thread Eric Fiselier via cfe-commits
I should mention that depends on C++17 string_view in older dialects :-S So this change will break that. I would prefer to fix your specific use case by making std::experimental::string_view literally be std::string_view. /Eric On Thu, Jun 15, 2017 at 8:42 PM, Eric Fiselier wrote: > > > On Th

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

2017-06-15 Thread Eric Fiselier via cfe-commits
I would also want to do serious performance analysis on this patch. Does removing the string_view overloads cause less optimal overloads to be chosen? Perhaps allocating ones? That would be really unfortunate, and I'm not sure that's in the best interest of our users at large. /Eric On Thu, Jun 1

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

2017-06-15 Thread Eric Fiselier via cfe-commits
On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Your suggestion is essentially to replace experimental/string_view with > something like: > > namespace std { inline namespace __1 { namespace experimental { > template > using basic_string_

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

2017-06-15 Thread Eric Fiselier via cfe-commits
On Jun 15, 2017 11:22 PM, "Eric Fiselier" wrote: On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Your suggestion is essentially to replace experimental/string_view with > something like: > > namespace std { inline namespace __1 { namespace experim

[libcxx] r305549 - Fix potential bug by casting to the POSIX specified type

2017-06-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jun 16 01:17:52 2017 New Revision: 305549 URL: http://llvm.org/viewvc/llvm-project?rev=305549&view=rev Log: Fix potential bug by casting to the POSIX specified type Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/experimen

[libcxx] r305955 - Attempt to avoid static init ordering issues with globalMemCounter

2017-06-21 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 21 16:42:50 2017 New Revision: 305955 URL: http://llvm.org/viewvc/llvm-project?rev=305955&view=rev Log: Attempt to avoid static init ordering issues with globalMemCounter Modified: libcxx/trunk/test/support/count_new.hpp Modified: libcxx/trunk/test/support/count_

Re: r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

2018-01-08 Thread Eric Fiselier via cfe-commits
I haven't done a ton of investigation yet, but I suspect this commit is responsible for breaking my LLVM module selfhost build, which uses libc++ as the STL, and builds LLD (No bots appear to test this configuration). The error message can be found here: https://gist.github.com/EricWF/fb5e1d18eb10

r333802 - Add Features.def to module map

2018-06-01 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jun 1 15:51:59 2018 New Revision: 333802 URL: http://llvm.org/viewvc/llvm-project?rev=333802&view=rev Log: Add Features.def to module map Modified: cfe/trunk/include/clang/module.modulemap Modified: cfe/trunk/include/clang/module.modulemap URL: http://llvm.org/view

[libcxx] r334053 - Fix PR37694 - std::vector doesn't correctly move construct allocators.

2018-06-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 5 15:32:52 2018 New Revision: 334053 URL: http://llvm.org/viewvc/llvm-project?rev=334053&view=rev Log: Fix PR37694 - std::vector doesn't correctly move construct allocators. C++2a[container.requirements.general]p8 states that when move constructing a container, the a

[libcxx] r334056 - Fix test failures after r334053.

2018-06-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 5 17:13:49 2018 New Revision: 334056 URL: http://llvm.org/viewvc/llvm-project?rev=334056&view=rev Log: Fix test failures after r334053. Modified: libcxx/trunk/test/std/containers/associative/map/map.cons/move.pass.cpp libcxx/trunk/test/std/containers/associa

[libcxx] r334069 - Remove unused code from __functional_base. NFC.

2018-06-05 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jun 5 23:42:27 2018 New Revision: 334069 URL: http://llvm.org/viewvc/llvm-project?rev=334069&view=rev Log: Remove unused code from __functional_base. NFC. Patch from Arthur O'Dwyer. `__user_alloc_construct_impl` is used by , but this `__user_alloc_construct` is never us

r345211 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2018-10-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 24 15:38:49 2018 New Revision: 345211 URL: http://llvm.org/viewvc/llvm-project?rev=345211&view=rev Log: [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03 Summary: When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t as an

r345225 - Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"

2018-10-24 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Oct 24 16:47:04 2018 New Revision: 345225 URL: http://llvm.org/viewvc/llvm-project?rev=345225&view=rev Log: Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03" This reverts commit 6f47cdd51341344c0e32630e19e72c94cd25f34e. Removed: cfe/trunk/

r345296 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2018-10-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Oct 25 11:16:16 2018 New Revision: 345296 URL: http://llvm.org/viewvc/llvm-project?rev=345296&view=rev Log: [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03 Summary: When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t as an

Re: r345296 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2018-10-25 Thread Eric Fiselier via cfe-commits
reverting On Thu., Oct. 25, 2018, 2:18 p.m. Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org wrote: > Author: ericwf > Date: Thu Oct 25 11:16:16 2018 > New Revision: 345296 > > URL: http://llvm.org/viewvc/llvm-project?rev=345296&view=rev > Log: > [SemaC

r345306 - Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"

2018-10-25 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Oct 25 12:50:43 2018 New Revision: 345306 URL: http://llvm.org/viewvc/llvm-project?rev=345306&view=rev Log: Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03" This reverts commit b5d8d0de744d2c212bdb17d5c5fd4447dd14dbd2. Removed: cfe/trunk/

Re: r345306 - Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"

2018-10-25 Thread Eric Fiselier via cfe-commits
Ack. My bad. On Thu, Oct 25, 2018 at 4:02 PM Richard Smith wrote: > When reverting (even when reverting your own commit), please include in > the commit description a reason for the revert. > > On Thu, 25 Oct 2018 at 12:52, Eric Fiselier via cfe-commits < > cfe-commits@lis

Re: r345306 - Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"

2018-10-25 Thread Eric Fiselier via cfe-commits
t; >> When reverting (even when reverting your own commit), please include in >> the commit description a reason for the revert. >> >> On Thu, 25 Oct 2018 at 12:52, Eric Fiselier via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Aut

r351294 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

2019-01-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Jan 15 18:34:36 2019 New Revision: 351294 URL: http://llvm.org/viewvc/llvm-project?rev=351294&view=rev Log: [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03 When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t as an unscoped

r351484 - Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides.

2019-01-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Thu Jan 17 13:44:24 2019 New Revision: 351484 URL: http://llvm.org/viewvc/llvm-project?rev=351484&view=rev Log: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides. Summary: Some style guides want to allow using CTAD only on types tha

[clang-tools-extra] r348633 - [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

2018-12-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Dec 7 12:03:03 2018 New Revision: 348633 URL: http://llvm.org/viewvc/llvm-project?rev=348633&view=rev Log: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions' Patch by Alex Strelnikov. Reviewed as D53830 Introduce a new check to upgrade user code based

r348864 - Pass PartialOverloading argument to the correct corresponding parameter

2018-12-11 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Dec 11 08:53:25 2018 New Revision: 348864 URL: http://llvm.org/viewvc/llvm-project?rev=348864&view=rev Log: Pass PartialOverloading argument to the correct corresponding parameter Modified: cfe/trunk/lib/Sema/SemaOverload.cpp cfe/trunk/test/CodeCompletion/function

r355743 - [8.0 Regression] Fix handling of `__builtin_constant_p` inside template arguments, enumerators, case statements, and the enable_if attribute.

2019-03-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Mar 8 14:06:48 2019 New Revision: 355743 URL: http://llvm.org/viewvc/llvm-project?rev=355743&view=rev Log: [8.0 Regression] Fix handling of `__builtin_constant_p` inside template arguments, enumerators, case statements, and the enable_if attribute. Summary: The followin

r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-04-23 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 23 19:23:30 2019 New Revision: 359067 URL: http://llvm.org/viewvc/llvm-project?rev=359067&view=rev Log: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a Summary: This patch implements `__builtin_is_constant_evaluated` as specifier by [P0595R2](ht

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-04-24 Thread Eric Fiselier via cfe-commits
Do I just edit the HTML file directly? Or is it generated by something? On Wed, Apr 24, 2019 at 3:35 PM Richard Smith wrote: > Thanks! Can you update cxx_status.html to mark P0595R2 as done? > > On Tue, 23 Apr 2019 at 19:21, Eric Fiselier via cfe-commits > wrote: > >

Re: r359361 - Revert Fix interactions between __builtin_constant_p and constexpr to match current trunk GCC.

2019-04-30 Thread Eric Fiselier via cfe-commits
Jorge, Why did you revert this? /Eric On Sat, Apr 27, 2019 at 6:01 AM Roman Lebedev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sat, Apr 27, 2019 at 3:29 AM Jorge Gorbe Moya via cfe-commits > wrote: > > > > Author: jgorbe > > Date: Fri Apr 26 17:32:04 2019 > > New Revision: 35936

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-05-08 Thread Eric Fiselier via cfe-commits
Sorry, I should have been on top of this. /Eric On Wed., May 8, 2019, 11:47 p.m. Richard Smith, wrote: > I went ahead and did this in r360310. > > On Thu, 25 Apr 2019 at 14:31, Richard Smith wrote: > > > > On Wed, 24 Apr 2019 at 19:28, Eric Fiselier via cfe-commits > &

r342827 - Fix modules build with shared library.

2018-09-22 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 22 17:48:05 2018 New Revision: 342827 URL: http://llvm.org/viewvc/llvm-project?rev=342827&view=rev Log: Fix modules build with shared library. r341994 caused clangAnalysis to pull all of the AST matchers library into clang. Due to inline key functions in the headers,

Re: r342827 - Fix modules build with shared library.

2018-09-30 Thread Eric Fiselier via cfe-commits
T matchers library into clang" - >>> how does including a header ever add a link dependency? >>> >>> - Dave >>> >>> >>> On Sat, Sep 22, 2018 at 5:49 PM Eric Fiselier via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >&

Re: r342827 - Fix modules build with shared library.

2018-09-30 Thread Eric Fiselier via cfe-commits
> understanding any layering problems in LLVM - and fixing them/making sure >>>> they're fixed/holding the line/etc) >>>> >>>> What do you mean by "pull all of the AST matchers library into clang" - >>>> how does including a head

r343420 - Fix linkage error on ProgramPoint's dump method.

2018-09-30 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Sep 30 11:05:39 2018 New Revision: 343420 URL: http://llvm.org/viewvc/llvm-project?rev=343420&view=rev Log: Fix linkage error on ProgramPoint's dump method. Currently, ProgramPoint::dump calls the out-of-line function ProgramPoint::print. This causes libraries which incl

<    1   2   3   4   5   6   7   8   9   10   >