echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Works for me. Thanks!
-eric
http://reviews.llvm.org/D12917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: echristo
Date: Fri Sep 18 16:26:24 2015
New Revision: 248046
URL: http://llvm.org/viewvc/llvm-project?rev=248046&view=rev
Log:
Reduce indentation in the TargetInfo implementations and fix up
a couple of macro builtin redefines.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Looks like a straight move? If so, LGTM, if not can you explain what changed?
Repository:
rL LLVM
http://reviews.llvm.org/D12982
___
cfe-c
echristo added a comment.
Nothing comes to mind.
Thanks!
-eric
Repository:
rL LLVM
http://reviews.llvm.org/D12982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
Make one of those big input directory sets of tests and run with/without that
option on it?
-eric
http://reviews.llvm.org/D12989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
echristo added a comment.
In http://reviews.llvm.org/D12989#250247, @tra wrote:
> I'll add tests for install dir detection. As for detection of bitcode files,
> perhaps I should remove it from this patch and commit it along with the code
> that's going to use it and where I can test it.
Seems
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
-eric
http://reviews.llvm.org/D12989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Seems to be what we were chatting about.
Thanks!
-eric
http://reviews.llvm.org/D13067
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
echristo added a subscriber: echristo.
echristo added a comment.
Aha, nice catch!
-eric
Repository:
rL LLVM
http://reviews.llvm.org/D12989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Aha, nice catch!
-eric
On Wed, Sep 23, 2015 at 9:32 PM NAKAMURA Takumi
wrote:
> chapuni added a subscriber: chapuni.
>
>
> Comment at: cfe/trunk/lib/Driver/ToolChains.cpp:1492
> @@ +1491,3 @@
> +const llvm::opt::ArgList
> &Args) {
> +
Author: echristo
Date: Thu Sep 24 16:17:04 2015
New Revision: 248539
URL: http://llvm.org/viewvc/llvm-project?rev=248539&view=rev
Log:
Move the darwin define static function to be close to the OS define.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
Author: echristo
Date: Thu Sep 24 16:17:02 2015
New Revision: 248538
URL: http://llvm.org/viewvc/llvm-project?rev=248538&view=rev
Log:
Use just one larger anonymous namespace instead of a lot of smaller ones.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
Author: echristo
Date: Fri Sep 25 12:44:31 2015
New Revision: 248592
URL: http://llvm.org/viewvc/llvm-project?rev=248592&view=rev
Log:
The Clang gcc-compatible driver (clang/tools/driver/driver.cpp) has some
logic to select an alternate target based on the executable it was
called as. For instance
Oh, sure I can.
Done thusly:
dzur:~/sources/llvm/tools/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
M include/clang/Driver/ToolChain.h
M lib/Driver/ToolChain.cpp
M tools/driver/driver.cpp
Committed r248592
-eric
On Fri, Sep 25, 2015 at 10:20 AM Luke Zark
echristo added a subscriber: echristo.
echristo added a comment.
Oh, sure I can.
Done thusly:
dzur:~/sources/llvm/tools/clang> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/cfe/trunk ...
M include/clang/Driver/ToolChain.h
M lib/Driver/ToolChain.cpp
M tools/driver/driver.cpp
Com
Author: echristo
Date: Fri Sep 25 20:25:08 2015
New Revision: 248645
URL: http://llvm.org/viewvc/llvm-project?rev=248645&view=rev
Log:
Replace a loop and temporary string copying with llvm::join.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp
echristo added a comment.
Bikeshed: it's part of the clang headers, do we really need "clang" in the
header name?
-eric
http://reviews.llvm.org/D13171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
echristo added a subscriber: echristo.
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
One inline comment reword.
Comment at: lib/CodeGen/CGClass.cpp:2111
@@ -2110,1 +2110,3 @@
+ // FIXME: It looks like InstCombine is very ineffic
Actually using the right list now...
On Mon, Sep 28, 2015 at 4:39 PM Eric Christopher wrote:
> Hi Adrian,
>
>
>>: CGO(new CodeGenOptions),
>> -CGM(new CodeGen::CodeGenModule(C, *CGO, M, TD, C.getDiagnostics(),
>> +HSO(new HeaderSearchOptions),
>> +PPO(new PreprocessorOptions),
>>
echristo added a comment.
Why not just call it cuda.h and use #include next for it and then fix it up?
-eric
http://reviews.llvm.org/D13171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
This seems a little odd, could you explain in a bit more detail? Me not
understanding I imagine. :)
-eric
On Wed, Sep 30, 2015, 7:48 PM Luke Zarko wrote:
> zarko created this revision.
> zarko added reviewers: rnk, echristo, klimek.
> zarko added a subscriber: cfe-commits.
> Herald added subscr
echristo added a subscriber: echristo.
echristo added a comment.
This seems a little odd, could you explain in a bit more detail? Me not
understanding I imagine. :)
-eric
http://reviews.llvm.org/D13318
___
cfe-commits mailing list
cfe-commits@lists
echristo added a comment.
BTW as Manuel is happy it's fine with me. Still curious though.
http://reviews.llvm.org/D13318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: echristo
Date: Tue Aug 11 18:17:31 2015
New Revision: 244695
URL: http://llvm.org/viewvc/llvm-project?rev=244695&view=rev
Log:
Untabify.
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeG
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for working on this.
-eric
http://reviews.llvm.org/D11993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: echristo
Date: Thu Aug 13 16:34:35 2015
New Revision: 244959
URL: http://llvm.org/viewvc/llvm-project?rev=244959&view=rev
Log:
Fix some coding standard issues and delete a dead conditional.
Modified:
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp
UR
echristo added a comment.
Hi Hal,
No, TargetOptions is exactly the wrong place to handle this due to wanting to
have various functions compiled with and without a force aligned stack at the
IR level that might not hold up at LTO time.
-eric
http://reviews.llvm.org/D11815
_
echristo added a comment.
No, RESET_OPTION isn't the right way to do this either. For exactly this sort
of reason. You can't actually represent all of the code and options this way in
the IR. If you can't do that then it's a non-starter.
-eric
http://reviews.llvm.org/D11815
___
On Thu, Aug 13, 2015 at 5:16 PM hfin...@anl.gov wrote:
> hfinkel added a comment.
>
> In http://reviews.llvm.org/D11815#224169, @echristo wrote:
>
> > No, RESET_OPTION isn't the right way to do this either. For exactly this
> sort of reason. You can't actually represent all of the code and option
>
>
> > Apologies, I'm really resistant to more things being used in
> > TargetOptions and I was (perhaps mistakenly) under the impression
> > that you wanted to move it to TargetOptions without an IR
> > serialization. We need all options to have that sort of
> > serialization right? :)
>
> Absolu
This is fine, but would you mind moving it to the cmake and autoconf checks
respectively? Probably near the warning checks where we already check for
compiler.
On Fri, Aug 14, 2015, 10:41 AM Chris Bieneman wrote:
> beanz updated this revision to Diff 32163.
> beanz added a comment.
>
> Should ha
On Sun, Aug 16, 2015 at 3:05 AM Simon Pilgrim
wrote:
> RKSimon added a comment.
>
> Yes using that uninitialized value has worried me as well. I originally
> set it to zero (and considered using __ LINE __ or __ COUNTER __) but both
> introduce defined behaviour that I could see causing all sorts
On Mon, Aug 17, 2015 at 11:57 AM Akira Hatanaka wrote:
> On Thu, Aug 13, 2015 at 5:56 PM, Eric Christopher
> wrote:
>
>>
>>> > Apologies, I'm really resistant to more things being used in
>>> > TargetOptions and I was (perhaps mistakenly) under the impression
>>> > that you wanted to move it to
There is nothing broken about not having the include guards there, it's
just not helpful. I'm working on the infrastructure for an error if you
call a function from within an incompatible routine at the moment (without
duplicating a lot of code it's actually a bit annoying), but there's
nothing act
Author: echristo
Date: Mon Aug 17 17:22:28 2015
New Revision: 245251
URL: http://llvm.org/viewvc/llvm-project?rev=245251&view=rev
Log:
Remove dead code, there's no need for an override that just duplicates
the default behavior.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/li
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Sure I guess. I'm still not sure why we can't do this in the configure side of
things, but I don't really care that much for now.
http://reviews.llvm.org/D12036
___
On Tue, Aug 18, 2015 at 10:51 AM Dimitry Andric wrote:
> The problems from my earlier mail still stand, even with trunk r245199.
>
> 1) Various configure scripts (e.g. lame and others) try to check for
> intrinsics using fragments similar to the following:
>
> #include
>
> then running that thro
On Tue, Aug 18, 2015 at 11:05 AM Dimitry Andric wrote:
> > On 18 Aug 2015, at 19:52, Eric Christopher wrote:
> >
> >
> >
> > On Tue, Aug 18, 2015 at 10:51 AM Dimitry Andric
> wrote:
> > The problems from my earlier mail still stand, even with trunk r245199.
> >
> > 1) Various configure scripts
Author: echristo
Date: Tue Aug 18 21:24:21 2015
New Revision: 245405
URL: http://llvm.org/viewvc/llvm-project?rev=245405&view=rev
Log:
Rename getDefaultFeatures -> initDefaultFeatures and update comment
with the current behavior as the name seems to match what's going on.
Modified:
cfe/trunk/
Author: echristo
Date: Fri Aug 21 11:24:01 2015
New Revision: 245706
URL: http://llvm.org/viewvc/llvm-project?rev=245706&view=rev
Log:
Fix typo - symetric -> symmetric.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL:
http://llvm.org/viewvc/ll
echristo added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:166-170
@@ +165,7 @@
+std::vector ModuleFuncNames;
+// We need to internalize contents of the linked module but it
+// has to be done *after* the linking because internalized
+
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
This seems like a decent incremental improvement. I think we still need to
separate out the pipeline a bit further and have the cuda compilation just be
separate actions that don't need th
echristo added inline comments.
Comment at: lib/CodeGen/CodeGenAction.cpp:181-190
@@ -166,2 +180,12 @@
return;
+if (LangOpts.CUDA && LangOpts.CUDAIsDevice &&
+LangOpts.CUDAUsesLibDevice) {
+ legacy::PassManager passes;
+ passes.add(
echristo added inline comments.
Comment at: include/clang/Driver/Options.td:1853-1854
@@ -1853,1 +1852,4 @@
+def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker ">,
Group;
+def linker : Separate<["-"], "linker">, Alias,
MetaVarName<"">;
+def linker_EQ : Joined<["-"]
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
One inline comment and then OK.
-eric
Comment at: test/Driver/fuse-ld.c:27-33
@@ -26,1 +26,9 @@
+// -linker= is an alias to fuse-ld. Don't need to retry all combination
echristo added inline comments.
Comment at: include/clang/Driver/Options.td:1853
@@ -1853,1 +1852,3 @@
+def fuse_ld_EQ : Joined<["-"], "fuse-ld=">, HelpText<"Use linker ">,
Group;
+def linker_EQ : Joined<["-"], "linker=">, Alias,
MetaVarName<"">;
thakis wrote:
Author: echristo
Date: Mon Aug 24 19:59:11 2015
New Revision: 245914
URL: http://llvm.org/viewvc/llvm-project?rev=245914&view=rev
Log:
Reimplement the PPC explicit option checking to be a bit more obvious
that we're looking for conflicting options and give an explanation.
Modified:
cfe/trunk/
echristo added a comment.
How about:
13. [apple,
14. banana,
15. cherry]{
16. printf("apple = %d\n",apple);
17. printf("banana = %d\n",banana);
18. printf("cherry = %d\n",cherry);
Should be 13, 14, 15 yes?
-eric
http://reviews.llvm.org/D12134
___
Author: echristo
Date: Tue Aug 25 08:45:24 2015
New Revision: 245935
URL: http://llvm.org/viewvc/llvm-project?rev=245935&view=rev
Log:
Extract handling of user defined features into a function so we can
specialize it on the targets.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe
Author: echristo
Date: Tue Aug 25 08:45:28 2015
New Revision: 245936
URL: http://llvm.org/viewvc/llvm-project?rev=245936&view=rev
Log:
Rewrite the PPC target feature handling to more resemble other targets.
This involved specializing handleUserFeatures so that we could perform
diagnostics on -onl
Yeah. I can't see a difference here being useful, and more likely harmful.
On Tue, Aug 25, 2015, 8:48 AM David Blaikie wrote:
> On Tue, Aug 25, 2015 at 8:44 AM, Bataev, Alexey
> wrote:
>
>> Debug info points to the real place where it is captured, while
>> diagnostics points to the first use of
c
> Thanks again,
> Hal
>
> ----- Original Message -----
> > From: "Eric Christopher via cfe-commits"
> > To: cfe-commits@lists.llvm.org
> > Sent: Monday, August 24, 2015 7:59:11 PM
> > Subject: r245914 - Reimplement the PPC explicit option checking to be a
> bi
Author: echristo
Date: Tue Aug 25 23:23:11 2015
New Revision: 246006
URL: http://llvm.org/viewvc/llvm-project?rev=246006&view=rev
Log:
Update file comment to more accurately describe what's implemented.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
Author: echristo
Date: Wed Aug 26 02:01:30 2015
New Revision: 246020
URL: http://llvm.org/viewvc/llvm-project?rev=246020&view=rev
Log:
Remove a TODO that isn't going to get fixed in this way.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llv
Author: echristo
Date: Wed Aug 26 02:01:33 2015
New Revision: 246021
URL: http://llvm.org/viewvc/llvm-project?rev=246021&view=rev
Log:
Remove dead code associated with parsing and setting ABI based on
string name.
Modified:
cfe/trunk/include/clang/Basic/TargetCXXABI.h
cfe/trunk/include/cl
Author: echristo
Date: Wed Aug 26 02:29:58 2015
New Revision: 246024
URL: http://llvm.org/viewvc/llvm-project?rev=246024&view=rev
Log:
Group some of the inline assembly related function prototypes near
each other.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
Modified: cfe/trunk/inclu
Author: echristo
Date: Wed Aug 26 03:21:55 2015
New Revision: 246027
URL: http://llvm.org/viewvc/llvm-project?rev=246027&view=rev
Log:
Convert a bunch of loops to ranged-for and clean up accordingly.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
ht
Author: echristo
Date: Wed Aug 26 18:42:18 2015
New Revision: 246122
URL: http://llvm.org/viewvc/llvm-project?rev=246122&view=rev
Log:
Pull out cpu string -> enum parsing for x86 as a separate function,
this is going to see use shortly in unifying feature set construction.
Modified:
cfe/trunk
Author: echristo
Date: Wed Aug 26 19:05:50 2015
New Revision: 246127
URL: http://llvm.org/viewvc/llvm-project?rev=246127&view=rev
Log:
const-ify X86TargetInfo::getCPUKind.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.org/viewvc/llvm-pr
Author: echristo
Date: Wed Aug 26 19:05:52 2015
New Revision: 246128
URL: http://llvm.org/viewvc/llvm-project?rev=246128&view=rev
Log:
Pass in a cpu to initDefaultFeatures so that we can share this code
with multiple uses of feature map construction.
Note: We could make this a static function on
Author: echristo
Date: Thu Aug 27 13:42:57 2015
New Revision: 246180
URL: http://llvm.org/viewvc/llvm-project?rev=246180&view=rev
Log:
const-ify TargetInfo::handleUserFeatures.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/includ
Author: echristo
Date: Thu Aug 27 14:59:34 2015
New Revision: 246195
URL: http://llvm.org/viewvc/llvm-project?rev=246195&view=rev
Log:
Rewrite the code generation handling for function feature and cpu attributes.
A couple of changes here:
a) Do less work in the case where we don't have a target
Author: echristo
Date: Thu Aug 27 15:05:48 2015
New Revision: 246197
URL: http://llvm.org/viewvc/llvm-project?rev=246197&view=rev
Log:
Target attribute syntax compatibility fix - gcc uses no- rather than mno-.
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/test/CodeGen/attr-target-p
Author: echristo
Date: Thu Aug 27 15:05:46 2015
New Revision: 246196
URL: http://llvm.org/viewvc/llvm-project?rev=246196&view=rev
Log:
Rename this file to have a processor suffix to help identify.
Added:
cfe/trunk/test/CodeGen/attr-target-x86.c
- copied, changed from r246195, cfe/trunk/
>
>
> > -assert(Features[i][0] == '+' && "Invalid target feature!");
> > +assert(Feature[0] == '+' && "Invalid target feature!");
>
> This assert is kind of pointless now, since we'll have continued in that
> case and the following code will DTRT anyway.
>
>
Was fairly pointless to begin wi
Author: echristo
Date: Thu Aug 27 15:32:24 2015
New Revision: 246202
URL: http://llvm.org/viewvc/llvm-project?rev=246202&view=rev
Log:
Remove a dead assert, we'd have gotten the case above.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.
On Thu, Aug 27, 2015 at 1:29 PM Eric Christopher wrote:
>
>> > -assert(Features[i][0] == '+' && "Invalid target feature!");
>> > +assert(Feature[0] == '+' && "Invalid target feature!");
>>
>> This assert is kind of pointless now, since we'll have continued in that
>> case and the followin
Author: echristo
Date: Thu Aug 27 17:20:03 2015
New Revision: 246225
URL: http://llvm.org/viewvc/llvm-project?rev=246225&view=rev
Log:
Use an explicit assignment.
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
http://llvm.org/viewvc/llvm-project/c
echristo added inline comments.
Comment at: lib/Driver/Tools.cpp:4232
@@ +4231,3 @@
+ false))
+CmdArgs.push_back(Args.MakeArgString("-force-align-stack"));
+
hfinkel wrote:
> The code below for OPT_mstackrealign uses -mstackrealign as the nam
echristo added inline comments.
Comment at: lib/Driver/Tools.cpp:4232
@@ +4231,3 @@
+ false))
+CmdArgs.push_back(Args.MakeArgString("-force-align-stack"));
+
hfinkel wrote:
> echristo wrote:
> > hfinkel wrote:
> > > The code below for OPT_mst
Author: echristo
Date: Thu Aug 27 21:13:58 2015
New Revision: 246259
URL: http://llvm.org/viewvc/llvm-project?rev=246259&view=rev
Log:
Merge the two feature map setting functions into a single function
and replace all callers.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk
Author: echristo
Date: Thu Aug 27 21:14:00 2015
New Revision: 246260
URL: http://llvm.org/viewvc/llvm-project?rev=246260&view=rev
Log:
Instead of duplicating code, call the base implementation.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://l
Hi Ahmed,
A quick note: I think this is going to fail in the presence of the target
attribute. I.e. if someone decorates a function with
__attribute__((target("avx512"))) this is unlikely to catch that.
Also, should we do this for all of the x86 OSes?
-eric
On Thu, Aug 27, 2015 at 3:31 PM Ahmed
Author: echristo
Date: Fri Aug 28 17:32:01 2015
New Revision: 246346
URL: http://llvm.org/viewvc/llvm-project?rev=246346&view=rev
Log:
Fold TargetInfo::handleUserFeatures into TargetInfo::initFeatureMap.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk/lib/Basic/Targets.cpp
Author: echristo
Date: Fri Aug 28 21:59:37 2015
New Revision: 246355
URL: http://llvm.org/viewvc/llvm-project?rev=246355&view=rev
Log:
Add a check for a function we're not testing.
Modified:
cfe/trunk/test/CodeGen/attr-target-x86.c
Modified: cfe/trunk/test/CodeGen/attr-target-x86.c
URL:
htt
Author: echristo
Date: Mon Aug 31 13:39:22 2015
New Revision: 246468
URL: http://llvm.org/viewvc/llvm-project?rev=246468&view=rev
Log:
Pull the target attribute parsing out of CGCall and onto TargetInfo.
Also:
- Add a typedef to make working with the result easier.
- Update callers to use the
Author: echristo
Date: Mon Aug 31 13:39:16 2015
New Revision: 246467
URL: http://llvm.org/viewvc/llvm-project?rev=246467&view=rev
Log:
Pull out the ppc incompatible features check into a separate function.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
UR
echristo added a subscriber: echristo.
echristo added a comment.
Some inline comments.
Thanks!
-eric
Comment at: include/clang/Basic/TargetCXXABI.h:166
@@ -148,1 +165,3 @@
+ /// \brief Are member functions differently aligned?
+ bool areMemberFunctionsAligned() const {
---
903/steps/gclient%20runhooks/logs/stdio
>
> On Mon, Aug 31, 2015 at 11:39 AM, Eric Christopher via cfe-commits
> wrote:
> > Author: echristo
> > Date: Mon Aug 31 13:39:22 2015
> > New Revision: 246468
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=24
Author: echristo
Date: Mon Aug 31 18:19:55 2015
New Revision: 246508
URL: http://llvm.org/viewvc/llvm-project?rev=246508&view=rev
Log:
Revert "Pull the target attribute parsing out of CGCall and onto TargetInfo."
This reverts commit r246468 while we figure out what to do about Basic and AST.
Mod
On Mon, Aug 31, 2015 at 4:34 PM Richard Smith wrote:
> On Mon, Aug 31, 2015 at 11:39 AM, Eric Christopher via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: echristo
>> Date: Mon Aug 31 13:39:22 2015
>> New Revision: 246468
>>
>>
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
The ternary is a bit ugly, but LGTM. :)
-eric
http://reviews.llvm.org/D11664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: echristo
Date: Tue Sep 1 13:13:20 2015
New Revision: 246565
URL: http://llvm.org/viewvc/llvm-project?rev=246565&view=rev
Log:
Pull initFeatureMap out of line now that it's used in multiple places.
Modified:
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk/lib/Basic/TargetInfo
Author: echristo
Date: Tue Sep 1 17:03:58 2015
New Revision: 246596
URL: http://llvm.org/viewvc/llvm-project?rev=246596&view=rev
Log:
Migrate the target attribute parsing code into an extension off of
the main attribute and cache the results so we don't have to parse
a single attribute more than
Author: echristo
Date: Tue Sep 1 17:03:56 2015
New Revision: 246595
URL: http://llvm.org/viewvc/llvm-project?rev=246595&view=rev
Log:
Use hasAttr, not getAttr if we're just checking for presence.
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
htt
Author: echristo
Date: Tue Sep 1 17:37:03 2015
New Revision: 246598
URL: http://llvm.org/viewvc/llvm-project?rev=246598&view=rev
Log:
Revert "Migrate the target attribute parsing code into an extension off of"
This is failing in release mode. Revert while I figure out what's happening.
This rev
Author: echristo
Date: Tue Sep 1 19:12:02 2015
New Revision: 246610
URL: http://llvm.org/viewvc/llvm-project?rev=246610&view=rev
Log:
Migrate the target attribute parsing code into an extension off of
the main attribute and cache the results so we don't have to parse
a single attribute more than
On Wed, Sep 2, 2015 at 7:24 AM Aaron Ballman wrote:
> A few nits in addition to what Ben pointed out...
>
> On Tue, Sep 1, 2015 at 8:12 PM, Eric Christopher via cfe-commits
> wrote:
> > Author: echristo
> > Date: Tue Sep 1 19:12:02 2015
> > New Revision: 24661
Author: echristo
Date: Wed Sep 2 15:13:41 2015
New Revision: 246701
URL: http://llvm.org/viewvc/llvm-project?rev=246701&view=rev
Log:
Update comment for AdditionalMembers with a note to avoid using
additional data members in attributes as they'll leak and provide
some guidance as to where they sh
gt; >>
> >> On Tue, Sep 1, 2015 at 8:12 PM, Eric Christopher via cfe-commits
> >> wrote:
> >> > Author: echristo
> >> > Date: Tue Sep 1 19:12:02 2015
> >> > New Revision: 246610
> >> >
> >> > URL: http://llvm.org/viewvc/ll
Author: echristo
Date: Wed Sep 2 15:40:12 2015
New Revision: 246706
URL: http://llvm.org/viewvc/llvm-project?rev=246706&view=rev
Log:
Migrate the target attribute parsing code to returning an instance
every time it's called rather than attempting to cache the result.
It's unlikely to be called fr
Wed, Sep 2, 2015 at 1:07 PM, Eric Christopher
>> wrote:
>> >
>> >
>> > On Wed, Sep 2, 2015 at 7:24 AM Aaron Ballman
>> wrote:
>> >>
>> >> A few nits in addition to what Ben pointed out...
>> >>
>> >> On Tue, Sep
echristo added a comment.
Replying to the inline comments. I know we're waiting on the linker stuff, but
Katya made me realize I hadn't replied to your comments.
-eric
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:203-208
@@ +202,8 @@
+ InGroup;
+def warn_drv_ps4_s
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
A couple things inline that need changing, but feel free to commit after
without a repost.
-eric
Comment at: lib/Basic/Targets.cpp:6943-6944
@@ +6942,4 @@
+
+ Diags.Report(diag
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
If you could interleave the test and the check I'd really appreciate it, e.g.:
__asm__ ("mov r8w, 100;");
// CHECK: call void asm sideeffect "mov r8w, 100;"
Otherwise LGTM. Thanks!
-er
echristo added inline comments.
Comment at: lib/Basic/Targets.cpp:7643-7649
@@ +7642,9 @@
+ case llvm::Triple::wasm64:
+// Until specific variations are defined, don't permit any.
+if (!(Triple == llvm::Triple("wasm64-unknown-unknown")) ||
+(!Triple.getVendorName(
Author: echristo
Date: Thu Sep 3 19:15:47 2015
New Revision: 246826
URL: http://llvm.org/viewvc/llvm-project?rev=246826&view=rev
Log:
Untabify.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/inc
Author: echristo
Date: Thu Oct 8 15:10:18 2015
New Revision: 249733
URL: http://llvm.org/viewvc/llvm-project?rev=249733&view=rev
Log:
Handle sse turning on mmx, but no -mmx not turning off SSE.
Rationale :
// sse3
__m128d test_mm_addsub_pd(__m128d A, __m128d B) {
return _mm_addsub_pd(A, B);
}
Author: echristo
Date: Thu Oct 8 15:10:14 2015
New Revision: 249732
URL: http://llvm.org/viewvc/llvm-project?rev=249732&view=rev
Log:
Migrate most feature map inclusion to initFeatureMap for the x86 target so
that we can build up an accurate set of features rather than relying on
TargetInfo initi
Pending naming from llvm review, LGTM.
On Thu, Oct 8, 2015 at 1:55 PM Stephen Hines wrote:
> srhines added a comment.
>
> LGTM
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13572
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.
201 - 300 of 571 matches
Mail list logo
