[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This looks fine to me now, might be good to get someone else to ack as well though. https://reviews.llvm.org/D27872 ___ cfe-commits mailing

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

echristo added a comment. Hal has given an ack (offline) as well. Go ahead Tim. https://reviews.llvm.org/D27872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

echristo closed this revision. echristo added a comment. This was committed: commit d65cd1f9424369c4ae7f945fac7fd9e4357451b2 Author: Sean Fertile Date: Thu Jan 5 21:43:30 2017 + Add vec_insert4b and vec_extract4b functions to altivec.h Add builtins for the functions and custom code

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

echristo added a comment. Can we not get llc to use the diags interfaces here? https://reviews.llvm.org/D29770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sorry, when I say "One inline comment otherwise LGTM" feel free to commit after fixing :) Since you have, then LGTM. -eric Repository: rL LLVM https://reviews.llvm.org/D33820

[PATCH] D34425: Unified ARM logic for computing target ABI.

echristo added a comment. I've committed this for you as: M lib/Driver/ToolChains/Clang.cpp M test/CodeGen/arm-v8.1a-neon-intrinsics.c M test/CodeGen/named_reg_global.c M test/CodeGen/neon-immediate-ubsan.c M test/CodeGen/xray-attribut

[PATCH] D35131: Prevent ClangTools from generating dependency files.D34304 created a way for ToolInvocations to conditionally generatedependency files, and updated call sites to preserve the old behav

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This sort of thing seems obvious in the future :) -eric https://reviews.llvm.org/D35131 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D35519: Add SEMA checking to attribute 'target'

echristo added a comment. If you wouldn't mind I'd like to see this separated out a bit - a) I think we can make the attribute info a struct rather than a pair as a simple change first b) setCPU split c) let's see where we are after that? Also the description makes it sound like you're adding su

[PATCH] D35449: [X86] Implement __builtin_cpu_is

echristo added a subscriber: erichkeane. echristo added a comment. Adding Erich Keane here on this since he's working on something similar for the target attribute. -eric https://reviews.llvm.org/D35449 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D35449: [X86] Implement __builtin_cpu_is

echristo added a comment. From my perspective here once you and Erich get some agreement on the checking between your two bits I'm fine :) -eric https://reviews.llvm.org/D35449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D35449: [X86] Implement __builtin_cpu_is

echristo added a comment. FWIW the duplication in CGCall.cpp of the enum set is painful if you can come up with anything else it'd be awesome. I don't have any good ideas, just a fond wish :) https://reviews.llvm.org/D35449 ___ cfe-commits mailing

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

echristo added a comment. Can you update the code in CGBuiltin to use this as part of this patch? :) Thanks! https://reviews.llvm.org/D35572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D35573: Improve SEMA for attribute-target

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM pending dependency approval https://reviews.llvm.org/D35573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D35574: Convert attribute 'target' parsing from a 'pair' to a 'struct' to make further improvements easier

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D35574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

echristo added a comment. In https://reviews.llvm.org/D35572#813520, @erichkeane wrote: > In https://reviews.llvm.org/D35572#813369, @echristo wrote: > > > Can you update the code in CGBuiltin to use this as part of this patch? :) > > > > Thanks! > > > I'm not sure which you're referring to? I d

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

echristo added a comment. LGTM. -eric https://reviews.llvm.org/D35572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35708: Remove Bitrig: Clang Changes

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D35709: Remove Bitrig: CompilerRT Changes

echristo accepted this revision. echristo added a comment. LGTM. https://reviews.llvm.org/D35709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

echristo added a comment. So, what's the overall logical idea behind the need for this option? While I understand that you don't want people just doing this via the -mllvm set of options, but if you're just doing this to provide a temporary option rather than turning it off in the backend I'm n

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. I'm going to say this ahead of time without looking into it "LGTM", but wait for ctopper (or someone else) to ack it for style etc since I'm unlikely to get to it any time shortly. :) Als

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

echristo added a comment. In https://reviews.llvm.org/D35577#817267, @sgundapa wrote: > The discussion is scattered across these patches > https://reviews.llvm.org/D35578 and https://reviews.llvm.org/D35579. > I will provide a brief summary here: > > The idea is to control the generation of dat

[PATCH] D42110: Move target MV resolver to COMDAT

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems reasonable. https://reviews.llvm.org/D42110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Let me know if you need this committed. Repository: rC Clang https://reviews.llvm.org/D42227 ___ cfe-commits mailing list cfe-commi

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

echristo added a comment. In https://reviews.llvm.org/D29770#674961, @sanwou01 wrote: > Use clang_cc1 -verify for testing as suggested by @rnk. > > @echristo, llc does use the same diags interfaces as clang, however, it is > lacking the infrastructure to make use of LocCookies. > > In any case,

[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D27066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D25435: Add -femit-accurate-debug-info to emit more debug info for sample pgo profile collection

echristo added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745 if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs && !CGM.getCodeGenOpts().EmitGcovNotes && + !CGM.getCodeGenOpts().Profil

[PATCH] D25435: Add -femit-accurate-debug-info to emit more debug info for sample pgo profile collection

echristo added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745 if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs && !CGM.getCodeGenOpts().EmitGcovNotes && + !CGM.getCodeGenOpts().Profil

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

echristo accepted this revision. echristo added a comment. Couple of small nits and a request to make some of the change separately, but otherwise LGTM. For the split part please don't actually submit another patch, just go ahead and do it :) Thanks! -eric Comment at: inclu

[PATCH] D33448: [CodeGen] Add thumb-mode to function target-features for arm/thumb triples.

echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. I probably would have added this as a feature in ARMTargetInfo similar to CRC/soft-float/etc. Thoughts? -eric https://reviews.llvm.org/D33448 __

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

echristo added inline comments. Comment at: clang/test/Frontend/invalid-cxx-abi.cpp:1 +// These should succeed. +// RUN: %clang -c -fc++-abi=itanium %s Following up on an offline conversation :) This should be a driver test rather than (what it ended up being) a

[PATCH] D101867: [clang][test] Update -fc++-abi tests

echristo added a comment. Couple cleanups, but should be better now. Thanks! -eric Comment at: clang/test/Driver/cxx-abi-flag.cpp:3 +// RUN: %clang -### -fc++-abi=itanium -target x86_64-unknown-linux-gnu %s \ +// RUN: |& FileCheck %s -check-prefix=ITANIUM +// RUN: %clang -##

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

echristo added a comment. In D17183#2656771 , @jyknight wrote: > In general, I think it's extremely unfortunate that Clang and LLVM have > different copies of the same information. It's a problem for way more than > just this one situation. So, I really

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

echristo added a comment. In D100776#2699603 , @thakis wrote: > In D100776#2699565 , @rnk wrote: > >> Of the three people who commented on D17183 >> , you and I are on the only on

<    1   2   3