Add BeforeWhileInDoWhile BraceWrapping option

2016-01-10 Thread Eric Baker via cfe-commits
Code like this: do { // Some code } while (1); becomes: do { // Some code } while (1); I couldn't think of a better name for the option than BeforeWhileInDoWhile. I'm open to suggestions! Also, this is my first attempt at submitting a patch for this project.

[PATCH] D16066: Add BeforeWhileInDoWhile BraceWrapping option

2016-01-11 Thread Eric Baker via cfe-commits
ebaker355 created this revision. ebaker355 added a subscriber: cfe-commits. Herald added a subscriber: klimek. Adds a new BraceWrapping option called BeforeWhileInDoWhile. Code like this: do { // Some code } while (1); becomes: do { // Some code } while (1);

Re: [PATCH] D16066: Add BeforeWhileInDoWhile BraceWrapping option

2016-01-11 Thread Eric Baker via cfe-commits
ebaker355 updated this revision to Diff 44506. ebaker355 added a comment. Remove unintended blank line change. http://reviews.llvm.org/D16066 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-25 Thread Eric Baker via cfe-commits
ebaker355 added a comment. Ping. Anyone have an opinion on this? http://reviews.llvm.org/D16066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-26 Thread Eric Baker via cfe-commits
ebaker355 added a comment. Thanks for responding, and for the documentation link! It is certainly wise to not attempt "to supporting every single style used by a codebase somewhere in the wild." I do not know of a predefined coding style that recommends this format. My thinking was: - it comp

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-26 Thread Eric Baker via cfe-commits
ebaker355 abandoned this revision. ebaker355 added a comment. Since I cannot meet these criteria: - be used in a project of significant size (have dozens of contributors) - have a publicly accessible style guide I will abandon this revision request. Thank you for considering! http://reviews.ll

Re: [PATCH] D16066: [clang-format] Add BeforeWhileInDoWhile BraceWrapping option

2016-01-26 Thread Eric Baker via cfe-commits
ebaker355 reclaimed this revision. ebaker355 added a comment. Ok, cool! :) Thanks! http://reviews.llvm.org/D16066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits