[PATCH] D48106: implemented proto to llvm

emmettneyman added inline comments. Comment at: tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:71 +return val_var; + } +} morehouse wrote: > Is it still possible for the protobuf to not have a constant, a binOp, or a > varRef? Right now, since the

[PATCH] D48106: implemented proto to llvm

emmettneyman updated this revision to Diff 151986. emmettneyman added a comment. - made changes to handle_llvm.cpp in response to reviewer comments Repository: rC Clang https://reviews.llvm.org/D48106 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer

[PATCH] D48106: implemented proto to llvm

emmettneyman updated this revision to Diff 152003. emmettneyman added a comment. - minor changes to improve readability and style Repository: rC Clang https://reviews.llvm.org/D48106 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp tools/clang

[PATCH] D48106: implemented proto to llvm

emmettneyman updated this revision to Diff 152005. emmettneyman added a comment. - removed unnecessary comment and fixed exit statement Repository: rC Clang https://reviews.llvm.org/D48106 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp tools

[PATCH] D48106: implemented proto to llvm

emmettneyman updated this revision to Diff 152006. emmettneyman added a comment. - actually fixed error statement Repository: rC Clang https://reviews.llvm.org/D48106 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp tools/clang-fuzzer/cxx_loop

[PATCH] D48106: implemented proto to llvm

emmettneyman added a comment. In https://reviews.llvm.org/D48106#1137224, @morehouse wrote: > Looks like `exit(0)` is still there. oops, forgot to `:w` Repository: rC Clang https://reviews.llvm.org/D48106 ___ cfe-commits mailing list cfe-commi

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman marked 3 inline comments as done. emmettneyman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">]; + let Subjects = SubjectList<[Record]>; --

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 209362. emmettneyman marked 2 inline comments as done. emmettneyman added a comment. Added documentation about using the attributes with unions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ htt

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1448 +def RequireDesignatedInitDocs : Documentation { + let Category = DocCatType; aaron.ballman wrote: > The behavior should be documented as to what happens when you apply

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman planned changes to this revision. emmettneyman added a comment. Changes planned: - Move diagnostics into a diagnostic group. - Add behavior and test cases for private members of structs/classes. - Investigate behavior of GCC `designated_init` attribute Repository: rG LLVM Github

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 210649. emmettneyman added a comment. Created diagnostic group, added behavior and documentation for private fields, added documentation regarding GCC attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman marked 16 inline comments as done. emmettneyman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequiresDesignator : InheritableAttr { + let Spellings = [Clang<"requires_designator">, GCC<"designated_init">]; + let Subjects = SubjectL

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 211988. emmettneyman marked 6 inline comments as done. emmettneyman added a comment. Addressed comments and feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208544. emmettneyman added a comment. Undo clang-format changes to SemaDecl.cpp and SemaDeclAttr.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: clang

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208741. emmettneyman marked 6 inline comments as done. emmettneyman added a comment. Small changes in response to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208814. emmettneyman marked 3 inline comments as done. emmettneyman added a comment. Changed attribute spelling from GNU to CXX11 and renamed the 'required' attribute to 'designated_init_required' Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208829. emmettneyman added a comment. Updated tests and diagnostic messages with new attribute spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: cl

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208840. emmettneyman marked an inline comment as done. emmettneyman added a comment. Remove cppreference link, add reference to C++ spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://re

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208842. emmettneyman added a comment. slight change to specification reference format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: clang/include/clang/

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman added a comment. In D64380#1577350 , @compnerd wrote: > I don't see any cases where `[[clang::required]]` is tested, am I missing > something? I renamed the attribute at your suggestion. It's now called `[[clang::designated_init_required]`

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman marked 2 inline comments as done. emmettneyman added inline comments. Comment at: clang/test/SemaCXX/attr-designated-init-required.cpp:3 + +#define ATTR [[clang::designated_init_required]] + compnerd wrote: > Why the macro? I modeled this file after

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 209097. emmettneyman marked 32 inline comments as done. emmettneyman added a comment. Addressed several of the comments regarding naming and style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3533-3541 +def err_require_designated_init_failed : Error< + "variable declaration does not use designated initializer syntax">; +def note_declared_required_designated_init_here : No

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman planned changes to this revision. emmettneyman added a comment. Working on adding more information to the documentation and adding more in-depth unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 209256. emmettneyman added a comment. Small changes: adding `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: clang/include/clang/Basic/Attr.td cla

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman created this revision. emmettneyman added reviewers: morehouse, kcc. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: alexshap. Made changes to the llvm-proto-fuzzer - Added loop vectorizer optimization pass in order to have two IR versions - Updated old fuzz t

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman added a comment. The files Object.h Object.cpp llvm-objcopy.h are from llvm/tools/llvm-obj-copy with only slight modifications, mostly deleting irrelevant parts. Repository: rC Clang https://reviews.llvm.org/D49526 ___ cfe-c

<    1   2