[clang] [lld] [llvm] [AMDGPU] Rename COV module flag to amdhsa_code_object_version (PR #79905)

2024-03-06 Thread Emma Pilkington via cfe-commits
https://github.com/epilk closed https://github.com/llvm/llvm-project/pull/79905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [lld] [clang] [AMDGPU] Rename COV module flag to amdhsa_code_object_version (PR #79905)

2024-02-01 Thread Emma Pilkington via cfe-commits
@@ -25,4 +25,4 @@ entry: } !llvm.module.flags = !{!0} -!0 = !{i32 1, !"amdgpu_code_object_version", i32 500} +!0 = !{i32 1, !"amdhsa_code_object_version", i32 500} epilk wrote: Sure, I'll make a PR for that too after this lands. https://github.com/llvm/llvm-

[clang] [llvm] [lld] [AMDGPU] Rename COV module flag to amdhsa_code_object_version (PR #79905)

2024-01-29 Thread Emma Pilkington via cfe-commits
epilk wrote: @tstellar there was some uncertainty about whether to leave the spelling as-is since mesa used to following HSA code object versions (but doesn't anymore). Would you have any objections to this change? https://github.com/llvm/llvm-project/pull/79905 ___

[clang] Enable unguarded availability diagnostic on instantiated template functions (PR #91699)

2024-05-10 Thread Emma Pilkington via cfe-commits
@@ -177,16 +177,19 @@ void justAtAvailable(void) { #ifdef OBJCPP -int f(char) AVAILABLE_10_12; +int f(char) AVAILABLE_10_12; // #f_char_def int f(int); template int use_f() { - // FIXME: We should warn here! - return f(T()); epilk wrote: Could you che

[clang] [clang][CGRecordLayout] Remove dependency on isZeroSize (PR #96422)

2025-05-16 Thread Emma Pilkington via cfe-commits
epilk wrote: Hello, apologies for jumping in here so late, but this commit is changing the device function ABI on AMDGPU. For instance, for a device function returning this struct: ``` struct Empty {}; struct RetTy { int f1[3]; Empty e; int f2; }; __device__ RetTy deviceFn() { ... } ```