[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48a932e13e04: [clang-format] Remove special case for kw_operator when aligning decls (authored by rymiel). Repository: rG LLVM Github Monorepo CH

[PATCH] D137474: [clang-format] Defer formatting of operator< to honor paren spacing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf6f4b85138f: [clang-format] Defer formatting of operator< to honor paren spacing (authored by rymiel). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other ty

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

rymiel added a comment. I don't know sphinx enough to know if the trailing underscore is needed in links, but there's about 5 links that don't have the underscore (Search for >`) ) Comment at: clang/docs/ReleaseNotes.rst:577 + potential false positives, this diagnostic wi

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

rymiel added a comment. I think it's worthwhile to mark comments with the "Done" checkmark in Phrabricator if they have been addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://reviews.llvm.org/D142578

[PATCH] D142139: [clang-format] Disallow templates to be followed by literal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a3de13573bd: [clang-format] Disallow templates to be followed by literal (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

rymiel added inline comments. Comment at: clang/lib/Format/Format.cpp:3901 + return Comment.startswith(Prefix) && + (Comment.size() == Size || isblank(Comment[Size])); +} Should the space be required? What about `// clang-format off: reasoning` or simil

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cddd7a2a1d2: [clang-format][docs] Add ability to link to specific config options (authored by rymiel). Changed prior to commit: https://reviews.llvm.org/D138446?vs=476929&id=488720#toc Repository: r

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. (This needs to run the updated dump script from D138446 ) I'm not sure what the strict //benefit// of squishing the two options together is, but I support it

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

rymiel added a comment. This also made me wonder, is there an actual policy on deprecated options? As in, when they are actually removed. Is there even prior precedent for doing this? (I wouldn't know because I'm a very recent user) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. rymiel added a project: clang-format. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The trailing return

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel planned changes to this revision. rymiel added a comment. In D141811#4055485 , @HazardyKnusperkeks wrote: > What about `decltype(auto)`? Turns out this is a problem even without this patch: `decltype(auto) a = (b) -> c;` I'm sure this could som

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel added a comment. I suppose this means `auto a = (b) -> c;` is also technically broken, actually, and there's no easy fix for that. I did have an idea for adding an additional pass taking place somewhere in `TokenAnnotator::calculateFormattingInformation`, which would detect trailing ret

[PATCH] D142139: [clang-format] Disallow templates to be followed by literal

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. rymiel added a project: clang-format. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There should not be

[PATCH] D142139: [clang-format] Disallow templates to be followed by literal

rymiel updated this revision to Diff 490584. rymiel added a comment. Drop unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142139/new/ https://reviews.llvm.org/D142139 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Fo

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel added a comment. In D141811#4068180 , @HazardyKnusperkeks wrote: > I thought about `auto NAME() -> int { return 42; }`. > > `decltype(auto) a = (b) -> c;` is something else... I'm not sure how that affects this? Using `decltype(auto)` as in `dec

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other ty

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other ty

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other ty

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. Could the check be hoisted to the top of the loop? could that possibly catch more cases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138371/new/ https://reviews.llvm.org/D138371 ___ cfe-commits mailing list cfe-comm

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. Oops, nevermind, I misunderstood the loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138371/new/ https://reviews.llvm.org/D138371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. In D138371#3939938 , @HazardyKnusperkeks wrote: > In D138371#3939682 , @rymiel wrote: > >> Oops, nevermind, I misunderstood the loop > > To understand this is really a tough one. Took me s

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. The behaviour of tabs still doesn't match that of spaces, but at least this makes it idempotent. This also fixes https://github.com/llvm/llvm-project/issues/51808, I'm closing it as duplicate

[PATCH] D138441: [clang-format][docs] Fix invalid CSS syntax in versionbadge

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CSS uses colons, not the equals sign. The final semicolon

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows for the creation of permalinks to specific cl

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

rymiel added a comment. I consulted a little bit with a friend who has a little bit of experience with sphinx and they suggested making a simple custom extension for this. But given that there is no custom sphinx logic right now at all, I don't feel great adding something that novel to the whol

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

rymiel added a comment. Maybe the docs need somewhat of a fresh coat of paint. As a clang-format user it's odd to find the options listed as "ConfigName (`EnumName`)" but when listing the actual options it's "`EnumOption` (In configuration: `ConfigOption`)". At the very least, the order of the l

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

rymiel added inline comments. Comment at: clang/include/clang/Frontend/DiagnosticRenderer.h:130 /// \param Message The diagnostic message to emit. + /// \param Reason Supplementary information for the message. /// \param Ranges The underlined ranges for this code snippet.

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch properly recognizes the generic selection expr

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel added a comment. I put WIP in the title right now because firstly, I still need to write more tests, but also, since I haven't touched the breaking and indenting part of the code before, I want to make sure what I'm doing is sensible. Basically, after making the colons their own type so

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel created this revision. rymiel added a project: clang. rymiel added reviewers: aaron.ballman, erichkeane. Herald added a project: All. rymiel requested review of this revision. Herald added a subscriber: cfe-commits. Since P0857, part of C++20, a *lambda-expression* can contain a *requires-c

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !IsLambdaRequiresClause && (IsT

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505499. rymiel added a comment. Slightly rewrite CheckForNonPrimary for slightly better clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/include/

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:116 // primary-expression, and complain that it is of non-bool type. - (NextToken.is(tok::l_paren) && + (NextToken.is(tok::l_paren) && !I

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505525. rymiel added a comment. utilize getCurFunction() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/lib/Sema/SemaConcept.cpp clang/test/SemaTempl

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1283 ParseScope LambdaScope(this, Scope::LambdaScope | Scope::DeclScope | Scope::FunctionDeclarationScope | ---

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 505534. rymiel added a comment. Use dyn_cast_if_present, otherwise we segfault in some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/lib/Sema/Se

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel added a comment. In D146140#4196886 , @erichkeane wrote: > Ah, also, before commit, ensure that pre-commit CI passes. Yep, found an issue already ;; In D146140#4196866 , @erichkeane wrote: > I presume

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel requested review of this revision. rymiel added a comment. This revision is now accepted and ready to land. Okay, I planned changes because I had more ambitious plans for fixing this, but those didn't work out, so instead I made a separate issue (https://github.com/llvm/llvm-project/issue

[PATCH] D146281: [clang-format] Don't wrap struct return types as structs

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using BraceWra

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The noexcept specif

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 506121. rymiel added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaConcept.cpp

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6acdf58919d5: [clang] Properly parse variable template requires clause in lambda (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

rymiel added a comment. Yes, good point, I will do that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146284/new/ https://reviews.llvm.org/D146284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

rymiel updated this revision to Diff 506370. rymiel added a comment. Annotator tests (copied from format tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146284/new/ https://reviews.llvm.org/D146284 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 507439. rymiel added a comment. Fix `true` edge case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittest

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 507440. rymiel added a comment. Remove unnecessary musing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/uni

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. In D145642#4213256 , @usaxena95 wrote: > Another point: > While testing this patch, the following still fails to recognise. Might be > something special with `true`. > > auto y = [&] > requires true(Callable && callable) >

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1352 + + // Both at once? Probably not even valid. + Tokens = annotate("[] requires Foo (T t) requires Bar {}"); usaxena95 wrote:

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGead9644684e8: [clang-format] Annotate noexcept, explicit specifiers as containing expressions (authored by rymiel). Repository: rG LLVM Github Mon

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel updated this revision to Diff 507451. rymiel added a comment. Reduce column limit for macro test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141811/new/ https://reviews.llvm.org/D141811 Files: clang/lib/Format/TokenAnnotator.cpp clang

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. So, it took me a while but I finally found where the logic is that makes the lambda braces stay on one line, but, now I'm not so sure if I should change it: The thing I wanted to avoid was cases like [&](T&& t) requires T { t; }; Simply because "those braces don't

[PATCH] D141811: [clang-format] Allow trailing return types in macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc70e360b355a: [clang-format] Allow trailing return types in macros (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D146760: [clang-format] Treat NTTP default values as expressions

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-format alread

[PATCH] D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. Could this possibly be an issue for more esoteric underscore-less UDLs, like `i`? Does the code need to search for a suffix, could it not detect the absence of a digit? Sorry if the questions

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5409fb38372d: [clang-format] Annotate lambdas with requires clauses. (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D146281: [clang-format] Don't wrap struct return types as structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8d2bff290e1: [clang-format] Don't wrap struct return types as structs (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D146760: [clang-format] Treat NTTP default values as expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb4f6c4dca98: [clang-format] Treat NTTP default values as expressions (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D144709: [clang-format] Improve west to east const

rymiel added a comment. just as a heads up, I'm applying https://reviews.llvm.org/D144537 since it's a quick bug fix; this patch *would* replace that one, but may need more time. (also conflicts may appear) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

rymiel added a comment. In D144537#4145545 , @MyDeveloperDay wrote: > maybe we should cherry pick into 16? It's up to one of you (mostly because I don't know how to do backports and I don't want to mess it up) Repository: rG LLVM Github Monorepo C

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ba91016c6ad: [clang-format] Rewrite how indent is reduced for compacted namespaces (authored by rymiel). Repository: rG LLVM Github Monorepo CHA

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG393e197cd6eb: [clang-format] Don't move qualifiers past pointers-to-member (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added a comment. In D144709#4158555 , @AlexanderHederstaf wrote: > Discovered incorrect code generation for `llvm/include/llvm/ADT/StringMap.h`. > > using base = StringMapIterBase, > const StringMapEntry>; > > w

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added a comment. This patch also fixes: https://github.com/llvm/llvm-project/issues/56111, https://github.com/llvm/llvm-project/issues/58696, and https://github.com/llvm/llvm-project/issues/54730 (some of those could probably be made duplicates but it seems they're all going down in one

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:523 + // TODO: Something strange is going on with this formating. + verifyFormat("Bar < Foo, Foo const >> ;", "Bar < Foo, const Foo >> ;", Style); + (see below) =

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:733 + // TODO: Something strange is going on with this formating. + verifyFormat("Bar < Foo, const Foo >> ;", "Bar < Foo, Foo const >> ;", Style); + AlexanderHederstaf wrot

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The C++ grammar all

[PATCH] D145656: [clang-format] Treat &/&& as reference when followed by requires clause

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the tok

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 503753. rymiel added a comment. Improve code flow in parseConstraintExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files: clang/lib/Format/UnwrappedLineP

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3393 +break; + } else { +return; HazardyKnusperkeks wrote: > don't need `else` after `break`. > In fact I would negate

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. In D145642#4183539 , @owenpan wrote: > Would this patch make the end result look worse without "making the requires > clause formatting of lambdas > match the formatting for functions"? If yes, then we should not land it just > y

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. Could you please clarify what you mean by "regressions" here? Isn't the behaviour of this syntax broken to begin with? It doesn't change anything about lambdas without //requires-clause//s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

rymiel added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", + Style.AllowShortCompoundRequirementOnASingleLine); ---

[PATCH] D145656: [clang-format] Treat &/&& as reference when followed by requires clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9163901c8e1: [clang-format] Treat &/&& as reference when followed by requires clause (authored by rymiel). Repository: rG LLVM Github Monorepo C

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

rymiel added a comment. > didn't go via the normal clang-format reviewers Is there a reason for this? This isn't the only case either, for example: https://reviews.llvm.org/D143070 https://reviews.llvm.org/D144170 https://reviews.llvm.org/D88299 https://reviews.llvm.org/D135356 I don't have a l

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

rymiel added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ? Style.ContinuationIndentWidth + : Style.Designate

[PATCH] D147295: [clang-format] Don't misannotate left squares as lambda introducers

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. This is great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147295/new/ https://reviews.llvm.org/D147295 _

[PATCH] D147318: [clang-format] Don't format typename template parameters as expression

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. bb4f6c4dca98a47054117708015bb2724256ee83

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

rymiel added inline comments. Comment at: clang/docs/tools/dump_format_style.py:72 - subtype, napplied = re.subn(r'^std::vector<(.*)>$', r'\1', typestr) - if napplied == 1: -return 'List of ' + pluralize(to_yaml_type(subtype)) + match = re.match(r'std::vector<(.*)>$', ty

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. The heuristic for determining if an arrow is

[PATCH] D147318: [clang-format] Don't format typename template parameters as expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50acd67018a5: [clang-format] Don't format typename template parameters as expression (authored by rymiel). Repository: rG LLVM Github Monorepo CH

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1922 } else if (Current.is(tok::arrow) && AutoFound && (Line.MustBeDeclaration || Line.InPPDirective) && Current.NestingLevel == 0 && owenpan wrote:

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel updated this revision to Diff 510315. rymiel marked an inline comment as done. rymiel added a comment. Use MightBeFunctionDecl instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147377/new/ https://reviews.llvm.org/D147377 Files: clang

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1493 + + Tokens = annotate("auto foo() -> auto { return Val; }"); + ASSERT_EQ(Tokens.size(), 12u) << Tokens; owenpan wrote: > Can th

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel updated this revision to Diff 510317. rymiel marked an inline comment as done. rymiel edited the summary of this revision. rymiel added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147377/new/ https://review

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd8678996296: [clang-format] Don't allow variable decls to have trailing return arrows (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D148024: [clang-format] Don't modify template arguments on the LHS of assignment

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. After clang-format has determined that an eq

[PATCH] D148024: [clang-format] Don't modify template arguments on the LHS of assignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dc94b3356bd: [clang-format] Don't modify template arguments on the LHS of assignment (authored by rymiel). Repository: rG LLVM Github Monorepo C

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. I've been sniped! (but only because i spent hours discussing with people if the error is pedantically valid, which it turns out it is) Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

rymiel added a comment. In D143546#4112077 , @owenpan wrote: > As this one is an invalid-code-generation bug, I wanted it fixed ASAP. Do you intend to backport it to the 16 release branch then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The previous versio

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel added a comment. Note: this patch also makes `LevelIndentTracker::skipLine` obsolete. I suppose I could clean that up in a following patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144296/new/ https://reviews.llvm.org/D144296 _

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel updated this revision to Diff 499328. rymiel marked 7 inline comments as done. rymiel added a comment. Apply suggestions and add extra test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144296/new/ https://reviews.llvm.org/D144296 Files:

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:387 +if (!(*compactedLine)->InPPDirective) + (*compactedLine)->Level-= dedentBy; + } owenpan wrote: > Did git-clang-format miss this? Nope, I f

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

rymiel updated this revision to Diff 499330. rymiel added a comment. Inline and remove LevelIndentTracker::skipLine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144296/new/ https://reviews.llvm.org/D144296 Files: clang/lib/Format/UnwrappedLineF

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: owenpan, MyDeveloperDay, HazardyKnusperkeks. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, given a

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

rymiel added a comment. (looks like you linked the same issue twice in the summary) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148777/new/ https://reviews.llvm.org/D148777 ___ cfe-commits mailing list

[PATCH] D139416: [clang-format] Don't require deduction guides to be templates

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The C++ standard doesn't require that class template dedu

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

rymiel added a comment. Please re-upload with full context. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: clang/lib/Format/Format.cpp:811 Style.AllowShortEnumsOnASingleLine); +IO.mapOptional("AllowShort

[PATCH] D139416: [clang-format] Don't require deduction guides to be templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8384347997f8: [clang-format] Don't require deduction guides to be templates (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SIN

<    1   2   3   >