[PATCH] D122344: [clang][driver] Disable non-functional --version option for clang -cc1

ekieri created this revision. ekieri added reviewers: bruno, v.g.vassilev, thakis, dexonsmith. Herald added a reviewer: sscalpone. Herald added a project: All. ekieri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes --vers

[PATCH] D122344: [clang][driver] Disable non-functional --version option for clang -cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rG35b89bc24ca5: [clang][driver] Disable non-functional --version option for clang -cc1 (authored by ekieri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1223

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

ekieri created this revision. ekieri added reviewers: PeteSteinfeld, awarzynski. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. ekieri requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This patch makes -versi

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

ekieri updated this revision to Diff 418643. ekieri added a comment. Address review comment. Fix typo in summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122542/new/ https://reviews.llvm.org/D122542 Files: clang/include/clang/Driver/Option

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

ekieri marked an inline comment as done. ekieri added inline comments. Comment at: clang/include/clang/Driver/Options.td:5756 + +} + awarzynski wrote: > [nit] IMHO this file lacks comments, hence the suggestion :) Sure! On the topic of this file's structure, I

[PATCH] D122542: [flang][driver] Make --version and -version consistent with clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ekieri marked an inline comment as done. Closed by commit rG577827cbbf10: [flang][driver] Make --version and -version consistent with clang (authored by ekieri). Repos

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri created this revision. ekieri added reviewers: awarzynski, thakis. Herald added a reviewer: sscalpone. Herald added a project: All. ekieri requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. W

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri added a comment. This patch is the result of discussions in https://reviews.llvm.org/D122542 There are probably a developer or two on the clang side that ought to have a say on this. I do not know the community that well, could you please help me with adding the appropriate people? Rep

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

ekieri added a comment. Thank you all for the support! @jansvoboda11 , yes, I did that, and will do it again before pushing. @hans , thanks, that is a valid concern. I was asked to add closing comments on an earlier patch though, and I find them particularly useful (when accurate...) in this f

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

ekieri added reviewers: klausler, PeteSteinfeld. ekieri added a comment. Herald added a reviewer: awarzynski. Hi! Thanks for this patch, and for your interest in contributing to Flang! I will leave it to somebody more experienced to accept the patch -- I am not familiar with this extension, and

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

ekieri added a comment. Ok, good. Then please abandon this revision (Add Action... down by the comment box), so that its status is clear to everybody. Cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123113/new/ https://reviews.llvm.org/D1231

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

This revision was automatically updated to reflect the committed changes. Closed by commit rGda1fc3ae955d: [Driver][NFC] Simplify handling of flags in Options.td (authored by ekieri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123070/new/ https:/

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

ekieri accepted this revision. ekieri added a comment. One nit/question inline, otherwise LGTM. Comment at: flang/lib/Frontend/FrontendActions.cpp:491 + // Create and configure `TargetMachine` + std::unique_ptr TM; + Is there a reason why use TM.reset instead

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

ekieri added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:491 + // Create and configure `TargetMachine` + std::unique_ptr TM; + awarzynski wrote: > ekieri wrote: > > Is there a reason why use TM.reset instead of initialising TM like you d

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

ekieri added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:491 + // Create and configure `TargetMachine` + std::unique_ptr TM; + awarzynski wrote: > ekieri wrote: > > awarzynski wrote: > > > ekieri wrote: > > > > Is there a reason why use

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri created this revision. ekieri added reviewers: awarzynski, peixin, sscalpone. Herald added projects: Flang, All. ekieri requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project: clang. Add --undefined=_QQmain to the link line, so t

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri added a comment. CI fail noted, update will come. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri updated this revision to Diff 463998. ekieri added a comment. Fix test link-f90-main.f90, which was failing for statically linked builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 Files: cl

[PATCH] D127207: [flang][driver] Fix support for `-x`

ekieri added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:268 + // pre-processed inputs. +.Case("f95", Language::Fortran) +.Case("f95-cpp-input", Language::Fortran) Is there a reason to cha

[PATCH] D127207: [flang][driver] Fix support for `-x`

ekieri added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:268 + // pre-processed inputs. +.Case("f95", Language::Fortran) +.Case("f95-cpp-input", Language::Fortran) awarzynski wrote: > rovk

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri abandoned this revision. ekieri added a comment. Herald added a subscriber: sunshaoce. Sorry to drop out on this. I got interrupted by other duties in life, and now I am no longer able to continue this work. If anybody wants to pick up the ball from here, please feel free to commandeer th