ellishg wrote:
> Is the plan to reuse the clang option -forder-file-instrumentation in the
> future?
No I wasn't planning on it. I'd like to remove this code for maintainability
reasons and to encourage others to use IRPGO instead
https://github.com/llvm/llvm-project/pull/121514
https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/122385
>From 28e1eb2d0383bf417f8f769f6964eacb02a45477 Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Thu, 9 Jan 2025 14:51:13 -0800
Subject: [PATCH 1/3] [InstrProf] Add frontent temporal profiling flag
---
clang/inc
https://github.com/ellishg edited
https://github.com/llvm/llvm-project/pull/122385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg closed
https://github.com/llvm/llvm-project/pull/122385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg edited
https://github.com/llvm/llvm-project/pull/121514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/121514
>From 432c55783cbb5d4a9675f1f6018b58ffc4fe636d Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Thu, 2 Jan 2025 10:51:54 -0800
Subject: [PATCH 1/2] Deprecate order file instrumentation
---
clang/include/clang/D
https://github.com/ellishg created
https://github.com/llvm/llvm-project/pull/121514
`-forder-file-instrumentation` is used to instrument a startup function order,
but this feature is also in IRPGO as Temporal Profiling. As discussed in
https://discourse.llvm.org/t/rfc-temporal-profiling-extens
https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/128920
>From 2e1946730f7ae2473a4fc94f8918eb3d9d225d17 Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Wed, 26 Feb 2025 09:48:46 -0800
Subject: [PATCH 1/3] [memprof] Export __memprof_default_options_str on Darwin
---
https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/128920
>From 2e1946730f7ae2473a4fc94f8918eb3d9d225d17 Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Wed, 26 Feb 2025 09:48:46 -0800
Subject: [PATCH 1/2] [memprof] Export __memprof_default_options_str on Darwin
---
https://github.com/ellishg created
https://github.com/llvm/llvm-project/pull/130192
Completely remove `-forder-file-instrumentation`. This was deprecated in
https://github.com/llvm/llvm-project/pull/121514 and removal was planned in
https://discourse.llvm.org/t/deprecate-forder-file-instrument
https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/130192
>From 72109c24229ce3a1deda9f8303e6e75677cd0ce4 Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Thu, 6 Mar 2025 14:17:51 -0800
Subject: [PATCH 1/2] [InstrProf] Remove -forder-file-instrumentation
---
clang/docs
@@ -1617,6 +1617,10 @@ void DarwinClang::AddLinkRuntimeLibArgs(const ArgList
&Args,
}
}
+ if (Sanitize.needsMemProfRt())
+if (hasExportSymbolDirective(Args))
+ addExportedSymbol(CmdArgs, "___memprof_default_options_str");
ellishg wrote:
@tere
ellishg wrote:
Moved to https://github.com/llvm/llvm-project/pull/128920
https://github.com/llvm/llvm-project/pull/128615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg closed
https://github.com/llvm/llvm-project/pull/128615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg closed
https://github.com/llvm/llvm-project/pull/130192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1334,7 +1334,10 @@ runThinLTOBackend(CompilerInstance &CI,
ModuleSummaryIndex *CombinedIndex,
// Context sensitive profile.
if (CGOpts.hasProfileCSIRInstr()) {
Conf.RunCSIRInstr = true;
-Conf.CSIRProfile = std::move(CGOpts.InstrProfileOutput);
+Conf.CSIRPro
ellishg wrote:
CC @SharonXSharon
https://github.com/llvm/llvm-project/pull/128615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg created
https://github.com/llvm/llvm-project/pull/128615
Add the clang frontend flag `-fmemory-profile-runtime-default-options` to
support the `-memprof-runtime-default-options` LLVM flag introduced in
https://github.com/llvm/llvm-project/pull/118874.
This enables u
https://github.com/ellishg created
https://github.com/llvm/llvm-project/pull/128920
The `-memprof-runtime-default-options` LLVM flag introduced in
https://github.com/llvm/llvm-project/pull/118874 creates the
`__memprof_default_options_str` symbol with `WeakAnyLinkage` on Darwin.
https://githu
@@ -1617,6 +1617,10 @@ void DarwinClang::AddLinkRuntimeLibArgs(const ArgList
&Args,
}
}
+ if (Sanitize.needsMemProfRt())
+if (hasExportSymbolDirective(Args))
+ addExportedSymbol(CmdArgs, "___memprof_default_options_str");
ellishg wrote:
@tere
@@ -1617,6 +1617,10 @@ void DarwinClang::AddLinkRuntimeLibArgs(const ArgList
&Args,
}
}
+ if (Sanitize.needsMemProfRt())
+if (hasExportSymbolDirective(Args))
+ addExportedSymbol(CmdArgs, "___memprof_default_options_str");
ellishg wrote:
Yes,
@@ -17,3 +17,11 @@
// RUN: not %clangxx --target=x86_64-linux-gnu -fprofile-generate
-fmemory-profile-use=foo %s -### 2>&1 | FileCheck %s
--check-prefix=CONFLICTWITHPGOINSTR
// CONFLICTWITHPGOINSTR: error: invalid argument '-fmemory-profile-use=foo'
not allowed with '-fprof
ellishg wrote:
> Not opposed to adding this as a clang driver flag especially if it is needed
> for something other than testing/debugging, however, you could presumably
> always add the exported symbol when -fmemory-profiler is specified (or does
> the linker give an error if the specified sy
https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/128615
>From fa0202169af23419c4bcbf66eabd1beb6b6e8e34 Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Mon, 24 Feb 2025 17:57:48 -0800
Subject: [PATCH 1/2] [memprof] Add memprof options clang frontend flag
---
clang/i
https://github.com/ellishg approved this pull request.
https://github.com/llvm/llvm-project/pull/136333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg closed
https://github.com/llvm/llvm-project/pull/145417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ellishg updated
https://github.com/llvm/llvm-project/pull/145417
>From 5ba3eab61982f9989c665091c672283b610b539d Mon Sep 17 00:00:00 2001
From: Ellis Hoag
Date: Mon, 23 Jun 2025 15:11:01 -0700
Subject: [PATCH 1/3] [InstrProf] Factor out getRecord and use NamedRecord
---
clan
https://github.com/ellishg approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/129736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 128 of 128 matches
Mail list logo
