[PATCH] D116174: [clang] support relative roots to vfs overlays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f61749e16f6: [clang] support relative roots to vfs overlays (authored by rmaz, committed by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

ellis added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:281-282 +/// An enum describing the attributes of an instrumented profile. +enum class InstrProfKind { + Unknown = 0x0, I've been working on a new coverage instrumentation in D1

[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

ellis added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProf.h:284-287 + FE = 0x1, // A frontend clang profile, incompatible with other attrs. + IR = 0x2, // An IR-level profile (default when -fprofile-generate is used). + BB = 0x4, // A profile with entry

[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

ellis added a comment. Herald added a subscriber: ormris. Herald added a project: All. Hi @tmsriram. I found a clang crash when using the flag `-funique-internal-linkage-names` that only happens after this diff. Would you mind taking a look? $ cat test.c inline void foo() {} extern void f

[PATCH] D116342: [clang][AST] Fix crash when printing error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe27b5f937138: [clang][AST] Fix crash when printing error (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 392471. ellis added a comment. Add a proper warning and simplify compiler-rt profile writer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 392576. ellis added a comment. Fix MachO profile dumping code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/

[PATCH] D114565: [InstrProf] Attach debug info to counters

ellis updated this revision to Diff 394097. ellis added a comment. Rebase and test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114565/new/ https://reviews.llvm.org/D114565 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/include/profile

[PATCH] D114565: [InstrProf] Attach debug info to counters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG800bf8ed29fb: [InstrProf] Attach debug info to counters (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D115689: Revert "[InstrProf] Attach debug info to counters"

ellis created this revision. Herald added subscribers: ormris, wenlei, hiraditya. ellis requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This reverts commit 800bf8ed29fbcaa9436540e83bc119ec92e7d40f

[PATCH] D115689: Revert "[InstrProf] Attach debug info to counters"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc809da7d9ce7: Revert "[InstrProf] Attach debug info to counters" (

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

ellis created this revision. Herald added subscribers: ormris, wenlei, hiraditya. ellis edited the summary of this revision. ellis added reviewers: kyulee, alanphipps, MaskRay, wenlei, davidxl. ellis updated this revision to Diff 394121. ellis added a comment. ellis published this revision for revi

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

ellis updated this revision to Diff 394982. ellis added a comment. Use `std::string` instead of `Twine` to pass around the default raw profile name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115693/new/ https://reviews.llvm.org/D115693 Files:

[PATCH] D115693: [Try2][InstrProf] Attach debug info to counters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58d9c1aec88d: [Try2][InstrProf] Attach debug info to counters (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

ellis created this revision. Herald added a subscriber: ormris. ellis added reviewers: kyulee, MaskRay, alanphipps. ellis published this revision for review. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Profile merging is not supported when using deb

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

ellis updated this revision to Diff 395481. ellis added a comment. Expand warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115979/new/ https://reviews.llvm.org/D115979 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/lib/profi

[PATCH] D115979: [InstrProf] Don't profile merge by default in lightweight mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac719d7c9ae6: [InstrProf] Don't profile merge by default in lightweight mode (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116342: [clang][AST] Fix crash when printing error

ellis created this revision. ellis added a reviewer: dblaikie. ellis published this revision for review. ellis added inline comments. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/lib/AST/TypePrinter.cpp:242 case Type::ObjCObjectPoi

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis updated this revision to Diff 369496. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 Files: clang/test/CodeGen/debug-info-codeview-heapallocsite.c clang/test/CodeG

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. Thanks for working on this! `getOrCreateGlobalVariableDIE()` is also called in `constructImportedEntityDIE()` which means that there could be some globals without DIE parents. In D108492 I've added this to the added test case. !18 = !

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

ellis added a comment. In D109703#2998350 , @krisb wrote: > In D109703#2998155 , @ellis wrote: > >> I've added this to the added test case. >> >> !18 = !DIImportedEntity(tag: DW_TAG_imported_declaration, scope:

<    1   2