[PATCH] D40925: Add option -fkeep-static-consts

eandrews updated this revision to Diff 161307. eandrews edited the summary of this revision. eandrews added a comment. This patch fell through the cracks earlier. I apologize. Based on Reid's and Erich's feedback, I am now adding the variable to @llvm.used. Additionally I modified the if stateme

[PATCH] D40925: Add option -fkeep-static-consts

eandrews updated this revision to Diff 161544. eandrews added a comment. Based on Reid's feedback, I changed option to CodeGenOption https://reviews.llvm.org/D40925 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenModule.cpp lib/Driver/

[PATCH] D40925: Add option -fkeep-static-consts

eandrews marked an inline comment as done. eandrews added inline comments. Comment at: include/clang/Basic/LangOptions.def:311 +BENIGN_LANGOPT(KeepStaticConsts , 1, 0, "keep static const variables even if unused") + rnk wrote: > Let's make this a CodeGenO

[PATCH] D40925: Add option -fkeep-static-consts

eandrews marked an inline comment as done. eandrews added a comment. In https://reviews.llvm.org/D40925#1206416, @rnk wrote: > lgtm! Thanks! https://reviews.llvm.org/D40925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D40925: Add option -fkeep-static-consts

This revision was automatically updated to reflect the committed changes. Closed by commit rC340439: Currently clang does not emit unused static constants. GCC emits these (authored by eandrews, committed by ). Changed prior to commit: https://reviews.llvm.org/D40925?vs=161544&id=162022#toc Re

[PATCH] D36487: Emit section information for extern variables.

eandrews updated this revision to Diff 116581. eandrews added a comment. I've modified the patch to emit a warning for re-declarations only. I also removed the isUsed check. https://reviews.llvm.org/D36487 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenModule.cpp li

[PATCH] D39210: Add default calling convention support for regcall.

eandrews created this revision. Added support for regcall as default calling convention. Also added code to exclude main when applying default calling conventions. https://reviews.llvm.org/D39210 Files: include/clang/AST/ASTContext.h include/clang/Basic/LangOptions.h include/clang/Drive

[PATCH] D51545: Enable -Wtautological-unsigned-zero-compare under -Wextra

eandrews created this revision. eandrews added reviewers: lebedev.ri, rsmith, rjmccall, rnk, mclow.lists, erichkeane. GCC enables -Wtype-limits under -Wextra. Warnings under GCC's -Wtype-limits is covered in Clang by -Wtautological-type-limit-compare and -Wtautological-unsigned-zero-compare. S

[PATCH] D51545: Enable -Wtautological-unsigned-zero-compare under -Wextra

eandrews added a comment. @lebedev.ri is there a specific reason -Wtautological-unsigned-zero-compare was removed? All the issues I am aware of talks about comparisons with min/max. https://reviews.llvm.org/D51545 ___ cfe-commits mailing list cfe-c

[PATCH] D51545: Enable -Wtautological-unsigned-zero-compare under -Wextra

eandrews added a comment. Alright. Thanks for the review. I will abandon this patch https://reviews.llvm.org/D51545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43259: Implement function attribute artificial

eandrews created this revision. eandrews added reviewers: erichkeane, aaron.ballman. Added support in clang for GCC function attribute 'artificial'. This attribute is used to control stepping behavior of debugger with respect to inline functions. https://reviews.llvm.org/D43259 Files: inclu

[PATCH] D40925: Add option -fkeep-static-consts

eandrews added a comment. I think we can use CodeGenModule::addUsedGlobal for this purpose. I noticed this is what attribute 'used' calls. I need to look into it though. https://reviews.llvm.org/D40925 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D43321: Improve documentation for attribute artificial

eandrews created this revision. eandrews added reviewers: rsmith, aaron.ballman, erichkeane. This patch is related to https://reviews.llvm.org/rC325081 The patch improves documentation for the attribute and removes reference to GCC documentation. https://reviews.llvm.org/D43321 Files: inclu

[PATCH] D40925: Add option -fkeep-static-consts

eandrews added a comment. Thanks for the review Reid. Sorry for the delay in my response. I was OOO. I am not sure if a new attribute is necessary. __ attribute __(used) is already supported in Clang. While this attribute can be used to retain static constants, it would require the user to modi

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews added a comment. Yes. I understand. At the moment, exception handling flags are generated based on `BENCHMARK_ENABLE_EXCEPTIONS` in `utils/benchmark/CMakeLists.txt` . However, `_HAS_EXCEPTIONS` is not defined based on this (code below). The warnings are a result of this mismatch.

[PATCH] D40925: Add option -fkeep-static-consts

eandrews added a comment. I think it makes sense to include this case just to make the flag more complete. Also, we don't really match GCC behavior for this flag. GCC emits all static constants by default (when O0). When optimized, this flag has no effect on GCC. The negation is used to not em

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews added a comment. In https://reviews.llvm.org/D52998#1259602, @lebedev.ri wrote: > In https://reviews.llvm.org/D52998#1258962, @eandrews wrote: > > > Yes. I understand. At the moment, exception handling flags are generated > > based on `BENCHMARK_ENABLE_EXCEPTIONS` in `utils/benchmark/C

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews updated this revision to Diff 172171. eandrews added a comment. @kbobyrev I apologize if I was unclear in the comments. I was asking if the changes proposed in the comments are alright with you since they would involve modifying `benchmark/CMakelists.txt` (instead of `llvm/CMakeLists.t

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews added a comment. > Upstreaming it first might be better, especially since the change seems to be > trivial. Is this line addition the only change proposed for the benchmark > library? Yes this line is the only change. > Do you want me to submit the patch to the benchmark library? It s

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews added a comment. Thanks! https://reviews.llvm.org/D52998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

This revision was automatically updated to reflect the committed changes. Closed by commit rL346237: [benchmark] Disable exceptions in Microsoft STL (authored by eandrews, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52998?vs=172171

[PATCH] D61023: Fix crash on switch conditions of non-integer types in templates

eandrews created this revision. eandrews added reviewers: rnk, erichkeane. Clang currently crashes for switch statements inside a template when the condition is non-integer and instantiation dependent. This is because contextual implicit conversion is skipped while acting on switch condition but

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews created this revision. eandrews added reviewers: rnk, riccibruno, erichkeane. Clang currently crashes for switch statements inside a template when the condition is non-integer and instantiation dependent. This is because contextual implicit conversion is skipped while acting on switch c

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. I apologize for the confusion. I was working on an incorrect branch earlier, and so abandoned that patch and uploaded a new revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews.llvm.org/D61027 __

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. I ran the test you provided and it does throw errors without instantiation bash-4.2$ clang -cc1 test/SemaTemplate/test2.cpp test/SemaTemplate/test2.cpp:3:7: error: statement requires expression of integer type ('int *' invalid) switch (N) case 0:; // should

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews created this revision. eandrews added reviewers: rnk, kbobyrev, omtcyfz, lebedev.ri, erichkeane. Herald added a subscriber: mgorny. Define _HAS_EXCEPTIONS=0, when compiling benchmark files, to disable exceptions in Microsoft STL. Windows builds were failing due to C4530 warnings (C++ ex

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews added a comment. I do not think defining _HAS_EXCEPTIONS=0 affects C++ exceptions in the application. I thought it only affected the STL. I will verify this and update you. https://reviews.llvm.org/D52998 ___ cfe-commits mailing list cfe-

[PATCH] D52998: [benchmark] Disable exceptions in Microsoft STL

eandrews added a comment. Thanks for the information Zachary. @lebedev.ri I do not know how benchmark library developers need/want to handle exceptions in MSVC STL. If these need to be enabled when BENCHMARK_ENABLE_EXCEPTIONS is true, I think we can just modify _HAS_EXCEPTIONS in utils/benc

[PATCH] D36487: Emit section information for extern variables.

eandrews added a comment. *ping* https://reviews.llvm.org/D36487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36487: Emit section information for extern variables.

eandrews updated this revision to Diff 116211. eandrews added a comment. I've updated the patch based on review comments. The changes include setting section unconditionally for extern variables and emitting a warning if section attribute is specified on a redeclaration. https://reviews.llvm.o

[PATCH] D36487: Emit section information for extern variables.

eandrews added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2434 +// Emit section information for extern variables. +if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) { + if (const SectionAttr *SA = D->getAttr()) efried

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews updated this revision to Diff 203854. eandrews edited the summary of this revision. eandrews added a reviewer: rsmith. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews.llvm.org/D61027 Files: lib/AST/Expr.cpp lib/Sema/SemaChecking.cpp test/SemaTempla

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. ping I just realized I modified the summary when I uploaded a new patch, but did not add a comment about the changes I made. Based on feedback from the bug report (https://bugs.llvm.org/show_bug.cgi?id=40982), I changed my approach for this crash. This patch changes t

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027/new/ https://reviews.llvm.org/D61027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. Thanks for taking a look Reid! I rebased the patch and had a conflict with one of Richard's patches and so ran the lit tests again and noticed there are several new failures. I am taking a look at those now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61027

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL368706: Fix crash on switch conditions of non-integer types in templates (authored by eandrews, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. In D61027#1627655 , @gribozavr wrote: > Sorry, but this change broke ClangTidy tests: > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16398. I > reverted it. Yes I've been trying to reproduce it locally. Co

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. Thank you for letting me know. I did try reproducing the issue with check-all yesterday but was unable to. I do not think I build with 'clang-tools-extra' project enabled though. I'll take another look today. Repository: rL LLVM CHANGES SINCE LAST ACTION https:/

[PATCH] D40925: Add option -fkeep-static-consts

eandrews created this revision. Currently clang does not emit unused static constants declared globally. Local static constants are emitted by default. -fkeep-static-consts can be used to emit static constants declared globally even if they are not used. This could be useful for producing ident

[PATCH] D40925: Add option -fkeep-static-consts

eandrews added a comment. *ping* https://reviews.llvm.org/D40925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119045: Fix address space for function types with AS qualifier

eandrews created this revision. eandrews added reviewers: rjmccall, dylanmckay, bader. eandrews requested review of this revision. This patch fixes a bug introduced in commit 4eaf5846d0e7 - https://reviews.llvm.org/D111566 Co

[PATCH] D119045: Fix address space for function types with AS qualifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed5b42b74188: Fix address space for function pointers with qualifier (authored by eandrews). Herald added a project: clang. Changed prior to commit:

[PATCH] D119045: Fix address space for function types with AS qualifier

eandrews added a comment. In D119045#3302129 , @aaron.ballman wrote: > LGTM aside from some nits Thanks! Fixed the nits in commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119045/new/ https://review

[PATCH] D36487: Emit section information for extern variables.

eandrews created this revision. Currently, if _attribute_((section())) is used for extern variables, section information is not emitted in generated IR when the variables are used. This is expected since sections are not generated for external linkage objects. However NiosII requires this info

[PATCH] D36487: Emit section information for extern variables.

eandrews added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2434 +// Emit section information for extern variables. +if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) { + if (const SectionAttr *SA = D->getAttr()) efried

[PATCH] D36487: Emit section information for extern variables.

eandrews updated this revision to Diff 111064. eandrews added a comment. As per review comments, removed extra RUNS in lit test. https://reviews.llvm.org/D36487 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/extern-section-attribute.cpp Index: test/CodeGenCXX/extern-section-attribut

[PATCH] D36712: Emit section information for extern variables

eandrews created this revision. Update IR generated to retain section information for external declarations. This is related to https://reviews.llvm.org/D36487 https://reviews.llvm.org/D36712 Files: docs/LangRef.rst Index: docs/LangRef.rst ==

[PATCH] D36712: Emit section information for extern variables

eandrews updated this revision to Diff 111227. eandrews added a comment. I updated the documentation to include Simon's comments. I wasn't sure whether to include the line about section information being retained in LLVM IR, since Eli mentioned it could vary for different front-ends. I have incl

[PATCH] D36712: Emit section information for extern variables

eandrews added inline comments. Comment at: docs/LangRef.rst:629 +corresponding to the LLVM module, section information specified in the +declaration is retained in LLVM IR to enable OpenCL processes. + kparzysz wrote: > sdardis wrote: > > efriedma wrote: > > >

[PATCH] D36712: Emit section information for extern variables

eandrews updated this revision to Diff 111341. eandrews added a comment. Corrected spelling error. https://reviews.llvm.org/D36712 Files: docs/LangRef.rst Index: docs/LangRef.rst === --- docs/LangRef.rst +++ docs/LangRef.rst @@

[PATCH] D36712: Emit section information for extern variables

eandrews added a comment. In https://reviews.llvm.org/D36712#842477, @kparzysz wrote: > In the cases when the section is explicitly given on a definition, it was > likely imposed by something like the "section" attribute in the source. I > don't think it's unreasonable to expect that the declar

[PATCH] D36712: Emit section information for extern variables

eandrews updated this revision to Diff 111388. eandrews added a comment. Updated the patch to include Krzysztof's comment about explicitly stating undefined behavior for section information mismatch in global variable declaration and definition. This should cover the case where section is expli

[PATCH] D36712: Emit section information for extern variables

eandrews added a comment. In https://reviews.llvm.org/D36712#843414, @kparzysz wrote: > The problem is that the mismatch between sections does not have to lead to > any undesirable behavior. Whether it does or not depends on a particular > case. I think we should be consistent though---if we

[PATCH] D36712: Emit section information for extern variables

eandrews updated this revision to Diff 112172. eandrews added a comment. Updated the documentation to explicitly state that section information for a variable can be explicit or inferred. https://reviews.llvm.org/D36712 Files: docs/LangRef.rst Index: docs/LangRef.rst ==

[PATCH] D36487: Emit section information for extern variables.

eandrews added a comment. LangRef has been updated and accepted. You can find it here - https://reviews.llvm.org/rL311459 https://reviews.llvm.org/D36487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews created this revision. eandrews added reviewers: rnk, erichkeane, alexfh, alexfh_. This patch is a follow up to D69950 , to fix a new crash on CXX condition expressions in templates, for value dependent bitfields. Clang currently crashes when integral p

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews added a comment. Thanks for taking a look Erich! > I'm concerned about just making this fallthrough to 'false'. These ARE > integral promotions, we just don't know the type size. In this case, when integral promotion is skipped, boolean conversion (C++ 4.12) is done instead when parsi

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews updated this revision to Diff 237132. eandrews edited the summary of this revision. eandrews added a comment. Semantic analysis for value dependent conditions is now skipped as per Erich's comment. Patch adds an argument to CheckBooleanCondition to still do the required analysis for no

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews created this revision. eandrews added reviewers: rnk, erichkeane. eandrews requested review of this revision. Fix link error for MSVC entry points when calling conventions are specified. MSVC entry points should have default calling convention. https://reviews.llvm.org/D87701 Files:

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cff1b40dacf: Do not apply calling conventions to MSVC entry points (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews added a comment. In D87701#2274860 , @rnk wrote: > lgtm, thanks. Thanks for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews added a comment. In D87701#2280246 , @dmajor wrote: > This broke Firefox builds too, in one of our helper binaries that uses a > `wWinMain`, although I'm having trouble writing a minimal reproducer for it. > Simply making a barebones `wWinMain`

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

eandrews accepted this revision. eandrews added a comment. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96538/new/ https://reviews.llvm.org/D96538 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. This has changed the behavior for - // Define __complex128 type corresponding to __float128 (as in GCC headers). typedef _Complex float __attribute__((mode(TC))) __complex128; void check() { // CHECK: alloca { fp128, fp128 } <- Fails because alloca { x86

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. In D109950#3097161 , @rjmccall wrote: > Oh, yes, I think this should be preserving the old logic there and just > adding a new clause for explicit requests for ibm128, right? I think the old logic should be preserved yes. Howev

[PATCH] D112975: Fix complex types declared using mode TC

eandrews created this revision. eandrews added reviewers: qiucf, rjmccall. eandrews requested review of this revision. This patch reverts incorrect IR - introduced in commit d11ec6f67e45 (https://reviews.llvm.org/rGd11ec6f67e4

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. In D109950#3097652 , @rjmccall wrote: > In D109950#3097544 , @eandrews > wrote: > >> In D109950#3097161 , @rjmccall >> wrote: >> >>> Oh, yes, I

[PATCH] D112975: Fix complex types declared using mode TC

eandrews added a comment. In D112975#3101720 , @rjmccall wrote: > For posterity in case someone tracks down this review: `TC` corresponds to an > unspecified 128-bit format, which on some targets is a double-double format > (like `__ibm128_t`) and on ot

[PATCH] D112975: Fix complex types declared using mode TC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c8d3053fa0c: Fix complex types declared using mode TC (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

eandrews added a comment. This patch causes a regression. To reproduce - `clang -cc1 -fsycl-is-device -triple spir64 test.cpp` // expected-note@+2 {{'bar<__float128>' defined here}} template T bar() { return T(); }; void usage() { // expected-error@+2 {{'bar<__float128>' requires

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

eandrews added a comment. In D98895#3119027 , @asavonic wrote: > In D98895#3118821 , @eandrews wrote: > >> This patch causes a regression. >> >> To reproduce - `clang -cc1 -fsycl-is-device -triple spir64 test.cpp` >

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

eandrews created this revision. eandrews added reviewers: rnk, akhuang, dmajor. Herald added a subscriber: mstorsjo. eandrews requested review of this revision. This patch is a second attempt at fixing a link error for MSVC entry points when calling conventions are specified using a flag. Callin

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

eandrews updated this revision to Diff 329099. eandrews edited the summary of this revision. eandrews added a comment. Implemented review comment to restrict __stdcall default calling convention (for WinMain, wWinMain, and DllMain) to 32 bit Windows. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

eandrews added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11206-11207 +} else if (FT->getCallConv() != CC_X86StdCall) { + // Default calling convention for WinMain, wWinMain and DllMain is + // __stdcall + FT = Context.adjustFunctionType(

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

eandrews added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:237-240 + std::string MangledName = MangleName(TmpltSpec); + typedef int (*TemplateSpecFn)(void *); + auto fn = (TemplateSpecFn)cantFail(Interp->getSymbolAddress(MangledName)); + EXPEC

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added a comment. ping * 3 Since this patch has been accepted by one code owner, and has been under review for over a month, I plan to submit it by the end of the week. If anyone has feedback/concerns, please comment on the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews added a comment. Thanks for the reviews @dylanmckay and @rjmccall ! I agree that moving the logic for functions pointers to `getTargetAddressSpace` makes sense. However, I'm not sure what the consequences are, since that increases the impact of this change quite a bit. I'm not sure if

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

eandrews created this revision. eandrews added reviewers: mikerice, jyu2, bader, jdoerfert, aaron.ballman. Herald added subscribers: Naghasan, Anastasia, ebevhan, guansong, yaxunl. Herald added a project: All. eandrews requested review of this revision. Herald added a subscriber: sstefan1. This pa

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

eandrews added a comment. In D141375#4041360 , @bader wrote: > LGTM. > I expect this to be a common issue for all single-source offloading > programming models (i.e. CUDA and HIP in addition to SYCL and OpenMP > offload). Probably we can generalize the

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf81d529f8955: [Clang] Fix compilation errors for unsupported __bf16 intrinsics (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

eandrews added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141375/new/ https://reviews.llvm.org/D141375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. In D157554#4577504 , @aaron.ballman wrote: > In D157554#4576720 , @eandrews > wrote: > >> In D157554#4576478 , >> @aaron.ballman wrote: >> >>>

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added a comment. Pre-merge check fails are unrelated - fatal error C1060: compiler is out of heap space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157454/new/ https://reviews.llvm.org/D157454 ___ cfe-commits mailing list cfe-comm

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG421c9bbf65b7: [NFC][Clang] Fix static analyzer concern (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D157885: [NFC][Clang] Fix static analyzer concern about null value derefence

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. eandrews requested review of this revision. https://reviews.llvm.org/D15

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews updated this revision to Diff 549960. eandrews added a comment. Applied review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 Files: clang/lib/Sema/SemaExprCXX.cpp Index: clang/lib/Sema/SemaExprCXX.cpp ==

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: steakhal, abrachet, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. eandrews reque

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4ada13e4b3e: [NFC][Clang] Fix static analyzer concern about null value dereference (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added a comment. In D157888#4586126 , @steakhal wrote: > Hmm. I guess the assertion is to silence some tool. And I think actually that > function might very well also return null in some cases. > Why do you think it cannot or at least should not

[PATCH] D157885: [NFC][Clang] Fix static analyzer concern about null value derefence

This revision was automatically updated to reflect the committed changes. Closed by commit rGc70dab026d37: [NFC][Clang] Fix static analyzer concern about null value dereference (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

This revision was automatically updated to reflect the committed changes. Closed by commit rGe62b2fc40d11: [NFC][Clang] Fix static analyzer concern (authored by eandrews). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D157888?vs=549962&id=550886#toc Repositor

[PATCH] D157888: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:657 + const Stmt *S = AcquireNode->getStmtForDiagnostics(); + assert(S && "Statmement cannot be null."); PathDiagnosticLocation LocUsedForUniqueing = --

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. eandrews requested review of this revision.

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. eandrews requested review of this revision.

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a4779cc235c: [NFC] Fix static analyzer concern (authored by eandrews). Herald added a project: clang. Changed prior to commit: https://reviews.ll

[PATCH] D157429: [NFC] [Clang] Fix static analyzer concern

eandrews added a comment. In D157429#4570540 , @aaron.ballman wrote: > LGTM with a small formatting nit. Thanks for the review! I committed the patch after fixing the formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. eandrews requested review of this revision. InterfacePointerType is dere

[PATCH] D157454: [NFC][Clang] Fix static analyzer concern about null value dereference

eandrews added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:222-223 Selector Sel = MethodWithObjects->getSelector(); - QualType ResultType = E->getType(); - const ObjCObjectPointerType *InterfacePointerType -= ResultType->getAsObjCInterfacePointerType(); +

  1   2   >