@@ -52,49 +52,54 @@ static void applyNullability(Sema &S, Decl *D,
NullabilityKind Nullability,
if (!Metadata.IsActive)
return;
- auto IsModified = [&](Decl *D, QualType QT,
-NullabilityKind Nullability) -> bool {
+ auto GetModified =
+ [&
egorzhdan wrote:
@compnerd I think I addressed all of your comments, let me know if this is good
to go!
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
egorzhdan wrote:
I'm going to land this patch now to unblock other work on APINotes, but I'm
happy to address more review feedback post-merge.
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/86820
This upstreams https://github.com/apple/llvm-project/pull/8063.
If module FooCore is re-exported through module Foo (by using `export_as` in
the modulemap), look for attributes of FooCore symbols in Foo.apinot
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/86820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/87006
This upstreams https://github.com/apple/llvm-project/pull/7930.
This adds a test to verify that we can apply attributes to C++ class templates
using API Notes. Doing the same for function templates is not curr
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/87006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
egorzhdan wrote:
@compnerd ping ;)
https://github.com/llvm/llvm-project/pull/78445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/84556
This fixes tests that are going to be upstreamed in the near future. Currently
they are failing downstream in the Apple open source fork.
Failing tests
Clang :: APINotes/retain-count-convention.m
Clang ::
egorzhdan wrote:
Apologies for the delay!
I looked into this performance hit, and it seems largely expected to me: the
compiler spends extra time checking if there is an apinotes file for a given
clang module with the notes for the declarations that are being processed. We
can consider adding
egorzhdan wrote:
The clang-format CI failure is unrelated to this patch.
https://github.com/llvm/llvm-project/pull/84556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/84556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/84772
When pretty printing an Objective-C interface declaration, Clang previously
didn't print any attributes that are applied to the declaration.
>From 71ce3d88b229ff604dff64172d1fd9bcc18d32ea Mon Sep 17 00:00:00 2
egorzhdan wrote:
This depends on https://github.com/llvm/llvm-project/pull/84772.
https://github.com/llvm/llvm-project/pull/84773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/84772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/78445
>From 40a6247d20e121d9dea0ff83a61f5e7abba7bba6 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Wed, 17 Jan 2024 13:41:25 +
Subject: [PATCH] [APINotes] Upstream Sema logic to apply API Notes to decls
This u
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/78445
>From 2e4aa8640d208767a3f560516f1b3fd8c31dee3f Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Wed, 17 Jan 2024 13:41:25 +
Subject: [PATCH] [APINotes] Upstream Sema logic to apply API Notes to decls
This u
@@ -0,0 +1,989 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,1014 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/78445
>From 806fe5abaeec7ad7d75d0be026bb42808d15bc41 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Wed, 17 Jan 2024 13:41:25 +
Subject: [PATCH] [APINotes] Upstream Sema logic to apply API Notes to decls
This u
@@ -0,0 +1,989 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,989 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,989 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,989 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,989 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,989 @@
+//===--- SemaAPINotes.cpp - API Notes Handling
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/78445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
egorzhdan wrote:
Oh, thanks @nikic for that data point. Let me try to avoid the overhead, I'll
put up a patch tomorrow morning.
https://github.com/llvm/llvm-project/pull/78445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/83057
This fixes a few breakages introduced during upstreaming – please see each
commit for details.
>From dae96657bee753a96bc41e8cde3ca81e082d82cb Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Mon, 26 Feb 2024 2
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/83057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
egorzhdan wrote:
@compnerd ping! ;)
https://github.com/llvm/llvm-project/pull/78445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
egorzhdan wrote:
@compnerd ping :)
https://github.com/llvm/llvm-project/pull/78445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/73017
>From 0cbb267cd3b18308acd3fc0b3b68132a2090b5b6 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Mon, 20 Nov 2023 18:03:18 +
Subject: [PATCH 1/4] [APINotes] Upstream attributes that are created
implicitly fr
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/73017
>From 447aabfbf20c8d286caf6ad3f2e30da116592860 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Mon, 20 Nov 2023 18:03:18 +
Subject: [PATCH 1/4] [APINotes] Upstream attributes that are created
implicitly fr
@@ -301,6 +301,9 @@ class VariadicEnumArgument values,
bit IsExternalType = isExternalType;
}
+// Represents an attribute wrapped by another attribute.
+class AttrArgument : Argument;
egorzhdan wrote:
Makes sense to me! Renamed to `WrappedAttr` to match the
@@ -2601,6 +2604,22 @@ def SwiftError : InheritableAttr {
let Documentation = [SwiftErrorDocs];
}
+def SwiftImportAsNonGeneric : InheritableAttr {
egorzhdan wrote:
It is still used for `NSDictionary`, `NSSet` and friends in Foundation.
https://github.com/l
@@ -2622,6 +2641,31 @@ def SwiftPrivate : InheritableAttr {
let SimpleHandler = 1;
}
+def SwiftVersioned : Attr {
egorzhdan wrote:
Done, renamed it
https://github.com/llvm/llvm-project/pull/73017
___
cfe-commits
@@ -2622,6 +2641,31 @@ def SwiftPrivate : InheritableAttr {
let SimpleHandler = 1;
}
+def SwiftVersioned : Attr {
+ // This attribute has no spellings as it is only ever created implicitly
+ // from API notes.
+ let Spellings = [];
+ let Args = [VersionArgument<"Version"
@@ -7539,74 +7559,65 @@ static NullabilityKind
mapNullabilityAttrKind(ParsedAttr::Kind kind) {
}
}
-/// Applies a nullability type specifier to the given type, if possible.
-///
-/// \param state The type processing state.
-///
-/// \param type The type to which the nullabi
@@ -15139,6 +15139,37 @@ void Sema::DiagnoseSizeOfParametersAndReturnValue(
}
}
+QualType Sema::AdjustParameterTypeForObjCAutoRefCount(QualType T,
+ SourceLocation NameLoc,
+
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/73017
>From 447aabfbf20c8d286caf6ad3f2e30da116592860 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Mon, 20 Nov 2023 18:03:18 +
Subject: [PATCH 1/4] [APINotes] Upstream attributes that are created
implicitly fr
@@ -7519,6 +7519,26 @@ static bool
HandleWebAssemblyFuncrefAttr(TypeProcessingState &State,
return false;
}
+/// Rebuild an attributed type without the nullability attribute on it.
+static QualType rebuildAttributedTypeWithoutNullability(ASTContext &Ctx,
+
@@ -7519,6 +7519,26 @@ static bool
HandleWebAssemblyFuncrefAttr(TypeProcessingState &State,
return false;
}
+/// Rebuild an attributed type without the nullability attribute on it.
+static QualType rebuildAttributedTypeWithoutNullability(ASTContext &Ctx,
+
@@ -7539,74 +7559,65 @@ static NullabilityKind
mapNullabilityAttrKind(ParsedAttr::Kind kind) {
}
}
-/// Applies a nullability type specifier to the given type, if possible.
-///
-/// \param state The type processing state.
-///
-/// \param type The type to which the nullabi
egorzhdan wrote:
> Do we want to submit the first three in the series and then take on the
> topmost commit?
Sounds good, let me remove the 4th commit from this PR
https://github.com/llvm/llvm-project/pull/73017
___
cfe-commits mailing list
cfe-commi
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/73017
>From 447aabfbf20c8d286caf6ad3f2e30da116592860 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Mon, 20 Nov 2023 18:03:18 +
Subject: [PATCH 1/3] [APINotes] Upstream attributes that are created
implicitly fr
https://github.com/egorzhdan edited
https://github.com/llvm/llvm-project/pull/73017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/73017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/78445
This upstreams more of the Clang API Notes functionality that is currently
implemented in the Apple fork:
https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes
This was extracted from a larger PR
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/78445
>From 6fdb42e20cc07a2f378239c6b7c6182e42544f18 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Wed, 17 Jan 2024 13:41:25 +
Subject: [PATCH] [APINotes] Upstream Sema logic to apply API Notes to decls
This u
https://github.com/egorzhdan edited
https://github.com/llvm/llvm-project/pull/66769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,202 @@
+//===--- APINotesReader.h - API Notes Reader *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/70333
```
clang/include/clang/Lex/Preprocessor.h:2893:14: warning: parameter 'isEnter:'
not found in the function declaration [-Wdocumentation]
/// \param isEnter: true if this PP is entering a region; otherwise, t
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/70333
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/66769
>From 4561ed86480e89d0e36560adab13f22a59627d81 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Tue, 19 Sep 2023 13:42:16 +0100
Subject: [PATCH] [APINotes] Upstream APINotesReader
This upstreams more of the Cla
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/66769
>From 629a80917e7968cf4617a0d5135cd12bdccd4e43 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Tue, 19 Sep 2023 13:42:16 +0100
Subject: [PATCH] [APINotes] Upstream APINotesReader
This upstreams more of the Cla
Author: Egor Zhdan
Date: 2022-11-10T16:16:36-08:00
New Revision: 97105e5bf70fae5d9902081e917fd178b57f1717
URL:
https://github.com/llvm/llvm-project/commit/97105e5bf70fae5d9902081e917fd178b57f1717
DIFF:
https://github.com/llvm/llvm-project/commit/97105e5bf70fae5d9902081e917fd178b57f1717.diff
LO
Author: Egor Zhdan
Date: 2022-05-27T16:51:36+01:00
New Revision: e917801eddbe1b32f1adc81391fd434557391b5e
URL:
https://github.com/llvm/llvm-project/commit/e917801eddbe1b32f1adc81391fd434557391b5e
DIFF:
https://github.com/llvm/llvm-project/commit/e917801eddbe1b32f1adc81391fd434557391b5e.diff
LO
https://github.com/egorzhdan created
https://github.com/llvm/llvm-project/pull/66769
This upstreams more of the Clang API Notes functionality that is currently
implemented in the Apple fork:
https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes
>From e0649eedbe9f77241a7e26980aa40
https://github.com/egorzhdan approved this pull request.
This is similar to a change that I did for the Linux toolchain a while ago
(https://github.com/llvm/llvm-project/commit/e917801eddbe1b32f1adc81391fd434557391b5e),
LGTM! 👍
https://github.com/llvm/llvm-project/pull/66863
__
https://github.com/egorzhdan approved this pull request.
The Darwin toolchain also does this. This change LGTM, although I'm not an
expert in FreeBSD.
https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/66769
>From c62e0c4f263cfb46b74931d9ae5962116faf427f Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Tue, 19 Sep 2023 13:42:16 +0100
Subject: [PATCH] [APINotes] Upstream APINotesReader
This upstreams more of the Cla
@@ -0,0 +1,202 @@
+//===--- APINotesReader.h - API Notes Reader *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,202 @@
+//===--- APINotesReader.h - API Notes Reader *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,202 @@
+//===--- APINotesReader.h - API Notes Reader *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,202 @@
+//===--- APINotesReader.h - API Notes Reader *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,202 @@
+//===--- APINotesReader.h - API Notes Reader *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,2001 @@
+//===--- APINotesReader.cpp - API Notes Reader --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,2001 @@
+//===--- APINotesReader.cpp - API Notes Reader --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,2001 @@
+//===--- APINotesReader.cpp - API Notes Reader --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,2001 @@
+//===--- APINotesReader.cpp - API Notes Reader --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,2001 @@
+//===--- APINotesReader.cpp - API Notes Reader --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,2001 @@
+//===--- APINotesReader.cpp - API Notes Reader --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
@@ -0,0 +1,2001 @@
+//===--- APINotesReader.cpp - API Notes Reader --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
Author: Jared Grubb
Date: 2023-07-17T14:47:49+01:00
New Revision: 63d6659a045d2e014d53ae890eec8b3cd96e5805
URL:
https://github.com/llvm/llvm-project/commit/63d6659a045d2e014d53ae890eec8b3cd96e5805
DIFF:
https://github.com/llvm/llvm-project/commit/63d6659a045d2e014d53ae890eec8b3cd96e5805.diff
L
Author: Egor Zhdan
Date: 2023-08-30T12:54:42+01:00
New Revision: 9939556625548d7ba2c3eba4d131b9b4d6bc0c02
URL:
https://github.com/llvm/llvm-project/commit/9939556625548d7ba2c3eba4d131b9b4d6bc0c02
DIFF:
https://github.com/llvm/llvm-project/commit/9939556625548d7ba2c3eba4d131b9b4d6bc0c02.diff
LO
https://github.com/egorzhdan opened
https://github.com/llvm/llvm-project/pull/65178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan labeled
https://github.com/llvm/llvm-project/pull/65178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan review_requested
https://github.com/llvm/llvm-project/pull/65178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan opened
https://github.com/llvm/llvm-project/pull/65187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan review_requested
https://github.com/llvm/llvm-project/pull/65187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan review_requested
https://github.com/llvm/llvm-project/pull/65187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan labeled
https://github.com/llvm/llvm-project/pull/65187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/65178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/65187:
>From e2150c20056e44a6ecbc82c63f499b6010c37930 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Fri, 1 Sep 2023 22:07:47 +0100
Subject: [PATCH] [APINotes] Upstream APINotesWriter
This upstreams more of the Cla
@@ -749,6 +750,17 @@ struct Context {
Context(ContextID id, ContextKind kind) : id(id), kind(kind) {}
};
+
+/// A temporary reference to an Objective-C selector, suitable for
+/// referencing selector data on the stack.
+///
+/// Instances of this struct do not store referen
@@ -19,11 +19,11 @@
namespace clang {
namespace api_notes {
-class APINotesWriter::Implementation {
- template
- using VersionedSmallVector =
- llvm::SmallVector, 1>;
+template
+using VersionedSmallVector =
+llvm::SmallVector, 1>;
egorzhdan wrote:
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default;
void APINotesWriter::writeToStream(llvm::raw_ostream &OS) {
Implementation->writeToStream(OS);
}
+
+ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID,
+
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default;
void APINotesWriter::writeToStream(llvm::raw_ostream &OS) {
Implementation->writeToStream(OS);
}
+
+ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID,
+
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default;
void APINotesWriter::writeToStream(llvm::raw_ostream &OS) {
Implementation->writeToStream(OS);
}
+
+ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID,
+
https://github.com/egorzhdan review_requested
https://github.com/llvm/llvm-project/pull/65187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan edited
https://github.com/llvm/llvm-project/pull/65187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/65187:
>From a553de6bbcc96f0bbd94859defcb64f2c6dfa0f5 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Fri, 1 Sep 2023 22:07:47 +0100
Subject: [PATCH] [APINotes] Upstream APINotesWriter
This upstreams more of the Cla
@@ -19,11 +19,11 @@
namespace clang {
namespace api_notes {
-class APINotesWriter::Implementation {
- template
- using VersionedSmallVector =
- llvm::SmallVector, 1>;
+template
+using VersionedSmallVector =
+llvm::SmallVector, 1>;
egorzhdan wrote:
@@ -33,6 +33,7 @@ class APINotesWriter::Implementation {
/// Mapping from strings to identifier IDs.
llvm::StringMap IdentifierIDs;
+public:
egorzhdan wrote:
Reverted this part of the change by making `APINotesWriter` a friend class of
`Implementation`
https://github.com/egorzhdan updated
https://github.com/llvm/llvm-project/pull/65187:
>From a3e72323513a5ac102abb6c28ae4071955cc2373 Mon Sep 17 00:00:00 2001
From: Egor Zhdan
Date: Fri, 1 Sep 2023 22:07:47 +0100
Subject: [PATCH] [APINotes] Upstream APINotesWriter
This upstreams more of the Cla
@@ -105,6 +110,40 @@ class APINotesWriter::Implementation {
llvm::SmallVector, 1>>
Typedefs;
+ /// Retrieve the ID for the given identifier.
+ IdentifierID getIdentifier(StringRef Identifier) {
+if (Identifier.empty())
+ return 0;
+
+auto
https://github.com/egorzhdan closed
https://github.com/llvm/llvm-project/pull/65187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 328 matches
Mail list logo
