[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86227 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286593. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:333 +/// expression . template_opt id-expression +/// id-expression +/// e.g. `x.a`, `xp->a` or even just `a` when we have an implicit `this->`.

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286762. eduucaldas added a comment. Implicit `MemberExpr` generates `id-expression` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/include/clang/Tool

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286799. eduucaldas marked 10 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/i

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:900 + +auto *unqualifiedId = new (allocator()) syntax::UnqualifiedId; +Builder.foldNode(Builder.getRange(S->getMemberLoc(), S->getEndLoc()), -

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286811. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Unify logic for generating `id-expression` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

This revision was automatically updated to reflect the committed changes. Closed by commit rGba32915db2ce: [SyntaxTree] Add support for `MemberExpression` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D86227?vs=286811&id=286820#toc Repository: rG LLVM Github Mon

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

eduucaldas updated this revision to Diff 286823. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86139/new/ https://reviews.llvm.org/D86139 Files: clang/unitt

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e983e24043: [SyntaxTree] Split tests related to Namespace (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D86298: [SyntaxTree] Add support for `this`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86298 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D86298: [SyntaxTree] Add support for `this`

This revision was automatically updated to reflect the committed changes. Closed by commit rG85c15f17cc68: [SyntaxTree] Add support for `this` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86298/new/ https://reviews.llvm.or

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 286983. eduucaldas added a comment. Adapt Statement tests to new testing infrastructure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:158 if (!Marks.empty()) OS << Marks << ": "; gribozavr2 wrote: > Maybe the marks should be moved after the primary identifier of the node, > WDYT? That would be more consis

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86345 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. Sorry for doing this after asking for review. I think it might be interesting landing this patch before : https://reviews.llvm.org/D85330 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG1beb11c61ae4: [SyntaxTree] Use annotations in Statement tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86345/new/ https://rev

[PATCH] D86437: [SyntaxTree] Split array declarator tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86437 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86439: [SyntaxTree] Use annotations to reduce noise on member function tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86439 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86440: [SyntaxTree] Split FreeStandingClass tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86440 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86441 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86443: [SyntaxTree] Group tests related to `using`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86443 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86459: [SyntaxTree] Split `ParametersAndQualifiers` tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86459 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

eduucaldas updated this revision to Diff 287378. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Template -> ClassTemplate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86441/new/ https://reviews.llvm.org/D86441 Files: c

[PATCH] D86440: [SyntaxTree] Split FreeStandingClass tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4093d663f83: [SyntaxTree] Split FreeStandingClass tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86439: [SyntaxTree] Use annotations to reduce noise on member function tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed83095254a3: [SyntaxTree] Use annotations to reduce noise on member function tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo

[PATCH] D86437: [SyntaxTree] Split array declarator tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e8dd506e666: [SyntaxTree] Split array declarator tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa722d6a197c7: [SyntaxTree] Split ExplicitTemplateInstantiation test (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D86459: [SyntaxTree] Split `ParametersAndQualifiers` tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4baa163c7423: [SyntaxTree] Split `ParametersAndQualifiers` tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86443: [SyntaxTree] Group tests related to `using`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90f85dfc14bc: [SyntaxTree] Group tests related to `using` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D86443?vs=28

[PATCH] D86467: [SyntaxTree] Split `MemberPointer` tests with annotations

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86467 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86469: [SyntaxTree] Split ConstVolatileQualifiers tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86469 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/un

[PATCH] D86470: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86470 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/un

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287430. eduucaldas marked an inline comment as done. eduucaldas added a comment. Update tests to dump role Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: c

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287431. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. - Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/

[PATCH] D86469: [SyntaxTree] Split ConstVolatileQualifiers tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGb493e4cb3e37: [SyntaxTree] Split ConstVolatileQualifiers tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86469/new/ https://re

[PATCH] D86467: [SyntaxTree] Split `MemberPointer` tests with annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG61273f298f2c: [SyntaxTree] Split `MemberPointer` tests with annotations (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86467/new/ h

[PATCH] D86470: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f426c65b06f: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287562. eduucaldas added a comment. reorganize and nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/li

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287563. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Syntax/B

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc655d8081570: [SyntaxTree] Extend the syntax tree dump to also cover `NodeRole` (authored by eduucaldas). Changed prior to commit: https://reviews

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Add support for all C++ call expressions, including those coming from `operator()`. A call expression's arguments are inside their own node - `Cal

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas updated this revision to Diff 287694. eduucaldas added a comment. - Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86544/new/ https://reviews.llvm.org/D86544 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Sy

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:506 | `-'~' -|-'decltype' +|-'decltype' OpenParen |-'(' This is wrong but it's just because decltype is all wrong =

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas updated this revision to Diff 287842. eduucaldas marked 8 inline comments as done. eduucaldas added a comment. Answer code review, squash commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86544/new/ https://reviews.llvm.org/D86544 F

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1070 +Builder.markChildToken( +std::next(Builder.findToken(S->getCallee()->getEndLoc())), +syntax::NodeRole::OpenParen); gribozavr2 wrote: > Could you add an

[PATCH] D86544: [SyntaxTree] Add support for call expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2de2ca348dfa: [SyntaxTree] Add support for `CallExpression` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D86591: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86591 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86591: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b75f65e6ba4: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 287889. eduucaldas added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Synt

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 287947. eduucaldas added a comment. answer code-review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 288010. eduucaldas added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc3d4743277b: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API (authored by eduucaldas). Repository: rG LLVM Github Monorepo

[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86679 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. It's worth noting that accessors in the base APIs don't follow this rule. Should we refactor them as well? In this patch? Examples: class Arena { public: const SourceManager &sourceManager() const { return SourceMgr; }

[PATCH] D86682: [SyntaxTree][NFC][Style] Functions start with lowercase

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86682 Files: clang/lib/Tooling/Syntax/BuildTree.cpp Index: clang/lib/Tooling/

[PATCH] D86698: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86698 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/S

[PATCH] D86698: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 288282. eduucaldas added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86698/new/ https://reviews.llvm.org/D86698 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/S

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/S

[PATCH] D86682: [SyntaxTree][NFC][Style] Functions start with lowercase

This revision was automatically updated to reflect the committed changes. Closed by commit rGac87a0b5873c: [SyntaxTree][NFC][Style] Functions start with lowercase (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86682/new/ htt

[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda3fa822cb6: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. The refactored functions were - `isReponsibleForCreatingDeclaration` - `getQualifiedNameStart` Repository: rG LLVM Github Monorepo https://re

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas updated this revision to Diff 288362. eduucaldas added a comment. Fix macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86719/new/ https://reviews.llvm.org/D86719 Files: clang/lib/Tooling/Syntax/BuildTree.cpp Index: clang/lib/Tool

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas updated this revision to Diff 288367. eduucaldas added a comment. Inline getDeclaratorRange inside buildTrailingReturn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86719/new/ https://reviews.llvm.org/D86719 Files: clang/lib/Tooling/S

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. As a result of this change `getDeclaratorRange` is used exclusively inside `processDeclaratorAndDeclaration` and the last two arguments are direct results of `getQualifiedNameStart(D)` and `getInitializerRange(D)`, which are us

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas updated this revision to Diff 288559. eduucaldas added a comment. Move `getDeclaratorRange` helpers outside of `TreeBuilder` Add coverage for qualified declarators and init-declarators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86719/n

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:225-226 +/// `int *a = nullptr` -> range of `= nullptr`. +/// `int a{}` -> range of `{}`. +/// `int a()` -> range of `()`. +static SourceRange getInitializerRange(Decl *D) { -

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. This allows users to use `IgnoreExprNodes` outside of `clang/AST/Expr.h` Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86778

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas updated this revision to Diff 288584. eduucaldas marked an inline comment as done. eduucaldas added a comment. Rebase and answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86719/new/ https://reviews.llvm.org/D86719 Files:

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:245 +/// `int S::f(){}` -> range of `S::f()`. +/// FIXME: \p Name must be a source range, e.g. for `operator+`. static SourceRange getDeclaratorR

[PATCH] D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. eduucaldas marked an inline comment as done. Closed by commit rG38bc0060e60f: [SyntaxTree][NFC] Refactor function templates into functions taking base class (authored b

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

eduucaldas updated this revision to Diff 288963. eduucaldas added a comment. Herald added a subscriber: mgorny. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/new/ https://reviews.llvm.org/D86778 Files: clang/include/clang/

[PATCH] D86880: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. eduucaldas requested review of this revision. This change groups - Rename: `ignoreParenBaseCasts` -> `IgnoreParenBaseCasts` for uniformity - Re

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

eduucaldas updated this revision to Diff 288965. eduucaldas added a comment. Fix lint problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/new/ https://reviews.llvm.org/D86778 Files: clang/include/clang/AST/IgnoreExpr.h clang/lib/AST/C

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

eduucaldas updated this revision to Diff 288978. eduucaldas marked an inline comment as done. eduucaldas added a comment. Answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/new/ https://reviews.llvm.org/D86778 Files: clang/inclu

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 288984. eduucaldas added a comment. Use `IgnoreExpr.h` infrastructure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cp

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 288987. eduucaldas added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Sy

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 288988. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:48-58 +static Expr *IgnoreImplicitCXXConstructExpr(Expr *E) { + if (auto *C = dyn_cast(E)) { +auto NumArgs = C->getNumArgs(); +if (NumArgs == 1 |

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 289103. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Add further tests and extract `IgnoreImplicitConstructorSingleStep` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ h

[PATCH] D86880: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a7a2cd7474e: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits (authored by eduucaldas). Changed prior to commit: https://

[PATCH] D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`

This revision was automatically updated to reflect the committed changes. Closed by commit rG81aa66f65f50: Extract infrastructure to ignore intermediate expressions into… (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86778/n

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290223. eduucaldas added a comment. Add more tests, not extract `IgnoreImplicitConstructorSingleStep` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290224. eduucaldas marked an inline comment as done. eduucaldas added a comment. Add FIXME for `CXXFunctionalCastExpr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700

[PATCH] D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87229 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/S

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290227. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Synta

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290228. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Synta

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:552 [[::n::S s1]]; [[n::S s2]]; } gribozavr2 wrote: > Do we have tests for calling constructors with arguments? > > `n::S s3(1, 2, 3);` > `n::S s3{1, 2, 3};` >

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290259. eduucaldas added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/To

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290260. eduucaldas added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/To

[PATCH] D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor

eduucaldas updated this revision to Diff 290261. eduucaldas added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87229/new/ https://reviews.llvm.org/D87229 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/To

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:48-50 +// Ignores the implicit `CXXConstructExpr` for copy/move constructors generated +// by the compiler, as well as in implicit conversions like the one wrapping `1` +// in `X x = 1;`. --

[PATCH] D87249: [SyntaxTree] Fix crash on functions with default arguments.

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. - Do not visit `CXXDefaultArgExpr` - To build `CallArguments` nodes, just go through non-default arguments

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290327. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/T

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas updated this revision to Diff 290328. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86700/new/ https://reviews.llvm.org/D86700 Files: clang/lib/T

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:4042 + +TEST_P(SyntaxTreeTest, ExplicitConversion_ZeroArguments) { + if (!GetParam().isCXX()) { gribozavr2 wrote: > This is not a conversion, this is an explicit const

[PATCH] D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1137 +// Ignore the implicit default constructs. +if ((S->getNumArgs() == 0 || isa(S->getArg(0))) && +S->getParenOrBraceRange().isInvalid()) gribozavr2 wrote: > I

[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`

eduucaldas updated this revision to Diff 290331. eduucaldas added a comment. - Rename tests - Add FIXMEs for init-declarators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86699/new/ https://reviews.llvm.org/D86699 Files: clang/lib/Tooling/Synta

<    1   2   3   4   5   >