[PATCH] D80540: Add support for binary operators in Syntax Trees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80540 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/B

[PATCH] D80624: Add support for UnaryOperator in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. gribozavr2 accepted this revision. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D806

[PATCH] D80731: Improve test infrastructure in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. - Test if the code sourcing the SyntaxTree compiles - Output compiler errors and warnings to err - Fix tests with code that did not compile Repository

[PATCH] D80812: Add support for Overloaded Binary Operators in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80812 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Syntax

[PATCH] D80822: Run syntax tree tests in many language modes

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:54-63 + bool isCXX() const { +return Language == Lang_CXX || Language == Lang_CXX11 || + Language == Lang_CXX14 || Language == Lang_CXX17 || + Language == Lang_CXX2a

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1048 + syntax::Tree *ChildNode; + if (Expr *ChildExpr = dyn_cast(Child)) { +// This is an expression in a statement position, consume the trailing ---

[PATCH] D81092: Add support for `nullptr` in SyntaxTrees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81092 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/B

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84348 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas added a reviewer: gribozavr2. eduucaldas marked 6 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:101-106 + UnknownNameSpecifier, + GlobalNameSpecifier, + NamespaceNameSpecifier, + TypeNameSpecifier,

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280216. eduucaldas added a comment. Update API to new nested-name-specifier grammar rule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files: clang/include/clang

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280497. eduucaldas added a comment. - Improve getLocalSourceRange - nested-name-specifier is now a ::-separated list of name-specifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://review

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280511. eduucaldas added a comment. - Remove UnknownNameSpecifier, answer to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files: clang/include/clang/To

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280899. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. - Answer code review - Simpler logic for `getUnqualifiedIdSourceRange` and inline it - Remove ambiguously named variable NNS Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:834 + // FIXME: I feel like this could be upstreamed. + SourceRange getUnqualifiedIdSourceRange(DeclRefExpr *S) { +if (S->hasExplicitTemplateArg

[PATCH] D84781: Use PointerUnion instead of inheritance for alternative clauses in NNS

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84781 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/include/clang/T

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268382. eduucaldas added a comment. Add support for IntegerLiteral in SyntaxTree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling

[PATCH] D81136: Define rules for naming NodeRole and apply them.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81136 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268397. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/T

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268403. eduucaldas added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Synta

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268420. eduucaldas added a comment. answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/li

[PATCH] D81135: Add support for IntegerLiteral in SyntaxTree

eduucaldas updated this revision to Diff 268428. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81135/new/ https://reviews.llvm.org/D81135 Files: clang/include/clan

[PATCH] D81155: Rename arrow -> arrowToken for unified naming

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81155 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/N

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a subscriber: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. eduucaldas marked an inline comment as not done. Comm

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas added a subscriber: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:829 +| | | | | `-:: +| | | | `-TypeSpecifier +| | | | |-S Perhaps we sh

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas updated this revision to Diff 268503. eduucaldas marked an inline comment as done. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/unittests/Tooling/S

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:94 /// a binary expression'. Used for implementing accessors. +// How to name NodeRole: +// If the child node is a token/keyword, end its name with 'Token'/'Keyword' griboza

[PATCH] D81168: Add support for id-expression in SyntaxTree

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:829 +| | | | | `-:: +| | | | `-TypeSpecifier +| | | | |-S eduucaldas wrote: > Perhaps we shouldn't differ between specifiers as that is semantical > informati

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas updated this revision to Diff 268502. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Fix cout, add explanation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files: c

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas updated this revision to Diff 268519. eduucaldas added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D81157: Propose naming principle for NodeRole and apply it

eduucaldas updated this revision to Diff 268517. eduucaldas added a comment. `ArrowToken`, `ExternKeyword` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81157/new/ https://reviews.llvm.org/D81157 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D81280: (Incomplete)Add support for id-expression

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - TODO: Differ between NameQualifiers - TODO: Box all operators - Done: Treat NestedNameSpecifiers - Done: [Try] Unbox all operators Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D81280: (Incomplete)Add support for id-expression

eduucaldas updated this revision to Diff 269127. eduucaldas added a comment. Add support for DeclRefExpr in SyntaxTree, by generating IdExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81280/new/ https://reviews.llvm.org/D81280 Files: cl

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269129. eduucaldas added a comment. cleanup for upstreaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h cla

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 6 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:618 + Builder.foldNode(Builder.getRange(it.getLocalSourceRange()), NS, nullptr); + Builder.markChild(NS, syntax::NodeRole::Unknown); +}

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269422. eduucaldas edited the summary of this revision. eduucaldas added a comment. Answering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269423. eduucaldas added a comment. nswering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h cl

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271620. eduucaldas marked 7 inline comments as done. eduucaldas added a comment. - cleanup for upstreaming - better coverage for unqualified-id - Better coverage for qualified-id - Finish implementing unqualified-id. Repository: rG LLVM Github Monorepo

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked an inline comment as not done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; gribozavr2 wrote: > Should there be getters for various parts

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271630. eduucaldas added a comment. Fix mistake on getting SourceRange for template-id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/T

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 274769. eduucaldas added a comment. better comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/lib/AST/ExprCXX.cpp clang/unittests/Tooling/CMake

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82954 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprCXX.cpp clang/lib/Tooling/Syntax/BuildTree.cpp clang/u

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas added a reviewer: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added a comment. Code that reproduces the crash Notice that when using a postfix unary operator ++ one argument is introduced to differ it from its prefix counterpart, b

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas updated this revision to Diff 274795. eduucaldas added a comment. Ordering nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/ https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tool

[PATCH] D82960: Add parenthesized expression to SyntaxTree

eduucaldas updated this revision to Diff 274796. eduucaldas added a comment. nitpick comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/ https://reviews.llvm.org/D82960 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/T

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/AST/ExprCXX.cpp:82 + default: +return getNumArgs() == 1; + } riccibruno wrote: > This will be true for `operator->`. Thank you ! I had missed that! I'll pro

[PATCH] D82960: Add parenthesized expression to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdbd78333fc6: Add parenthesized expression to SyntaxTree (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/ https://reviews.

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275318. eduucaldas added a comment. Revert mistake on last update, used `arc diff --update` with the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275315. eduucaldas added a comment. - Remove predicates in `CXXOperatorCallExpr`. - Implement getOperatorNodeKind to dispatch from `CXXOperatorCallExpr` to syntax constructs like `BinaryOperatorExpression`, `PrefixUnaryOperatorExpression`... Repository

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 275317. eduucaldas added a comment. Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprCXX.cpp cla

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas updated this revision to Diff 275316. eduucaldas added a comment. Herald added a subscriber: mgorny. Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files: clang/include/clang/AST/ExprCXX.

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 275325. eduucaldas added a comment. Remove review formatting noise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/include/clang/AST/ExprCXX.h clang

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid sloc

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:118 +syntax::NodeKind getOperatorNodeKind(const CXXOperatorCallExpr &E) { + switch (E.getOperator()) { # Where to put this logic? The pro of having this function inside `Buil

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:188 + case OO_Comma: + case OO_ArrowStar: +return syntax::NodeKind::UnknownExpression; Actually arrow star is treated like a normal binary operator in the [[ https://eel.i

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 275930. eduucaldas added a comment. `->*` and `,` are binary operators. Unit tests covering most of the operator kinds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 275940. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files: clang/li

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas added a comment. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:741 bool WalkUpFromIntegerLiteral(IntegerLiteral *S) { +if (S->getLocation().isInvalid()) + return true; gribozavr2 wrote: > WDYT about overriding `TraverseCXXOperatorCa

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 275942. eduucaldas added a comment. Unifying user defined binary operator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files: clang/lib/Tooling/Syntax/Bui

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192 R"cpp( +class osstream {}; struct X { gribozavr2 wrote: > I don't think we need a separate class to show the left shift operator. The > declaration below can b

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 276344. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. answering minor comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files: cl

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276361. eduucaldas added a comment. Reflect fix on RecursiveASTVisitor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Tooling/Syntax/No

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192 R"cpp( +class osstream {}; struct X { gribozavr2 wrote: > eduucaldas wrote: > > gribozavr2 wrote: > > > I don't thi

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 276408. eduucaldas marked an inline comment as done. eduucaldas added a comment. Switch to `TraverseCXXOperatorCallExpr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D829

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 276411. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. minor fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files: clang/li

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8bba7e8d0d: Fix crash on overloaded postfix unary operators due to invalid sloc (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D829

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1265 +| |-UserDefinedLiteralExpression +| | `-12_w +| `-; gribozavr2 wrote: > It looks somewhat weird to me that int

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGea8bba7e8d0d: Fix crash on overloaded postfix unary operators due to invalid sloc (authored by eduucaldas). Changed prior

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276637. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Add support for {Integer,Float,Char,String}UserDefinedLiteral Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https:/

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276638. eduucaldas added a comment. workaround size_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Testing/TestClangConfig.h clang/

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas marked 4 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:347-357 +/// Expression for an unkonwn user-defined literal. C++ [lex.ext] +class UnknownUserDefinedLiteralExpression final +: public UserDefi

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276678. eduucaldas added a comment. Polishing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/T

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:634 +// `SourceLocation`s. As a result one of these nodes has a valid +// `SourceLocation` that doesn't point to a token. +// gribozavr2 wrote: > "The semantic AST no

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276681. eduucaldas added a comment. Document proposed solution for treating raw literal operators and numeric template operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

eduucaldas accepted this revision. eduucaldas added a comment. This revision is now accepted and ready to land. Additionally, consider applying a similar change to `CharLiteralParser`, for consistency. All the comments are just suggestions. Feel free to land this without answering them.

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276770. eduucaldas added a comment. Add support for integer and floating UDL even for raw literal operator and numeric literal operator template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ http

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276771. eduucaldas added a comment. nothing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/S

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:736 + auto TokSpelling = + Builder.findToken(TokLoc)->text(Context.getSourceManager()); + auto Literal = NumericLiteralParser{TokSp

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276772. eduucaldas added a comment. Nothing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/S

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276919. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. Use right function to get TokSpelling, answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://review

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1210 + 12_t; // call: operator<'1', '2'> "" _x() | kind: integer + 1.2_t; // call: operator<'1', '2'> "" _x() | kind: float } gribozavr2 wrote: > call -> calls? (as in,

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:723 + syntax::UserDefinedLiteralExpression * + buildUserDefinedLiteral(UserDefinedLiteral *S) { +switch (S->getLiteralOperatorKind()) {

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276960. eduucaldas added a comment. - Add comment explaining complication on LOK_Raw and LOK_Template - Use FileRange::text instead of Lexer::getSpelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/ne

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 277060. eduucaldas marked an inline comment as done. eduucaldas added a comment. Add assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/cl

[PATCH] D82157: Fix crash on `user defined literals`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf33c2c27a8d4: Fix crash on `user defined literals` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82157?vs=277060&id=277071#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271744. eduucaldas marked 12 inline comments as done. eduucaldas added a comment. Aswering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/in

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; eduucaldas wrote: > gribozavr2 wrote: > > Should there be getters

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271784. eduucaldas added a comment. change if -> asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Given an UserDefinedLiteral `1.2_w`: Problem: Lexer generates one Token for the literal, but ClangAST references two source locations Fix: Ignore the operator and interpret it as the underlying

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 271980. eduucaldas added a comment. Why does this work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unitt

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82302 Files: clang/include/clang/Tooling/Syntax/Nodes.h Index: clang/include/clang/Tooling/Syntax/Nodes.h ==

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas updated this revision to Diff 272445. eduucaldas added a comment. update comments, rollback references, and add them as proposition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82302/new/ https://reviews.llvm.org/D82302 Files: clang/

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82310 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas marked 3 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:268 +/// Expression for boolean literals. C++ [lex.bool] +class BoolLiteralExpression final : public Expression { Homogenize th

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82312 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/B

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 272492. eduucaldas added a comment. removing automatically added include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82318/new/ https://reviews.llvm.org/D82318 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas updated this revision to Diff 272492. eduucaldas added a comment. removing automatically added include Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82318 Files

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} gribozavr2 wrote: > C99 has bool literals, but the program should include stdbool.h. > > I feel like

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas added a reviewer: gribozavr2. eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:72-75 + bool isCXX17OrLater() const { +return Language == Lang_CXX17 || Language == Lang_CXX20; +

  1   2   3   4   5   >