eraman created this revision.
eraman added a reviewer: vsk.
eraman added subscribers: cfe-commits, davidxl.
http://reviews.llvm.org/D19612
Files:
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CoverageMappingGen.cpp
Index: lib/CodeGen/CoverageMappingGen.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268090: Use the new path for coverage related headers and
update CMakeLists.txt (authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D19612?vs=55279&id=55643#toc
Repository:
rL LLVM
Author: eraman
Date: Fri Apr 29 13:53:16 2016
New Revision: 268090
URL: http://llvm.org/viewvc/llvm-project?rev=268090&view=rev
Log:
Use the new path for coverage related headers and update CMakeLists.txt
Differential Revision: http://reviews.llvm.org/D19612
Modified:
cfe/trunk/lib/CodeGen/C
eraman created this revision.
eraman added a reviewer: vsk.
eraman added subscribers: cfe-commits, davidxl.
Step 2 of MaxFunctionCount removal. It is superseded by ProfileSummary flag.
http://reviews.llvm.org/D19184
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/max-function-count.c
Inde
eraman added a comment.
This patch and the one in http://reviews.llvm.org/D19185 are now ready to land
as the inliner now uses ProfileSummaryInfo. I will check them in.
http://reviews.llvm.org/D19184
___
cfe-commits mailing list
cfe-commits@lists.
Author: eraman
Date: Mon Jun 20 15:48:32 2016
New Revision: 273198
URL: http://llvm.org/viewvc/llvm-project?rev=273198&view=rev
Log:
Remove MaxFunctionCount module flag annotation.
Differential revision: http://reviews.llvm.org/D19184
Removed:
cfe/trunk/test/Profile/max-function-count.c
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273198: Remove MaxFunctionCount module flag annotation.
(authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D19184?vs=53969&id=61302#toc
Repository:
rL LLVM
http://reviews.llvm.or
eraman created this revision.
eraman added a reviewer: vsk.
eraman added subscribers: cfe-commits, davidxl.
This allows optimization passes to make use of detailed profile summary. Once
this is in and the optimization passes are made to use this, the
"MaxFunctionCount" flag will be removed as th
eraman updated this revision to Diff 51342.
eraman added a comment.
Address Vedant's comments
http://reviews.llvm.org/D18289
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/Inputs/profile-summary.proftext
test/Profile/profile-summary.c
Index: test/Profile/profile-summary.c
eraman marked 2 inline comments as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:398-399
@@ -397,3 +397,4 @@
if (PGOReader) {
getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());
+getModule().setProfileSummary(PGOReader->getSummary().getMD(VMCon
eraman added a comment.
Since test case tests this change - that profile summary is attached to the
module - I think it is sufficient. David and Vedant, does this sound reasonable?
http://reviews.llvm.org/D18289
___
cfe-commits mailing list
cfe-com
Author: eraman
Date: Thu Mar 24 16:32:25 2016
New Revision: 264342
URL: http://llvm.org/viewvc/llvm-project?rev=264342&view=rev
Log:
Attach profile summary information to Module.
Differential Revision: http://reviews.llvm.org/D18289
Added:
cfe/trunk/test/Profile/Inputs/profile-summary.prof
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264342: Attach profile summary information to Module.
(authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D18289?vs=51342&id=51604#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: eraman
Date: Mon Jan 4 17:32:28 2016
New Revision: 256793
URL: http://llvm.org/viewvc/llvm-project?rev=256793&view=rev
Log:
Remove setting of inlinehint and cold attributes based on profile data
NFC. These hints are only used for inlining and the inliner now uses
the same criteria to ide
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256793: Remove setting of inlinehint and cold attributes
based on profile data (authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D15726?vs=43479&id=43937#toc
Repository:
rL LLVM
eraman updated this revision to Diff 42549.
eraman added a comment.
Added a test case.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/pgo-max-function-count.c
Index: test/CodeGen/pgo-max-function-count.c
=
eraman marked an inline comment as done.
eraman added a comment.
I've added a test case to check for the presence of MaxFunctionCount module
flag. I'll check in this patch soon.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits
Author: eraman
Date: Fri Dec 11 18:31:02 2015
New Revision: 255397
URL: http://llvm.org/viewvc/llvm-project?rev=255397&view=rev
Log:
Attach maximum function count to Module when using PGO mode
This sets the maximum entry count among all functions in the program to the
module using module flags. T
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255397: Attach maximum function count to Module when using
PGO mode (authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D15163?vs=42549&id=42604#toc
Repository:
rL LLVM
http://rev
Author: eraman
Date: Fri Dec 11 19:11:09 2015
New Revision: 255416
URL: http://llvm.org/viewvc/llvm-project?rev=255416&view=rev
Log:
Revert r254647.
Reason: The testcase fails in many architectures.
Differential Revision: http://reviews.llvm.org/D15163
Removed:
cfe/trunk/test/CodeGen/pgo-m
eraman added a comment.
I have reverted the commit in r255416 because the test failed in many
architectures. In many cases the linker is not able to find
libclang_rt.profile-$ARCH.a file. There are also other errors. Here is one:
0. Program arguments:
/var/lib/buildbot/slaves/hexagon-buil
On Fri, Dec 11, 2015 at 6:12 PM, Justin Bogner
wrote:
> Easwaran Raman writes:
> > eraman added a comment.
> >
> > I have reverted the commit in r255416 because the test failed in many
> > architectures.
>
> You also committed without waiting for further review, despite that
> David said "LGTM b
On Mon, Dec 14, 2015 at 3:26 PM, Xinliang David Li
wrote:
> On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner
> wrote:
> > Easwaran Raman writes:
> >> eraman updated this revision to Diff 42549.
> >> eraman added a comment.
> >>
> >> Added a test case.
> >>
> >>
> >> Repository:
> >> rL LLVM
> >
eraman updated this revision to Diff 42797.
eraman added a comment.
Updated the patch addressing Justin's comments and a new test case.
(Should I open a new review thread since phabricator thinks this has been
submitted?)
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/Code
eraman updated this revision to Diff 42801.
eraman added a comment.
Fix the comment in the test case
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/Inputs/max-function-count.proftext
test/Profile/max-function-count.c
Index: test/Pr
eraman updated this revision to Diff 43089.
eraman added a comment.
Updated the test case.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/Inputs/max-function-count.proftext
test/Profile/max-function-count.c
Index: test/Profile/max-
eraman added a comment.
Justin, does this patch look ok?
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eraman
Date: Thu Dec 17 13:14:27 2015
New Revision: 255918
URL: http://llvm.org/viewvc/llvm-project?rev=255918&view=rev
Log:
Attach maximum function count to Module when using PGO mode.
This sets the maximum entry count among all functions in the program to the
module using module flags.
eraman created this revision.
eraman added reviewers: bogner, davidxl.
eraman added a subscriber: cfe-commits.
NFC. These hints are only used for inlining and the inliner now uses the same
criteria to identify hot and cold callees and set appropriate thresholds
without relying on these hints. He
29 matches
Mail list logo
