Author: dexonsmith
Date: Sat Feb 20 18:14:36 2016
New Revision: 261461
URL: http://llvm.org/viewvc/llvm-project?rev=261461&view=rev
Log:
Lex: Never overflow the file in HeaderMap::lookupFilename()
If a header map file is corrupt, the strings in the string table may not
be null-terminated. The lo
Author: dexonsmith
Date: Mon Feb 22 16:24:22 2016
New Revision: 261585
URL: http://llvm.org/viewvc/llvm-project?rev=261585&view=rev
Log:
Lex: Check for 0 buckets on header map construction
Switch to using `isPowerOf2_32()` to check whether the buckets are a
power of two, and as a side benefit rej
> On 2016-Feb-22, at 10:39, Adrian Prantl wrote:
>
>>
>> On Feb 20, 2016, at 1:00 PM, Duncan P. N. Exon Smith via cfe-commits
>> wrote:
>>
>> Author: dexonsmith
>> Date: Sat Feb 20 15:00:58 2016
>> New Revision: 261448
>>
>>
Author: dexonsmith
Date: Mon Feb 22 18:48:16 2016
New Revision: 261596
URL: http://llvm.org/viewvc/llvm-project?rev=261596&view=rev
Log:
Lex: Return "" when HeaderMap::lookupFilename fails
Change getString() to return Optional, and change
lookupFilename() to return an empty string if either one o
> On 2016-Feb-22, at 17:24, Manman Ren wrote:
>
>
>
>> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith
>> wrote:
>>
>> This patch adds support for templates in availability attributes.
>> - If the context for an availability diagnostic is a
>> `FunctionTemplateDecl`, look through it t
> On 2016-Feb-23, at 11:18, Aaron Ballman wrote:
>
> On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote:
>> This patch looks good to me. But I am not sure if Aaron has any comment.
>>
>> On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith
>> wrote:
>>
>>
>> On 2016-Feb-22, at 17:24, Manman
Is this something that you need the linker to treat as "used", or just
something you don't want the compiler to drop? If the latter,
@llvm.compiler.used seems more appropriate.
> On 2016-May-13, at 14:01, Steven Wu wrote:
>
> Attach a patch using private linkage type and adding to llvm.used.
I don't think we even need a helper.
Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a
`DiagnosticsEngine`, which has a `DiagnosticsOptions`.
In other words, I think you can delete the code in Clang::ConstructJob (change
it to a lookup) now that you've changed clang::
dexonsmith added a comment.
I don't think we even need a helper.
Clang::ConstructJob takes a `Compilation`, which has a `Driver`, which has a
`DiagnosticsEngine`, which has a `DiagnosticsOptions`.
In other words, I think you can delete the code in Clang::ConstructJob (change
it to a lookup) no
LGTM from the Darwin-side, assuming Reid doesn't have any more comments.
> On 2016-Mar-28, at 13:12, Bruno Cardoso Lopes wrote:
>
> bruno updated this revision to Diff 51828.
> bruno added a comment.
>
> Thanks Reid. The original idea was to have MaxDigits despite the size of the
> input array
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
LGTM from the Darwin-side, assuming Reid doesn't have any more comments.
http://reviews.llvm.org/D18304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
LGTM. Thanks for picking this up (and sorry for getting distracted)!
> On 2016-Mar-30, at 21:15, Eric Fiselier wrote:
>
> EricWF created this revision.
> EricWF added reviewers: mclow.lists, dexonsmith.
> EricWF added a subscriber: cfe-commits.
>
> This patch applies Duncan's work on __hash_ta
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
LGTM. Thanks for picking this up (and sorry for getting distracted)!
http://reviews.llvm.org/D18637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
IR changes LGTM, if you add the missing verifier check (I'm surprised
this *ever* passed the verifier...)
Someone else will have to look at DwarfDebug.cpp.
> On 2016-Apr-05, at 16:55, Adrian Prantl wrote:
>
> aprantl created this revision.
> aprantl added reviewers: dblaikie, echristo, dexonsm
Okay, weird. So the DICompileUnit wouldn't even get written out to
bitcode, IIUC. LGTM then.
> On 2016-Apr-06, at 14:31, Adrian Prantl wrote:
>
> aprantl added a comment.
>
> Duncan: There already exists a verifier check that ensures each DICompileUnit
> is listed in llvm.dbg.cu.
> This didn
> On 2016-Apr-13, at 09:50, Eric Fiselier wrote:
>
> EricWF added inline comments.
>
>
> Comment at:
> test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp:29
> @@ +28,3 @@
> +template
> +void PrintInfo(int line, Arg&& arg)
> +{
> ---
Author: dexonsmith
Date: Sun Apr 17 02:45:08 2016
New Revision: 266556
URL: http://llvm.org/viewvc/llvm-project?rev=266556&view=rev
Log:
DebugInfo: Make DICompositeTypes distinct most of the time
Since elements of most kinds of DICompositeType have back references,
most are involved in uniquing c
Author: dexonsmith
Date: Sat Apr 23 16:08:27 2016
New Revision: 267297
URL: http://llvm.org/viewvc/llvm-project?rev=267297&view=rev
Log:
DebugInfo: Adapt to loss of DITypeRef in LLVM r267296
LLVM stopped using MDString-based type references, and DIBuilder no
longer fills 'retainedTypes:' with eve
Author: dexonsmith
Date: Sat Apr 23 17:29:26 2016
New Revision: 267302
URL: http://llvm.org/viewvc/llvm-project?rev=267302&view=rev
Log:
DebugInfo: DIGlobalVariables became 'distinct' in LLVM r267301
Update testcases due to DIBuilder change.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-glo
LGTM.
> On 2016-May-26, at 11:34, Bruno Cardoso Lopes wrote:
>
> bruno added a comment.
>
> Ping!
>
>
> http://reviews.llvm.org/D20404
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
LGTM.
http://reviews.llvm.org/D20404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I agree with Mehdi. I expect `-S -flto` to give equivalent output to `-c
-flto`.
In effect, with this change, `-flto -S` would silently ignore the `-flto` flag.
That doesn't make sense to me.
> On 2016-Jun-05, at 18:28, Mehdi AMINI wrote:
>
> mehdi_amini added a comment.
>
> What makes me
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
I agree with Mehdi. I expect `-S -flto` to give equivalent output to `-c
-flto`.
In effect, with this change, `-flto -S` would silently ignore the `-flto` flag.
That doesn't make sense to me.
http://reviews.llvm.org/D210
> On 2016-Jun-27, at 11:02, Aaron Ballman wrote:
>
> aaron.ballman requested changes to this revision.
> aaron.ballman added a comment.
> This revision now requires changes to proceed.
>
> Missing Sema tests for the attribute.
>
>
>
> Comment at: include/clang/Basic/AttrDocs.
The fix looks fairly obvious, but you haven't added a testcase. Would you
please do so?
> On 2016-May-17, at 12:20, Akira Hatanaka via cfe-commits
> wrote:
>
> ahatanak created this revision.
> ahatanak added reviewers: mclow.lists, EricWF, howard.hinnant.
> ahatanak added a subscriber: cfe-c
(Ignore me, I was looking at an old version.)
> On 2016-Jun-28, at 17:56, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> The fix looks fairly obvious, but you haven't added a testcase. Would you
> please do so?
>
>> On 2016-May-17, at 12:20, Akira Hatana
dexonsmith added a comment.
I agree with Ben that this looks good.
Marshall and Eric, do you want Akira to hold off, or are you happy deferring to
Ben and me?
http://reviews.llvm.org/D20334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
I agree with Ben that this looks good.
Marshall and Eric, do you want Akira to hold off, or are you happy deferring to
Ben and me?
> On 2016-May-26, at 18:31, Akira Hatanaka via cfe-commits
> wrote:
>
> ahatanak updated this revision to Diff 58740.
> ahatanak added a comment.
>
> Remove unus
> On 2016-Jul-12, at 16:53, Vedant Kumar wrote:
>
> vsk created this revision.
> vsk added a reviewer: dexonsmith.
> vsk added a subscriber: cfe-commits.
> Herald added subscribers: srhines, danalbert, tberghammer, aemerson.
>
> Compute an effective target triple exactly once in ConstructJob(),
If no one is using it, making it private is obvious goodness. LGTM.
> On 2016-Jul-12, at 16:52, Vedant Kumar wrote:
>
> vsk created this revision.
> vsk added a reviewer: dexonsmith.
> vsk added a subscriber: cfe-commits.
>
> The clang driver knows about two kinds of target triples: default an
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
If no one is using it, making it private is obvious goodness. LGTM.
http://reviews.llvm.org/D22289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
> On 2016-Jul-12, at 17:47, Vedant Kumar wrote:
>
>
>> On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith
>> wrote:
>>
>>
>>> On 2016-Jul-12, at 16:53, Vedant Kumar wrote:
>>>
>>> vsk created this revision.
>>> vsk added a reviewer: dexonsmith.
>>> vsk added a subscriber: cfe-commits.
>
> On 2016-Jul-12, at 18:59, Vedant Kumar wrote:
>
>>
>> On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith
>> wrote:
>>
>>
>>> On 2016-Jul-12, at 17:47, Vedant Kumar wrote:
>>>
>>>
On Jul 12, 2016, at 5:41 PM, Duncan P. N. Exon Smith
wrote:
> On 2016-Jul-12,
We saw mixed results from this on LNT, including some major regressions. For
example, on x86_64, SingleSource/Benchmarks/Shootout-C++/hash2 regressed 18.5%
at -O3 and over 20% at -Os.
Is this expected?
> On 2016-Jul-11, at 15:02, Eric Fiselier via cfe-commits
> wrote:
>
> Author: ericwf
> D
Hmm. I implied there were other regressions, but I just finished scanning
them. Shootout-C++/hash2 is the only major one. The others were small, and
only at -O0.
> On 2016-Jul-13, at 17:38, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> We saw mixed results from
> On 2016-Jul-13, at 11:18, Vedant Kumar wrote:
>
>>
>> On Jul 13, 2016, at 10:30 AM, Duncan P. N. Exon Smith
>> wrote:
>>
>>
>>> On 2016-Jul-12, at 18:59, Vedant Kumar wrote:
>>>
On Jul 12, 2016, at 6:23 PM, Duncan P. N. Exon Smith
wrote:
> On 2016-Jul-1
++/hash2 is the only major one. The others were small, and
> only at -O0.
>
> > On 2016-Jul-13, at 17:38, Duncan P. N. Exon Smith via cfe-commits
> > wrote:
> >
> > We saw mixed results from this on LNT, including some major regressions.
> > For example, on
s:
http://llvm.org/perf/db_default/v4/nts/86784
>
>>
>> On Wed, Jul 13, 2016 at 6:41 PM, Duncan P. N. Exon Smith
>> wrote:
>> Hmm. I implied there were other regressions, but I just finished scanning
>> them. Shootout-C++/hash2 is the only major one. The othe
Author: dexonsmith
Date: Fri Feb 26 13:27:00 2016
New Revision: 262050
URL: http://llvm.org/viewvc/llvm-project?rev=262050&view=rev
Log:
SemaCXX: Support templates in availability attributes
If the availability context is `FunctionTemplateDecl`, we should look
through it to the `FunctionDecl`. T
> On 2016-Feb-24, at 10:01, Aaron Ballman wrote:
>
> On Tue, Feb 23, 2016 at 6:39 PM, Duncan P. N. Exon Smith
> wrote:
>>
>>> On 2016-Feb-23, at 11:18, Aaron Ballman wrote:
>>>
>>> On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote:
This patch looks good to me. But I am not sure if Aaro
Author: dexonsmith
Date: Tue Mar 8 00:12:54 2016
New Revision: 262915
URL: http://llvm.org/viewvc/llvm-project?rev=262915&view=rev
Log:
Sema: Treat 'strict' availability flag like unavailable
This is a follow-up to r261512, which made the 'strict' availability
attribute flag behave like 'unavail
Author: dexonsmith
Date: Tue Mar 8 04:28:52 2016
New Revision: 262921
URL: http://llvm.org/viewvc/llvm-project?rev=262921&view=rev
Log:
Sema: Methods in unavailable classes are unavailable
Similar to the template cases in r262050, when a C++ method in an
unavailable struct/class calls unavailabl
Does anyone have a problem with this direction? I have commits to
follow that get tests green when run against various releases of OSX
but I need this in place first.
> On 2016-Feb-19, at 17:59, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> dexonsmith created t
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Does anyone have a problem with this direction? I have commits to
follow that get tests green when run against various releases of OSX
but I need this in place first.
http://reviews.llvm.org/D17469
___
Chad and I talked about this off-list (my fault!) a couple of weeks
ago; finally moving this to an actual review thread.
> On 2016-Jan-06, at 06:35, Chad Rosier via cfe-commits
> wrote:
>
> Author: mcrosier
> Date: Wed Jan 6 08:35:46 2016
> New Revision: 256937
>
> URL: http://llvm.org/viewvc
Did anyone file a PR for this?
> On 2015-Oct-19, at 15:52, Richard Smith via cfe-commits
> wrote:
>
> Ugh, looks like I missed a submodule for stdio.h :(
>
> On Oct 19, 2015 11:34 AM, "Adrian Prantl" wrote:
> While building module 'std' imported from
> /Volumes/Data/llvm/_build.ninja.release
dexonsmith created this revision.
dexonsmith added a reviewer: EricWF.
dexonsmith added a subscriber: cfe-commits.
Modernize the test from r239666 as a precursor for making similar fixes
to unordered_map.
http://reviews.llvm.org/D18115
Files:
test/libcxx/containers/unord/unord.set/insert_dup_
dexonsmith updated this revision to Diff 50514.
dexonsmith added a comment.
A few updates:
- Rebased on top of http://reviews.llvm.org/D18115.
- Rewrote the test to match suggested style.
- Updated the code to catch unordered_set::emplace as well, using a
__can_extract_key trait and a companion
Author: dexonsmith
Date: Thu Mar 17 15:45:20 2016
New Revision: 263746
URL: http://llvm.org/viewvc/llvm-project?rev=263746&view=rev
Log:
unord: Extract key to avoid preemptive mallocs in insert/emplace
unordered_set::emplace and unordered_map::emplace construct a node, then
try to insert it. If
dexonsmith updated this revision to Diff 50869.
dexonsmith added a comment.
Eric and I had a quick chat on IRC.
- The asymmetric usage of __extract_key and __can_extract_key was awkward, as
Eric pointed out already.
- However, a symmetric __extract_key would have caused Clang (and other
compile
> On 2016-Mar-16, at 12:20, Eric Fiselier wrote:
>
> EricWF added a comment.
>
> Adding inline comments for the implementation. Comments on the tests to
> follow shortly.
>
>
>
> Comment at: include/__hash_table:103
> @@ -102,1 +102,3 @@
>
> +template
> +struct __extract_k
dexonsmith updated this revision to Diff 50883.
dexonsmith added a comment.
Eric sent me his preferred tests, which look fine to me. I've applied them to
this patch.
http://reviews.llvm.org/D16360
Files:
include/__hash_table
test/libcxx/containers/unord/unord.set/insert_dup_alloc.pass.cpp
> On 2016-Mar-16, at 15:41, Eric Fiselier wrote:
>
> EricWF accepted this revision.
> EricWF added a comment.
> This revision is now accepted and ready to land.
>
> LGTM after change in inline comment.
>
>
>
> Comment at: include/__hash_table:114
> @@ +113,3 @@
> +template
>
> On 2016-Mar-16, at 12:31, Duncan P. N. Exon Smith
> wrote:
>
>>
>> On 2016-Mar-16, at 12:20, Eric Fiselier wrote:
>>
>> EricWF added a comment.
>>
>> Adding inline comments for the implementation. Comments on the tests to
>> follow shortly.
>>
>>
>>
>> Comment at: incl
r263746.
> On 2016-Mar-17, at 13:36, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
>>
>> On 2016-Mar-16, at 15:41, Eric Fiselier wrote:
>>
>> EricWF accepted this revision.
>> EricWF added a comment.
>> This revision is now accepted and read
Author: dexonsmith
Date: Thu Mar 24 19:38:14 2016
New Revision: 264372
URL: http://llvm.org/viewvc/llvm-project?rev=264372&view=rev
Log:
CGLoopInfo: Use the MD_loop metadata kind from r264371, NFC
Besides a small compile-time speedup, there should be no real
functionality change here.
Modified:
> On 2016-Jan-04, at 12:02, Marshall Clow via cfe-commits
> wrote:
>
> mclow.lists updated this revision to Diff 43906.
> mclow.lists added a comment.
>
> Howard suggested a fix for the "is incremental" problem in the type trait. I
> also added assignable.
>
>
> http://reviews.llvm.org/D1586
ping
> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith
> wrote:
>
>
>> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith
>> wrote:
>>
>> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert
>> calls operator new when no insert occurs". That fix didn't apply to
>> `unorder
> On 2016-Jan-08, at 10:49, Nico Weber via cfe-commits
> wrote:
>
> On OS X 10.8, __ZNSt3__115basic_streambufIcNS_11char_traitsIcEEE5sputcEc (and
> others) are a hidden symbol in libc++.1.dylib. This means:
>
> * If I use streambuf::sputc() and link against the 10.8 SDK, and the compiler
> d
No one is waiting for me on this, are they? FWIW, this seems like
a good solution to me. I'll see what I can do internally (I filed
a radar), but other platforms will likely need this anyway.
> On 2016-Jan-08, at 16:06, Richard Smith wrote:
>
> Ping, is this OK to commit?
>
> On Thu, Dec 10,
[re-send to lists.llvm.org]
[necromancy]
This is causing some strangeness for users of libc++ headers that
ship dylibs and build with -fno-rtti and -fvisibility=hidden.
Strangely, -fno-rtti does *not* imply -fno-exceptions; the type info
needed for exceptions is generated on-the-fly. This means
> On 2016-Jan-11, at 15:40, Rafael Espíndola wrote:
>
> On 8 January 2016 at 19:50, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>> [re-send to lists.llvm.org]
>> [necromancy]
>>
>> This is causing some strangeness for users of libc++ headers that
>
> On 2016-Jan-11, at 15:57, Rafael Espíndola wrote:
>
>> I'm not sure about GCC. Note that there is no linkage for -frtti,
>> since the type info is deferred to the TU with the vtable.
>
> Yes, that is what I mean. It is odd that -frtti changes us from "this
> is not available anywhere, use li
ping
> On 2016-Jan-04, at 12:37, Duncan P. N. Exon Smith
> wrote:
>
> ping
>
>> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith
>> wrote:
>>
>>
>>> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith
>>> wrote:
>>>
>>> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert
ping
> On 2016-Jan-11, at 16:23, Duncan P. N. Exon Smith
> wrote:
>
> ping
>
>> On 2016-Jan-04, at 12:37, Duncan P. N. Exon Smith
>> wrote:
>>
>> ping
>>
>>> On 2015-Dec-17, at 13:56, Duncan P. N. Exon Smith
>>> wrote:
>>>
>>>
On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith
>>
dexonsmith created this revision.
dexonsmith added a reviewer: EricWF.
dexonsmith added a subscriber: cfe-commits.
(Repost of:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160118/147379.html
on Phabricator as requested by Eric.)
This is a follow-up to r239666: "Fix PR12999 - unordere
Reviewer's choice:
http://reviews.llvm.org/D16360
(I've barely used phab, so let me know if it's broken somehow...)
> On 2016-Jan-19, at 16:15, Eric Fiselier wrote:
>
> Hey Duncan,
>
> I know this isn't required, but would it be possible to put this on
> phabricator?
>
> /Eric
>
> On Mon,
This patch looks correct to me. Is there any reason it wasn't committed?
> On 2015-Aug-25, at 22:22, Eric Fiselier via cfe-commits
> wrote:
>
> EricWF updated this revision to Diff 33180.
> EricWF added a comment.
>
> Cleanup the diff and remove extra changes.
>
>
> https://urldefense.proof
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
This patch looks correct to me. Is there any reason it wasn't committed?
http://reviews.llvm.org/D12354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
> On 2016-Jan-21, at 17:59, Eric Fiselier wrote:
>
> EricWF added a comment.
>
> In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
>
>> This patch looks correct to me. Is there any reason it wasn't committed?
>
>
> I was concerned about using a function-local static in the librar
dexonsmith created this revision.
dexonsmith added reviewers: EricWF, mclow.lists.
dexonsmith added a subscriber: cfe-commits.
Rather than crashing in match_results::format() when a reference to a
marked subexpression is out of range, format the subexpression as
empty (i.e., replace it with an emp
> On 2016-Jan-21, at 22:22, Eric Fiselier wrote:
>
>
>
> On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith
> wrote:
>
> > On 2016-Jan-21, at 17:59, Eric Fiselier wrote:
> >
> > EricWF added a comment.
> >
> > In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
> >
> >> Thi
Author: dexonsmith
Date: Fri Jan 22 12:27:26 2016
New Revision: 258511
URL: http://llvm.org/viewvc/llvm-project?rev=258511&view=rev
Log:
unordered: Rename __construct_node_hash() to allow forwarding, NFC
Rename the version of __construct_node() that takes a hash as an
argument to __construct_node
> On 2016-Jan-21, at 23:14, Eric Fiselier wrote:
>
> EricWF added a comment.
>
>> - Did I successfully match the coding style? (I'm kind of lost without
>> clang-format TBH.)
>
>
> The style looks pretty good. I'll comment on any nits I have.
>
>> - Should I separate the change to __constru
Author: dexonsmith
Date: Fri Jan 22 16:48:02 2016
New Revision: 258575
URL: http://llvm.org/viewvc/llvm-project?rev=258575&view=rev
Log:
unordered_map: Reuse insert logic in emplace when possible, NFC
An upcoming commit will add an optimization to insert() that avoids
unnecessary mallocs when we
I'll upload a new patch in a moment. Replies inline below.
> On 2016-Jan-21, at 23:12, Eric Fiselier wrote:
>
> EricWF added a comment.
>
> Overall the patch looks good but I have a few concerns.
>
>> - If argument.first can be trivially converted to key_type, don't alloc.
>
>
> I'm concern
dexonsmith updated this revision to Diff 45758.
dexonsmith added a comment.
Committed r258511 and r258575 as preps. Updated patch addresses review
comments (and skips the trivially constructible parts).
http://reviews.llvm.org/D16360
Files:
include/__hash_table
include/unordered_map
tes
Author: dexonsmith
Date: Sat Jan 23 09:12:47 2016
New Revision: 258625
URL: http://llvm.org/viewvc/llvm-project?rev=258625&view=rev
Log:
Revert "unordered_map: Reuse insert logic in emplace when possible, NFC"
This reverts commit r258575. EricWF sent me an email (no link since it
was off-list) r
+cfe-commits
(This looks like a broken feature of Phab. I suggest not using it,
since it hasn't put the patch context in this email, it didn't CC
the list, and it spawned a new thread instead of replying to the
commit:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160118/147763.html
Note that this was reverted due to post-commit review, but Phab
forked it into a different thread. Here it is:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160118/147795.html
> On 2016-Jan-22, at 14:48, Duncan P. N. Exon Smith via cfe-commits
> wrote:
>
> Author
> On 2016-Jan-22, at 18:01, Eric Fiselier wrote:
>
>
>
> On Fri, Jan 22, 2016 at 10:44 AM, Duncan P. N. Exon Smith
> wrote:
>
> > On 2016-Jan-21, at 22:22, Eric Fiselier wrote:
> >
> >
> >
> > On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith
> > wrote:
> >
> > > On 2016-Jan-21,
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Great, I should have time to clean this up tomorrow afternoon.
Regarding emplace, this patch as is has tests for emplace, but
they depend on r258575 being in tree. You asked me to revert
that... I'll wait for your response ov
Great, I should have time to clean this up tomorrow afternoon.
Regarding emplace, this patch as is has tests for emplace, but
they depend on r258575 being in tree. You asked me to revert
that... I'll wait for your response over in that thread:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-M
> On 2016-Jan-25, at 08:49, Marshall Clow wrote:
>
> mclow.lists added inline comments.
>
>
> Comment at: include/regex:5390
> @@ -5389,3 +5389,3 @@
> size_t __i = *__fmt_first - '0';
> -__out = _VSTD::copy(__matches_[__i].first,
> -
Given your follow-up review, and the behaviour of
match_results::operator[], do you still have reservations?
> On 2016-Jan-25, at 08:19, Marshall Clow wrote:
>
> mclow.lists added a comment.
>
> Not crashing is good; but silently returning a "wrong" answer rubs me the
> wrong way. I'll do som
dexonsmith created this revision.
dexonsmith added a reviewer: mclow.lists.
dexonsmith added a subscriber: cfe-commits.
This entire test was effectively disabled in r187636 with no relevant
explanation. The test passes for me just by removing the comment
markers.
http://reviews.llvm.org/D16541
dexonsmith updated this revision to Diff 45879.
dexonsmith added a comment.
Addressed Marshall's review comments: deferring to match_results::operator[]()
rather than duplicating the logic.
http://reviews.llvm.org/D16467
Files:
include/regex
test/std/re/re.results/re.results.form/form1.pas
Testcase?
> On 2015-Dec-01, at 14:58, Sumanth Gundapaneni via cfe-commits
> wrote:
>
> sgundapa created this revision.
> sgundapa added reviewers: vkalintiris, echristo.
> sgundapa added a subscriber: cfe-commits.
>
> This patch is a fix to r252901 which changed the behavior of
> clang driver
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
Testcase?
http://reviews.llvm.org/D15130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On 2015-Dec-01, at 09:15, Aaron Ballman via cfe-commits
> wrote:
>
> Author: aaronballman
> Date: Tue Dec 1 11:15:13 2015
> New Revision: 254423
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254423&view=rev
> Log:
> It appears that this horrible mutating copy constructor is unused. Kill
> On 2015-Dec-07, at 13:29, Bruno Cardoso Lopes wrote:
>
> bruno added a comment.
>
> Hi Argyrios,
>
> Thanks for the suggestions, will apply them.
> The assertion seems important to catch subtle bugs, are you sure it should be
> placed inside a "#ifndef NDEBUG”?
FYI, the definition for `ass
> On 2015-Dec-07, at 14:22, Duncan P. N. Exon Smith
> wrote:
>
>
>> On 2015-Dec-07, at 13:29, Bruno Cardoso Lopes
>> wrote:
>>
>> bruno added a comment.
>>
>> Hi Argyrios,
>>
>> Thanks for the suggestions, will apply them.
>> The assertion seems important to catch subtle bugs, are you sur
> On 2015-Dec-10, at 15:32, Richard Smith wrote:
>
> On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow wrote:
> On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith wrote:
> Ping.
>
> Sorry about that.
> Completely missed this in my email flood.
>
> This approach looks ok to me, but I wonder if it wo
This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert
calls operator new when no insert occurs". That fix didn't apply to
`unordered_map` because unordered_map::value_type gets packed inside:
--
union __value_type {
pair __nc; // Only C++11 or higher.
pair __cc; // Always.
> On 2015-Dec-16, at 14:42, Duncan P. N. Exon Smith
> wrote:
>
> This is a follow-up to r239666: "Fix PR12999 - unordered_set::insert
> calls operator new when no insert occurs". That fix didn't apply to
> `unordered_map` because unordered_map::value_type gets packed inside:
> --
> union __val
dexonsmith wrote:
@benlangmuir and @jansvoboda11 might also be good reviewers for this.
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Duncan P. N. Exon Smith
Date: 2021-04-22T11:29:39-07:00
New Revision: d4ee603c8f21b4ae722c2a34d4dfa54b7abeeb16
URL:
https://github.com/llvm/llvm-project/commit/d4ee603c8f21b4ae722c2a34d4dfa54b7abeeb16
DIFF:
https://github.com/llvm/llvm-project/commit/d4ee603c8f21b4ae722c2a34d4dfa54b7abe
Author: Duncan P. N. Exon Smith
Date: 2021-05-03T10:50:09-07:00
New Revision: 64a390c1bc75eb55eeed3061df15dc581fd563e6
URL:
https://github.com/llvm/llvm-project/commit/64a390c1bc75eb55eeed3061df15dc581fd563e6
DIFF:
https://github.com/llvm/llvm-project/commit/64a390c1bc75eb55eeed3061df15dc581fd5
Author: Duncan P. N. Exon Smith
Date: 2022-01-11T17:01:46-08:00
New Revision: f0b2a1a629dab17f2ea161a9281d8dc63b37a7a0
URL:
https://github.com/llvm/llvm-project/commit/f0b2a1a629dab17f2ea161a9281d8dc63b37a7a0
DIFF:
https://github.com/llvm/llvm-project/commit/f0b2a1a629dab17f2ea161a9281d8dc63b37
Author: Duncan P. N. Exon Smith
Date: 2022-01-11T17:47:23-08:00
New Revision: 3110060bc721a02e69ead4c56e037a03d31bedef
URL:
https://github.com/llvm/llvm-project/commit/3110060bc721a02e69ead4c56e037a03d31bedef
DIFF:
https://github.com/llvm/llvm-project/commit/3110060bc721a02e69ead4c56e037a03d31b
301 - 400 of 406 matches
Mail list logo
