[clang] 32c501d - Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-02T14:07:23-08:00 New Revision: 32c501dd88b62787d3a5ffda7aabcf4650dbe3cd URL: https://github.com/llvm/llvm-project/commit/32c501dd88b62787d3a5ffda7aabcf4650dbe3cd DIFF: https://github.com/llvm/llvm-project/commit/32c501dd88b62787d3a5ffda7aabcf4650db

[clang] dcc4f7f - ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

2020-12-02 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-02T16:28:33-08:00 New Revision: dcc4f7f3c4b4442710ae73d6f73cded665426678 URL: https://github.com/llvm/llvm-project/commit/dcc4f7f3c4b4442710ae73d6f73cded665426678 DIFF: https://github.com/llvm/llvm-project/commit/dcc4f7f3c4b4442710ae73d6f73cded66542

[clang] 3b18a59 - Frontend: Sink named pipe logic from CompilerInstance down to FileManager

2020-12-02 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-02T17:14:27-08:00 New Revision: 3b18a594c7717a328c33b9c1eba675e9f4bd367c URL: https://github.com/llvm/llvm-project/commit/3b18a594c7717a328c33b9c1eba675e9f4bd367c DIFF: https://github.com/llvm/llvm-project/commit/3b18a594c7717a328c33b9c1eba675e9f4bd

[clang] b346322 - Revert "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

2020-12-02 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-02T17:36:20-08:00 New Revision: b34632201987eed369bb7ef4646f341b901c95b8 URL: https://github.com/llvm/llvm-project/commit/b34632201987eed369bb7ef4646f341b901c95b8 DIFF: https://github.com/llvm/llvm-project/commit/b34632201987eed369bb7ef4646f341b901c

[clang] 99b823c - Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

2020-12-03 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-03T16:10:59-08:00 New Revision: 99b823c2eba391877a0fcd6bc5f03f0d9f0077cb URL: https://github.com/llvm/llvm-project/commit/99b823c2eba391877a0fcd6bc5f03f0d9f0077cb DIFF: https://github.com/llvm/llvm-project/commit/99b823c2eba391877a0fcd6bc5f03f0d9f00

[clang] e763e03 - Support: Change InMemoryFileSystem::addFileNoOwn to take a MemoryBufferRef, NFC

2020-12-03 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-03T18:09:52-08:00 New Revision: e763e032f8bbf5a4da60d099b1df4cd16e44e139 URL: https://github.com/llvm/llvm-project/commit/e763e032f8bbf5a4da60d099b1df4cd16e44e139 DIFF: https://github.com/llvm/llvm-project/commit/e763e032f8bbf5a4da60d099b1df4cd16e44

[clang] 5b267fb - ADT: Stop peeking inside AlignedCharArrayUnion, NFC

2020-12-04 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-04T11:07:42-08:00 New Revision: 5b267fb7966157e0d79ea85cbc1d07f92f840d3c URL: https://github.com/llvm/llvm-project/commit/5b267fb7966157e0d79ea85cbc1d07f92f840d3c DIFF: https://github.com/llvm/llvm-project/commit/5b267fb7966157e0d79ea85cbc1d07f92f84

[clang] d10f986 - ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

2020-12-04 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-04T12:34:49-08:00 New Revision: d10f9863a5ac1cb681af07719650c44b48f289ce URL: https://github.com/llvm/llvm-project/commit/d10f9863a5ac1cb681af07719650c44b48f289ce DIFF: https://github.com/llvm/llvm-project/commit/d10f9863a5ac1cb681af07719650c44b48f2

[clang] 1b023f5 - Frontend: Use translateLineCol instead of translateFileLineCol, NFC

2020-12-04 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:37:48-08:00 New Revision: 1b023f54b61737552242868bdfc385487f1c3e74 URL: https://github.com/llvm/llvm-project/commit/1b023f54b61737552242868bdfc385487f1c3e74 DIFF: https://github.com/llvm/llvm-project/commit/1b023f54b61737552242868bdfc385487f1c

[clang] 9ae0a46 - ARCMigrate: Initialize fields in EditEntry inline, NFC

2020-12-04 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:43:22-08:00 New Revision: 9ae0a46f2bbff5c0eb962c5a6225a2b469d1802f URL: https://github.com/llvm/llvm-project/commit/9ae0a46f2bbff5c0eb962c5a6225a2b469d1802f DIFF: https://github.com/llvm/llvm-project/commit/9ae0a46f2bbff5c0eb962c5a6225a2b469d1

[clang] b4f4fc6 - ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

2020-12-04 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-04T14:45:59-08:00 New Revision: b4f4fc6872fbe4e296d3270d297a0e4afbda6670 URL: https://github.com/llvm/llvm-project/commit/b4f4fc6872fbe4e296d3270d297a0e4afbda6670 DIFF: https://github.com/llvm/llvm-project/commit/b4f4fc6872fbe4e296d3270d297a0e4afbda

[clang] d126943 - Index: Remove unused internal header SimpleFormatContext.h, NFC

2020-12-04 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-12-04T15:10:27-08:00 New Revision: d126943251d0cd77e572bced5ab6c23595acd468 URL: https://github.com/llvm/llvm-project/commit/d126943251d0cd77e572bced5ab6c23595acd468 DIFF: https://github.com/llvm/llvm-project/commit/d126943251d0cd77e572bced5ab6c23595ac

[clang] 0ddf4bd - clang/{Format,Rewrite}: Stop using SourceManager::getBuffer, NFC

2020-10-19 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-19T17:02:59-04:00 New Revision: 0ddf4bd47c18a4608b67fdda537f575c4c7a0a52 URL: https://github.com/llvm/llvm-project/commit/0ddf4bd47c18a4608b67fdda537f575c4c7a0a52 DIFF: https://github.com/llvm/llvm-project/commit/0ddf4bd47c18a4608b67fdda537f575c4c7a

[clang] b3eff6b - Lexer: Update the Lexer to use MemoryBufferRef, NFC

2020-10-19 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-19T19:10:21-04:00 New Revision: b3eff6b7bb31e7ef059a3d238de138849839fbbd URL: https://github.com/llvm/llvm-project/commit/b3eff6b7bb31e7ef059a3d238de138849839fbbd DIFF: https://github.com/llvm/llvm-project/commit/b3eff6b7bb31e7ef059a3d238de138849839

[clang] b03ae74 - clang/Lex: Stop using SourceManager::getBuffer

2020-10-19 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-19T20:27:56-04:00 New Revision: b03ae74319f19c3b86982638671d00205a91d263 URL: https://github.com/llvm/llvm-project/commit/b03ae74319f19c3b86982638671d00205a91d263 DIFF: https://github.com/llvm/llvm-project/commit/b03ae74319f19c3b86982638671d00205a91

[clang] 51d1d58 - clang/Frontend: Use MemoryBufferRef in FrontendInputFile (and remove SourceManager::getBuffer)

2020-10-20 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-20T13:35:46-04:00 New Revision: 51d1d585e5838ea0f02f1271f7543c4e43639969 URL: https://github.com/llvm/llvm-project/commit/51d1d585e5838ea0f02f1271f7543c4e43639969 DIFF: https://github.com/llvm/llvm-project/commit/51d1d585e5838ea0f02f1271f7543c4e4363

[clang] 729d7d2 - FileManager: Test FileManager::getFileRef

2020-10-20 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-20T13:40:23-04:00 New Revision: 729d7d23282e9b00eaa7a5f35a4224929d73d3a4 URL: https://github.com/llvm/llvm-project/commit/729d7d23282e9b00eaa7a5f35a4224929d73d3a4 DIFF: https://github.com/llvm/llvm-project/commit/729d7d23282e9b00eaa7a5f35a4224929d73

[clang] 2dc7e0c - clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

2020-10-20 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-20T17:01:23-04:00 New Revision: 2dc7e0c6a586135fe236cd7ebf065617a7638bdb URL: https://github.com/llvm/llvm-project/commit/2dc7e0c6a586135fe236cd7ebf065617a7638bdb DIFF: https://github.com/llvm/llvm-project/commit/2dc7e0c6a586135fe236cd7ebf065617a763

[clang] 747b134 - clang/Basic: Remove SourceManager::getBufferPointer, NFC

2020-10-20 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-20T18:02:42-04:00 New Revision: 747b134d019ce99bc4463d09992634965ee95031 URL: https://github.com/llvm/llvm-project/commit/747b134d019ce99bc4463d09992634965ee95031 DIFF: https://github.com/llvm/llvm-project/commit/747b134d019ce99bc4463d09992634965ee9

[clang] 1d78e21 - clang/Basic: ContentCache::InvalidFlag => ContentCache::IsBufferInvalid, NFC

2020-10-20 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-20T19:28:17-04:00 New Revision: 1d78e2101ab75f01615a45467c44da7181cccedb URL: https://github.com/llvm/llvm-project/commit/1d78e2101ab75f01615a45467c44da7181cccedb DIFF: https://github.com/llvm/llvm-project/commit/1d78e2101ab75f01615a45467c44da7181cc

[clang] 2963145 - ContentCache: Simplify by always owning the MemoryBuffer

2020-10-20 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-20T21:03:53-04:00 New Revision: 296314516d103f8eeb987a08b509c1381cfeef89 URL: https://github.com/llvm/llvm-project/commit/296314516d103f8eeb987a08b509c1381cfeef89 DIFF: https://github.com/llvm/llvm-project/commit/296314516d103f8eeb987a08b509c1381cfe

[clang] 4aa97e3 - SourceManager: Simplify early returns in ContentCache::getBufferOrNone, NFC

2020-10-20 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-20T21:26:37-04:00 New Revision: 4aa97e3dacf3bdf5636fbf89dd8c64f1e4648065 URL: https://github.com/llvm/llvm-project/commit/4aa97e3dacf3bdf5636fbf89dd8c64f1e4648065 DIFF: https://github.com/llvm/llvm-project/commit/4aa97e3dacf3bdf5636fbf89dd8c64f1e464

[clang-tools-extra] 156e8b3 - clang/Basic: Remove ContentCache::getRawBuffer, NFC

2020-10-22 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-22T14:00:44-04:00 New Revision: 156e8b37024abd8630666e0ae8a251b80299ed1d URL: https://github.com/llvm/llvm-project/commit/156e8b37024abd8630666e0ae8a251b80299ed1d DIFF: https://github.com/llvm/llvm-project/commit/156e8b37024abd8630666e0ae8a251b80299

[clang] b6c6daa - SourceManager: Factor out helpers for common SLocEntry lookup pattern, NFC

2020-10-22 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-22T21:30:31-04:00 New Revision: b6c6daa95d3aa2206d5a42b46793226f181c3e44 URL: https://github.com/llvm/llvm-project/commit/b6c6daa95d3aa2206d5a42b46793226f181c3e44 DIFF: https://github.com/llvm/llvm-project/commit/b6c6daa95d3aa2206d5a42b46793226f181c

[clang] 168db92 - SourceManager: Change SourceManager::isMainFile to take a FileEntry, NFC

2020-10-22 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-22T21:32:28-04:00 New Revision: 168db92465c504974274302a6a1a5d4a1580ccfe URL: https://github.com/llvm/llvm-project/commit/168db92465c504974274302a6a1a5d4a1580ccfe DIFF: https://github.com/llvm/llvm-project/commit/168db92465c504974274302a6a1a5d4a1580

[clang] cf593d2 - SourceManager: getFileEntryRefForID => getNonBuiltinFilenameForID, NFC

2020-10-22 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-22T22:20:50-04:00 New Revision: cf593d224c9c3fc2cf93827cb66fd9e550a6a486 URL: https://github.com/llvm/llvm-project/commit/cf593d224c9c3fc2cf93827cb66fd9e550a6a486 DIFF: https://github.com/llvm/llvm-project/commit/cf593d224c9c3fc2cf93827cb66fd9e550a6

[clang] 3b8d895 - SourceManager: Remove a redundant nullptr check in getNonBuiltinFilenameForID, NFC

2020-10-22 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-22T22:20:50-04:00 New Revision: 3b8d8954bf2c192502d757019b9fe434864068e9 URL: https://github.com/llvm/llvm-project/commit/3b8d8954bf2c192502d757019b9fe434864068e9 DIFF: https://github.com/llvm/llvm-project/commit/3b8d8954bf2c192502d757019b9fe4348640

[clang] 74a8783 - SourceManager: Clarify that FileInfo always has a ContentCache, NFC

2020-10-23 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-23T12:38:53-04:00 New Revision: 74a8783480219f5f0e5c4673a6d0e29b4ad99877 URL: https://github.com/llvm/llvm-project/commit/74a8783480219f5f0e5c4673a6d0e29b4ad99877 DIFF: https://github.com/llvm/llvm-project/commit/74a8783480219f5f0e5c4673a6d0e29b4ad9

[clang] dbbc4f4 - SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

2020-10-23 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-23T12:55:51-04:00 New Revision: dbbc4f4e226be44e484f448be2d308d205c81038 URL: https://github.com/llvm/llvm-project/commit/dbbc4f4e226be44e484f448be2d308d205c81038 DIFF: https://github.com/llvm/llvm-project/commit/dbbc4f4e226be44e484f448be2d308d205c8

[clang] 5431c37 - SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC

2020-10-23 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-23T13:22:47-04:00 New Revision: 5431c37b55e2c2952b6b56c9690bd1ce05b23c7e URL: https://github.com/llvm/llvm-project/commit/5431c37b55e2c2952b6b56c9690bd1ce05b23c7e DIFF: https://github.com/llvm/llvm-project/commit/5431c37b55e2c2952b6b56c9690bd1ce05b2

[clang] cf52a85 - SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC

2020-10-23 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-23T14:56:41-04:00 New Revision: cf52a85ddc9be165daca3d32521747c898f4ffd1 URL: https://github.com/llvm/llvm-project/commit/cf52a85ddc9be165daca3d32521747c898f4ffd1 DIFF: https://github.com/llvm/llvm-project/commit/cf52a85ddc9be165daca3d32521747c898f4

[clang] 81ac81f - FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC

2020-10-23 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-23T20:47:15-04:00 New Revision: 81ac81f8644a7c6ed19bea95385794f7870d0fda URL: https://github.com/llvm/llvm-project/commit/81ac81f8644a7c6ed19bea95385794f7870d0fda DIFF: https://github.com/llvm/llvm-project/commit/81ac81f8644a7c6ed19bea95385794f7870d

[clang-tools-extra] 434f377 - clangd: Stop calling FileEntryRef::FileEntryRef

2020-10-23 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-23T21:28:09-04:00 New Revision: 434f3774f629f5896614e9efb4eda82d813402ed URL: https://github.com/llvm/llvm-project/commit/434f3774f629f5896614e9efb4eda82d813402ed DIFF: https://github.com/llvm/llvm-project/commit/434f3774f629f5896614e9efb4eda82d8134

[clang] 74910cb - HeaderSearch: Simplify use of FileEntryRef in HeaderSearch::LookupFile, NFC

2020-10-23 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-23T22:10:50-04:00 New Revision: 74910cbbd8d1df824ab1d5e742c50641d0fee907 URL: https://github.com/llvm/llvm-project/commit/74910cbbd8d1df824ab1d5e742c50641d0fee907 DIFF: https://github.com/llvm/llvm-project/commit/74910cbbd8d1df824ab1d5e742c50641d0fe

[clang] 0387015 - SourceManager: Return non-const references in getOrCreateContentCache and related, NFC

2020-10-26 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-26T14:07:46-04:00 New Revision: 0387015d7549fc2c0cc8c45d3e78114cc4fd153f URL: https://github.com/llvm/llvm-project/commit/0387015d7549fc2c0cc8c45d3e78114cc4fd153f DIFF: https://github.com/llvm/llvm-project/commit/0387015d7549fc2c0cc8c45d3e78114cc4fd

[clang] 22e6b18 - SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

2020-10-26 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-26T15:38:13-04:00 New Revision: 22e6b1863e74136908842d71b4f942313d89b273 URL: https://github.com/llvm/llvm-project/commit/22e6b1863e74136908842d71b4f942313d89b273 DIFF: https://github.com/llvm/llvm-project/commit/22e6b1863e74136908842d71b4f942313d89

[clang] aab50af - SourceManager: Use the same fake SLocEntry whenever it fails to load

2020-10-26 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-26T20:56:28-04:00 New Revision: aab50af8c18ab2eb2149bb516c8a0993ffc5abb7 URL: https://github.com/llvm/llvm-project/commit/aab50af8c18ab2eb2149bb516c8a0993ffc5abb7 DIFF: https://github.com/llvm/llvm-project/commit/aab50af8c18ab2eb2149bb516c8a0993ffc5

[clang] f057e6d - SourceManager: clang-format the SrcMgr namespace, NFC

2020-10-26 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-26T21:58:52-04:00 New Revision: f057e6dc5e29751dbba700bc62d8c42c57a502b0 URL: https://github.com/llvm/llvm-project/commit/f057e6dc5e29751dbba700bc62d8c42c57a502b0 DIFF: https://github.com/llvm/llvm-project/commit/f057e6dc5e29751dbba700bc62d8c42c57a5

[clang] 917acac - FileManager: Shrink FileEntryRef to the size of a pointer

2020-10-27 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-27T14:55:41-04:00 New Revision: 917acac960d40280ea02ea453e594034b1be1f6b URL: https://github.com/llvm/llvm-project/commit/917acac960d40280ea02ea453e594034b1be1f6b DIFF: https://github.com/llvm/llvm-project/commit/917acac960d40280ea02ea453e594034b1be

[clang] 23ed570 - Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

2020-10-28 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-28T16:38:32-04:00 New Revision: 23ed570af1cc165afea1b70a533a4a39d6656501 URL: https://github.com/llvm/llvm-project/commit/23ed570af1cc165afea1b70a533a4a39d6656501 DIFF: https://github.com/llvm/llvm-project/commit/23ed570af1cc165afea1b70a533a4a39d665

[clang] 946406a - ModuleManager: Simplify lookupModuleFile by only setting the out parameter once, NFC

2020-10-28 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-28T19:04:22-04:00 New Revision: 946406aebce298725b07097934cb39b1e5bee656 URL: https://github.com/llvm/llvm-project/commit/946406aebce298725b07097934cb39b1e5bee656 DIFF: https://github.com/llvm/llvm-project/commit/946406aebce298725b07097934cb39b1e5be

[clang] 84e8257 - FileManager: Improve the FileEntryRef API and customize its OptionalStorage

2020-10-30 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-30T13:25:46-04:00 New Revision: 84e8257937ec6a332aa0b688f4dce57016516ffd URL: https://github.com/llvm/llvm-project/commit/84e8257937ec6a332aa0b688f4dce57016516ffd DIFF: https://github.com/llvm/llvm-project/commit/84e8257937ec6a332aa0b688f4dce5701651

[clang] 010238a - Speculative fix for bots after 84e8257937ec6a332aa0b688f4dce57016516ffd

2020-10-30 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:01:01-04:00 New Revision: 010238a296e61cbf6f4d7f4383e26cf00c4e4992 URL: https://github.com/llvm/llvm-project/commit/010238a296e61cbf6f4d7f4383e26cf00c4e4992 DIFF: https://github.com/llvm/llvm-project/commit/010238a296e61cbf6f4d7f4383e26cf00c4e

[clang] 5530fb5 - Speculative fix for bots after 84e8257937ec6a332aa0b688f4dce57016516ffd, v2

2020-10-30 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:04:48-04:00 New Revision: 5530fb586f30da9dcb434f6be39198dbf016b866 URL: https://github.com/llvm/llvm-project/commit/5530fb586f30da9dcb434f6be39198dbf016b866 DIFF: https://github.com/llvm/llvm-project/commit/5530fb586f30da9dcb434f6be39198dbf016

[clang] 940d0a3 - Revert "FileManager: Improve the FileEntryRef API and customize its OptionalStorage" and follow-ups

2020-10-30 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-30T14:06:55-04:00 New Revision: 940d0a310dca31ae97080b068cef92eadfee6367 URL: https://github.com/llvm/llvm-project/commit/940d0a310dca31ae97080b068cef92eadfee6367 DIFF: https://github.com/llvm/llvm-project/commit/940d0a310dca31ae97080b068cef92eadfee

[clang] ac49500 - Reapply "FileManager: Improve the FileEntryRef API and customize its OptionalStorage"

2020-10-30 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-30T15:06:01-04:00 New Revision: ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 URL: https://github.com/llvm/llvm-project/commit/ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 DIFF: https://github.com/llvm/llvm-project/commit/ac49500cd0484e1b2dcf37fa4c0dade6f113

[clang] 814141f - Remove `noexcept` from ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 to fix bots

2020-10-30 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-30T16:29:16-04:00 New Revision: 814141f9bd0a64bbedae05773972d140f04f654d URL: https://github.com/llvm/llvm-project/commit/814141f9bd0a64bbedae05773972d140f04f654d DIFF: https://github.com/llvm/llvm-project/commit/814141f9bd0a64bbedae05773972d140f04f

[clang] 9f151df - Change Module::ASTFile and ModuleFile::File => Optional, NFC

2020-11-02 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-11-02T15:11:51-05:00 New Revision: 9f151df17800e1668c32e5314a290ae94c8f2dd3 URL: https://github.com/llvm/llvm-project/commit/9f151df17800e1668c32e5314a290ae94c8f2dd3 DIFF: https://github.com/llvm/llvm-project/commit/9f151df17800e1668c32e5314a290ae94c8f

[clang] 5cb8d93 - Fix build error on bots after 9f151df17800e1668c32e5314a290ae94c8f2dd3

2020-11-02 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-11-02T15:55:13-05:00 New Revision: 5cb8d93205463f169ad4dd532829147fed2e38d0 URL: https://github.com/llvm/llvm-project/commit/5cb8d93205463f169ad4dd532829147fed2e38d0 DIFF: https://github.com/llvm/llvm-project/commit/5cb8d93205463f169ad4dd532829147fed2e

[clang] 7c2afd5 - Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

2021-05-13 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:10:46-07:00 New Revision: 7c2afd5899df876eaf5ffb485194dc58e92daf89 URL: https://github.com/llvm/llvm-project/commit/7c2afd5899df876eaf5ffb485194dc58e92daf89 DIFF: https://github.com/llvm/llvm-project/commit/7c2afd5899df876eaf5ffb485194dc58e92d

[clang] 23e9146 - Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

2021-05-13 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:22:40-07:00 New Revision: 23e9146fba298d38142337b615e17067fb8ccb91 URL: https://github.com/llvm/llvm-project/commit/23e9146fba298d38142337b615e17067fb8ccb91 DIFF: https://github.com/llvm/llvm-project/commit/23e9146fba298d38142337b615e17067fb8c

[clang] 7c57a9b - Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

2021-05-13 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:39:40-07:00 New Revision: 7c57a9bd7d4c976b7a824472c427433359200e02 URL: https://github.com/llvm/llvm-project/commit/7c57a9bd7d4c976b7a824472c427433359200e02 DIFF: https://github.com/llvm/llvm-project/commit/7c57a9bd7d4c976b7a824472c42743335920

[clang] ba5628f - ADT: Use 'using' to inherit assign and append in SmallString

2021-01-22 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-01-22T16:17:58-08:00 New Revision: ba5628f2c2a9de049b80b3e276f7e05f481c49e7 URL: https://github.com/llvm/llvm-project/commit/ba5628f2c2a9de049b80b3e276f7e05f481c49e7 DIFF: https://github.com/llvm/llvm-project/commit/ba5628f2c2a9de049b80b3e276f7e05f481c

[clang] 64d8c78 - Revert "Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC"

2021-02-23 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-02-23T09:57:28-08:00 New Revision: 64d8c7818db2bd428d4e2a9f27661ee49225477f URL: https://github.com/llvm/llvm-project/commit/64d8c7818db2bd428d4e2a9f27661ee49225477f DIFF: https://github.com/llvm/llvm-project/commit/64d8c7818db2bd428d4e2a9f27661ee49225

[clang] 05d0f1a - Frontend: Respect -fno-temp-file when creating a PCH

2021-06-17 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Zachary Henkel Date: 2021-06-17T18:34:10-07:00 New Revision: 05d0f1a8ea012a6b7b8ea65893ec4121106444b5 URL: https://github.com/llvm/llvm-project/commit/05d0f1a8ea012a6b7b8ea65893ec4121106444b5 DIFF: https://github.com/llvm/llvm-project/commit/05d0f1a8ea012a6b7b8ea65893ec4121106444b5.diff

[clang] c130300 - Frontend: Refactor compileModuleAndReadAST, NFC

2021-08-12 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-08-12T15:16:08-07:00 New Revision: c130300f8ba0363749cf2490bbd43515fad8a759 URL: https://github.com/llvm/llvm-project/commit/c130300f8ba0363749cf2490bbd43515fad8a759 DIFF: https://github.com/llvm/llvm-project/commit/c130300f8ba0363749cf2490bbd43515fad8

[clang] b714f73 - Frontend: Add -f{,no-}implicit-modules-uses-lock and -Rmodule-lock

2021-08-12 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-08-12T15:58:19-07:00 New Revision: b714f73defc8e0755c7c7cf043df1f1c21344839 URL: https://github.com/llvm/llvm-project/commit/b714f73defc8e0755c7c7cf043df1f1c21344839 DIFF: https://github.com/llvm/llvm-project/commit/b714f73defc8e0755c7c7cf043df1f1c2134

[clang] d8a08fa - Clean up test for -f{, no-}implicit-modules-uses-lock

2021-08-16 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-08-16T16:23:04-07:00 New Revision: d8a08fae0af9aa09c108b3e7c60f192249dd2098 URL: https://github.com/llvm/llvm-project/commit/d8a08fae0af9aa09c108b3e7c60f192249dd2098 DIFF: https://github.com/llvm/llvm-project/commit/d8a08fae0af9aa09c108b3e7c60f192249dd

[clang] 9902362 - Support: Use sys::path::is_style_{posix, windows}() in a few places

2021-10-29 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-10-29T12:09:41-07:00 New Revision: 99023627010bbfefb71e25a2b4d056de1cbd354e URL: https://github.com/llvm/llvm-project/commit/99023627010bbfefb71e25a2b4d056de1cbd354e DIFF: https://github.com/llvm/llvm-project/commit/99023627010bbfefb71e25a2b4d056de1cbd

Re: [PATCH] D112289: Support: Use sys::path::is_style_{posix,windows}() in a few places

2021-10-29 Thread Duncan P. N. Exon Smith via cfe-commits
Looking now. > On 2021 Oct 29, at 16:07, Nico Weber via Phabricator > wrote: > > thakis added a comment. > > Looks like this breaks tests on windows: > http://45.33.8.238/win/47971/step_7.txt > > Please take a look and revert for now if it takes a while to fix. > > > Repository: > rG LLV

[clang] 9091df5 - Fix a use-after-scope from 99023627010bbfefb71e25a2b4d056de1cbd354e

2021-10-29 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-10-29T16:25:13-07:00 New Revision: 9091df5fad52ab6a281d7f4d6a508696e6f9fbae URL: https://github.com/llvm/llvm-project/commit/9091df5fad52ab6a281d7f4d6a508696e6f9fbae DIFF: https://github.com/llvm/llvm-project/commit/9091df5fad52ab6a281d7f4d6a508696e6f9

[clang] 46a68c8 - Sema: const-qualify ParsedAttr::iterator::operator*()

2021-11-12 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2021-11-12T11:47:16-08:00 New Revision: 46a68c85bfc99f0bc651e5096a641d5d4051e99d URL: https://github.com/llvm/llvm-project/commit/46a68c85bfc99f0bc651e5096a641d5d4051e99d DIFF: https://github.com/llvm/llvm-project/commit/46a68c85bfc99f0bc651e5096a641d5d4051

[clang] 31e14f4 - clang/Modules: Sink CompilerInstance::KnownModules into ModuleMap

2019-11-03 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-03T19:57:33-08:00 New Revision: 31e14f41a21f9016050a20f07d5da03db2e8c13e URL: https://github.com/llvm/llvm-project/commit/31e14f41a21f9016050a20f07d5da03db2e8c13e DIFF: https://github.com/llvm/llvm-project/commit/31e14f41a21f9016050a20f07d5da03db2e8

[clang] 8112a42 - clang/Modules: Bring back optimization lost in 31e14f41a21f

2019-11-04 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-04T11:40:03-08:00 New Revision: 8112a423a8ede9bce64b6553e6451bf10995105c URL: https://github.com/llvm/llvm-project/commit/8112a423a8ede9bce64b6553e6451bf10995105c DIFF: https://github.com/llvm/llvm-project/commit/8112a423a8ede9bce64b6553e6451bf10995

[clang] 8e9e433 - clang/Modules: Remove unused parameter from ModuleManager::removeModules

2019-11-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-10T11:18:33-08:00 New Revision: 8e9e433a2af7c435923ba71ea7d75374408b0b32 URL: https://github.com/llvm/llvm-project/commit/8e9e433a2af7c435923ba71ea7d75374408b0b32 DIFF: https://github.com/llvm/llvm-project/commit/8e9e433a2af7c435923ba71ea7d75374408b

[clang] eef6902 - clang/Modules: Delay err_module_file_conflict if a diagnostic is in flight

2019-11-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-11T15:34:52-08:00 New Revision: eef69021607950487a9e4110851a05abb54d0fb6 URL: https://github.com/llvm/llvm-project/commit/eef69021607950487a9e4110851a05abb54d0fb6 DIFF: https://github.com/llvm/llvm-project/commit/eef69021607950487a9e4110851a05abb54d

[clang] 01782c3 - clang/Modules: Split loop in ReadAST between failable and not

2019-11-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-11T15:53:48-08:00 New Revision: 01782c3e4df1830d7991e9edfee9119ed41e4c27 URL: https://github.com/llvm/llvm-project/commit/01782c3e4df1830d7991e9edfee9119ed41e4c27 DIFF: https://github.com/llvm/llvm-project/commit/01782c3e4df1830d7991e9edfee9119ed41e

[clang] bfd58fc - clang/Modules: Use range-based for in ASTReader::ReadAST, NFC

2019-11-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-11T15:53:48-08:00 New Revision: bfd58fc60ff4b0c081b5b489119c3798d3e2b53c URL: https://github.com/llvm/llvm-project/commit/bfd58fc60ff4b0c081b5b489119c3798d3e2b53c DIFF: https://github.com/llvm/llvm-project/commit/bfd58fc60ff4b0c081b5b489119c3798d3e2

[clang] 8e2c192 - clang/Modules: Add missing diagnostics for malformed AST files

2019-11-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-11T16:00:47-08:00 New Revision: 8e2c192e2af8c760152ba3b28e774dbb1548e4aa URL: https://github.com/llvm/llvm-project/commit/8e2c192e2af8c760152ba3b28e774dbb1548e4aa DIFF: https://github.com/llvm/llvm-project/commit/8e2c192e2af8c760152ba3b28e774dbb1548

[clang] c46b3a2 - clang/Modules: Clean up modules on error in ReadAST

2019-11-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-11T16:36:02-08:00 New Revision: c46b3a2abd38d6fecd389c97dfa7df54af77fdb9 URL: https://github.com/llvm/llvm-project/commit/c46b3a2abd38d6fecd389c97dfa7df54af77fdb9 DIFF: https://github.com/llvm/llvm-project/commit/c46b3a2abd38d6fecd389c97dfa7df54af77

[clang] 83dcb34 - clang/Modules: Error if ReadASTBlock does not find the main module

2019-11-12 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-12T08:40:53-08:00 New Revision: 83dcb34b6bf4c175040b18d3e8c3c468418009fc URL: https://github.com/llvm/llvm-project/commit/83dcb34b6bf4c175040b18d3e8c3c468418009fc DIFF: https://github.com/llvm/llvm-project/commit/83dcb34b6bf4c175040b18d3e8c3c4684180

[clang] d4e1ba3 - Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

2019-11-18 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Pierre Habouzit Date: 2019-11-18T11:48:40-08:00 New Revision: d4e1ba3fa9dfec2613bdcc7db0b58dea490c56b1 URL: https://github.com/llvm/llvm-project/commit/d4e1ba3fa9dfec2613bdcc7db0b58dea490c56b1 DIFF: https://github.com/llvm/llvm-project/commit/d4e1ba3fa9dfec2613bdcc7db0b58dea490c56b1.dif

[clang] 8c48405 - Wrap C APIs with pragmas enforcing -Werror=strict-prototypes

2019-11-19 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-19T13:18:43-08:00 New Revision: 8c48405069085a2c8b6b80816eda99e5dad31fc1 URL: https://github.com/llvm/llvm-project/commit/8c48405069085a2c8b6b80816eda99e5dad31fc1 DIFF: https://github.com/llvm/llvm-project/commit/8c48405069085a2c8b6b80816eda99e5dad3

[clang] 69242e9 - clang/Modules: Sink ASTReadResult in ReadControlBlock, NFC

2019-11-19 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-19T16:10:44-08:00 New Revision: 69242e986823e3fdd11a8e51f47f36bec714363c URL: https://github.com/llvm/llvm-project/commit/69242e986823e3fdd11a8e51f47f36bec714363c DIFF: https://github.com/llvm/llvm-project/commit/69242e986823e3fdd11a8e51f47f36bec714

[clang] 8700831 - clang/Modules: Early return in CompilerInstance::createModuleManager, NFC

2019-11-19 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-19T18:16:23-08:00 New Revision: 8700831734811cb89eafb72b75206f21e9f047e9 URL: https://github.com/llvm/llvm-project/commit/8700831734811cb89eafb72b75206f21e9f047e9 DIFF: https://github.com/llvm/llvm-project/commit/8700831734811cb89eafb72b75206f21e9f0

[clang] f7170d1 - clang/Modules: Move Serialization/Module.{h, cpp} to ModuleFile, NFC

2019-11-21 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-21T19:07:00-08:00 New Revision: f7170d17a846cd67d70884ba168fd0fad63549ea URL: https://github.com/llvm/llvm-project/commit/f7170d17a846cd67d70884ba168fd0fad63549ea DIFF: https://github.com/llvm/llvm-project/commit/f7170d17a846cd67d70884ba168fd0fad635

[clang] 5cca622 - clang/Modules: Refactor CompilerInstance::loadModule, NFC

2019-11-22 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-22T18:23:47-08:00 New Revision: 5cca622310c10fdf6f921b6cce26f91d9f14c762 URL: https://github.com/llvm/llvm-project/commit/5cca622310c10fdf6f921b6cce26f91d9f14c762 DIFF: https://github.com/llvm/llvm-project/commit/5cca622310c10fdf6f921b6cce26f91d9f14

[clang-tools-extra] 20d51b2 - clang/Modules: Rename CompilerInstance::ModuleManager, NFC

2019-11-22 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2019-11-22T18:24:11-08:00 New Revision: 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d URL: https://github.com/llvm/llvm-project/commit/20d51b2f14ac4488f684f8fc57cb0ba718a6b91d DIFF: https://github.com/llvm/llvm-project/commit/20d51b2f14ac4488f684f8fc57cb0ba718a6

[clang] 1e487e4 - clang: Only define OBJC_NEW_PROPERTIES when -x objective-c

2020-01-24 Thread Duncan P. N. Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-01-24T14:55:12-08:00 New Revision: 1e487e4c16821b6de3d651f618274df90bd3fad9 URL: https://github.com/llvm/llvm-project/commit/1e487e4c16821b6de3d651f618274df90bd3fad9 DIFF: https://github.com/llvm/llvm-project/commit/1e487e4c16821b6de3d651f618274df90bd3

Re: [PATCH] D28404: IRGen: Add optnone attribute on function during O0

2017-01-09 Thread Duncan P. N. Exon Smith via cfe-commits
This seems like a massive rehash of a discussion Peter Collingbourne and I had about passing -O0 to the linker for -flto=full. I had previously thought of LTO as "link time optimization", but in practice it's useful for (and required for correctness of some) non-optimization IR passes. In othe

r278898 - CodeGen: Avoid dereferencing end() in ScalarExprEmitter::EmitOverflowCheckedBinOp

2016-08-16 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Aug 16 22:15:29 2016 New Revision: 278898 URL: http://llvm.org/viewvc/llvm-project?rev=278898&view=rev Log: CodeGen: Avoid dereferencing end() in ScalarExprEmitter::EmitOverflowCheckedBinOp Use BB.getNextNode(), which returns nullptr on end(), instead of &*BB.getIter

r279457 - ADT: Remove uses of ilist_*sentinel_traits, NFC

2016-08-22 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Mon Aug 22 13:57:44 2016 New Revision: 279457 URL: http://llvm.org/viewvc/llvm-project?rev=279457&view=rev Log: ADT: Remove uses of ilist_*sentinel_traits, NFC Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h Modified: cfe/trunk/include

r297770 - Modules: Optimize bitcode encoding of diagnostic state

2017-03-14 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Mar 14 14:31:27 2017 New Revision: 297770 URL: http://llvm.org/viewvc/llvm-project?rev=297770&view=rev Log: Modules: Optimize bitcode encoding of diagnostic state Since bitcode uses VBR encoding, large numbers are more expensive than small ones. Instead of emitting a

r298165 - Modules: Cache PCMs in memory and avoid a use-after-free

2017-03-17 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Fri Mar 17 17:55:13 2017 New Revision: 298165 URL: http://llvm.org/viewvc/llvm-project?rev=298165&view=rev Log: Modules: Cache PCMs in memory and avoid a use-after-free Clang's internal build system for implicit modules uses lock files to ensure that after a process write

r298278 - Reapply "Modules: Cache PCMs in memory and avoid a use-after-free"

2017-03-20 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Mon Mar 20 12:58:26 2017 New Revision: 298278 URL: http://llvm.org/viewvc/llvm-project?rev=298278&view=rev Log: Reapply "Modules: Cache PCMs in memory and avoid a use-after-free" This reverts commit r298185, effectively reapplying r298165, after fixing the new unit tests

r298414 - Modules: Remove an invalid check in unit tests for r298278

2017-03-21 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Mar 21 13:26:18 2017 New Revision: 298414 URL: http://llvm.org/viewvc/llvm-project?rev=298414&view=rev Log: Modules: Remove an invalid check in unit tests for r298278 This is a fixup for the unit tests from r298278 (originally r298165). Since the buffer that RawB2 po

Re: [libcxx] r281681 - [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

2017-03-29 Thread Duncan P. N. Exon Smith via cfe-commits
Why are we propagating the use of always_inline? In other places, we use always_inline to avoid affecting ABI (a visibility hack). But you're not removing basic_string from the dylib here. It has major downsides: - It causes inlining at -O0, which causes major regressions in debugging experien

[libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Fri Mar 31 12:39:56 2017 New Revision: 299236 URL: http://llvm.org/viewvc/llvm-project?rev=299236&view=rev Log: Use strong enums independently of -fobjc-arc r145698 introduced _LIBCPP_HAS_NO_STRONG_ENUMS by copy-pasting the __has_feature check from objc_arc_weak/_LIBCPP_H

Re: [libcxx] r299236 - Use strong enums independently of -fobjc-arc

2017-03-31 Thread Duncan P. N. Exon Smith via cfe-commits
; On Mar 31, 2017, at 13:37, Eric Fiselier wrote: > > This will be ABI breaking for Objective-C++ users. I'm not objecting to > fixing the bogus configuration, but I just wanted to point it out. > > /Eric > > On Fri, Mar 31, 2017 at 11:39 AM, Duncan P. N. Exon Smith v

[libcxx] r299290 - string: Remove always_inline from basic_string::__init

2017-03-31 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Fri Mar 31 22:20:48 2017 New Revision: 299290 URL: http://llvm.org/viewvc/llvm-project?rev=299290&view=rev Log: string: Remove always_inline from basic_string::__init This is effectively a partial revert of r278356, which started inlining basic_string::__init. Even if we

Re: [PATCH] D30009: Add support for '#pragma clang attribute'

2017-04-05 Thread Duncan P. N. Exon Smith via cfe-commits
> On Apr 5, 2017, at 05:44, Alex L wrote: > > > > On 5 April 2017 at 13:38, Duncan Exon Smith > wrote: > > > > On Apr 5, 2017, at 05:13, Aaron Ballman via Phabricator > > mailto:revi...@reviews.llvm.org>> wrote: > > > > aaron.ballman added inline comments. > >

r300021 - Serialization: Skip check in WritePragmaDiagnosticMappings, NFC

2017-04-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Apr 11 21:31:17 2017 New Revision: 300021 URL: http://llvm.org/viewvc/llvm-project?rev=300021&view=rev Log: Serialization: Skip check in WritePragmaDiagnosticMappings, NFC The record is never empty, since we always serialize the initial state. Skip the check. Modifie

r300024 - Serialization: Emit the final diagnostic state last, almost NFC

2017-04-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Apr 11 22:45:32 2017 New Revision: 300024 URL: http://llvm.org/viewvc/llvm-project?rev=300024&view=rev Log: Serialization: Emit the final diagnostic state last, almost NFC Emit the final diagnostic state last to match source order. This also prepares for a follow-up

r300025 - Serialization: Simulate -Werror settings in implicit modules

2017-04-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Apr 11 22:58:58 2017 New Revision: 300025 URL: http://llvm.org/viewvc/llvm-project?rev=300025&view=rev Log: Serialization: Simulate -Werror settings in implicit modules r293123 started serializing diagnostic pragma state for modules. This makes the serialization work

r300380 - Modules: Do not serialize #pragma pack state

2017-04-14 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Fri Apr 14 19:07:57 2017 New Revision: 300380 URL: http://llvm.org/viewvc/llvm-project?rev=300380&view=rev Log: Modules: Do not serialize #pragma pack state The modules side of r299226, which serializes #pragma pack state, doesn't work well. The main purpose was to make

Re: r299226 - [Modules][PCH] Serialize #pragma pack

2017-04-14 Thread Duncan P. N. Exon Smith via cfe-commits
FYI, I reverted the modules side of this in r300380. For details, see the commit message. TL;DR: this didn't actually make modules builds closer to matching non-modules builds, thanks to how submodules work; on the contrary, it made them diverge. > On 2017-Mar-31, at 08:36, Alex Lorenz via cf

Re: [PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

2017-01-24 Thread Duncan P. N. Exon Smith via cfe-commits
According to the comment at line 239: if (LoadedSuccessfully.count(*victim) == 0) { // Before removing the module file, check if it was validated in an // ancestor thread, if yes, throw a hard error instead of causing // use-after-free in the ancestor thread. bool IsSys

r293393 - Modules: Separate out a checkSignature helper, almost NFC

2017-01-28 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Sat Jan 28 15:34:28 2017 New Revision: 293393 URL: http://llvm.org/viewvc/llvm-project?rev=293393&view=rev Log: Modules: Separate out a checkSignature helper, almost NFC The main point is to move the delete-the-new-module logic into the same block that creates it, so I ca

r293394 - Modules: Return ModuleFile& from ModuleManager::begin, etc.; NFC

2017-01-28 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Sat Jan 28 16:15:22 2017 New Revision: 293394 URL: http://llvm.org/viewvc/llvm-project?rev=293394&view=rev Log: Modules: Return ModuleFile& from ModuleManager::begin, etc.; NFC Hide the pointer indirection in ModuleManager::begin, ModuleManager::end, ModuleManager::rbegin

r293395 - Modules: Clarify ownership of ModuleFile instances in ModuleManager, NFC

2017-01-28 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Sat Jan 28 16:24:01 2017 New Revision: 293395 URL: http://llvm.org/viewvc/llvm-project?rev=293395&view=rev Log: Modules: Clarify ownership of ModuleFile instances in ModuleManager, NFC Use std::unique_ptr to clarify the ownership of the ModuleFile instances in ModuleManag

<    1   2   3   4   5   >