[PATCH] D46767: Force the PS4 clang ABI version to 6, and add a warning if this is attempted to be overridden

dyung created this revision. dyung added a reviewer: probinson. For compatibility reasons, the PS4 clang ABI must use version 6, so we force the compiler to use this version if the PS4 target triple is specified. We also emit a new warning now if a clang abi version was specified which is not 6

[PATCH] D46767: Force the PS4 clang ABI version to 6, and add a warning if this is attempted to be overridden

This revision was automatically updated to reflect the committed changes. Closed by commit rC332160: Force the PS4 clang ABI version to 6. (authored by dyung, committed by ). Repository: rC Clang https://reviews.llvm.org/D46767 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Front

[PATCH] D47084: Maintain PS4 ABI compatibility

dyung created this revision. dyung added a reviewer: probinson. In r331136, a change was made to the compiler to fix a problem with how clang applied the packed attribute to classes. This is an ABI breaking change for the PS4 target, so this change maintains the broken behavior for the PS4 targe

[PATCH] D47084: Maintain PS4 ABI compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL332773: Maintain PS4 ABI compatibility by making the fix made in r331136 not apply when… (authored by dyung, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D47175: [DOXYGEN] Formatting changes for better intrinsics documentation rendering

dyung added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D47175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41507: avxintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix incorrect wording in various intrinsic descriptions. Previously the descriptions used "low-

[PATCH] D41516: emmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fixed innaccurate instruction mappings for various intrinsics. 2. Fixed description of NaN handl

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix instruction mappings/listings for various intrinsics These patches were made by Craig Flore

[PATCH] D41518: pmmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix incorrect wording in various intrinsic descriptions. Previously the descriptions used "low-

[PATCH] D41520: smmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix formatting issue due to hyphenated terms at line breaks. 2. Fix typo These patches were mad

[PATCH] D41523: xmmintrin.h documentation fixes and updates

dyung created this revision. This is the result of several patches we made internally to update the documentation that we would like to have reviewed for possible submission. The changes include: 1. Fix inaccurate instruction listings. 2. Fix small issues in _mm_getcsr and _mm_setcsr. 3. Fix de

[PATCH] D41516: emmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rL321669: [DOXYGEN] Fix doxygen and content issues in emmintrin.h (authored by dyung, committed by ). Changed prior to commit: https://reviews.llvm.org/D41516?vs=127939&id=128447#toc Repository: rL LLV

[PATCH] D41518: pmmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rL321670: [DOXYGEN] Fix doxygen and content issues in pmmintrin.h (authored by dyung, committed by ). Changed prior to commit: https://reviews.llvm.org/D41518?vs=127947&id=128448#toc Repository: rL LLV

[PATCH] D41520: smmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rL321671: [DOXYGEN] Fix doxygen and content issues in smmintrin.h (authored by dyung, committed by ). Changed prior to commit: https://reviews.llvm.org/D41520?vs=127949&id=128449#toc Repository: rL LLV

[PATCH] D41507: avxintrin.h documentation fixes and updates

dyung updated this revision to Diff 128861. dyung added a comment. Updated change to address review feedback. https://reviews.llvm.org/D41507 Files: avxintrin.h Index: avxintrin.h === --- avxintrin.h +++ avxintrin.h @@ -1120,7 +

[PATCH] D41523: xmmintrin.h documentation fixes and updates

dyung added inline comments. Comment at: lib/Headers/xmmintrin.h:1927 /// -/// This intrinsic corresponds to the VPEXTRQ / MOVQ instruction. +/// This intrinsic corresponds to the VPEXTRQ / PEXTRQ instruction. /// RKSimon wrote: > Not necessarily, it could

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung added inline comments. Comment at: lib/Headers/mmintrin.h:1402 /// -/// This intrinsic corresponds to the VPSHUFLW / PSHUFLW instruction. +/// This intrinsic corresponds to the PSHUFLW instruction. /// craig.topper wrote: > This is overly specific Jus

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung updated this revision to Diff 129015. dyung added a comment. Updating diff based on review feedback. https://reviews.llvm.org/D41517 Files: lib/Headers/mmintrin.h Index: lib/Headers/mmintrin.h === --- lib/Headers/mmintrin

[PATCH] D41523: xmmintrin.h documentation fixes and updates

dyung updated this revision to Diff 129021. dyung added a comment. Update review based on feedback. https://reviews.llvm.org/D41523 Files: lib/Headers/xmmintrin.h Index: lib/Headers/xmmintrin.h === --- lib/Headers/xmmintrin.h ++

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung updated this revision to Diff 136221. dyung added a comment. Updated documentation for instruction generated for _mm_cvtsi32_si64, _mm_cvtsi64_si32, _mm_cvtsi64_m64 and _mm_cvtm64_si64 based on feedback. https://reviews.llvm.org/D41517 Files: lib/Headers/mmintrin.h Index: lib/Headers

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung marked an inline comment as done. dyung added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// efriedma wrote: > RK

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung updated this revision to Diff 137333. dyung marked an inline comment as done. dyung added a comment. Update based on feedback from Simon. https://reviews.llvm.org/D41517 Files: lib/Headers/mmintrin.h Index: lib/Headers/mmintrin.h ===

[PATCH] D41517: mmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rL327090: [DOXYGEN] Fix doxygen and content issues in mmintrin.h (authored by dyung, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41517?vs=13

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

dyung added a comment. In https://reviews.llvm.org/D45050#1281178, @whisperity wrote: > I have installed said Ubuntu in a virtual machine for testing this, but > unfortunately only the following Clangs are available in the package manager > for `Trusty`: > > clang - C, C++ and Objective-C com

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

dyung added a comment. In D61187#1486249 , @probinson wrote: > FYI, we had to disable clangd entirely after this patch, getting a weird > problem with lit that we haven't figured out yet. > In case anybody else has seen something like this, and knows wha

[PATCH] D61790: [C++20] add Basic consteval specifier

dyung added a comment. Hi, the test cxx2a-consteval.cpp that you added in this commit is failing on the PS4 Windows bot. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/9/steps/test/logs/stdio FAIL: Clang :: SemaCXX/cxx2a-consteval.cpp (13131 of 50204

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung created this revision. dyung added reviewers: thakis, rnk. dyung added a project: clang. A previous change D65233 (r367165) attempted to fix this issue, but it missed a case where the integrated assembler is not being used. For example, consider the case w

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung marked an inline comment as done. dyung added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3559 // CollectArgsForIntegratedAssembler(). -if (TC.useIntegratedAs()) { +if (TC.useIntegratedAs() || isa(JA)) { Args.ClaimAllArgs(options::

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung updated this revision to Diff 214278. dyung added a comment. Reverted changes in Clang.cpp and updated test to expect warning when an external assembler is requested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/ https://reviews.llvm.org/D65974

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung marked an inline comment as done. dyung added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3559 // CollectArgsForIntegratedAssembler(). -if (TC.useIntegratedAs()) { +if (TC.useIntegratedAs() || isa(JA)) { Args.ClaimAllArgs(options::

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung marked an inline comment as done. dyung added a comment. In D65974#1623140 , @thakis wrote: > Thanks! Looks like the change to the cpp file got lost? I only see the test > change now. Yes, I abandoned that change as I thought you said it was unnec

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung added a comment. Oh, I just re-read your comments and realized that we should claim the Wa_COMMA and Xassembler arguments, I'll reinstate the change to just claim those. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/ https://reviews.llvm.org/D659

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung added a comment. Actually it seems your original change already implemented that, so I think only the updated test change that I made is needed. Let me know if you disagree with that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65974/new/ https://review

[PATCH] D65974: Driver: Don't warn about assembler flags being unused when not assembling AND not using the integrated assembler

dyung added a comment. In D65974#1623368 , @thakis wrote: > Something like "fix test for out-of-tree targets that don't enable the > internal assembler by default by explicitly passing -fintegrated-as > everywhere" or something like that. Thanks. I had

[PATCH] D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368474: Update test to explicity test with -fintegrated-as and -fno-integrated-as and… (authored by dyung, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

dyung added a comment. It's probably a pathological case, but wouldn't this still fail if the build directory contained ".s" followed by a space in the name? Something like "build-foo.s bar"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66176/new

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

dyung added a comment. Taking a step back and thinking about this, the compile command uses "-S", but explicitly specifies the output file to be "%t/module.pcm.o" (even though it is generating an assembly file instead of an object file), could we change the test to just check for "-o {{.*}}modu

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

dyung created this revision. dyung added reviewers: ro, rnk, jkorous. dyung added a project: clang. Herald added subscribers: dexonsmith, fedor.sergeev. This is a follow up to D63600 that attempts to fix the test to work on all platforms including Windows (which

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

dyung added a comment. In D63600#1554029 , @rnk wrote: > This causes the test to fail on Windows: > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/7712 > > There seems to be something wrong with the blamelist, so it didn't send > email.

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL364245: Fix test cl-response-file.c to work on all platforms including Windows/Solaris. (authored by dyung, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

[PATCH] D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds

dyung added a comment. In D55382#1330668 , @anemet wrote: > Actually this has been failing for 8 hours. So reverted in r349117. Also > reverted your attempt to update the test. It wasn't updating the right test: > r349118 And I was just about to com

[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

dyung added a comment. I have reverted this in r349121 as it has been causing the PS4 bots to be red for hours now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55595/new/ https://reviews.llvm.org/D55595

[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

dyung marked an inline comment as done. dyung added inline comments. Comment at: clang-tidy/ClangTidyForceLinker.h:11 +#include "llvm/Support/Compiler.h" + +namespace clang { Is there a reason that this header file does not use the standard header guards? Repos

[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

dyung added inline comments. Comment at: clang-tidy/ClangTidyForceLinker.h:11 +#include "llvm/Support/Compiler.h" + +namespace clang { dyung wrote: > Is there a reason that this header file does not use the standard header > guards? Sorry, this should not have b

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66176/new/ https://reviews.llvm.org/D66176 ___ c

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dyung added a comment. Hi, we noticed an issue with the GDB test suite that was bisected back to this change and I have put the details in PR46052. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76801/new/ https://reviews.llvm.

[PATCH] D80931: AMDGPU: Fix clang side null pointer value for private

dyung added a comment. Matt, this change to the test was causing a failure in the upstream PS4 linux bot here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68593 I put in a fix for the test to unbreak the bot in 086be9fb20489540e6228a6d9eb4afad533202fa <

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

dyung added a comment. I've reverted this change in g059ba74bb6f6166ca7c1783ef81dd37a5209b758 to get the bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

dyung added a comment. Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly f

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

dyung added a comment. In D50078#1999183 , @Typz wrote: > In D50078#1998578 , @hokein wrote: > > > In D50078#1998520 , @Typz wrote: > > > > > In D50078#1998398

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

dyung created this revision. dyung added a reviewer: craig.topper. dyung added a project: clang. For the PS4 platform, we want to exclude certain headers from being included because we do not support the features they provide. To achieve this, we do not include any header files by default, and r

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

dyung added inline comments. Comment at: clang/test/Headers/x86intrin-2.c:3 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual %s -verify +// RUN: %clang_cc1 -triple i386-unknown-unknown -fsyntax-only -ffreestanding -flax-vector-conversi

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

dyung updated this revision to Diff 261385. dyung added a comment. Removed REQUIRES line in test since it is not needed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79194/new/ https://reviews.llvm.org/D79194 Files: clang/lib/Headers/bmiintrin.h clang/lib/Headers/immintrin.h clan

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

dyung marked 2 inline comments as done. dyung added inline comments. Comment at: clang/test/Headers/x86intrin-2.c:7 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -ffreestanding -Wcast-qual -x c++ %s -verify +// REQUIRES: x86-registered-target // expected-no-d

[PATCH] D79194: Add header guards for header files that should not be included on the PS4 platform

This revision was automatically updated to reflect the committed changes. dyung marked an inline comment as done. Closed by commit rG046130490f23: Add header guards for header files that should not be included on the PS4… (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. The test you added is failing on the PS4 linux bot because the PS4 platform requires an external linker that isn't present. Is linking necessary for your test? Or can -S or even -c work instead to accomplish what you are trying to test? Repository: rG LLVM Github Mono

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768274 , @dongjunduo wrote: > In D131469#3768260 , @dyung wrote: > >> The test you added is failing on the PS4 linux bot because the PS4 platform >> requires an external linker

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768283 , @dongjunduo wrote: > In D131469#3768282 , @dyung wrote: > >> In D131469#3768274 , @dongjunduo >> wrote: >> >>> In D131469#376

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768352 , @steven_wu wrote: > In D131469#3768308 , @dongjunduo > wrote: > >> In D131469#3768288 , @dyung wrote: >> >>> In D131469#376828

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

dyung added a comment. Hi @masoud.ataei, the test you added in this commit is failing on the PS4 bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/24469 clang (LLVM option parsing): Unknown command line argument '-enable-ppc-gen-scalar-mass'. Try: 'clang (LLVM op

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

dyung added a comment. This change is causing a build failure on the Windows PS4 bot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/builds/7026 FAILED: tools/clang/lib/Analysis/FlowSensitive/CMakeFiles/obj.clangAnalysisFlo

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

dyung added a comment. I've reverted this change in order to get the build bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 ___ cfe-commits mai

[PATCH] D122611: [clang][extract-api] Add support for macros

dyung added a comment. This change is causing 9 test failures on a buildbot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/19441 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

dyung added a comment. Hi, one of the tests you added. csky-toolchain.c seems to be failing on a Windows build bot, and from a quick look, it appears to be a path separator issue. Can you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/2452 Repository: rG LLVM Github Monore

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

dyung added a comment. Hi @sammccall, your change seems to be causing a build failure on the PS4 linux bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/25678 FAILED: tools/clang/tools/extra/pseudo/gen/CMakeFiles/clang-pseudo-gen.dir/Main.cpp.o CCACHE_CPP2=yes

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. The test simple-exception.cpp is failing on the PS5 Windows bot after this change. Can you take a look? I forced a build using the commit prior to yours which passed: https://lab.llvm.org/buildbot/#/builders/216/builds/7636 And then I forced a build using your commit, and

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. In D130788#3689795 , @sunho wrote: > The test isn't supposed to be ran on windows -- we don't support exception on > windows at all yet. I guess XFAIL: windows-msvc, windows-gnu is not working > out. If you don't want the test ru

[PATCH] D130788: [clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.

dyung added a comment. In D130788#3689918 , @sunho wrote: > In D130788#3689820 , @dyung wrote: > >> In D130788#3689795 , @sunho wrote: >> >>> The test isn't supposed to be

[PATCH] D130689: [LLVM] Update C++ standard to 17

dyung added a comment. Your change is causing a build failure on the PS4 linux build bot using GCC 9.3. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/26186 FAILED: tools/clang/tools/extra/clang-tidy/bugprone/CMakeFiles/obj.clangTidyBugproneModule.dir/SignalHandlerCh

[PATCH] D130689: [LLVM] Update C++ standard to 17

dyung added a comment. We are seeing an additional failure on an internal linux bot due to the change to using C++17 by default when using GNU ld: [3/7] Generating GwpAsan-x86_64-Test FAILED: projects/compiler-rt/lib/gwp_asan/tests/GwpAsan-x86_64-Test cd /home/jenkins/j/w/workspace/opens

[PATCH] D121556: [randstruct] Add randomize structure layout support

dyung added a comment. Hi, the test you added is failing on the PS4 Windows bot https://lab.llvm.org/buildbot/#/builders/216/builds/2647. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

dyung added a comment. Hi, your change is causing a test failure in the test attr-trivial-abi.cpp that you modified on the PS4 Windows box: https://lab.llvm.org/staging/#/builders/204/builds/758/steps/7/logs/FAIL__Clang__attr-trivial-abi_cpp TEST 'Clang :: SemaCXX/attr-tr

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

dyung added a comment. In D114732#3294794 , @devin.jeanpierre wrote: > Oops, sorry about that. What is the correct way to test/reproduce the change? > Do I / can I submit builds to the buildbot manually for testing? > > Also, should I be rolling back th

[PATCH] D118070: Make lld-link work in a non-MSVC shell

dyung added a comment. I'm not exactly sure why, but this change seems to be causing the Driver/cl-options.c test to fail on the PS4 Windows bot: https://lab.llvm.org/staging/#/builders/204/builds/1343 It was also failing previously after the original commit until it was reverted at which poin

[PATCH] D118070: Make lld-link work in a non-MSVC shell

dyung added a comment. I've reverted this and the follow-up change to fix the build in 437d4e01fe4c057509dff30efd560049ad07bc99 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

dyung added a comment. Hi, the test you added is failing on the PS4 Linux bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/17199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D11920

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

dyung added a comment. In D119207#3330494 , @shangwuyao wrote: > In D119207#3330385 , @dyung wrote: > >> Hi, the test you added is failing on the PS4 Linux bot, can you take a look? >> >> https://lab.llvm.org/bui

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

dyung added a comment. I think the problem here is that if zlib is not available, you won't get the clang command line you expect: https://lab.llvm.org/buildbot/#/builders/216/builds/3519 Input was: << 1: clang version 15.0.0 (https://github.com/llvm/llvm-project.git 2d

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

dyung added a comment. Hi @jkorous, 4 of the tests you added seem to be failing on the PS4 linux and Window buildbots, can you take a look, and revert if it might take a while to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/21573 https://lab.llvm.org/buildbot/#/builders/216/

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

dyung added a comment. Hi, this is causing 3 test failures on the PS4 linux bot. The changes may not have been initially flagged because a different issue was causing a build failure which masked the problem. I have bisected the test failures to this change though. http://lab.llvm.org:8011/bui

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

dyung added a comment. In D64931#1647880 , @dyung wrote: > Hi, this is causing 3 test failures on the PS4 linux bot. The changes may not > have been initially flagged because a different issue was causing a build > failure which masked the problem. I hav

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

dyung added a comment. Hi, we are seeing this test fail on our internal linux build bot. I built/ran your latest change r310537 and here is the test result: /home/dyung/src/upstream/llvm_clean/tools/clang/test/Driver/openmp-offload.c:722:23: error: expected string not found in input

[PATCH] D86965: Do not emit "-tune-cpu generic" for PS4 platform

dyung created this revision. dyung added a reviewer: probinson. dyung added a project: clang. dyung requested review of this revision. For the PS4, do not emit "-tune-cpu generic" since the platform only has 1 known CPU and we do not want to prevent optimizations by tuning for a generic rather t

[PATCH] D86965: Do not emit "-tune-cpu generic" for PS4 platform

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1f394862053: Do not emit "-tune-cpu generic" for PS4 platform (authored by dyung). Changed prior to commit: https://reviews.llvm.org/D86965?vs=28

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

dyung added a comment. I have reverted this change in 8d2d0e84857cb1f2d01456eb433b5172d3a0772b to get the build bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D78699: [X86] Passing union type through register.

dyung added a comment. Hi, the test you added seems to pass both before and after your change, is this intended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78699/new/ https://reviews.llvm.org/D78699

[PATCH] D78699: [X86] Passing union type through register.

dyung added inline comments. Comment at: clang/test/CodeGen/X86/avx-union.c:2 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx -emit-llvm -o %t %s || FileCheck < %t %s --check-prefix=CHECK, AVX +// RUN: %clang_cc1 -w -ffreestanding -triple x86_

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

dyung created this revision. dyung added reviewers: probinson, rsmith, LiuChen3, craig.topper. dyung added a project: clang. Herald added subscribers: dexonsmith, pengfei. dyung requested review of this revision. Recently commit D78699 (commit 26cfb6e562f1

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

dyung added a comment. Sorry for the lack of context, I made my diffs using a new method this time, but I'll make sure it has the full context next time. Thanks! Comment at: clang/test/CodeGen/X86/avx-union.c:7 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -ta

[PATCH] D89747: Add option to use older clang ABI behavior when passing certain union types as function arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG774ab60125ee: Add option to use older clang ABI behavior when passing certain union types as… (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

dyung added a comment. The test added in this commit was failing on the PS4 bot (https://lab.llvm.org/buildbot/#/builders/139/builds/4059). I've reverted the change in 59b419adc6e608db8d7c31efcc37f34c0b57b7d0 to get the bot

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

dyung added a comment. PS4 changes lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

dyung added a comment. Hi, our internal testing started to hit an assertion failure in one of our tests after this commit. I have put the details in PR52011, can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/ ht

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

dyung added a comment. Hi, the test you modified Driver/crash-report.cpp is failing on the PS4 bot after your change. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/10939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1107

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

dyung added a comment. It also failed on the PS4 linux bot: http://lab.llvm.org:8014/#/builders/125/builds/125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 __

[PATCH] D102736: Fix tmp files being left on Windows builds.

dyung added a comment. Hi Amy, after your change, the compile time for one of our internal test files went from about 1 second to 30 seconds. I have put a repro and the details in PR50628, can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

dyung added a comment. Another +1 for it failing intermittently on the bot I watch over, llvm-clang-x86_64-sie-ubuntu-fast. Anything that can be done to stabilize the test or to remove it would be appreciated! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D104295: removes redundant test

dyung added a comment. I'll commit it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104295/new/ https://reviews.llvm.org/D104295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D104295: removes redundant test

This revision was automatically updated to reflect the committed changes. Closed by commit rGefebe76e93d5: Remove redundant test that was causing intermittent build bot failures. (authored by dyung). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1042

  1   2   3   >